Preparing report...

Report for github.com/atomix/atomix-go-framework

A+    Excellent!    Found 63 issues across 122 files

Tweet

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint54%

Golint is a linter for Go source code.

    • atomix-go-framework/pkg/atomix/time/physical.go
    • Line 25: warning: exported var PhysicalScheme should have comment or be unexported (golint)
    • Line 63: warning: exported method PhysicalClock.Scheme should have comment or be unexported (golint)
    • Line 67: warning: exported method PhysicalClock.Get should have comment or be unexported (golint)
    • Line 73: warning: exported method PhysicalClock.Increment should have comment or be unexported (golint)
    • Line 80: warning: exported method PhysicalClock.Update should have comment or be unexported (golint)
    • Line 111: warning: exported method PhysicalTimestamp.Scheme should have comment or be unexported (golint)
    • Line 115: warning: exported method PhysicalTimestamp.Before should have comment or be unexported (golint)
    • Line 123: warning: exported method PhysicalTimestamp.After should have comment or be unexported (golint)
    • Line 131: warning: exported method PhysicalTimestamp.Equal should have comment or be unexported (golint)
    • Line 142: warning: exported method PhysicalTimestampCodec.EncodeTimestamp should have comment or be unexported (golint)
    • Line 156: warning: exported method PhysicalTimestampCodec.DecodeTimestamp should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/indexedmap/server.go
    • Line 35: warning: exported method ProxyServer.Size should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Put should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Get should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.FirstEntry should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.LastEntry should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.PrevEntry should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.NextEntry should have comment or be unexported (golint)
    • Line 63: warning: exported method ProxyServer.Remove should have comment or be unexported (golint)
    • Line 67: warning: exported method ProxyServer.Clear should have comment or be unexported (golint)
    • Line 71: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • Line 75: warning: exported method ProxyServer.Entries should have comment or be unexported (golint)
    • atomix-go-framework/codegen/meta/context.go
    • Line 52: warning: comment on exported method Context.GetTemplatePath should be of the form "GetTemplatePath ..." (golint)
    • Line 81: warning: exported method Context.GetStateMeta should have comment or be unexported (golint)
    • Line 523: warning: comment on exported method Context.GetPartitionKeyFieldMeta should be of the form "GetPartitionKeyFieldMeta ..." (golint)
    • Line 528: warning: comment on exported method Context.GetPartitionRangeFieldMeta should be of the form "GetPartitionRangeFieldMeta ..." (golint)
    • Line 566: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • atomix-go-framework/pkg/atomix/time/logical.go
    • Line 63: warning: exported method LogicalClock.Scheme should have comment or be unexported (golint)
    • Line 67: warning: exported method LogicalClock.Get should have comment or be unexported (golint)
    • Line 73: warning: exported method LogicalClock.Increment should have comment or be unexported (golint)
    • Line 83: warning: exported method LogicalClock.Update should have comment or be unexported (golint)
    • Line 119: warning: exported method LogicalTimestamp.Scheme should have comment or be unexported (golint)
    • Line 123: warning: exported method LogicalTimestamp.Increment should have comment or be unexported (golint)
    • Line 129: warning: exported method LogicalTimestamp.Before should have comment or be unexported (golint)
    • Line 137: warning: exported method LogicalTimestamp.After should have comment or be unexported (golint)
    • Line 145: warning: exported method LogicalTimestamp.Equal should have comment or be unexported (golint)
    • Line 156: warning: exported method LogicalTimestampCodec.EncodeTimestamp should have comment or be unexported (golint)
    • Line 170: warning: exported method LogicalTimestampCodec.DecodeTimestamp should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/storage/protocol/gossip/peer.go
    • Line 27: warning: exported type MemberID should have comment or be unexported (golint)
    • Line 33: warning: exported type PeerID should have comment or be unexported (golint)
    • Line 53: warning: exported type Peer should have comment or be unexported (golint)
    • Line 226: warning: exported method Peer.ReadAll should have comment or be unexported (golint)
    • Line 250: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 260: warning: exported method Peer.Advertise should have comment or be unexported (golint)
    • Line 267: warning: exported method Peer.Update should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/counter/server.go
    • Line 35: warning: exported method ProxyServer.Get should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Set should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Increment should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.Decrement should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/time/epoch.go
    • Line 24: warning: exported var EpochScheme should have comment or be unexported (golint)
    • Line 62: warning: exported method EpochClock.Scheme should have comment or be unexported (golint)
    • Line 66: warning: exported method EpochClock.Get should have comment or be unexported (golint)
    • Line 72: warning: exported method EpochClock.Increment should have comment or be unexported (golint)
    • Line 79: warning: exported method EpochClock.Update should have comment or be unexported (golint)
    • Line 100: warning: exported type Epoch should have comment or be unexported (golint)
    • Line 116: warning: exported method EpochTimestamp.Scheme should have comment or be unexported (golint)
    • Line 120: warning: exported method EpochTimestamp.Before should have comment or be unexported (golint)
    • Line 128: warning: exported method EpochTimestamp.After should have comment or be unexported (golint)
    • Line 136: warning: exported method EpochTimestamp.Equal should have comment or be unexported (golint)
    • Line 147: warning: exported method EpochTimestampCodec.EncodeTimestamp should have comment or be unexported (golint)
    • Line 166: warning: exported method EpochTimestampCodec.DecodeTimestamp should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/storage/protocol/gossip/peergroup.go
    • Line 26: warning: exported function NewPeerGroup should have comment or be unexported (golint)
    • Line 43: warning: exported type PeerGroup should have comment or be unexported (golint)
    • Line 108: warning: exported method PeerGroup.MemberID should have comment or be unexported (golint)
    • Line 112: warning: exported method PeerGroup.Peer should have comment or be unexported (golint)
    • Line 116: warning: exported method PeerGroup.Peers should have comment or be unexported (golint)
    • Line 144: warning: exported method PeerGroup.ReadAll should have comment or be unexported (golint)
    • Line 175: warning: exported method PeerGroup.Advertise should have comment or be unexported (golint)
    • Line 184: warning: exported method PeerGroup.Update should have comment or be unexported (golint)
    • Line 193: warning: exported method PeerGroup.Close should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/election/server.go
    • Line 35: warning: exported method ProxyServer.Enter should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Withdraw should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Anoint should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.Promote should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.Evict should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.GetTerm should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/util/retry/options.go
    • Line 23: warning: exported function WithInterval should have comment or be unexported (golint)
    • Line 29: warning: exported function WithMaxInterval should have comment or be unexported (golint)
    • Line 35: warning: exported function WithRetryOn should have comment or be unexported (golint)
    • Line 47: warning: exported type CallOption should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/storage/protocol/gossip/primitive.go
    • Line 24: warning: exported function RegisterPrimitiveServer should have comment or be unexported (golint)
    • Line 34: warning: exported type PrimitiveServer should have comment or be unexported (golint)
    • Line 38: warning: exported method PrimitiveServer.Create should have comment or be unexported (golint)
    • Line 45: warning: exported method PrimitiveServer.Close should have comment or be unexported (golint)
    • Line 52: warning: exported method PrimitiveServer.Delete should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/meta/object.go
    • Line 22: warning: exported function Equal should have comment or be unexported (golint)
    • Line 70: warning: exported method ObjectMeta.AsObject should have comment or be unexported (golint)
    • Line 76: warning: exported method ObjectMeta.AsTombstone should have comment or be unexported (golint)
    • Line 82: warning: exported method ObjectMeta.Meta should have comment or be unexported (golint)
    • Line 86: warning: exported method ObjectMeta.Proto should have comment or be unexported (golint)
    • Line 105: warning: exported method ObjectMeta.Equal should have comment or be unexported (golint)
    • Line 115: warning: exported method ObjectMeta.Before should have comment or be unexported (golint)
    • Line 125: warning: exported method ObjectMeta.After should have comment or be unexported (golint)
    • atomix-go-framework/codegen/meta/meta.go
    • Line 17: warning: exported type CodegenMeta should have comment or be unexported (golint)
    • Line 25: warning: exported type GeneratorMeta should have comment or be unexported (golint)
    • Line 83: warning: exported type StateMeta should have comment or be unexported (golint)
    • Line 91: warning: exported type ServiceTypeMeta should have comment or be unexported (golint)
    • Line 163: warning: exported type AggregatorMeta should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/broker/server.go
    • Line 24: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 30: warning: exported type Server should have comment or be unexported (golint)
    • Line 35: warning: exported method Server.RegisterPrimitive should have comment or be unexported (golint)
    • Line 51: warning: exported method Server.UnregisterPrimitive should have comment or be unexported (golint)
    • Line 67: warning: exported method Server.LookupPrimitive should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/list/server.go
    • Line 35: warning: exported method ProxyServer.Size should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Append should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Insert should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.Get should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.Set should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.Remove should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.Clear should have comment or be unexported (golint)
    • Line 63: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • Line 67: warning: exported method ProxyServer.Elements should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/storage/protocol/gossip/manager.go
    • Line 67: warning: exported method Manager.AddRequestHeaders should have comment or be unexported (golint)
    • Line 71: warning: exported method Manager.AddResponseHeaders should have comment or be unexported (golint)
    • Line 75: warning: exported method Manager.Partition should have comment or be unexported (golint)
    • Line 79: warning: exported method Manager.PartitionBy should have comment or be unexported (golint)
    • Line 87: warning: exported method Manager.PartitionFrom should have comment or be unexported (golint)
    • Line 104: warning: exported method Manager.PartitionFor should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/rsm/primitive.go
    • Line 28: warning: exported function RegisterPrimitiveServer should have comment or be unexported (golint)
    • Line 40: warning: exported type PrimitiveServer should have comment or be unexported (golint)
    • Line 46: warning: exported method PrimitiveServer.Create should have comment or be unexported (golint)
    • Line 69: warning: exported method PrimitiveServer.Close should have comment or be unexported (golint)
    • Line 92: warning: exported method PrimitiveServer.Delete should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/broker/primitives.go
    • Line 37: warning: exported method PrimitiveRegistry.AddPrimitive should have comment or be unexported (golint)
    • Line 48: warning: exported method PrimitiveRegistry.RemovePrimitive should have comment or be unexported (golint)
    • Line 59: warning: exported method PrimitiveRegistry.LookupPrimitive should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/time/composite.go
    • Line 78: warning: exported method CompositeClock.Scheme should have comment or be unexported (golint)
    • Line 82: warning: exported method CompositeClock.Get should have comment or be unexported (golint)
    • Line 88: warning: exported method CompositeClock.Increment should have comment or be unexported (golint)
    • Line 96: warning: exported method CompositeClock.Update should have comment or be unexported (golint)
    • Line 131: warning: exported method CompositeTimestamp.Scheme should have comment or be unexported (golint)
    • Line 135: warning: exported method CompositeTimestamp.Before should have comment or be unexported (golint)
    • Line 164: warning: exported method CompositeTimestamp.After should have comment or be unexported (golint)
    • Line 193: warning: exported method CompositeTimestamp.Equal should have comment or be unexported (golint)
    • Line 216: warning: exported method CompositeTimestampCodec.EncodeTimestamp should have comment or be unexported (golint)
    • Line 234: warning: exported method CompositeTimestampCodec.DecodeTimestamp should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/server.go
    • Line 29: warning: exported type Server should have comment or be unexported (golint)
    • Line 33: warning: exported method Server.StartAgent should have comment or be unexported (golint)
    • Line 44: warning: exported method Server.ConfigureAgent should have comment or be unexported (golint)
    • Line 55: warning: exported method Server.StopAgent should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/rsm/client.go
    • Line 48: warning: exported method Client.Partition should have comment or be unexported (golint)
    • Line 52: warning: exported method Client.PartitionBy should have comment or be unexported (golint)
    • Line 60: warning: exported method Client.Partitions should have comment or be unexported (golint)
    • Line 64: warning: exported method Client.Connect should have comment or be unexported (golint)
    • Line 70: warning: exported method Client.Close should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/storage/protocol/gossip/registry.go
    • Line 36: warning: exported method Registry.RegisterServer should have comment or be unexported (golint)
    • Line 40: warning: exported method Registry.GetServers should have comment or be unexported (golint)
    • Line 44: warning: exported method Registry.RegisterService should have comment or be unexported (golint)
    • Line 48: warning: exported method Registry.GetServiceFuncs should have comment or be unexported (golint)
    • Line 52: warning: exported method Registry.GetServiceFunc should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/map/server.go
    • Line 15: warning: don't use an underscore in package name (golint)
    • Line 35: warning: exported method ProxyServer.Size should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Put should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Get should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.Remove should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.Clear should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.Entries should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/cache/map/cache.go
    • Line 15: warning: don't use an underscore in package name (golint)
    • Line 37: warning: exported type Server should have comment or be unexported (golint)
    • Line 44: warning: exported method Server.Size should have comment or be unexported (golint)
    • Line 48: warning: exported method Server.Put should have comment or be unexported (golint)
    • Line 70: warning: exported method Server.Get should have comment or be unexported (golint)
    • Line 101: warning: exported method Server.Remove should have comment or be unexported (golint)
    • Line 122: warning: exported method Server.Clear should have comment or be unexported (golint)
    • Line 134: warning: exported method Server.Events should have comment or be unexported (golint)
    • Line 138: warning: exported method Server.Entries should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/gossip/primitive.go
    • Line 26: warning: exported function RegisterPrimitiveServer should have comment or be unexported (golint)
    • Line 38: warning: exported type PrimitiveServer should have comment or be unexported (golint)
    • Line 44: warning: exported method PrimitiveServer.Create should have comment or be unexported (golint)
    • Line 68: warning: exported method PrimitiveServer.Close should have comment or be unexported (golint)
    • Line 92: warning: exported method PrimitiveServer.Delete should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/gossip/client.go
    • Line 64: warning: exported method Client.AddResponseHeaders should have comment or be unexported (golint)
    • Line 68: warning: exported method Client.Partition should have comment or be unexported (golint)
    • Line 72: warning: exported method Client.PartitionBy should have comment or be unexported (golint)
    • Line 80: warning: exported method Client.Partitions should have comment or be unexported (golint)
    • Line 84: warning: exported method Client.Close should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/set/server.go
    • Line 35: warning: exported method ProxyServer.Size should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Contains should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Add should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.Remove should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.Clear should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.Elements should have comment or be unexported (golint)
    • atomix-go-framework/pkg/atomix/driver/proxy/ro/log/server.go
    • Line 35: warning: exported method ProxyServer.Size should have comment or be unexported (golint)
    • Line 39: warning: exported method ProxyServer.Append should have comment or be unexported (golint)
    • Line 43: warning: exported method ProxyServer.Get should have comment or be unexported (golint)
    • Line 47: warning: exported method ProxyServer.FirstEntry should have comment or be unexported (golint)
    • Line 51: warning: exported method ProxyServer.LastEntry should have comment or be unexported (golint)
    • Line 55: warning: exported method ProxyServer.PrevEntry should have comment or be unexported (golint)
    • Line 59: warning: exported method ProxyServer.NextEntry should have comment or be unexported (golint)
    • Line 63: warning: exported method ProxyServer.Remove should have comment or be unexported (golint)
    • Line 67: warning: exported method ProxyServer.Clear should have comment or be unexported (golint)
    • Line 71: warning: exported method ProxyServer.Events should have comment or be unexported (golint)
    • Line 75: warning: exported method ProxyServer.Entries should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!