Last refresh: 4 years ago

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

- Line 1: warning: file is not gofmted with -s (gofmt)

- Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 987: warning: cyclomatic complexity 20 of function (*EC2InstanceMetadataCache).DescribeAllENIs() is high (> 15) (gocyclo)

- Line 333: warning: cyclomatic complexity 24 of function (*IPAMContext).nodeInit() is high (> 15) (gocyclo)
- Line 942: warning: cyclomatic complexity 16 of function (*IPAMContext).nodeIPPoolReconcile() is high (> 15) (gocyclo)

- Line 63: warning: cyclomatic complexity 16 of function (*TrafficTest).TestTraffic() is high (> 15) (gocyclo)

- Line 52: warning: cyclomatic complexity 16 of function main() is high (> 15) (gocyclo)

- Line 61: warning: cyclomatic complexity 23 of function main() is high (> 15) (gocyclo)

- Line 32: warning: cyclomatic complexity 21 of function TestNetworkingSetupForRegularPod() is high (> 15) (gocyclo)

- Line 61: warning: cyclomatic complexity 23 of function (*server).AddNetwork() is high (> 15) (gocyclo)

- Line 851: warning: cyclomatic complexity 19 of function setupENINetwork() is high (> 15) (gocyclo)
- Line 228: warning: cyclomatic complexity 16 of function (*linuxNetwork).SetupHostNetwork() is high (> 15) (gocyclo)

- Line 278: warning: cyclomatic complexity 16 of function (*linuxNetwork).SetupPodENINetwork() is high (> 15) (gocyclo)

golint69%

Golint is a linter for Go source code.

- Line 17: warning: exported const CNIMetricsHelperChartDir should have comment (or a comment on this block) or be unexported (golint)

- Line 24: warning: exported type InstallationManager should have comment or be unexported (golint)
- Line 29: warning: exported function NewDefaultInstallationManager should have comment or be unexported (golint)

- Line 25: warning: exported type EC2 should have comment or be unexported (golint)
- Line 279: warning: exported function NewEC2 should have comment or be unexported (golint)

- Line 26: warning: should not use dot imports (golint)
- Line 61: warning: comment on exported method TrafficTest.TestTraffic should be of the form "TestTraffic ..." (golint)

- Line 23: warning: exported type ENIConfigBuilder should have comment or be unexported (golint)
- Line 29: warning: exported function NewENIConfigBuilder should have comment or be unexported (golint)
- Line 35: warning: exported method ENIConfigBuilder.Name should have comment or be unexported (golint)
- Line 40: warning: exported method ENIConfigBuilder.SubnetID should have comment or be unexported (golint)
- Line 45: warning: exported method ENIConfigBuilder.SecurityGroup should have comment or be unexported (golint)
- Line 50: warning: exported method ENIConfigBuilder.Build should have comment or be unexported (golint)

- Line 22: warning: exported function GetInstanceIDFromNode should have comment or be unexported (golint)

- Line 26: warning: exported type DaemonSetManager should have comment or be unexported (golint)
- Line 35: warning: exported function NewDefaultDaemonSetManager should have comment or be unexported (golint)

- Line 28: warning: exported type ServiceManager should have comment or be unexported (golint)
- Line 38: warning: exported function NewDefaultServiceManager should have comment or be unexported (golint)

- Line 29: warning: exported type CloudFormation should have comment or be unexported (golint)
- Line 38: warning: exported function NewCloudFormation should have comment or be unexported (golint)

- Line 23: warning: exported type EKS should have comment or be unexported (golint)
- Line 31: warning: exported function NewEKS should have comment or be unexported (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 24: warning: exported type ServiceBuilder should have comment or be unexported (golint)
- Line 35: warning: exported function NewHTTPService should have comment or be unexported (golint)
- Line 45: warning: exported method ServiceBuilder.Name should have comment or be unexported (golint)
- Line 50: warning: exported method ServiceBuilder.Namespace should have comment or be unexported (golint)
- Line 55: warning: exported method ServiceBuilder.Port should have comment or be unexported (golint)
- Line 60: warning: exported method ServiceBuilder.NodePort should have comment or be unexported (golint)
- Line 65: warning: exported method ServiceBuilder.Protocol should have comment or be unexported (golint)
- Line 70: warning: exported method ServiceBuilder.Selector should have comment or be unexported (golint)
- Line 75: warning: exported method ServiceBuilder.ServiceType should have comment or be unexported (golint)
- Line 80: warning: exported method ServiceBuilder.Annotations should have comment or be unexported (golint)
- Line 85: warning: exported method ServiceBuilder.Build should have comment or be unexported (golint)

- Line 34: warning: exported const ClientRequestData should have comment (or a comment on this block) or be unexported (golint)

- Line 92: warning: should omit 2nd value from range; this loop is equivalent to `for key := range ...` (golint)

- Line 37: warning: exported type PodManager should have comment or be unexported (golint)
- Line 53: warning: exported function NewDefaultPodManager should have comment or be unexported (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 19: warning: exported const DefaultTestNamespace should have comment (or a comment on this block) or be unexported (golint)
- Line 24: warning: comment on exported const TestAgentImage should be of the form "TestAgentImage ..." (golint)
- Line 29: warning: exported const PollIntervalShort should have comment (or a comment on this block) or be unexported (golint)

- Line 24: warning: exported type PodBuilder should have comment or be unexported (golint)
- Line 36: warning: exported function NewDefaultPodBuilder should have comment or be unexported (golint)
- Line 47: warning: exported method PodBuilder.Name should have comment or be unexported (golint)
- Line 52: warning: exported method PodBuilder.Namespace should have comment or be unexported (golint)
- Line 57: warning: exported method PodBuilder.HostNetwork should have comment or be unexported (golint)
- Line 62: warning: exported method PodBuilder.Container should have comment or be unexported (golint)
- Line 67: warning: exported method PodBuilder.PodLabel should have comment or be unexported (golint)
- Line 72: warning: exported method PodBuilder.NodeName should have comment or be unexported (golint)
- Line 77: warning: exported method PodBuilder.NodeSelector should have comment or be unexported (golint)
- Line 82: warning: exported method PodBuilder.TerminationGracePeriod should have comment or be unexported (golint)
- Line 87: warning: exported method PodBuilder.RestartPolicy should have comment or be unexported (golint)
- Line 92: warning: exported method PodBuilder.Build should have comment or be unexported (golint)

- Line 28: warning: exported type NamespaceManager should have comment or be unexported (golint)
- Line 37: warning: exported function NewDefaultNamespaceManager should have comment or be unexported (golint)

- Line 26: warning: exported type NodeManager should have comment or be unexported (golint)
- Line 37: warning: exported function NewDefaultNodeManager should have comment or be unexported (golint)

- Line 22: warning: exported type CloudConfig should have comment or be unexported (golint)
- Line 28: warning: exported type Cloud should have comment or be unexported (golint)
- Line 47: warning: exported function NewCloud should have comment or be unexported (golint)

- Line 37: warning: comment on exported function CreateCachedKubeClient should be of the form "CreateCachedKubeClient ..." (golint)
- Line 67: warning: exported function GetKubeClientSet should have comment or be unexported (golint)
- Line 82: warning: exported function CheckAPIServerConnectivity should have comment or be unexported (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 23: warning: should not use dot imports (golint)
- Line 32: warning: exported type Framework should have comment or be unexported (golint)
- Line 40: warning: exported function New should have comment or be unexported (golint)

- Line 23: warning: exported const ServerResponse should have comment or be unexported (golint)
- Line 48: warning: exported function StartTCPServer should have comment or be unexported (golint)
- Line 99: warning: exported function StartUDPServer should have comment or be unexported (golint)

- Line 22: warning: exported type CloudWatch should have comment or be unexported (golint)
- Line 30: warning: exported function NewCloudWatch should have comment or be unexported (golint)

- Line 24: warning: exported type JobBuilder should have comment or be unexported (golint)
- Line 35: warning: exported function NewDefaultJobBuilder should have comment or be unexported (golint)
- Line 45: warning: exported method JobBuilder.Name should have comment or be unexported (golint)
- Line 50: warning: exported method JobBuilder.Namespace should have comment or be unexported (golint)
- Line 55: warning: exported method JobBuilder.Container should have comment or be unexported (golint)
- Line 60: warning: exported method JobBuilder.PodLabels should have comment or be unexported (golint)
- Line 65: warning: exported method JobBuilder.TerminationGracePeriod should have comment or be unexported (golint)
- Line 70: warning: exported method JobBuilder.NodeName should have comment or be unexported (golint)
- Line 75: warning: exported method JobBuilder.Parallelism should have comment or be unexported (golint)
- Line 80: warning: exported method JobBuilder.HostNetwork should have comment or be unexported (golint)
- Line 85: warning: exported method JobBuilder.Build should have comment or be unexported (golint)

- Line 21: warning: should not use dot imports (golint)
- Line 22: warning: should not use dot imports (golint)
- Line 26: warning: exported function AddEnvVarToDaemonSetAndWaitTillUpdated should have comment or be unexported (golint)
- Line 32: warning: exported function RemoveVarFromDaemonSetAndWaitTillUpdated should have comment or be unexported (golint)
- Line 38: warning: exported function UpdateEnvVarOnDaemonSetAndWaitUntilReady should have comment or be unexported (golint)

- Line 31: warning: exported const CreateNodeGroupCFNTemplateURL should have comment or be unexported (golint)
- Line 33: warning: exported type NodeGroupProperties should have comment or be unexported (golint)
- Line 49: warning: exported type ClusterVPCConfig should have comment or be unexported (golint)
- Line 55: warning: exported type AWSAuthMapRole should have comment or be unexported (golint)
- Line 61: warning: exported function CreateAndWaitTillSelfManagedNGReady should have comment or be unexported (golint)
- Line 198: warning: exported function DeleteAndWaitTillSelfManagedNGStackDeleted should have comment or be unexported (golint)
- Line 208: warning: exported function GetClusterVPCConfig should have comment or be unexported (golint)

- Line 29: warning: exported type JobManager should have comment or be unexported (golint)
- Line 38: warning: exported function NewDefaultJobManager should have comment or be unexported (golint)

- Line 23: warning: exported var GlobalOptions should have comment or be unexported (golint)
- Line 29: warning: exported type Options should have comment or be unexported (golint)
- Line 39: warning: exported method Options.BindFlags should have comment or be unexported (golint)
- Line 49: warning: exported method Options.Validate should have comment or be unexported (golint)

- Line 13: warning: exported type PodWatcher should have comment or be unexported (golint)

- Line 151: warning: should omit 2nd value from range; this loop is equivalent to `for index := range ...` (golint)

- Line 25: warning: exported type AutoScaling should have comment or be unexported (golint)
- Line 33: warning: exported function NewAutoScaling should have comment or be unexported (golint)

- Line 30: warning: exported function GetEnvValueForKeyFromDaemonSet should have comment or be unexported (golint)

- Line 25: warning: exported type DeploymentBuilder should have comment or be unexported (golint)
- Line 39: warning: exported function NewBusyBoxDeploymentBuilder should have comment or be unexported (golint)
- Line 51: warning: exported function NewDefaultDeploymentBuilder should have comment or be unexported (golint)
- Line 60: warning: exported method DeploymentBuilder.NodeSelector should have comment or be unexported (golint)
- Line 65: warning: exported method DeploymentBuilder.Namespace should have comment or be unexported (golint)
- Line 70: warning: exported method DeploymentBuilder.TerminationGracePeriod should have comment or be unexported (golint)
- Line 75: warning: exported method DeploymentBuilder.Name should have comment or be unexported (golint)
- Line 80: warning: exported method DeploymentBuilder.NodeName should have comment or be unexported (golint)
- Line 85: warning: exported method DeploymentBuilder.Replicas should have comment or be unexported (golint)
- Line 90: warning: exported method DeploymentBuilder.Container should have comment or be unexported (golint)
- Line 95: warning: exported method DeploymentBuilder.PodLabel should have comment or be unexported (golint)
- Line 100: warning: exported method DeploymentBuilder.HostNetwork should have comment or be unexported (golint)
- Line 105: warning: exported method DeploymentBuilder.MountVolume should have comment or be unexported (golint)
- Line 111: warning: exported method DeploymentBuilder.Build should have comment or be unexported (golint)

- Line 23: warning: exported type CustomResourceManager should have comment or be unexported (golint)
- Line 32: warning: exported function NewCustomResourceManager should have comment or be unexported (golint)

- Line 27: warning: exported type ReleaseManager should have comment or be unexported (golint)
- Line 37: warning: exported function NewDefaultReleaseManager should have comment or be unexported (golint)

- Line 24: warning: exported type ResourceManagers should have comment or be unexported (golint)
- Line 48: warning: exported function NewResourceManager should have comment or be unexported (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 18: warning: exported type TestStatus should have comment or be unexported (golint)
- Line 25: warning: exported type Failure should have comment or be unexported (golint)
- Line 30: warning: exported type PodNetworkingValidationInput should have comment or be unexported (golint)
- Line 43: warning: exported type Pod should have comment or be unexported (golint)
- Line 55: warning: exported method PodNetworkingValidationInput.Serialize should have comment or be unexported (golint)

- Line 23: warning: exported type PolicyDocument should have comment or be unexported (golint)
- Line 28: warning: exported type StatementEntry should have comment or be unexported (golint)
- Line 34: warning: exported type IAM should have comment or be unexported (golint)
- Line 87: warning: exported function NewIAM should have comment or be unexported (golint)

- Line 14: warning: don't use an underscore in package name (golint)

- Line 22: warning: exported type Container should have comment or be unexported (golint)
- Line 32: warning: exported function NewBusyBoxContainerBuilder should have comment or be unexported (golint)
- Line 42: warning: exported function NewCurlContainer should have comment or be unexported (golint)
- Line 50: warning: comment on exported function NewTestHelperContainer should be of the form "NewTestHelperContainer ..." (golint)
- Line 59: warning: exported function NewNetCatAlpineContainer should have comment or be unexported (golint)
- Line 67: warning: exported method Container.Name should have comment or be unexported (golint)
- Line 72: warning: exported method Container.Image should have comment or be unexported (golint)
- Line 77: warning: exported method Container.ImagePullPolicy should have comment or be unexported (golint)
- Line 82: warning: exported method Container.Command should have comment or be unexported (golint)
- Line 87: warning: exported method Container.Args should have comment or be unexported (golint)
- Line 92: warning: exported method Container.LivenessProbe should have comment or be unexported (golint)
- Line 97: warning: exported method Container.Port should have comment or be unexported (golint)
- Line 102: warning: exported method Container.Build should have comment or be unexported (golint)

- Line 115: warning: exported function GetNodeSpecificENIConfigName should have comment or be unexported (golint)

- Line 24: warning: exported type ConfigMapManager should have comment or be unexported (golint)
- Line 44: warning: exported function NewConfigMapManager should have comment or be unexported (golint)

- Line 28: warning: exported type DeploymentManager should have comment or be unexported (golint)
- Line 83: warning: exported function NewDefaultDeploymentManager should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

- Line 141: warning: ineffectual assignment to err (ineffassign)

- Line 178: warning: ineffectual assignment to err (ineffassign)

- Line 90: warning: ineffectual assignment to err (ineffassign)

- Line 56: warning: ineffectual assignment to deployment (ineffassign)

- Line 85: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

- Line 267: warning: "recieved" is a misspelling of "received" (misspell)

- Line 128: warning: "contianer" is a misspelling of "container" (misspell)

- Line 74: warning: "sucessfully" is a misspelling of "successfully" (misspell)
- Line 123: warning: "recieved" is a misspelling of "received" (misspell)
- Line 132: warning: "sucessfully" is a misspelling of "successfully" (misspell)

- Line 172: warning: "recieved" is a misspelling of "received" (misspell)

Go Report Card

Preparing report...

Report for github.com/aws/amazon-vpc-cni-k8s