Last refresh: 4 years ago

gofmt98%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

- Line 1: warning: file is not gofmted with -s (gofmt)

- Line 1: warning: file is not gofmted with -s (gofmt)

- Line 1: warning: file is not gofmted with -s (gofmt)

- Line 1: warning: file is not gofmted with -s (gofmt)

- Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 66: warning: cyclomatic complexity 16 of function (*queryParser).parseStruct() is high (> 15) (gocyclo)

- Line 221: warning: cyclomatic complexity 21 of function (unmarshaler).unmarshalScalar() is high (> 15) (gocyclo)

- Line 149: warning: cyclomatic complexity 17 of function (*trunkENI).InitTrunk() is high (> 15) (gocyclo)

- Line 17: warning: cyclomatic complexity 18 of function stringValue() is high (> 15) (gocyclo)

- Line 20: warning: cyclomatic complexity 25 of function prettify() is high (> 15) (gocyclo)

- Line 37: warning: cyclomatic complexity 23 of function rcopy() is high (> 15) (gocyclo)

- Line 168: warning: cyclomatic complexity 17 of function shouldRetryError() is high (> 15) (gocyclo)

- Line 48: warning: cyclomatic complexity 17 of function isNumberValue() is high (> 15) (gocyclo)

- Line 67: warning: cyclomatic complexity 17 of function (numberHelper).CorrectByte() is high (> 15) (gocyclo)

- Line 237: warning: cyclomatic complexity 17 of function envConfigLoad() is high (> 15) (gocyclo)

- Line 16: warning: cyclomatic complexity 47 of function rValuesAtPath() is high (> 15) (gocyclo)

- Line 137: warning: cyclomatic complexity 37 of function parse() is high (> 15) (gocyclo)

- Line 226: warning: cyclomatic complexity 18 of function (*WaiterAcceptor).match() is high (> 15) (gocyclo)

- Line 196: warning: cyclomatic complexity 18 of function buildScalar() is high (> 15) (gocyclo)
- Line 75: warning: cyclomatic complexity 17 of function buildStruct() is high (> 15) (gocyclo)

- Line 372: warning: cyclomatic complexity 17 of function newSession() is high (> 15) (gocyclo)

- Line 189: warning: cyclomatic complexity 25 of function unmarshalHeader() is high (> 15) (gocyclo)

- Line 65: warning: cyclomatic complexity 19 of function buildLocationElements() is high (> 15) (gocyclo)

- Line 101: warning: cyclomatic complexity 17 of function (*eniManager).CreateIPV4Address() is high (> 15) (gocyclo)

- Line 26: warning: cyclomatic complexity 19 of function TestNewRateLimitedClient() is high (> 15) (gocyclo)

- Line 46: warning: cyclomatic complexity 17 of function (*PodResourceInjector).Handle() is high (> 15) (gocyclo)

- Line 77: warning: cyclomatic complexity 26 of function getNumericalValue() is high (> 15) (gocyclo)

golint77%

Golint is a linter for Go source code.

- Line 29: warning: exported type Manager should have comment or be unexported (golint)
- Line 34: warning: exported function NewManager should have comment or be unexported (golint)

- Line 29: warning: should not use dot imports (golint)
- Line 38: warning: exported type Framework should have comment or be unexported (golint)
- Line 51: warning: exported function New should have comment or be unexported (golint)

- Line 62: warning: exported const LeaderElectionKey should have comment (or a comment on this block) or be unexported (golint)

- Line 30: warning: exported var ENIDescription should have comment or be unexported (golint)
- Line 50: warning: exported type ENIManager should have comment or be unexported (golint)

- Line 29: warning: exported const CreateENIDescriptionPrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 66: warning: exported function NewEC2APIHelper should have comment or be unexported (golint)
- Line 76: warning: exported type EC2APIHelper should have comment or be unexported (golint)
- Line 407: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 47: warning: exported type Manager should have comment or be unexported (golint)
- Line 197: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

- Line 27: warning: exported type Manager should have comment or be unexported (golint)
- Line 32: warning: exported function NewManager should have comment or be unexported (golint)

- Line 46: warning: error var mockError should have name of the form errFoo (golint)

- Line 22: warning: exported type ServiceBuilder should have comment or be unexported (golint)
- Line 32: warning: exported function NewHTTPService should have comment or be unexported (golint)
- Line 40: warning: exported method ServiceBuilder.Name should have comment or be unexported (golint)
- Line 45: warning: exported method ServiceBuilder.Namespace should have comment or be unexported (golint)
- Line 50: warning: exported method ServiceBuilder.Port should have comment or be unexported (golint)
- Line 55: warning: exported method ServiceBuilder.NodePort should have comment or be unexported (golint)
- Line 60: warning: exported method ServiceBuilder.Protocol should have comment or be unexported (golint)
- Line 65: warning: exported method ServiceBuilder.Selector should have comment or be unexported (golint)
- Line 70: warning: exported method ServiceBuilder.ServiceType should have comment or be unexported (golint)
- Line 75: warning: exported method ServiceBuilder.Build should have comment or be unexported (golint)

- Line 62: warning: exported var ReasonSecurityGroupRequested should have comment or be unexported (golint)
- Line 80: warning: exported var ErrTrunkExistInCache should have comment or be unexported (golint)

- Line 44: warning: exported type Controller should have comment or be unexported (golint)
- Line 51: warning: exported type CustomController should have comment or be unexported (golint)

- Line 30: warning: exported const MaxConcurrentReconciles should have comment or be unexported (golint)
- Line 43: warning: exported method NodeReconciler.Reconcile should have comment or be unexported (golint)
- Line 68: warning: exported method NodeReconciler.SetupWithManager should have comment or be unexported (golint)

- Line 25: warning: exported type DeploymentBuilder should have comment or be unexported (golint)
- Line 35: warning: exported function NewDefaultDeploymentBuilder should have comment or be unexported (golint)
- Line 47: warning: exported function NewWindowsDeploymentBuilder should have comment or be unexported (golint)
- Line 57: warning: exported method DeploymentBuilder.Namespace should have comment or be unexported (golint)
- Line 62: warning: exported method DeploymentBuilder.TerminationGracePeriod should have comment or be unexported (golint)
- Line 67: warning: exported method DeploymentBuilder.Name should have comment or be unexported (golint)
- Line 72: warning: exported method DeploymentBuilder.Replicas should have comment or be unexported (golint)
- Line 77: warning: exported method DeploymentBuilder.OS should have comment or be unexported (golint)
- Line 82: warning: exported method DeploymentBuilder.Container should have comment or be unexported (golint)
- Line 87: warning: exported method DeploymentBuilder.PodLabel should have comment or be unexported (golint)
- Line 92: warning: exported method DeploymentBuilder.Build should have comment or be unexported (golint)

- Line 32: warning: exported type PodReconciler should have comment or be unexported (golint)
- Line 152: warning: receiver name c should be consistent with previous receiver name r for CreateUpdateReconciler (golint)

- Line 27: warning: exported type Manager should have comment or be unexported (golint)
- Line 35: warning: exported function NewManager should have comment or be unexported (golint)

- Line 38: warning: exported const MaxRetries should have comment (or a comment on this block) or be unexported (golint)
- Line 41: warning: exported type EC2Wrapper should have comment or be unexported (golint)

- Line 16: warning: exported function GetNamespacedName should have comment or be unexported (golint)

- Line 50: warning: comment on exported type SecurityGroupPolicy should be of the form "SecurityGroupPolicy ..." (with optional leading article) (golint)

- Line 51: warning: error should be the last type when returning multiple items (golint)

- Line 191: warning: error var MockError should have name of the form ErrFoo (golint)

- Line 22: warning: exported const OperationProcessDeleteQueue should have comment (or a comment on this block) or be unexported (golint)
- Line 27: warning: comment on exported const OperationDeleted should be of the form "OperationDeleted ..." (golint)
- Line 53: warning: comment on exported function NewOnDemandCreateJob should be of the form "NewOnDemandCreateJob ..." (golint)
- Line 63: warning: comment on exported function NewOnDemandDeletedJob should be of the form "NewOnDemandDeletedJob ..." (golint)
- Line 72: warning: comment on exported function NewOnDemandReconcileNodeJob should be of the form "NewOnDemandReconcileNodeJob ..." (golint)
- Line 117: warning: exported function NewWarmPoolDeleteJob should have comment or be unexported (golint)
- Line 126: warning: exported function NewWarmProcessDeleteQueueJob should have comment or be unexported (golint)

- Line 64: warning: error var MockError should have name of the form ErrFoo (golint)

- Line 83: warning: error var mockError should have name of the form errFoo (golint)

- Line 28: warning: exported var ErrPoolAtMaxCapacity should have comment or be unexported (golint)
- Line 37: warning: exported type Pool should have comment or be unexported (golint)
- Line 75: warning: exported function NewResourcePool should have comment or be unexported (golint)

- Line 23: warning: exported type JobBuilder should have comment or be unexported (golint)
- Line 33: warning: exported function NewWindowsJob should have comment or be unexported (golint)
- Line 43: warning: exported method JobBuilder.Name should have comment or be unexported (golint)
- Line 48: warning: exported method JobBuilder.Namespace should have comment or be unexported (golint)
- Line 53: warning: exported method JobBuilder.OS should have comment or be unexported (golint)
- Line 58: warning: exported method JobBuilder.Container should have comment or be unexported (golint)
- Line 63: warning: exported method JobBuilder.PodLabels should have comment or be unexported (golint)
- Line 68: warning: exported method JobBuilder.TerminationGracePeriod should have comment or be unexported (golint)
- Line 73: warning: exported method JobBuilder.Parallelism should have comment or be unexported (golint)
- Line 78: warning: exported method JobBuilder.Build should have comment or be unexported (golint)

- Line 33: warning: exported type Manager should have comment or be unexported (golint)
- Line 46: warning: exported function NewManager should have comment or be unexported (golint)

- Line 58: warning: error var WorkersAlreadyStartedError should have name of the form ErrFoo (golint)
- Line 61: warning: exported type Worker should have comment or be unexported (golint)
- Line 87: warning: context.Context should be the first parameter of a function (golint)

- Line 51: warning: comment on exported type ResourceProviderAndPool should be of the form "ResourceProviderAndPool ..." (with optional leading article) (golint)
- Line 57: warning: exported function NewIPv4Provider should have comment or be unexported (golint)

- Line 28: warning: exported type Manager should have comment or be unexported (golint)
- Line 38: warning: exported function NewManager should have comment or be unexported (golint)

- Line 32: warning: exported const RequeueAfterWhenWPEmpty should have comment (or a comment on this block) or be unexported (golint)
- Line 45: warning: exported function NewWarmResourceHandler should have comment or be unexported (golint)

- Line 42: warning: exported method AnnotationValidator.Handle should have comment or be unexported (golint)

- Line 24: warning: exported type PodBuilder should have comment or be unexported (golint)
- Line 36: warning: exported method PodBuilder.Build should have comment or be unexported (golint)
- Line 54: warning: exported function NewDefaultPodBuilder should have comment or be unexported (golint)
- Line 67: warning: exported function NewWindowsPodBuilder should have comment or be unexported (golint)
- Line 77: warning: exported method PodBuilder.Namespace should have comment or be unexported (golint)
- Line 82: warning: exported method PodBuilder.Name should have comment or be unexported (golint)
- Line 87: warning: exported method PodBuilder.Container should have comment or be unexported (golint)
- Line 92: warning: exported method PodBuilder.OS should have comment or be unexported (golint)
- Line 97: warning: exported method PodBuilder.RestartPolicy should have comment or be unexported (golint)
- Line 102: warning: exported method PodBuilder.Labels should have comment or be unexported (golint)
- Line 107: warning: exported method PodBuilder.Annotations should have comment or be unexported (golint)
- Line 112: warning: exported method PodBuilder.ServiceAccount should have comment or be unexported (golint)
- Line 117: warning: exported method PodBuilder.TerminationGracePeriod should have comment or be unexported (golint)

- Line 25: warning: exported type SGPBuilder should have comment or be unexported (golint)
- Line 33: warning: exported function NewSGPBuilder should have comment or be unexported (golint)
- Line 43: warning: exported method SGPBuilder.Name should have comment or be unexported (golint)
- Line 48: warning: exported method SGPBuilder.Namespace should have comment or be unexported (golint)
- Line 53: warning: exported method SGPBuilder.SecurityGroup should have comment or be unexported (golint)
- Line 58: warning: exported method SGPBuilder.PodMatchLabel should have comment or be unexported (golint)
- Line 69: warning: exported method SGPBuilder.ServiceAccountMatchLabel should have comment or be unexported (golint)
- Line 80: warning: exported method SGPBuilder.ServiceAccountMatchExpression should have comment or be unexported (golint)
- Line 95: warning: exported method SGPBuilder.Build should have comment or be unexported (golint)
- Line 116: warning: exported method SGPBuilder.PodMatchExpression should have comment or be unexported (golint)

- Line 19: warning: should not use dot imports (golint)
- Line 20: warning: should not use dot imports (golint)
- Line 24: warning: context.Context should be the first parameter of a function (golint)
- Line 24: warning: exported function CreateAndWaitForDeploymentToStart should have comment or be unexported (golint)

- Line 29: warning: exported type Manager should have comment or be unexported (golint)
- Line 35: warning: exported function NewManager should have comment or be unexported (golint)

- Line 48: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 17: warning: exported var GitVersion should have comment or be unexported (golint)

- Line 34: warning: error var mockError should have name of the form errFoo (golint)

- Line 55: warning: error var mockError should have name of the form errFoo (golint)

- Line 23: warning: exported type ServiceAccountBuilder should have comment or be unexported (golint)
- Line 29: warning: exported function NewServiceAccountBuilder should have comment or be unexported (golint)
- Line 36: warning: exported method ServiceAccountBuilder.Name should have comment or be unexported (golint)
- Line 41: warning: exported method ServiceAccountBuilder.Namespace should have comment or be unexported (golint)
- Line 46: warning: exported method ServiceAccountBuilder.Label should have comment or be unexported (golint)
- Line 54: warning: exported method ServiceAccountBuilder.Build should have comment or be unexported (golint)

- Line 19: warning: exported const PollIntervalShort should have comment (or a comment on this block) or be unexported (golint)

- Line 24: warning: should not use dot imports (golint)
- Line 25: warning: should not use dot imports (golint)
- Line 29: warning: exported type PodVerification should have comment or be unexported (golint)
- Line 34: warning: context.Context should be the first parameter of a function (golint)
- Line 34: warning: exported function NewPodVerification should have comment or be unexported (golint)
- Line 41: warning: exported method PodVerification.PodHasExpectedSG should have comment or be unexported (golint)
- Line 58: warning: exported method PodVerification.PodsHaveExpectedSG should have comment or be unexported (golint)
- Line 70: warning: exported method PodVerification.PodHasNoBranchENIAnnotationInjected should have comment or be unexported (golint)
- Line 76: warning: exported method PodVerification.WindowsPodsHaveExpectedIPv4Address should have comment or be unexported (golint)
- Line 87: warning: exported method PodVerification.WindowsPodHaveExpectedIPv4Address should have comment or be unexported (golint)

- Line 19: warning: should not use dot imports (golint)
- Line 20: warning: should not use dot imports (golint)
- Line 24: warning: context.Context should be the first parameter of a function (golint)
- Line 24: warning: exported function CreateAndWaitForPodToStart should have comment or be unexported (golint)

- Line 27: warning: exported type Manager should have comment or be unexported (golint)
- Line 36: warning: exported function NewManager should have comment or be unexported (golint)

- Line 25: warning: exported type ENIConfigBuilder should have comment or be unexported (golint)
- Line 31: warning: exported function NewENIConfigBuilder should have comment or be unexported (golint)
- Line 37: warning: exported method ENIConfigBuilder.Name should have comment or be unexported (golint)
- Line 42: warning: exported method ENIConfigBuilder.SubnetID should have comment or be unexported (golint)
- Line 47: warning: exported method ENIConfigBuilder.SecurityGroup should have comment or be unexported (golint)
- Line 52: warning: exported method ENIConfigBuilder.Build should have comment or be unexported (golint)

- Line 17: warning: exported const ResourceNamePrefix should have comment (or a comment on this block) or be unexported (golint)

- Line 40: warning: exported const NodeNameSpec should have comment (or a comment on this block) or be unexported (golint)

- Line 53: warning: exported type K8sCacheHelper should have comment or be unexported (golint)

- Line 17: warning: exported const WorkQueueDefaultMaxRetries should have comment (or a comment on this block) or be unexported (golint)
- Line 19: warning: comment on exported const PodENIDefaultWorker should be of the form "PodENIDefaultWorker ..." (golint)
- Line 22: warning: comment on exported const IPv4DefaultWorker should be of the form "IPv4DefaultWorker ..." (golint)
- Line 28: warning: comment on exported const UserServiceClientQPS should be of the form "UserServiceClientQPS ..." (golint)
- Line 32: warning: comment on exported const InstanceServiceClientQPS should be of the form "InstanceServiceClientQPS ..." (golint)
- Line 36: warning: comment on exported const DefaultAPIServerQPS should be of the form "DefaultAPIServerQPS ..." (golint)

- Line 28: warning: exported type ENICleaner should have comment or be unexported (golint)
- Line 38: warning: context.Context should be the first parameter of a function (golint)
- Line 48: warning: comment on exported method ENICleaner.Start should be of the form "Start ..." (golint)

- Line 20: warning: exported type Container should have comment or be unexported (golint)
- Line 28: warning: exported function NewBusyBoxContainerBuilder should have comment or be unexported (golint)
- Line 38: warning: exported function NewWindowsContainerBuilder should have comment or be unexported (golint)
- Line 48: warning: exported method Container.Name should have comment or be unexported (golint)
- Line 53: warning: exported method Container.Image should have comment or be unexported (golint)
- Line 58: warning: exported method Container.ImagePullPolicy should have comment or be unexported (golint)
- Line 63: warning: exported method Container.Command should have comment or be unexported (golint)
- Line 68: warning: exported method Container.Args should have comment or be unexported (golint)
- Line 73: warning: exported method Container.Build should have comment or be unexported (golint)

- Line 49: warning: exported type Node should have comment or be unexported (golint)

- Line 46: warning: exported method PodResourceInjector.Handle should have comment or be unexported (golint)

- Line 23: warning: should not use dot imports (golint)
- Line 24: warning: should not use dot imports (golint)
- Line 28: warning: context.Context should be the first parameter of a function (golint)
- Line 28: warning: exported function CreateSecurityGroupPolicy should have comment or be unexported (golint)
- Line 35: warning: context.Context should be the first parameter of a function (golint)
- Line 35: warning: exported function UpdateSecurityGroupPolicy should have comment or be unexported (golint)

- Line 67: warning: error var mockError should have name of the form errFoo (golint)

- Line 23: warning: exported var GlobalOptions should have comment or be unexported (golint)
- Line 29: warning: exported type Options should have comment or be unexported (golint)
- Line 36: warning: exported method Options.BindFlags should have comment or be unexported (golint)
- Line 43: warning: exported method Options.Validate should have comment or be unexported (golint)

- Line 46: warning: exported var InterfaceTypeTrunk should have comment or be unexported (golint)
- Line 52: warning: exported var ErrCurrentlyAtMaxCapacity should have comment or be unexported (golint)
- Line 68: warning: exported type TrunkENI should have comment or be unexported (golint)
- Line 105: warning: comment on exported type ENIDetails should be of the form "ENIDetails ..." (with optional leading article) (golint)
- Line 140: warning: exported function PrometheusRegister should have comment or be unexported (golint)

- Line 37: warning: comment on exported method PodConverter.ConvertObject should be of the form "ConvertObject ..." (golint)
- Line 46: warning: comment on exported method PodConverter.ConvertList should be of the form "ConvertList ..." (golint)