Preparing report...

Report for github.com/backube/scribe

A+    Excellent!    Found 12 issues across 25 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint56%

Golint is a linter for Go source code.

    • scribe/api/v1alpha1/replicationdestination_types.go
    • Line 34: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
    • Line 63: warning: exported type ReplicationDestinationVolumeOptions should have comment or be unexported (golint)
    • Line 89: warning: exported type ReplicationDestinationRsyncSpec should have comment or be unexported (golint)
    • Line 163: warning: exported type ReplicationDestinationRsyncStatus should have comment or be unexported (golint)
    • scribe/api/v1alpha1/replicationsource_types.go
    • Line 34: warning: package comment should be of the form "Package v1alpha1 ..." (golint)
    • Line 75: warning: exported type ReplicationSourceVolumeOptions should have comment or be unexported (golint)
    • Line 96: warning: exported type ReplicationSourceRsyncSpec should have comment or be unexported (golint)
    • Line 210: warning: exported type ReplicationSourceRsyncStatus should have comment or be unexported (golint)
    • scribe/pkg/cmd/destination.go
    • Line 16: warning: exported type DestinationOptions should have comment or be unexported (golint)
    • Line 38: warning: comment on exported method DestinationOptions.Bind should be of the form "Bind ..." (golint)
    • scribe/pkg/cmd/set_replication.go
    • Line 1: warning: package comment should be of the form "Package cmd ..." (golint)
    • Line 50: warning: exported type FinalizeOptions should have comment or be unexported (golint)
    • Line 62: warning: exported function NewFinalizeOptions should have comment or be unexported (golint)
    • Line 68: warning: exported function NewCmdScribeSetReplication should have comment or be unexported (golint)
    • Line 106: warning: exported method FinalizeOptions.Bind should have comment or be unexported (golint)
    • Line 118: warning: exported method FinalizeOptions.Complete should have comment or be unexported (golint)
    • Line 131: warning: comment on exported method FinalizeOptions.SetReplication should be of the form "SetReplication ..." (golint)
    • scribe/controllers/replicationdestination_controller.go
    • Line 88: warning: comment on exported method ReplicationDestinationReconciler.Reconcile should be of the form "Reconcile ..." (golint)
    • Line 157: warning: exported method ReplicationDestinationReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 291: warning: comment on exported function RunRsyncDestReconciler should be of the form "RunRsyncDestReconciler ..." (golint)
    • scribe/pkg/cmd/continue_replication.go
    • Line 39: warning: exported function NewCmdScribeContinueReplication should have comment or be unexported (golint)
    • Line 60: warning: comment on exported method FinalizeOptions.Continue should be of the form "Continue ..." (golint)
    • scribe/pkg/cmd/create_replication.go
    • Line 50: warning: exported type SetupReplicationOptions should have comment or be unexported (golint)
    • Line 72: warning: exported function NewSetupReplicationOptions should have comment or be unexported (golint)
    • Line 78: warning: exported function NewCmdScribeStartReplication should have comment or be unexported (golint)
    • Line 140: warning: exported method SetupReplicationOptions.Bind should have comment or be unexported (golint)
    • Line 152: warning: exported method SetupReplicationOptions.Complete should have comment or be unexported (golint)
    • Line 171: warning: comment on exported method SetupReplicationOptions.Validate should be of the form "Validate ..." (golint)
    • Line 222: warning: comment on exported method SetupReplicationOptions.StartReplication should be of the form "StartReplication ..." (golint)
    • Line 387: warning: exported method SetupReplicationOptions.GetSourcePVC should have comment or be unexported (golint)
    • Line 441: warning: comment on exported method SetupReplicationOptions.CreateDestination should be of the form "CreateDestination ..." (golint)
    • scribe/pkg/cmd/remove_replication.go
    • Line 42: warning: exported function NewCmdScribeRemoveReplication should have comment or be unexported (golint)
    • Line 63: warning: comment on exported method FinalizeOptions.RemoveReplication should be of the form "RemoveReplication ..." (golint)
    • scribe/pkg/cmd/scribe.go
    • Line 40: warning: exported var ScribeVersion should have comment or be unexported (golint)
    • Line 43: warning: exported type ReplicationOptions should have comment or be unexported (golint)
    • Line 50: warning: exported type Config should have comment or be unexported (golint)
    • Line 54: warning: exported type ScribeSourceOptions should have comment or be unexported (golint)
    • Line 72: warning: exported type ScribeDestinationOptions should have comment or be unexported (golint)
    • Line 90: warning: comment on exported method ScribeSourceOptions.Bind should be of the form "Bind ..." (golint)
    • Line 105: warning: comment on exported method ScribeDestinationOptions.Bind should be of the form "Bind ..." (golint)
    • Line 171: warning: exported method Config.Bind should have comment or be unexported (golint)
    • Line 179: warning: exported method ReplicationOptions.Bind should have comment or be unexported (golint)
    • Line 207: warning: exported method ReplicationOptions.Complete should have comment or be unexported (golint)
    • Line 219: warning: comment on exported method ScribeSourceOptions.Complete should be of the form "Complete ..." (golint)
    • Line 251: warning: comment on exported method ScribeDestinationOptions.Complete should be of the form "Complete ..." (golint)
    • scribe/pkg/cmd/sync_secret.go
    • Line 17: warning: exported type SSHKeysSecretOptions should have comment or be unexported (golint)
    • Line 23: warning: comment on exported method SSHKeysSecretOptions.Bind should be of the form "Bind ..." (golint)
    • Line 36: warning: exported method SSHKeysSecretOptions.SyncSSHSecret should have comment or be unexported (golint)
    • scribe/controllers/replicationsource_controller.go
    • Line 74: warning: comment on exported method ReplicationSourceReconciler.Reconcile should be of the form "Reconcile ..." (golint)
    • Line 143: warning: exported method ReplicationSourceReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 294: warning: comment on exported function RunRsyncSrcReconciler should be of the form "RunRsyncSrcReconciler ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell96%

Misspell Finds commonly misspelled English words