Preparing report...

Report for github.com/bilibili/overlord

A+    Excellent!    Found 46 issues across 176 files

Tweet

gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • overlord/platform/mesos/scheduler.go
    • Line 253: warning: cyclomatic complexity 21 of function (*Scheduler).tryRecovery() is high (> 15) (gocyclo)
    • Line 570: warning: cyclomatic complexity 19 of function (*Scheduler).dispatchSingleton() is high (> 15) (gocyclo)
    • overlord/anzi/rdb.go
    • Line 460: warning: cyclomatic complexity 32 of function (*RDB).readObject() is high (> 15) (gocyclo)
    • Line 683: warning: cyclomatic complexity 31 of function (*RDB).readZipListEntry() is high (> 15) (gocyclo)
    • Line 1047: warning: cyclomatic complexity 25 of function (*RDB).readStream() is high (> 15) (gocyclo)
    • Line 107: warning: cyclomatic complexity 22 of function (*RDB).bgSyncProc() is high (> 15) (gocyclo)

golint92%

Golint is a linter for Go source code.

    • overlord/pkg/mockconn/conn.go
    • Line 71: warning: exported method MockConn.Close should have comment or be unexported (golint)
    • Line 76: warning: exported method MockConn.LocalAddr should have comment or be unexported (golint)
    • Line 77: warning: exported method MockConn.RemoteAddr should have comment or be unexported (golint)
    • Line 79: warning: exported method MockConn.SetDeadline should have comment or be unexported (golint)
    • Line 80: warning: exported method MockConn.SetReadDeadline should have comment or be unexported (golint)
    • Line 81: warning: exported method MockConn.SetWriteDeadline should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell93%

Misspell Finds commonly misspelled English words

    • overlord/platform/mesos/mesos.go
    • Line 56: warning: "insufficent" is a misspelling of "insufficient" (misspell)
    • Line 60: warning: "insufficent" is a misspelling of "insufficient" (misspell)
    • Line 71: warning: "insufficent" is a misspelling of "insufficient" (misspell)