gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• overlord/platform/chunk/chunk_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/platform/job/create/job_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/redis/cluster/slot_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/memcache/request.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/memcache/binary/proxy_conn_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/redis/resp_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/platform/job/balance/exec.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/ci/tests/proxy/proxy_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/forwarder.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/platform/job/create/tools.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/enri/node.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/platform/job/state.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/memcache/binary/request.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• overlord/proxy/proto/redis/proxy_conn_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• overlord/platform/chunk/chunk.go
  • Line 468: warning: cyclomatic complexity 17 of function ChunksRecover() is high (> 15) (gocyclo)

• overlord/platform/mesos/scheduler.go
  • Line 253: warning: cyclomatic complexity 21 of function (*Scheduler).tryRecovery() is high (> 15) (gocyclo)
  • Line 570: warning: cyclomatic complexity 19 of function (*Scheduler).dispatchSingleton() is high (> 15) (gocyclo)

• overlord/proxy/proto/memcache/proxy_conn.go
  • Line 75: warning: cyclomatic complexity 19 of function (*proxyConn).decode() is high (> 15) (gocyclo)

• overlord/proxy/proto/memcache/request.go
  • Line 74: warning: cyclomatic complexity 18 of function (RequestType).String() is high (> 15) (gocyclo)
  • Line 115: warning: cyclomatic complexity 18 of function (RequestType).Bytes() is high (> 15) (gocyclo)

• overlord/platform/job/balance/exec.go
  • Line 37: warning: cyclomatic complexity 17 of function genTryBalanceJob() is high (> 15) (gocyclo)

• overlord/platform/job/create/server_singleton.go
  • Line 48: warning: cyclomatic complexity 16 of function (*CacheJob).buildTplTree() is high (> 15) (gocyclo)

• overlord/proxy/proto/memcache/node_conn.go
  • Line 93: warning: cyclomatic complexity 16 of function (*nodeConn).Read() is high (> 15) (gocyclo)

• overlord/proxy/proto/redis/cluster/slot.go
  • Line 34: warning: cyclomatic complexity 16 of function parseSlots() is high (> 15) (gocyclo)

• overlord/enri/manage.go
  • Line 108: warning: cyclomatic complexity 18 of function Migrate() is high (> 15) (gocyclo)

• overlord/platform/chunk/dist.go
  • Line 57: warning: cyclomatic complexity 16 of function DistAppendIt() is high (> 15) (gocyclo)

• overlord/proxy/proto/pipe.go
  • Line 128: warning: cyclomatic complexity 20 of function (*msgPipe).pipe() is high (> 15) (gocyclo)

• overlord/platform/job/create/server_cluster.go
  • Line 57: warning: cyclomatic complexity 17 of function (*RedisClusterJob).buildTplTree() is high (> 15) (gocyclo)

• overlord/proxy/proto/memcache/binary/request.go
  • Line 202: warning: cyclomatic complexity 27 of function (RequestType).String() is high (> 15) (gocyclo)
  • Line 143: warning: cyclomatic complexity 27 of function (RequestType).Bytes() is high (> 15) (gocyclo)

• overlord/anzi/rdb.go
  • Line 460: warning: cyclomatic complexity 32 of function (*RDB).readObject() is high (> 15) (gocyclo)
  • Line 683: warning: cyclomatic complexity 31 of function (*RDB).readZipListEntry() is high (> 15) (gocyclo)
  • Line 1047: warning: cyclomatic complexity 25 of function (*RDB).readStream() is high (> 15) (gocyclo)
  • Line 107: warning: cyclomatic complexity 22 of function (*RDB).bgSyncProc() is high (> 15) (gocyclo)

• overlord/enri/cmd.go
  • Line 25: warning: cyclomatic complexity 16 of function Run() is high (> 15) (gocyclo)

golint92%

Golint is a linter for Go source code.

• overlord/ci/fuzz/mcparser/fuzz.go
  • Line 22: warning: exported function Fuzz should have comment or be unexported (golint)

• overlord/ci/fuzz/redisparser/redisparser.go
  • Line 22: warning: exported function Fuzz should have comment or be unexported (golint)

• overlord/pkg/myredis/cmd.go
  • Line 23: warning: exported type Resp should have comment or be unexported (golint)
  • Line 99: warning: exported method Command.Arg should have comment or be unexported (golint)

• overlord/platform/api/dao/dao.go
  • Line 27: warning: exported method Dao.ETCD should have comment or be unexported (golint)

• overlord/ci/fuzz/mcNodeConnRetirival/fuzz.go
  • Line 1: warning: don't use MixedCaps in package name; mcNodeConnRetrival should be mcnodeconnretrival (golint)
  • Line 8: warning: exported function Fuzz should have comment or be unexported (golint)

• overlord/ci/fuzz/mcNodeConnRetirival/mock.go
  • Line 1: warning: don't use MixedCaps in package name; mcNodeConnRetrival should be mcnodeconnretrival (golint)

• overlord/pkg/mockconn/conn.go
  • Line 71: warning: exported method MockConn.Close should have comment or be unexported (golint)
  • Line 76: warning: exported method MockConn.LocalAddr should have comment or be unexported (golint)
  • Line 77: warning: exported method MockConn.RemoteAddr should have comment or be unexported (golint)
  • Line 79: warning: exported method MockConn.SetDeadline should have comment or be unexported (golint)
  • Line 80: warning: exported method MockConn.SetReadDeadline should have comment or be unexported (golint)
  • Line 81: warning: exported method MockConn.SetWriteDeadline should have comment or be unexported (golint)

• overlord/proxy/proto/message.go
  • Line 161: warning: comment on exported method Message.MarkEndPipe should be of the form "MarkEndPipe ..." (golint)

• overlord/pkg/myredis/myredis.go
  • Line 230: warning: exported method Conn.Exec should have comment or be unexported (golint)

• overlord/platform/mesos/scheduler.go
  • Line 240: warning: context.Context should be the first parameter of a function (golint)

• overlord/proxy/proto/memcache/request.go
  • Line 275: warning: exported method MCRequest.Merge should have comment or be unexported (golint)

• overlord/platform/mesos/tools.go
  • Line 20: warning: exported method Duration.UnmarshalText should have comment or be unexported (golint)

• overlord/proxy/proto/memcache/binary/request.go
  • Line 372: warning: exported method MCRequest.Merge should have comment or be unexported (golint)

• overlord/proxy/proto/redis/request.go
  • Line 158: warning: exported method Request.Merge should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell93%

Misspell Finds commonly misspelled English words

• overlord/platform/api/service/cluster.go
  • Line 36: warning: "asign" is a misspelling of "assign" (misspell)

• overlord/platform/mesos/mesos.go
  • Line 56: warning: "insufficent" is a misspelling of "insufficient" (misspell)
  • Line 60: warning: "insufficent" is a misspelling of "insufficient" (misspell)
  • Line 71: warning: "insufficent" is a misspelling of "insufficient" (misspell)

• overlord/ci/tests/proxy/proxy_test.go
  • Line 129: warning: "avaliable" is a misspelling of "available" (misspell)
  • Line 276: warning: "basicly" is a misspelling of "basically" (misspell)
  • Line 297: warning: "basicly" is a misspelling of "basically" (misspell)

• overlord/platform/chunk/node.go
  • Line 50: warning: "contians" is a misspelling of "contains" (misspell)

• overlord/proxy/proto/redis/cluster/fetch.go
  • Line 84: warning: "conneciton" is a misspelling of "connection" (misspell)

• overlord/pkg/proc/proc.go
  • Line 33: warning: "useing" is a misspelling of "using" (misspell)

• overlord/platform/mesos/executor.go
  • Line 192: warning: "sucess" is a misspelling of "success" (misspell)

• overlord/platform/mesos/scheduler.go
  • Line 112: warning: "comming" is a misspelling of "coming" (misspell)
  • Line 234: warning: "comming" is a misspelling of "coming" (misspell)

• overlord/pkg/memcache/conn.go
  • Line 48: warning: "happend" is a misspelling of "happened" (misspell)

• overlord/platform/job/create/types.go
  • Line 20: warning: "becasue" is a misspelling of "because" (misspell)

• overlord/proxy/proto/slowlog.go
  • Line 11: warning: "infomation" is a misspelling of "information" (misspell)