Report for github.com/binance-chain/tss-lib
A+ Excellent! Found 62 issues across 103 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo88%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
tss-lib/ecdsa/keygen/round_3.go
- Line 23: warning: cyclomatic complexity 29 of function (*round3).Start() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/resharing/local_party_test.go
- Line 40: warning: cyclomatic complexity 35 of function TestE2EConcurrent() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/resharing/round_2_new_step_1.go
- Line 106: warning: cyclomatic complexity 19 of function (*round2).Update() is high (> 15) (gocyclo)
-
-
tss-lib/eddsa/keygen/round_3.go
- Line 23: warning: cyclomatic complexity 32 of function (*round3).Start() is high (> 15) (gocyclo)
-
-
tss-lib/eddsa/resharing/local_party_test.go
- Line 38: warning: cyclomatic complexity 33 of function TestE2EConcurrent() is high (> 15) (gocyclo)
-
-
tss-lib/eddsa/resharing/round_4_new_step_2.go
- Line 21: warning: cyclomatic complexity 17 of function (*round4).Start() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/keygen/prepare.go
- Line 31: warning: cyclomatic complexity 20 of function GeneratePreParams() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/keygen/local_party_test.go
- Line 169: warning: cyclomatic complexity 19 of function TestE2EConcurrentAndSaveFixtures() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/keygen/round_2.go
- Line 18: warning: cyclomatic complexity 16 of function (*round2).Start() is high (> 15) (gocyclo)
-
-
tss-lib/ecdsa/resharing/round_4_new_step_2.go
- Line 24: warning: cyclomatic complexity 30 of function (*round4).Start() is high (> 15) (gocyclo)
-
-
tss-lib/common/safe_prime.go
- Line 210: warning: cyclomatic complexity 20 of function runGenPrimeRoutine() is high (> 15) (gocyclo)
-
-
tss-lib/eddsa/keygen/local_party_test.go
- Line 40: warning: cyclomatic complexity 20 of function TestE2EConcurrentAndSaveFixtures() is high (> 15) (gocyclo)
golint50%
Golint is a linter for Go source code.
-
-
tss-lib/eddsa/keygen/test_utils.go
- Line 25: warning: comment on exported const TestParticipants should be of the form "TestParticipants ..." (golint)
- Line 28: warning: exported const TestThreshold should have comment (or a comment on this block) or be unexported (golint)
- Line 35: warning: exported function LoadKeygenTestFixtures should have comment or be unexported (golint)
- Line 66: warning: exported function LoadKeygenTestFixturesRandomSet should have comment or be unexported (golint)
-
-
tss-lib/crypto/schnorr/schnorr_proof.go
- Line 19: warning: exported type ZKProof should have comment or be unexported (golint)
- Line 24: warning: exported type ZKVProof should have comment or be unexported (golint)
- Line 53: warning: comment on exported method ZKProof.Verify should be of the form "Verify ..." (golint)
- Line 76: warning: exported method ZKProof.ValidateBasic should have comment or be unexported (golint)
- Line 80: warning: comment on exported function NewZKVProof should be of the form "NewZKVProof ..." (golint)
- Line 106: warning: exported method ZKVProof.Verify should have comment or be unexported (golint)
- Line 131: warning: exported method ZKVProof.ValidateBasic should have comment or be unexported (golint)
-
-
tss-lib/crypto/commitments/commitment.go
- Line 19: warning: exported const HashLength should have comment (or a comment on this block) or be unexported (golint)
- Line 23: warning: exported type HashCommitment should have comment or be unexported (golint)
- Line 24: warning: exported type HashDeCommitment should have comment or be unexported (golint)
- Line 26: warning: exported type HashCommitDecommit should have comment or be unexported (golint)
- Line 32: warning: exported function NewHashCommitmentWithRandomness should have comment or be unexported (golint)
- Line 46: warning: exported function NewHashCommitment should have comment or be unexported (golint)
- Line 51: warning: exported function NewHashDeCommitmentFromBytes should have comment or be unexported (golint)
- Line 55: warning: exported method HashCommitDecommit.Verify should have comment or be unexported (golint)
- Line 64: warning: exported method HashCommitDecommit.DeCommit should have comment or be unexported (golint)
- Line 68: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
tss-lib/crypto/commitments/commitment_builder.go
- Line 16: warning: exported const PartsCap should have comment (or a comment on this block) or be unexported (golint)
- Line 24: warning: exported function NewBuilder should have comment or be unexported (golint)
- Line 59: warning: exported function ParseSecrets should have comment or be unexported (golint)
-
-
tss-lib/eddsa/resharing/local_party.go
- Line 27: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 62: warning: comment on exported function NewLocalParty should be of the form "NewLocalParty ..." (golint)
- Line 96: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 100: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 104: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 108: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 116: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 135: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 162: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/tss/error.go
- Line 13: warning: comment on exported type Error should be of the form "Error ..." (with optional leading article) (golint)
- Line 22: warning: exported function NewError should have comment or be unexported (golint)
- Line 28: warning: exported method Error.Cause should have comment or be unexported (golint)
- Line 30: warning: exported method Error.Task should have comment or be unexported (golint)
- Line 32: warning: exported method Error.Round should have comment or be unexported (golint)
- Line 34: warning: exported method Error.Victim should have comment or be unexported (golint)
- Line 36: warning: exported method Error.Culprits should have comment or be unexported (golint)
-
-
tss-lib/eddsa/signing/messages.go
- Line 41: warning: exported function NewSignRound1Message should have comment or be unexported (golint)
- Line 56: warning: exported method SignRound1Message.ValidateBasic should have comment or be unexported (golint)
- Line 61: warning: exported method SignRound1Message.UnmarshalCommitment should have comment or be unexported (golint)
- Line 67: warning: exported function NewSignRound2Message should have comment or be unexported (golint)
- Line 87: warning: exported method SignRound2Message.ValidateBasic should have comment or be unexported (golint)
- Line 95: warning: exported method SignRound2Message.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 100: warning: exported method SignRound2Message.UnmarshalZKProof should have comment or be unexported (golint)
- Line 116: warning: exported function NewSignRound3Message should have comment or be unexported (golint)
- Line 131: warning: exported method SignRound3Message.ValidateBasic should have comment or be unexported (golint)
- Line 136: warning: exported method SignRound3Message.UnmarshalS should have comment or be unexported (golint)
-
-
tss-lib/crypto/mta/share_protocol.go
- Line 19: warning: exported function AliceInit should have comment or be unexported (golint)
- Line 31: warning: exported function BobMid should have comment or be unexported (golint)
- Line 59: warning: exported function BobMidWC should have comment or be unexported (golint)
- Line 88: warning: exported function AliceEnd should have comment or be unexported (golint)
- Line 105: warning: exported function AliceEndWC should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/keygen/local_party.go
- Line 26: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 57: warning: comment on exported function NewLocalParty should be of the form "NewLocalParty ..." (golint)
- Line 94: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 98: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 102: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 106: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 114: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 126: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 151: warning: comment on exported method LocalPartySaveData.OriginalIndex should be of the form "OriginalIndex ..." (golint)
- Line 168: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/signing/rounds.go
- Line 16: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/crypto/utils.go
- Line 16: warning: exported function GenerateNTildei should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/resharing/messages.go
- Line 46: warning: exported function NewDGRound1Message should have comment or be unexported (golint)
- Line 67: warning: exported method DGRound1Message.ValidateBasic should have comment or be unexported (golint)
- Line 74: warning: exported method DGRound1Message.UnmarshalECDSAPub should have comment or be unexported (golint)
- Line 81: warning: exported method DGRound1Message.UnmarshalVCommitment should have comment or be unexported (golint)
- Line 87: warning: exported function NewDGRound2Message1 should have comment or be unexported (golint)
- Line 123: warning: exported method DGRound2Message1.ValidateBasic should have comment or be unexported (golint)
- Line 135: warning: exported method DGRound2Message1.UnmarshalPaillierPK should have comment or be unexported (golint)
- Line 141: warning: exported method DGRound2Message1.UnmarshalNTilde should have comment or be unexported (golint)
- Line 145: warning: exported method DGRound2Message1.UnmarshalH1 should have comment or be unexported (golint)
- Line 149: warning: exported method DGRound2Message1.UnmarshalH2 should have comment or be unexported (golint)
- Line 153: warning: exported method DGRound2Message1.UnmarshalPaillierProof should have comment or be unexported (golint)
- Line 160: warning: exported method DGRound2Message1.UnmarshalDLNProof1 should have comment or be unexported (golint)
- Line 164: warning: exported method DGRound2Message1.UnmarshalDLNProof2 should have comment or be unexported (golint)
- Line 170: warning: exported function NewDGRound2Message2 should have comment or be unexported (golint)
- Line 185: warning: exported method DGRound2Message2.ValidateBasic should have comment or be unexported (golint)
- Line 191: warning: exported function NewDGRound3Message1 should have comment or be unexported (golint)
- Line 209: warning: exported method DGRound3Message1.ValidateBasic should have comment or be unexported (golint)
- Line 216: warning: exported function NewDGRound3Message2 should have comment or be unexported (golint)
- Line 235: warning: exported method DGRound3Message2.ValidateBasic should have comment or be unexported (golint)
- Line 240: warning: exported method DGRound3Message2.UnmarshalVDeCommitment should have comment or be unexported (golint)
- Line 247: warning: exported function NewDGRound4Message should have comment or be unexported (golint)
- Line 262: warning: exported method DGRound4Message.ValidateBasic should have comment or be unexported (golint)
-
-
tss-lib/tss/peers.go
- Line 10: warning: exported type PeerContext should have comment or be unexported (golint)
- Line 15: warning: exported function NewPeerContext should have comment or be unexported (golint)
- Line 19: warning: exported method PeerContext.IDs should have comment or be unexported (golint)
- Line 23: warning: exported method PeerContext.SetIDs should have comment or be unexported (golint)
-
-
tss-lib/eddsa/signing/local_party.go
- Line 27: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 65: warning: exported function NewLocalParty should have comment or be unexported (golint)
- Line 93: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 97: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 110: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 114: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 122: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 134: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 160: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/common/logger.go
- Line 13: warning: exported var Logger should have comment or be unexported (golint)
-
-
tss-lib/common/slice.go
- Line 13: warning: exported function BigIntsToBytes should have comment or be unexported (golint)
- Line 24: warning: exported function MultiBytesToBigInts should have comment or be unexported (golint)
- Line 32: warning: comment on exported function NonEmptyBytes should be of the form "NonEmptyBytes ..." (golint)
- Line 37: warning: comment on exported function NonEmptyMultiBytes should be of the form "NonEmptyMultiBytes ..." (golint)
-
-
tss-lib/crypto/mta/proofs.go
- Line 21: warning: exported const ProofBobBytesParts should have comment (or a comment on this block) or be unexported (golint)
- Line 26: warning: exported type ProofBob should have comment or be unexported (golint)
- Line 30: warning: exported type ProofBobWC should have comment or be unexported (golint)
- Line 148: warning: exported function ProofBobWCFromBytes should have comment or be unexported (golint)
- Line 165: warning: exported function ProofBobFromBytes should have comment or be unexported (golint)
- Line 186: warning: comment on exported method ProofBobWC.Verify should be of the form "Verify ..." (golint)
- Line 270: warning: comment on exported method ProofBob.Verify should be of the form "Verify ..." (golint)
- Line 279: warning: exported method ProofBob.ValidateBasic should have comment or be unexported (golint)
- Line 292: warning: exported method ProofBobWC.ValidateBasic should have comment or be unexported (golint)
- Line 296: warning: exported method ProofBob.Bytes should have comment or be unexported (golint)
- Line 311: warning: exported method ProofBobWC.Bytes should have comment or be unexported (golint)
-
-
tss-lib/eddsa/keygen/messages.go
- Line 42: warning: exported function NewKGRound1Message should have comment or be unexported (golint)
- Line 54: warning: exported method KGRound1Message.ValidateBasic should have comment or be unexported (golint)
- Line 58: warning: exported method KGRound1Message.UnmarshalCommitment should have comment or be unexported (golint)
- Line 64: warning: exported function NewKGRound2Message1 should have comment or be unexported (golint)
- Line 80: warning: exported method KGRound2Message1.ValidateBasic should have comment or be unexported (golint)
- Line 85: warning: exported method KGRound2Message1.UnmarshalShare should have comment or be unexported (golint)
- Line 91: warning: exported function NewKGRound2Message2 should have comment or be unexported (golint)
- Line 111: warning: exported method KGRound2Message2.ValidateBasic should have comment or be unexported (golint)
- Line 116: warning: exported method KGRound2Message2.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 121: warning: exported method KGRound2Message2.UnmarshalZKProof should have comment or be unexported (golint)
-
-
tss-lib/crypto/dlnproof/proof.go
- Line 22: warning: exported const Iterations should have comment or be unexported (golint)
- Line 25: warning: exported type Proof should have comment or be unexported (golint)
- Line 31: warning: exported function NewDLNProof should have comment or be unexported (golint)
- Line 52: warning: exported method Proof.Verify should have comment or be unexported (golint)
- Line 76: warning: exported method Proof.Serialize should have comment or be unexported (golint)
- Line 95: warning: exported function UnmarshalDLNProof should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/resharing/local_party.go
- Line 27: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 63: warning: comment on exported function NewLocalParty should be of the form "NewLocalParty ..." (golint)
- Line 101: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 105: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 109: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 113: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 121: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 140: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 169: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/eddsa/resharing/messages.go
- Line 43: warning: exported function NewDGRound1Message should have comment or be unexported (golint)
- Line 64: warning: exported method DGRound1Message.ValidateBasic should have comment or be unexported (golint)
- Line 71: warning: exported method DGRound1Message.UnmarshalEDDSAPub should have comment or be unexported (golint)
- Line 78: warning: exported method DGRound1Message.UnmarshalVCommitment should have comment or be unexported (golint)
- Line 84: warning: exported function NewDGRound2Message should have comment or be unexported (golint)
- Line 99: warning: exported method DGRound2Message.ValidateBasic should have comment or be unexported (golint)
- Line 105: warning: exported function NewDGRound3Message1 should have comment or be unexported (golint)
- Line 123: warning: exported method DGRound3Message1.ValidateBasic should have comment or be unexported (golint)
- Line 130: warning: exported function NewDGRound3Message2 should have comment or be unexported (golint)
- Line 149: warning: exported method DGRound3Message2.ValidateBasic should have comment or be unexported (golint)
- Line 154: warning: exported method DGRound3Message2.UnmarshalVDeCommitment should have comment or be unexported (golint)
- Line 161: warning: exported function NewDGRound4Message should have comment or be unexported (golint)
- Line 176: warning: exported method DGRound4Message.ValidateBasic should have comment or be unexported (golint)
-
-
tss-lib/common/safe_prime.go
- Line 26: warning: exported type GermainSafePrime should have comment or be unexported (golint)
- Line 32: warning: exported method GermainSafePrime.Prime should have comment or be unexported (golint)
- Line 36: warning: exported method GermainSafePrime.SafePrime should have comment or be unexported (golint)
- Line 40: warning: exported method GermainSafePrime.Validate should have comment or be unexported (golint)
-
-
tss-lib/eddsa/keygen/local_party.go
- Line 26: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 57: warning: comment on exported function NewLocalParty should be of the form "NewLocalParty ..." (golint)
- Line 83: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 87: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 91: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 95: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 103: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 115: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 138: warning: comment on exported method LocalPartySaveData.OriginalIndex should be of the form "OriginalIndex ..." (golint)
- Line 155: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/keygen/test_utils.go
- Line 26: warning: comment on exported const TestParticipants should be of the form "TestParticipants ..." (golint)
- Line 29: warning: exported const TestThreshold should have comment (or a comment on this block) or be unexported (golint)
- Line 36: warning: exported function LoadKeygenTestFixtures should have comment or be unexported (golint)
- Line 67: warning: exported function LoadKeygenTestFixturesRandomSet should have comment or be unexported (golint)
- Line 105: warning: exported function LoadNTildeH1H2FromTestFixture should have comment or be unexported (golint)
-
-
tss-lib/tss/message.go
- Line 66: warning: comment on exported type MessageImpl should be of the form "MessageImpl ..." (with optional leading article) (golint)
- Line 105: warning: exported function NewMessage should have comment or be unexported (golint)
- Line 113: warning: exported method MessageImpl.Type should have comment or be unexported (golint)
- Line 117: warning: exported method MessageImpl.GetTo should have comment or be unexported (golint)
- Line 121: warning: exported method MessageImpl.GetFrom should have comment or be unexported (golint)
- Line 125: warning: exported method MessageImpl.IsBroadcast should have comment or be unexported (golint)
- Line 129: warning: comment on exported method MessageImpl.IsToOldCommittee should be of the form "IsToOldCommittee ..." (golint)
- Line 134: warning: comment on exported method MessageImpl.IsToOldAndNewCommittees should be of the form "IsToOldAndNewCommittees ..." (golint)
- Line 139: warning: exported method MessageImpl.WireBytes should have comment or be unexported (golint)
- Line 147: warning: exported method MessageImpl.WireMsg should have comment or be unexported (golint)
- Line 151: warning: exported method MessageImpl.Content should have comment or be unexported (golint)
- Line 155: warning: exported method MessageImpl.ValidateBasic should have comment or be unexported (golint)
-
-
tss-lib/eddsa/signing/prepare.go
- Line 17: warning: comment on exported function PrepareForSigning should be of the form "PrepareForSigning ..." (golint)
-
-
tss-lib/ecdsa/signing/local_party.go
- Line 28: warning: exported type LocalParty should have comment or be unexported (golint)
- Line 96: warning: exported function NewLocalParty should have comment or be unexported (golint)
- Line 137: warning: exported method LocalParty.FirstRound should have comment or be unexported (golint)
- Line 141: warning: exported method LocalParty.Start should have comment or be unexported (golint)
- Line 154: warning: exported method LocalParty.Update should have comment or be unexported (golint)
- Line 158: warning: exported method LocalParty.UpdateFromBytes should have comment or be unexported (golint)
- Line 166: warning: exported method LocalParty.ValidateMessage should have comment or be unexported (golint)
- Line 178: warning: exported method LocalParty.StoreMessage should have comment or be unexported (golint)
- Line 215: warning: exported method LocalParty.PartyID should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/signing/prepare.go
- Line 18: warning: comment on exported function PrepareForSigning should be of the form "PrepareForSigning ..." (golint)
-
-
tss-lib/tss/party_id.go
- Line 26: warning: exported type UnSortedPartyIDs should have comment or be unexported (golint)
- Line 27: warning: exported type SortedPartyIDs should have comment or be unexported (golint)
- Line 30: warning: exported method PartyID.ValidateBasic should have comment or be unexported (golint)
- Line 36: warning: exported method MessageWrapper_PartyID.KeyInt should have comment or be unexported (golint)
- Line 104: warning: exported method SortedPartyIDs.Keys should have comment or be unexported (golint)
- Line 112: warning: exported method SortedPartyIDs.ToUnSorted should have comment or be unexported (golint)
- Line 116: warning: exported method SortedPartyIDs.FindByKey should have comment or be unexported (golint)
- Line 125: warning: exported method SortedPartyIDs.Exclude should have comment or be unexported (golint)
-
-
tss-lib/eddsa/signing/rounds.go
- Line 16: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/crypto/paillier/paillier.go
- Line 34: warning: exported const ProofIters should have comment (or a comment on this block) or be unexported (golint)
- Line 40: warning: exported type PublicKey should have comment or be unexported (golint)
- Line 44: warning: exported type PrivateKey should have comment or be unexported (golint)
- Line 55: warning: exported var ErrMessageTooLong should have comment or be unexported (golint)
- Line 66: warning: comment on exported function GenerateKeyPair should be of the form "GenerateKeyPair ..." (golint)
- Line 111: warning: exported method PublicKey.EncryptAndReturnRandomness should have comment or be unexported (golint)
- Line 126: warning: exported method PublicKey.Encrypt should have comment or be unexported (golint)
- Line 131: warning: exported method PublicKey.HomoMult should have comment or be unexported (golint)
- Line 143: warning: exported method PublicKey.HomoAdd should have comment or be unexported (golint)
- Line 155: warning: exported method PublicKey.NSquare should have comment or be unexported (golint)
- Line 171: warning: exported method PrivateKey.Decrypt should have comment or be unexported (golint)
- Line 192: warning: exported method PrivateKey.Proof should have comment or be unexported (golint)
- Line 203: warning: exported method Proof.Verify should have comment or be unexported (golint)
- Line 244: warning: exported function L should have comment or be unexported (golint)
-
-
tss-lib/eddsa/keygen/rounds.go
- Line 14: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/ecdsa/resharing/rounds.go
- Line 15: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/eddsa/resharing/rounds.go
- Line 15: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/tss/party.go
- Line 17: warning: exported type Party should have comment or be unexported (golint)
- Line 41: warning: exported type BaseParty should have comment or be unexported (golint)
- Line 47: warning: exported method BaseParty.Running should have comment or be unexported (golint)
- Line 51: warning: exported method BaseParty.WaitingFor should have comment or be unexported (golint)
- Line 60: warning: exported method BaseParty.WrapError should have comment or be unexported (golint)
- Line 67: warning: comment on exported method BaseParty.ValidateMessage should be of the form "ValidateMessage ..." (golint)
- Line 114: warning: exported function BaseStart should have comment or be unexported (golint)
- Line 142: warning: comment on exported function BaseUpdate should be of the form "BaseUpdate ..." (golint)
-
-
tss-lib/tss/round.go
- Line 9: warning: exported type Round should have comment or be unexported (golint)
-
-
tss-lib/tss/wire.go
- Line 18: warning: exported const ECDSAProtoNamePrefix should have comment (or a comment on this block) or be unexported (golint)
- Line 22: warning: comment on exported function ParseWireMessage should be of the form "ParseWireMessage ..." (golint)
-
-
tss-lib/common/hash.go
- Line 11: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
- Line 20: warning: comment on exported function SHA512_256 should be of the form "SHA512_256 ..." (golint)
- Line 53: warning: exported function SHA512_256i should have comment or be unexported (golint)
- Line 86: warning: exported function SHA512_256iOne should have comment or be unexported (golint)
-
-
tss-lib/crypto/mta/range_proof.go
- Line 20: warning: exported const RangeProofAliceBytesParts should have comment (or a comment on this block) or be unexported (golint)
- Line 28: warning: exported type RangeProofAlice should have comment or be unexported (golint)
- Line 92: warning: exported function RangeProofAliceFromBytes should have comment or be unexported (golint)
- Line 106: warning: exported method RangeProofAlice.Verify should have comment or be unexported (golint)
- Line 160: warning: exported method RangeProofAlice.ValidateBasic should have comment or be unexported (golint)
- Line 169: warning: exported method RangeProofAlice.Bytes should have comment or be unexported (golint)
-
-
tss-lib/crypto/vss/feldman_vss.go
- Line 24: warning: exported type Share should have comment or be unexported (golint)
- Line 30: warning: exported type Vs should have comment or be unexported (golint)
- Line 32: warning: exported type Shares should have comment or be unexported (golint)
- Line 36: warning: exported var ErrNumSharesBelowThreshold should have comment or be unexported (golint)
- Line 42: warning: comment on exported function Create should be of the form "Create ..." (golint)
- Line 75: warning: exported method Share.Verify should have comment or be unexported (golint)
- Line 96: warning: exported method Shares.ReConstruct should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/keygen/messages.go
- Line 44: warning: exported function NewKGRound1Message should have comment or be unexported (golint)
- Line 76: warning: exported method KGRound1Message.ValidateBasic should have comment or be unexported (golint)
- Line 88: warning: exported method KGRound1Message.UnmarshalCommitment should have comment or be unexported (golint)
- Line 92: warning: exported method KGRound1Message.UnmarshalPaillierPK should have comment or be unexported (golint)
- Line 96: warning: exported method KGRound1Message.UnmarshalNTilde should have comment or be unexported (golint)
- Line 100: warning: exported method KGRound1Message.UnmarshalH1 should have comment or be unexported (golint)
- Line 104: warning: exported method KGRound1Message.UnmarshalH2 should have comment or be unexported (golint)
- Line 108: warning: exported method KGRound1Message.UnmarshalDLNProof1 should have comment or be unexported (golint)
- Line 112: warning: exported method KGRound1Message.UnmarshalDLNProof2 should have comment or be unexported (golint)
- Line 118: warning: exported function NewKGRound2Message1 should have comment or be unexported (golint)
- Line 134: warning: exported method KGRound2Message1.ValidateBasic should have comment or be unexported (golint)
- Line 139: warning: exported method KGRound2Message1.UnmarshalShare should have comment or be unexported (golint)
- Line 145: warning: exported function NewKGRound2Message2 should have comment or be unexported (golint)
- Line 161: warning: exported method KGRound2Message2.ValidateBasic should have comment or be unexported (golint)
- Line 166: warning: exported method KGRound2Message2.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 173: warning: exported function NewKGRound3Message should have comment or be unexported (golint)
- Line 195: warning: exported method KGRound3Message.ValidateBasic should have comment or be unexported (golint)
- Line 200: warning: exported method KGRound3Message.UnmarshalProofInts should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/keygen/save_data.go
- Line 20: warning: exported type LocalPreParams should have comment or be unexported (golint)
- Line 28: warning: exported type LocalSecrets should have comment or be unexported (golint)
- Line 33: warning: comment on exported type LocalPartySaveData should be of the form "LocalPartySaveData ..." (with optional leading article) (golint)
- Line 53: warning: exported function NewLocalPartySaveData should have comment or be unexported (golint)
- Line 62: warning: exported method LocalPreParams.Validate should have comment or be unexported (golint)
- Line 69: warning: exported method LocalPreParams.ValidateWithProof should have comment or be unexported (golint)
-
-
tss-lib/eddsa/keygen/save_data.go
- Line 19: warning: exported type LocalSecrets should have comment or be unexported (golint)
- Line 24: warning: comment on exported type LocalPartySaveData should be of the form "LocalPartySaveData ..." (with optional leading article) (golint)
- Line 39: warning: exported function NewLocalPartySaveData should have comment or be unexported (golint)
-
-
tss-lib/test/config.go
- Line 10: warning: comment on exported const TestParticipants should be of the form "TestParticipants ..." (golint)
- Line 13: warning: exported const TestThreshold should have comment (or a comment on this block) or be unexported (golint)
-
-
tss-lib/test/utils.go
- Line 13: warning: exported function SharedPartyUpdater should have comment or be unexported (golint)
-
-
tss-lib/crypto/ecpoint.go
- Line 34: warning: comment on exported function NewECPoint should be of the form "NewECPoint ..." (golint)
- Line 42: warning: comment on exported function NewECPointNoCurveCheck should be of the form "NewECPointNoCurveCheck ..." (golint)
- Line 48: warning: exported method ECPoint.X should have comment or be unexported (golint)
- Line 52: warning: exported method ECPoint.Y should have comment or be unexported (golint)
- Line 56: warning: exported method ECPoint.Add should have comment or be unexported (golint)
- Line 61: warning: exported method ECPoint.ScalarMult should have comment or be unexported (golint)
- Line 67: warning: exported method ECPoint.IsOnCurve should have comment or be unexported (golint)
- Line 71: warning: exported method ECPoint.Equals should have comment or be unexported (golint)
- Line 78: warning: exported method ECPoint.SetCurve should have comment or be unexported (golint)
- Line 83: warning: exported method ECPoint.ValidateBasic should have comment or be unexported (golint)
- Line 87: warning: exported method ECPoint.EightInvEight should have comment or be unexported (golint)
- Line 91: warning: exported function ScalarBaseMult should have comment or be unexported (golint)
- Line 106: warning: exported function FlattenECPoints should have comment or be unexported (golint)
- Line 121: warning: exported function UnFlattenECPoints should have comment or be unexported (golint)
- Line 148: warning: exported method ECPoint.GobEncode should have comment or be unexported (golint)
- Line 173: warning: exported method ECPoint.GobDecode should have comment or be unexported (golint)
- Line 211: warning: comment on exported method ECPoint.MarshalJSON should be of the form "MarshalJSON ..." (golint)
- Line 220: warning: exported method ECPoint.UnmarshalJSON should have comment or be unexported (golint)
-
-
tss-lib/tss/params.go
- Line 15: warning: exported type Parameters should have comment or be unexported (golint)
- Line 23: warning: exported type ReSharingParameters should have comment or be unexported (golint)
- Line 35: warning: comment on exported function NewParameters should be of the form "NewParameters ..." (golint)
- Line 55: warning: exported method Parameters.Parties should have comment or be unexported (golint)
- Line 59: warning: exported method Parameters.PartyID should have comment or be unexported (golint)
- Line 63: warning: exported method Parameters.PartyCount should have comment or be unexported (golint)
- Line 67: warning: exported method Parameters.Threshold should have comment or be unexported (golint)
- Line 71: warning: exported method Parameters.SafePrimeGenTimeout should have comment or be unexported (golint)
- Line 77: warning: comment on exported function NewReSharingParameters should be of the form "NewReSharingParameters ..." (golint)
- Line 88: warning: exported method ReSharingParameters.OldParties should have comment or be unexported (golint)
- Line 92: warning: exported method ReSharingParameters.OldPartyCount should have comment or be unexported (golint)
- Line 96: warning: exported method ReSharingParameters.NewParties should have comment or be unexported (golint)
- Line 100: warning: exported method ReSharingParameters.NewPartyCount should have comment or be unexported (golint)
- Line 104: warning: exported method ReSharingParameters.NewThreshold should have comment or be unexported (golint)
- Line 108: warning: exported method ReSharingParameters.OldAndNewParties should have comment or be unexported (golint)
- Line 112: warning: exported method ReSharingParameters.OldAndNewPartyCount should have comment or be unexported (golint)
- Line 116: warning: exported method ReSharingParameters.IsOldCommittee should have comment or be unexported (golint)
- Line 126: warning: exported method ReSharingParameters.IsNewCommittee should have comment or be unexported (golint)
-
-
tss-lib/common/int.go
- Line 22: warning: exported function ModInt should have comment or be unexported (golint)
-
-
tss-lib/common/random.go
- Line 38: warning: exported function GetRandomPositiveInt should have comment or be unexported (golint)
- Line 52: warning: exported function GetRandomPrimeInt should have comment or be unexported (golint)
- Line 70: warning: comment on exported function GetRandomPositiveRelativelyPrimeInt should be of the form "GetRandomPositiveRelativelyPrimeInt ..." (golint)
- Line 86: warning: exported function IsNumberInMultiplicativeGroup should have comment or be unexported (golint)
- Line 95: warning: comment on exported function GetRandomGeneratorOfTheQuadraticResidue should be of the form "GetRandomGeneratorOfTheQuadraticResidue ..." (golint)
-
-
tss-lib/ecdsa/signing/messages.go
- Line 56: warning: exported function NewSignRound1Message1 should have comment or be unexported (golint)
- Line 75: warning: exported method SignRound1Message1.ValidateBasic should have comment or be unexported (golint)
- Line 81: warning: exported method SignRound1Message1.UnmarshalC should have comment or be unexported (golint)
- Line 85: warning: exported method SignRound1Message1.UnmarshalRangeProofAlice should have comment or be unexported (golint)
- Line 91: warning: exported function NewSignRound1Message2 should have comment or be unexported (golint)
- Line 106: warning: exported method SignRound1Message2.ValidateBasic should have comment or be unexported (golint)
- Line 111: warning: exported method SignRound1Message2.UnmarshalCommitment should have comment or be unexported (golint)
- Line 117: warning: exported function NewSignRound2Message should have comment or be unexported (golint)
- Line 141: warning: exported method SignRound2Message.ValidateBasic should have comment or be unexported (golint)
- Line 149: warning: exported method SignRound2Message.UnmarshalProofBob should have comment or be unexported (golint)
- Line 153: warning: exported method SignRound2Message.UnmarshalProofBobWC should have comment or be unexported (golint)
- Line 159: warning: exported function NewSignRound3Message should have comment or be unexported (golint)
- Line 174: warning: exported method SignRound3Message.ValidateBasic should have comment or be unexported (golint)
- Line 181: warning: exported function NewSignRound4Message should have comment or be unexported (golint)
- Line 201: warning: exported method SignRound4Message.ValidateBasic should have comment or be unexported (golint)
- Line 209: warning: exported method SignRound4Message.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 214: warning: exported method SignRound4Message.UnmarshalZKProof should have comment or be unexported (golint)
- Line 230: warning: exported function NewSignRound5Message should have comment or be unexported (golint)
- Line 245: warning: exported method SignRound5Message.ValidateBasic should have comment or be unexported (golint)
- Line 250: warning: exported method SignRound5Message.UnmarshalCommitment should have comment or be unexported (golint)
- Line 256: warning: exported function NewSignRound6Message should have comment or be unexported (golint)
- Line 281: warning: exported method SignRound6Message.ValidateBasic should have comment or be unexported (golint)
- Line 293: warning: exported method SignRound6Message.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 298: warning: exported method SignRound6Message.UnmarshalZKProof should have comment or be unexported (golint)
- Line 312: warning: exported method SignRound6Message.UnmarshalZKVProof should have comment or be unexported (golint)
- Line 329: warning: exported function NewSignRound7Message should have comment or be unexported (golint)
- Line 344: warning: exported method SignRound7Message.ValidateBasic should have comment or be unexported (golint)
- Line 349: warning: exported method SignRound7Message.UnmarshalCommitment should have comment or be unexported (golint)
- Line 355: warning: exported function NewSignRound8Message should have comment or be unexported (golint)
- Line 371: warning: exported method SignRound8Message.ValidateBasic should have comment or be unexported (golint)
- Line 376: warning: exported method SignRound8Message.UnmarshalDeCommitment should have comment or be unexported (golint)
- Line 383: warning: exported function NewSignRound9Message should have comment or be unexported (golint)
- Line 398: warning: exported method SignRound9Message.ValidateBasic should have comment or be unexported (golint)
- Line 403: warning: exported method SignRound9Message.UnmarshalS should have comment or be unexported (golint)
-
-
tss-lib/ecdsa/keygen/rounds.go
- Line 14: warning: exported const TaskName should have comment (or a comment on this block) or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!