Preparing report...

Report for github.com/binwiederhier/ntfy

(v1.5.1)

A    Great!    Found 6 issues across 13 files

Tweet

gofmt84%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo92%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • server/server.go
    • Line 205: warning: cyclomatic complexity 20 of function (*Server).handleInternal() is high (> 15) (gocyclo)
    • Line 352: warning: cyclomatic complexity 16 of function (*Server).handleSubscribe() is high (> 15) (gocyclo)

golint61%

Golint is a linter for Go source code.

    • util/embedfs.go
    • Line 11: warning: exported type CachingEmbedFS should have comment or be unexported (golint)
    • Line 16: warning: exported method CachingEmbedFS.Open should have comment or be unexported (golint)
    • util/util.go
    • Line 18: warning: exported function FileExists should have comment or be unexported (golint)
    • server/cache_mem.go
    • Line 65: warning: should omit 2nd value from range; this loop is equivalent to `for topic := range ...` (golint)
    • server/cache_sqlite.go
    • Line 144: warning: receiver name s should be consistent with previous receiver name c for sqliteCache (golint)
    • Line 165: warning: receiver name s should be consistent with previous receiver name c for sqliteCache (golint)
    • server/server.go
    • Line 103: warning: exported function New should have comment or be unexported (golint)
    • Line 168: warning: exported method Server.Run should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!