Go Report Card

Preparing report...

Report for github.com/bmc-toolbox/actor

A+    Excellent!    Found 16 issues across 34 files

Tweet
Last refresh:

Refresh now

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint52%

Golint is a linter for Go source code.

    • actor/internal/actions/plan-maker.go
    • Line 6: warning: exported type Action should have comment or be unexported (golint)
    • Line 11: warning: exported type PlanMaker should have comment or be unexported (golint)
    • Line 15: warning: exported type ActionResult should have comment or be unexported (golint)
    • Line 22: warning: exported type ExecutorFactory should have comment or be unexported (golint)
    • Line 26: warning: exported type Executor should have comment or be unexported (golint)
    • Line 32: warning: exported type ExecutionPlan should have comment or be unexported (golint)
    • Line 37: warning: exported type ActionFn should have comment or be unexported (golint)
    • Line 40: warning: exported function NewPlanMaker should have comment or be unexported (golint)
    • Line 44: warning: exported method PlanMaker.MakePlan should have comment or be unexported (golint)
    • Line 70: warning: exported method ExecutionPlan.Run should have comment or be unexported (golint)
    • Line 90: warning: exported function NewActionResult should have comment or be unexported (golint)
    • actor/internal/blade-by-serial-executor.go
    • Line 10: warning: exported type BladeBySerialExecutorFactory should have comment or be unexported (golint)
    • Line 15: warning: exported type BladeBySerialExecutor should have comment or be unexported (golint)
    • Line 21: warning: exported function NewBladeBySerialExecutorFactory should have comment or be unexported (golint)
    • Line 25: warning: exported method BladeBySerialExecutorFactory.New should have comment or be unexported (golint)
    • Line 36: warning: exported method BladeBySerialExecutor.Run should have comment or be unexported (golint)
    • actor/routes/host-api.go
    • Line 13: warning: exported type HostAPI should have comment or be unexported (golint)
    • Line 18: warning: exported function NewHostAPI should have comment or be unexported (golint)
    • actor/internal/providers/blade-bmc-wrapper.go
    • Line 6: warning: exported type BladeBmcWrapper should have comment or be unexported (golint)
    • Line 13: warning: exported function NewBladeBmcWrapper should have comment or be unexported (golint)
    • Line 25: warning: exported method BladeBmcWrapper.IsOnBlade should have comment or be unexported (golint)
    • Line 32: warning: exported method BladeBmcWrapper.PowerOnBlade should have comment or be unexported (golint)
    • Line 39: warning: exported method BladeBmcWrapper.PowerOffBlade should have comment or be unexported (golint)
    • Line 46: warning: exported method BladeBmcWrapper.PowerCycleBlade should have comment or be unexported (golint)
    • Line 53: warning: exported method BladeBmcWrapper.PowerCycleBmcBlade should have comment or be unexported (golint)
    • Line 60: warning: exported method BladeBmcWrapper.ReseatBlade should have comment or be unexported (golint)
    • Line 67: warning: exported method BladeBmcWrapper.PxeOnceBlade should have comment or be unexported (golint)
    • Line 74: warning: exported method BladeBmcWrapper.FindBladePosition should have comment or be unexported (golint)
    • actor/internal/providers/server-bmc-wrapper.go
    • Line 17: warning: exported type ServerBmcWrapper should have comment or be unexported (golint)
    • Line 40: warning: exported function NewServerBmcWrapper should have comment or be unexported (golint)
    • Line 58: warning: exported method ServerBmcWrapper.IsOn should have comment or be unexported (golint)
    • Line 65: warning: exported method ServerBmcWrapper.PowerOn should have comment or be unexported (golint)
    • Line 72: warning: exported method ServerBmcWrapper.PowerOff should have comment or be unexported (golint)
    • Line 79: warning: exported method ServerBmcWrapper.PowerCycle should have comment or be unexported (golint)
    • Line 86: warning: exported method ServerBmcWrapper.PowerCycleBmc should have comment or be unexported (golint)
    • Line 93: warning: exported method ServerBmcWrapper.PxeOnce should have comment or be unexported (golint)
    • Line 100: warning: exported method ServerBmcWrapper.Screenshot should have comment or be unexported (golint)
    • Line 112: warning: exported method ServerBmcWrapper.HardwareType should have comment or be unexported (golint)
    • Line 124: warning: exported method ServerBmcWrapper.Close should have comment or be unexported (golint)
    • actor/internal/blade-by-pos-executor.go
    • Line 11: warning: exported type BladeByPosExecutorFactory should have comment or be unexported (golint)
    • Line 16: warning: exported type BladeByPosExecutor should have comment or be unexported (golint)
    • Line 22: warning: exported function NewBladeByPosExecutorFactory should have comment or be unexported (golint)
    • Line 26: warning: exported method BladeByPosExecutorFactory.New should have comment or be unexported (golint)
    • Line 42: warning: exported method BladeByPosExecutor.Run should have comment or be unexported (golint)
    • actor/internal/chassis-executor.go
    • Line 11: warning: exported type ChassisExecutorFactory should have comment or be unexported (golint)
    • Line 16: warning: exported type ChassisExecutor should have comment or be unexported (golint)
    • Line 28: warning: exported function NewChassisExecutorFactory should have comment or be unexported (golint)
    • Line 32: warning: exported method ChassisExecutorFactory.New should have comment or be unexported (golint)
    • Line 42: warning: exported method ChassisExecutor.Validate should have comment or be unexported (golint)
    • Line 47: warning: exported method ChassisExecutor.Run should have comment or be unexported (golint)
    • Line 77: warning: exported method ChassisExecutor.Cleanup should have comment or be unexported (golint)
    • actor/internal/sleep-executor.go
    • Line 12: warning: exported type SleepExecutorFactory should have comment or be unexported (golint)
    • Line 15: warning: exported type SleepExecutor should have comment or be unexported (golint)
    • Line 19: warning: exported function NewSleepExecutorFactory should have comment or be unexported (golint)
    • Line 23: warning: exported method SleepExecutorFactory.New should have comment or be unexported (golint)
    • Line 27: warning: exported method SleepExecutor.Validate should have comment or be unexported (golint)
    • Line 35: warning: exported method SleepExecutor.Run should have comment or be unexported (golint)
    • Line 46: warning: exported method SleepExecutor.Cleanup should have comment or be unexported (golint)
    • actor/server/server.go
    • Line 13: warning: exported type Server should have comment or be unexported (golint)
    • Line 18: warning: exported type Config should have comment or be unexported (golint)
    • Line 24: warning: exported type APIs should have comment or be unexported (golint)
    • actor/internal/host-executor.go
    • Line 13: warning: exported type HostExecutorFactory should have comment or be unexported (golint)
    • Line 42: warning: exported function NewHostExecutorFactory should have comment or be unexported (golint)
    • Line 46: warning: exported method HostExecutorFactory.New should have comment or be unexported (golint)
    • actor/internal/providers/chassis-bmc-wrapper.go
    • Line 4: warning: exported type ChassisBmcWrapper should have comment or be unexported (golint)
    • Line 9: warning: exported function NewChassisBmcWrapper should have comment or be unexported (golint)
    • Line 19: warning: exported method ChassisBmcWrapper.IsOn should have comment or be unexported (golint)
    • Line 25: warning: exported method ChassisBmcWrapper.PowerOn should have comment or be unexported (golint)
    • Line 31: warning: exported method ChassisBmcWrapper.PowerCycle should have comment or be unexported (golint)
    • actor/internal/providers/ipmi/ipmi.go
    • Line 16: warning: comment on exported type Ipmi should be of the form "Ipmi ..." (with optional leading article) (golint)
    • Line 24: warning: exported function New should have comment or be unexported (golint)
    • Line 61: warning: comment on exported method Ipmi.PowerCycle should be of the form "PowerCycle ..." (golint)
    • Line 88: warning: comment on exported method Ipmi.PowerReset should be of the form "PowerReset ..." (golint)
    • Line 101: warning: comment on exported method Ipmi.PowerCycleBmc should be of the form "PowerCycleBmc ..." (golint)
    • Line 114: warning: comment on exported method Ipmi.PowerResetBmc should be of the form "PowerResetBmc ..." (golint)
    • Line 127: warning: comment on exported method Ipmi.PowerOn should be of the form "PowerOn ..." (golint)
    • Line 149: warning: comment on exported method Ipmi.PowerOff should be of the form "PowerOff ..." (golint)
    • Line 167: warning: comment on exported method Ipmi.BootDeviceSet should be of the form "BootDeviceSet ..." (golint)
    • Line 197: warning: comment on exported method Ipmi.PxeOnceEfi should be of the form "PxeOnceEfi ..." (golint)
    • Line 209: warning: comment on exported method Ipmi.PxeOnceMbr should be of the form "PxeOnceMbr ..." (golint)
    • Line 221: warning: comment on exported method Ipmi.PxeOnce should be of the form "PxeOnce ..." (golint)
    • Line 226: warning: comment on exported method Ipmi.IsOn should be of the form "IsOn ..." (golint)
    • Line 239: warning: comment on exported method Ipmi.ReadUsers should be of the form "ReadUsers ..." (golint)
    • Line 270: warning: exported method Ipmi.Close should have comment or be unexported (golint)
    • actor/routes/chassis-api.go
    • Line 13: warning: exported type ChassisAPI should have comment or be unexported (golint)
    • Line 18: warning: exported function NewChassisAPI should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!