Preparing report...

Report for github.com/bndw/pick

A+    Excellent!    Found 53 issues across 86 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint40%

Golint is a linter for Go source code.

    • pick/backends/file/register.go
    • Line 8: warning: exported const ClientName should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported function Register should have comment or be unexported (golint)
    • pick/strings/strings.go
    • Line 4: warning: exported const PasswordCopiedToClipboard should have comment (or a comment on this block) or be unexported (golint)
    • pick/crypto/pbkdf2/pbkdf2.go
    • Line 13: warning: exported type PBKDF2 should have comment or be unexported (golint)
    • Line 27: warning: exported function New should have comment or be unexported (golint)
    • Line 35: warning: exported method PBKDF2.HashFunc should have comment or be unexported (golint)
    • Line 50: warning: exported method PBKDF2.DeriveKeyWithSalt should have comment or be unexported (golint)
    • Line 56: warning: exported method PBKDF2.DeriveKey should have comment or be unexported (golint)
    • pick/backends/file/client.go
    • Line 32: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 71: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • pick/crypto/scrypt/scrypt.go
    • Line 9: warning: exported type Scrypt should have comment or be unexported (golint)
    • Line 23: warning: exported function New should have comment or be unexported (golint)
    • Line 32: warning: exported method Scrypt.DeriveKeyWithSalt should have comment or be unexported (golint)
    • Line 40: warning: exported method Scrypt.DeriveKey should have comment or be unexported (golint)
    • pick/backends/config.go
    • Line 3: warning: exported type Config should have comment or be unexported (golint)
    • Line 9: warning: exported type BackupConfig should have comment or be unexported (golint)
    • Line 15: warning: exported function NewDefaultConfig should have comment or be unexported (golint)
    • pick/utils/clipboard/duration.go
    • Line 7: warning: exported type Duration should have comment or be unexported (golint)
    • Line 11: warning: exported method Duration.UnmarshalText should have comment or be unexported (golint)
    • Line 17: warning: exported method Duration.MarshalText should have comment or be unexported (golint)
    • pick/safe/pass.go
    • Line 3: warning: exported method Safe.ChangePassword should have comment or be unexported (golint)
    • pick/utils/format.go
    • Line 9: warning: exported function PrettyPrint should have comment or be unexported (golint)
    • Line 18: warning: exported function FormatUnixTime should have comment or be unexported (golint)
    • pick/crypto/aes_gcm.go
    • Line 15: warning: exported type AESGCMClient should have comment or be unexported (golint)
    • Line 20: warning: exported type AESGCMSettings should have comment or be unexported (golint)
    • Line 31: warning: exported type AESGCMStore should have comment or be unexported (golint)
    • Line 42: warning: exported function DefaultAESGCMSettings should have comment or be unexported (golint)
    • Line 51: warning: exported function NewAESGCMClient should have comment or be unexported (golint)
    • Line 106: warning: exported method AESGCMClient.Decrypt should have comment or be unexported (golint)
    • Line 135: warning: exported method AESGCMClient.Encrypt should have comment or be unexported (golint)
    • pick/crypto/chacha20poly1305.go
    • Line 15: warning: exported type ChaCha20Poly1305Client should have comment or be unexported (golint)
    • Line 20: warning: exported type ChaCha20Poly1305Settings should have comment or be unexported (golint)
    • Line 26: warning: exported type ChaCha20Poly1305Store should have comment or be unexported (golint)
    • Line 36: warning: exported function DefaultChaCha20Poly1305Settings should have comment or be unexported (golint)
    • Line 44: warning: exported function NewChaCha20Poly1305Client should have comment or be unexported (golint)
    • Line 81: warning: exported method ChaCha20Poly1305Client.Decrypt should have comment or be unexported (golint)
    • Line 105: warning: exported method ChaCha20Poly1305Client.Encrypt should have comment or be unexported (golint)
    • pick/crypto/config.go
    • Line 3: warning: exported type Config should have comment or be unexported (golint)
    • Line 11: warning: exported const ConfigTypeOpenPGP should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: exported function NewDefaultConfig should have comment or be unexported (golint)
    • Line 32: warning: exported function NewDefaultConfigWithType should have comment or be unexported (golint)
    • pick/commands/root.go
    • Line 17: warning: exported function RootCmd should have comment or be unexported (golint)
    • Line 21: warning: exported function Execute should have comment or be unexported (golint)
    • pick/backends/s3/register.go
    • Line 8: warning: exported const ClientName should have comment (or a comment on this block) or be unexported (golint)
    • Line 12: warning: exported function Register should have comment or be unexported (golint)
    • pick/crypto/openpgp.go
    • Line 14: warning: exported type OpenPGPClient should have comment or be unexported (golint)
    • Line 19: warning: exported type OpenPGPSettings should have comment or be unexported (golint)
    • Line 29: warning: exported function DefaultOpenPGPSettings should have comment or be unexported (golint)
    • Line 36: warning: exported function NewOpenPGPClient should have comment or be unexported (golint)
    • Line 65: warning: comment on exported method OpenPGPClient.Decrypt should be of the form "Decrypt ..." (golint)
    • Line 102: warning: comment on exported method OpenPGPClient.Encrypt should be of the form "Encrypt ..." (golint)
    • pick/crypto/client.go
    • Line 7: warning: exported type Client should have comment or be unexported (golint)
    • Line 12: warning: exported type KeyDerivation should have comment or be unexported (golint)
    • Line 17: warning: exported function New should have comment or be unexported (golint)
    • pick/safe/account.go
    • Line 9: warning: exported type Account should have comment or be unexported (golint)
    • Line 17: warning: exported method Account.Update should have comment or be unexported (golint)
    • Line 22: warning: exported method Account.SyncWith should have comment or be unexported (golint)
    • Line 83: warning: exported function NewAccount should have comment or be unexported (golint)
    • pick/config/config.go
    • Line 14: warning: exported type Config should have comment or be unexported (golint)
    • Line 28: warning: exported function Load should have comment or be unexported (golint)
    • pick/backends/client.go
    • Line 3: warning: exported type Client should have comment or be unexported (golint)
    • Line 14: warning: exported function New should have comment or be unexported (golint)
    • Line 22: warning: exported function NewWithType should have comment or be unexported (golint)
    • pick/backends/registry.go
    • Line 10: warning: exported var ErrClientAlreadyExists should have comment or be unexported (golint)
    • Line 18: warning: exported type NewClientFunc should have comment or be unexported (golint)
    • Line 26: warning: exported function Register should have comment or be unexported (golint)
    • pick/utils/pswdgen/config.go
    • Line 8: warning: exported const PasswordModeNonInteractive should have comment (or a comment on this block) or be unexported (golint)
    • Line 16: warning: exported type Config should have comment or be unexported (golint)
    • Line 22: warning: exported function NewDefaultConfig should have comment or be unexported (golint)
    • Line 30: warning: exported function StrengthByString should have comment or be unexported (golint)
    • pick/utils/user_input.go
    • Line 12: warning: exported function Confirm should have comment or be unexported (golint)
    • Line 36: warning: exported function GetInput should have comment or be unexported (golint)
    • Line 53: warning: exported function GetPasswordInput should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell95%

Misspell Finds commonly misspelled English words