Report for github.com/broderickhyman/albiondata-client
A+ Excellent! Found 10 issues across 45 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo95%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
albiondata-client/albiondata-client.go
- Line 132: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)
-
-
albiondata-client/client/listener.go
- Line 178: warning: cyclomatic complexity 31 of function (*listener).onReliableCommand() is high (> 15) (gocyclo)
golint82%
Golint is a linter for Go source code.
-
-
albiondata-client/lib/gold.go
- Line 14: warning: exported method GoldPricesUpload.StringArrays should have comment or be unexported (golint)
-
-
albiondata-client/lib/map.go
- Line 18: warning: exported method MapDataUpload.StringArrays should have comment or be unexported (golint)
-
-
albiondata-client/lib/market.go
- Line 19: warning: exported method MarketOrder.StringArray should have comment or be unexported (golint)
- Line 34: warning: exported const SalesTax should have comment (or a comment on this block) or be unexported (golint)
- Line 37: warning: exported type MarketNotificationType should have comment or be unexported (golint)
- Line 40: warning: exported const SalesNotification should have comment (or a comment on this block) or be unexported (golint)
- Line 44: warning: exported type MarketNotification should have comment or be unexported (golint)
- Line 48: warning: exported type MarketSellNotification should have comment or be unexported (golint)
- Line 57: warning: exported type MarketExpiryNotification should have comment or be unexported (golint)
- Line 63: warning: exported method MarketSellNotification.Type should have comment or be unexported (golint)
- Line 67: warning: exported method MarketExpiryNotification.Type should have comment or be unexported (golint)
- Line 71: warning: exported type MarketNotificationUpload should have comment or be unexported (golint)
-
-
albiondata-client/lib/marketHistory.go
- Line 50: warning: exported type MarketHistoriesUpload should have comment or be unexported (golint)
-
-
albiondata-client/lib/nats.go
- Line 4: warning: comment on exported const NatsGoldPricesIngest should be of the form "NatsGoldPricesIngest ..." (golint)
- Line 6: warning: exported const NatsGoldPricesDeduped should have comment (or a comment on this block) or be unexported (golint)
- Line 15: warning: comment on exported const NatsSkillData should be of the form "NatsSkillData ..." (golint)
-
-
albiondata-client/notification/notification_nix_darw.go
- Line 7: warning: exported function Push should have comment or be unexported (golint)
-
-
albiondata-client/systray/systray_others.go
- Line 5: warning: exported var ConsoleHidden should have comment or be unexported (golint)
- Line 7: warning: exported const CanHideConsole should have comment or be unexported (golint)
- Line 9: warning: exported function HideConsole should have comment or be unexported (golint)
- Line 13: warning: exported function ShowConsole should have comment or be unexported (golint)
- Line 17: warning: exported function Run should have comment or be unexported (golint)
-
-
albiondata-client/lib/common.go
- Line 3: warning: exported type PrivateUpload should have comment or be unexported (golint)
- Line 8: warning: exported method PrivateUpload.Personalize should have comment or be unexported (golint)
- Line 13: warning: exported type PersonalizedUpload should have comment or be unexported (golint)
- Line 17: warning: comment on exported type CharacterID should be of the form "CharacterID ..." (with optional leading article) (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!