gofmt96%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• go-dqlite/internal/protocol/request.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• go-dqlite/internal/protocol/response.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo94%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• go-dqlite/cmd/dqlite/dqlite.go
  • Line 20: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• go-dqlite/app/app.go
  • Line 47: warning: cyclomatic complexity 37 of function New() is high (> 15) (gocyclo)
  • Line 254: warning: cyclomatic complexity 18 of function (*App).Handover() is high (> 15) (gocyclo)

• go-dqlite/app/roles.go
  • Line 129: warning: cyclomatic complexity 22 of function (*RolesChanges).Adjust() is high (> 15) (gocyclo)

golint86%

Golint is a linter for Go source code.

• go-dqlite/internal/protocol/connector.go
  • Line 185: warning: comment on exported function Handshake should be of the form "Handshake ..." (golint)

• go-dqlite/internal/protocol/message.go
  • Line 588: warning: exported method Files.Next should have comment or be unexported (golint)
  • Line 602: warning: exported method Files.Close should have comment or be unexported (golint)

• go-dqlite/app/tls.go
  • Line 42: warning: exported function SimpleTLSConfig should have comment or be unexported (golint)

• go-dqlite/internal/bindings/server.go
  • Line 85: warning: exported type Node should have comment or be unexported (golint)
  • Line 93: warning: exported function ConfigSingleThread should have comment or be unexported (golint)
  • Line 100: warning: exported function ConfigMultiThread should have comment or be unexported (golint)
  • Line 126: warning: exported method Node.SetDialFunc should have comment or be unexported (golint)
  • Line 138: warning: exported method Node.SetBindAddress should have comment or be unexported (golint)
  • Line 148: warning: exported method Node.SetNetworkLatency should have comment or be unexported (golint)
  • Line 157: warning: exported method Node.SetFailureDomain should have comment or be unexported (golint)
  • Line 166: warning: exported method Node.GetBindAddress should have comment or be unexported (golint)
  • Line 171: warning: exported method Node.Start should have comment or be unexported (golint)
  • Line 180: warning: exported method Node.Stop should have comment or be unexported (golint)
  • Line 194: warning: exported method Node.Recover should have comment or be unexported (golint)

• go-dqlite/internal/shell/shell.go
  • Line 86: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• go-dqlite/driver/driver.go
  • Line 174: warning: comment on exported function New should be of the form "New ..." (golint)

• go-dqlite/client/store.go
  • Line 77: warning: comment on exported type NodeStoreOption should be of the form "NodeStoreOption ..." (with optional leading article) (golint)
  • Line 178: warning: comment on exported type YamlNodeStore should be of the form "YamlNodeStore ..." (with optional leading article) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign94%

IneffAssign detects ineffectual assignments in Go code.

• go-dqlite/internal/protocol/connector.go
  • Line 165: warning: ineffectual assignment to leader (ineffassign)

• go-dqlite/client/store_test.go
  • Line 25: warning: ineffectual assignment to err (ineffassign)
  • Line 37: warning: ineffectual assignment to err (ineffassign)
  • Line 50: warning: ineffectual assignment to err (ineffassign)

• go-dqlite/app/app_test.go
  • Line 358: warning: ineffectual assignment to cluster (ineffassign)

misspell94%

Misspell Finds commonly misspelled English words

• go-dqlite/internal/protocol/message.go
  • Line 422: warning: "exahusted" is a misspelling of "exhausted" (misspell)

• go-dqlite/app/app.go
  • Line 371: warning: "succeeed" is a misspelling of "succeed" (misspell)

• go-dqlite/app/app_test.go
  • Line 296: warning: "transfered" is a misspelling of "transferred" (misspell)