Go Report Card

Preparing report...

Report for github.com/cert-manager/istio-csr

A    Great!    Found 20 issues across 31 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint41%

Golint is a linter for Go source code.

    • istio-csr/cmd/app/options/options.go
    • Line 28: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 67: warning: exported function New should have comment or be unexported (golint)
    • Line 71: warning: exported method Options.Prepare should have comment or be unexported (golint)
    • Line 76: warning: exported method Options.Complete should have comment or be unexported (golint)
    • istio-csr/test/e2e/framework/framework.go
    • Line 21: warning: should not use dot imports (golint)
    • Line 22: warning: should not use dot imports (golint)
    • Line 30: warning: exported type Framework should have comment or be unexported (golint)
    • Line 40: warning: exported function NewDefaultFramework should have comment or be unexported (golint)
    • Line 44: warning: exported function NewFramework should have comment or be unexported (golint)
    • Line 55: warning: exported method Framework.BeforeEach should have comment or be unexported (golint)
    • Line 72: warning: exported method Framework.Helper should have comment or be unexported (golint)
    • Line 76: warning: exported method Framework.Config should have comment or be unexported (golint)
    • Line 80: warning: exported function CasesDescribe should have comment or be unexported (golint)
    • istio-csr/test/e2e/framework/config/config.go
    • Line 28: warning: exported type Config should have comment or be unexported (golint)
    • Line 39: warning: exported function SetConfig should have comment or be unexported (golint)
    • Line 43: warning: exported function GetConfig should have comment or be unexported (golint)
    • Line 47: warning: exported method Config.AddFlags should have comment or be unexported (golint)
    • Line 54: warning: exported method Config.Validate should have comment or be unexported (golint)
    • istio-csr/test/gen/certificaterequest.go
    • Line 23: warning: exported type CertificateRequestModifier should have comment or be unexported (golint)
    • Line 25: warning: exported function CertificateRequest should have comment or be unexported (golint)
    • Line 35: warning: exported function CertificateRequestFrom should have comment or be unexported (golint)
    • Line 43: warning: exported function AddCertificateRequestStatusCondition should have comment or be unexported (golint)
    • Line 49: warning: exported function SetCertificateRequestCertificate should have comment or be unexported (golint)
    • Line 55: warning: exported function SetCertificateRequestCA should have comment or be unexported (golint)
    • istio-csr/pkg/certmanager/fake/fake.go
    • Line 30: warning: exported type Fake should have comment or be unexported (golint)
    • Line 34: warning: exported function New should have comment or be unexported (golint)
    • Line 42: warning: exported method Fake.WithSign should have comment or be unexported (golint)
    • Line 47: warning: exported method Fake.Sign should have comment or be unexported (golint)
    • istio-csr/pkg/server/server.go
    • Line 51: warning: exported type Options should have comment or be unexported (golint)
    • Line 78: warning: exported function New should have comment or be unexported (golint)
    • Line 192: warning: comment on exported method Server.NeedLeaderElection should be of the form "NeedLeaderElection ..." (golint)
    • istio-csr/pkg/tls/fake/fake.go
    • Line 36: warning: exported function New should have comment or be unexported (golint)
    • Line 44: warning: exported method FakeTLS.WithRootCAs should have comment or be unexported (golint)
    • Line 49: warning: exported method FakeTLS.TrustDomain should have comment or be unexported (golint)
    • Line 53: warning: exported method FakeTLS.RootCAs should have comment or be unexported (golint)
    • Line 57: warning: exported method FakeTLS.Config should have comment or be unexported (golint)
    • istio-csr/pkg/controller/namespace.go
    • Line 36: warning: exported const IstioConfigLabelKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 39: warning: exported type Options should have comment or be unexported (golint)
    • Line 77: warning: exported function AddCARootController should have comment or be unexported (golint)
    • istio-csr/test/gen/csr.go
    • Line 45: warning: exported type CSRBuilder should have comment or be unexported (golint)
    • Line 51: warning: exported type CSRModifier should have comment or be unexported (golint)
    • Line 53: warning: exported function MustCSR should have comment or be unexported (golint)
    • Line 62: warning: exported function CSR should have comment or be unexported (golint)
    • Line 104: warning: exported function SetCSRIdentities should have comment or be unexported (golint)
    • Line 110: warning: exported function SetCSRDNS should have comment or be unexported (golint)
    • Line 116: warning: exported function SetCSRIPs should have comment or be unexported (golint)
    • Line 122: warning: exported function SetCSREmails should have comment or be unexported (golint)
    • Line 128: warning: exported function SetCSRCommonName should have comment or be unexported (golint)
    • istio-csr/pkg/tls/tls.go
    • Line 73: warning: exported type Options should have comment or be unexported (golint)
    • Line 369: warning: exported method Provider.TrustDomain should have comment or be unexported (golint)
    • Line 373: warning: comment on exported method Provider.NeedLeaderElection should be of the form "NeedLeaderElection ..." (golint)
    • istio-csr/test/gen/configmap.go
    • Line 24: warning: exported type ConfigMapModifier should have comment or be unexported (golint)
    • Line 26: warning: exported function ConfigMap should have comment or be unexported (golint)
    • Line 40: warning: exported function ConfigMapFrom should have comment or be unexported (golint)
    • Line 48: warning: exported function SetConfigMapNamespace should have comment or be unexported (golint)
    • Line 54: warning: exported function SetConfigMapData should have comment or be unexported (golint)
    • Line 60: warning: exported function SetConfigMapResourceVersion should have comment or be unexported (golint)
    • Line 66: warning: exported function SetConfigMapLabels should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign0%

IneffAssign detects ineffectual assignments in Go code.

An error occurred while running this test (signal: killed)

misspell90%

Misspell Finds commonly misspelled English words

    • istio-csr/pkg/server/server.go
    • Line 69: warning: "auther" is a misspelling of "author" (misspell)
    • Line 87: warning: "auther" is a misspelling of "author" (misspell)
    • Line 92: warning: "auther" is a misspelling of "author" (misspell)
    • Line 92: warning: "auther" is a misspelling of "author" (misspell)