gofmt90%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• gleam/sql/plan/validator.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/types/datum.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/distributed/driver/driver.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_op.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/filesort/filesort.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_like.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_time.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/constant_fold.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/types/datum_eval.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/distributed/master/ui/svg_writer_helper.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/plugins/file/parquet/parquet_file_reader.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/types/etc.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/table/tables/tables.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_math.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/plan/range.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/plan/column_pruning.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_compare.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/distinct/distinct.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_control.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/constant_propagation.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/plan/expression_rewriter.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/plan/join_reorder.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/plan/predicate_push_down.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/types/convert.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/util/codec/codec.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• gleam/sql/expression/builtin_other.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo87%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• gleam/distributed/driver/scheduler/scheduler_execute_task_group.go
  • Line 20: warning: cyclomatic complexity 21 of function (*Scheduler).ExecuteTaskGroup() is high (> 15) (gocyclo)

• gleam/plugins/file/csv/generic_csv_reader.go
  • Line 253: warning: cyclomatic complexity 45 of function (*Reader).parseField() is high (> 15) (gocyclo)

• gleam/util/row_codec.go
  • Line 284: warning: cyclomatic complexity 32 of function (*Row).UnmarshalMsgWithCfg() is high (> 15) (gocyclo)
  • Line 13: warning: cyclomatic complexity 30 of function (*Row).DecodeMsg() is high (> 15) (gocyclo)
  • Line 167: warning: cyclomatic complexity 16 of function (*Row).EncodeMsg() is high (> 15) (gocyclo)

• gleam/sql/util/types/datum_eval.go
  • Line 255: warning: cyclomatic complexity 19 of function ComputeMod() is high (> 15) (gocyclo)

• gleam/sql/plan/validator.go
  • Line 153: warning: cyclomatic complexity 17 of function (*validator).checkAutoIncrement() is high (> 15) (gocyclo)

• gleam/sql/plan/planbuilder.go
  • Line 289: warning: cyclomatic complexity 16 of function getShowColNamesAndTypes() is high (> 15) (gocyclo)

• gleam/sql/parser/goyacc/main.go
  • Line 228: warning: cyclomatic complexity 79 of function main1() is high (> 15) (gocyclo)

• gleam/instruction/join_partitioned_sorted.go
  • Line 57: warning: cyclomatic complexity 26 of function DoJoinPartitionedSorted() is high (> 15) (gocyclo)

• gleam/sql/plan/expression_rewriter.go
  • Line 205: warning: cyclomatic complexity 27 of function (*expressionRewriter).handleCompareSubquery() is high (> 15) (gocyclo)
  • Line 578: warning: cyclomatic complexity 23 of function (*expressionRewriter).Leave() is high (> 15) (gocyclo)
  • Line 150: warning: cyclomatic complexity 19 of function (*expressionRewriter).Enter() is high (> 15) (gocyclo)

• gleam/sql/util/stringutil/string_util.go
  • Line 50: warning: cyclomatic complexity 16 of function UnquoteChar() is high (> 15) (gocyclo)

• gleam/sql/executor/builder.go
  • Line 28: warning: cyclomatic complexity 37 of function (*executorBuilder).build() is high (> 15) (gocyclo)

• gleam/flow/dataset_output.go
  • Line 109: warning: cyclomatic complexity 18 of function setValueTo() is high (> 15) (gocyclo)

• gleam/sql/expression/builtin_time.go
  • Line 1362: warning: cyclomatic complexity 25 of function dateArithFuncFactory() is high (> 15) (gocyclo)

• gleam/sql/expression/util.go
  • Line 113: warning: cyclomatic complexity 16 of function getValidPrefix() is high (> 15) (gocyclo)

• gleam/sql/util/types/mydecimal.go
  • Line 1826: warning: cyclomatic complexity 43 of function doDivMod() is high (> 15) (gocyclo)
  • Line 1344: warning: cyclomatic complexity 40 of function doSub() is high (> 15) (gocyclo)
  • Line 680: warning: cyclomatic complexity 40 of function (*MyDecimal).Round() is high (> 15) (gocyclo)
  • Line 285: warning: cyclomatic complexity 32 of function (*MyDecimal).FromString() is high (> 15) (gocyclo)
  • Line 1042: warning: cyclomatic complexity 25 of function (*MyDecimal).ToBin() is high (> 15) (gocyclo)
  • Line 416: warning: cyclomatic complexity 24 of function (*MyDecimal).Shift() is high (> 15) (gocyclo)
  • Line 1663: warning: cyclomatic complexity 22 of function DecimalMul() is high (> 15) (gocyclo)
  • Line 1164: warning: cyclomatic complexity 21 of function (*MyDecimal).FromBin() is high (> 15) (gocyclo)
  • Line 1509: warning: cyclomatic complexity 19 of function doAdd() is high (> 15) (gocyclo)

• gleam/sql/util/codec/codec.go
  • Line 39: warning: cyclomatic complexity 18 of function encode() is high (> 15) (gocyclo)

• gleam/sql/ast/flag.go
  • Line 34: warning: cyclomatic complexity 26 of function (*flagSetter).Leave() is high (> 15) (gocyclo)

• gleam/sql/plan/stringer.go
  • Line 27: warning: cyclomatic complexity 22 of function toString() is high (> 15) (gocyclo)

• gleam/sql/plan/join_reorder.go
  • Line 92: warning: cyclomatic complexity 19 of function (*joinReOrderSolver).reorderJoin() is high (> 15) (gocyclo)

• gleam/distributed/driver/driver_execution_status.go
  • Line 26: warning: cyclomatic complexity 18 of function (*FlowDriver).logExecutionPlan() is high (> 15) (gocyclo)

• gleam/sql/terror/terror.go
  • Line 83: warning: cyclomatic complexity 19 of function (ErrClass).String() is high (> 15) (gocyclo)

• gleam/sql/session.go
  • Line 100: warning: cyclomatic complexity 22 of function checkArgs() is high (> 15) (gocyclo)

• gleam/sql/ast/dml.go
  • Line 467: warning: cyclomatic complexity 16 of function (*SelectStmt).Accept() is high (> 15) (gocyclo)

• gleam/sql/expression/builtin_op.go
  • Line 320: warning: cyclomatic complexity 26 of function unaryOpFactory() is high (> 15) (gocyclo)

• gleam/sql/util/format/format.go
  • Line 69: warning: cyclomatic complexity 28 of function (*indentFormatter).format() is high (> 15) (gocyclo)

• gleam/sql/resolver/resolver.go
  • Line 232: warning: cyclomatic complexity 41 of function (*nameResolver).Leave() is high (> 15) (gocyclo)
  • Line 138: warning: cyclomatic complexity 38 of function (*nameResolver).Enter() is high (> 15) (gocyclo)
  • Line 841: warning: cyclomatic complexity 29 of function (*nameResolver).fillShowFields() is high (> 15) (gocyclo)
  • Line 478: warning: cyclomatic complexity 24 of function (*nameResolver).resolveColumnNameInContext() is high (> 15) (gocyclo)
  • Line 578: warning: cyclomatic complexity 20 of function (*nameResolver).resolveColumnInTableSources() is high (> 15) (gocyclo)
  • Line 633: warning: cyclomatic complexity 17 of function (*nameResolver).resolveColumnInResultFields() is high (> 15) (gocyclo)
  • Line 701: warning: cyclomatic complexity 17 of function (*nameResolver).createResultFields() is high (> 15) (gocyclo)

• gleam/sql/expression/builtin_compare.go
  • Line 236: warning: cyclomatic complexity 17 of function compareFuncFactory() is high (> 15) (gocyclo)

• gleam/sql/util/types/mytime.go
  • Line 365: warning: cyclomatic complexity 26 of function timestampDiff() is high (> 15) (gocyclo)
  • Line 236: warning: cyclomatic complexity 18 of function calcWeek() is high (> 15) (gocyclo)

• gleam/sql/util/types/datum.go
  • Line 1357: warning: cyclomatic complexity 23 of function CoerceDatum() is high (> 15) (gocyclo)
  • Line 379: warning: cyclomatic complexity 22 of function (*Datum).CompareDatum() is high (> 15) (gocyclo)
  • Line 738: warning: cyclomatic complexity 22 of function (*Datum).convertToString() is high (> 15) (gocyclo)
  • Line 681: warning: cyclomatic complexity 21 of function (*Datum).convertToFloat() is high (> 15) (gocyclo)
  • Line 329: warning: cyclomatic complexity 21 of function (*Datum).SetValue() is high (> 15) (gocyclo)
  • Line 805: warning: cyclomatic complexity 19 of function (*Datum).convertToUint() is high (> 15) (gocyclo)
  • Line 955: warning: cyclomatic complexity 18 of function (*Datum).convertToMysqlDecimal() is high (> 15) (gocyclo)
  • Line 1196: warning: cyclomatic complexity 18 of function (*Datum).toSignedInteger() is high (> 15) (gocyclo)
  • Line 1107: warning: cyclomatic complexity 16 of function (*Datum).ToBool() is high (> 15) (gocyclo)

• gleam/sql/util/types/convert.go
  • Line 242: warning: cyclomatic complexity 19 of function getValidFloatPrefix() is high (> 15) (gocyclo)
  • Line 289: warning: cyclomatic complexity 18 of function ToString() is high (> 15) (gocyclo)
  • Line 174: warning: cyclomatic complexity 16 of function floatStrToIntStr() is high (> 15) (gocyclo)

• gleam/sql/plan/range.go
  • Line 567: warning: cyclomatic complexity 17 of function (*rangeBuilder).buildTableRanges() is high (> 15) (gocyclo)

• gleam/sql/expression/builtin_math.go
  • Line 481: warning: cyclomatic complexity 26 of function builtinConv() is high (> 15) (gocyclo)

• gleam/sql/util/types/time.go
  • Line 1667: warning: cyclomatic complexity 46 of function (Time).convertDateFormat() is high (> 15) (gocyclo)
  • Line 821: warning: cyclomatic complexity 24 of function ParseDuration() is high (> 15) (gocyclo)
  • Line 1238: warning: cyclomatic complexity 23 of function ExtractTimeNum() is high (> 15) (gocyclo)
  • Line 512: warning: cyclomatic complexity 18 of function parseDatetime() is high (> 15) (gocyclo)

• gleam/sql/plan/typeinferer.go
  • Line 254: warning: cyclomatic complexity 44 of function (*typeInferrer).handleFuncCallExpr() is high (> 15) (gocyclo)
  • Line 50: warning: cyclomatic complexity 24 of function (*typeInferrer).Leave() is high (> 15) (gocyclo)

• gleam/sql/plan/logical_plan_builder.go
  • Line 807: warning: cyclomatic complexity 23 of function (*planBuilder).buildSelect() is high (> 15) (gocyclo)
  • Line 585: warning: cyclomatic complexity 22 of function (*havingAndOrderbyExprResolver).Leave() is high (> 15) (gocyclo)

• gleam/sql/expression/helper.go
  • Line 57: warning: cyclomatic complexity 20 of function getTimeValue() is high (> 15) (gocyclo)

• gleam/sql/plan/refiner.go
  • Line 154: warning: cyclomatic complexity 16 of function (*conditionChecker).checkScalarFunction() is high (> 15) (gocyclo)

golint48%

Golint is a linter for Go source code.

• gleam/plugins/cassandra/cassandra_source.go
  • Line 16: warning: exported type CassandraSource should have comment or be unexported (golint)

• gleam/flow/dataset_sort_option.go
  • Line 10: warning: exported type SortOption should have comment or be unexported (golint)
  • Line 14: warning: exported function Field should have comment or be unexported (golint)
  • Line 25: warning: exported function OrderBy should have comment or be unexported (golint)
  • Line 40: warning: comment on exported method SortOption.By should be of the form "By ..." (golint)
  • Line 53: warning: comment on exported method SortOption.Indexes should be of the form "Indexes ..." (golint)

• gleam/sql/expression/scalar_function.go
  • Line 114: warning: context.Context should be the first parameter of a function (golint)
  • Line 144: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/master/ui/master_status_template.go
  • Line 7: warning: exported var MasterStatusTpl should have comment or be unexported (golint)

• gleam/sql/table/tables/tables.go
  • Line 27: warning: exported type Table should have comment or be unexported (golint)
  • Line 39: warning: exported function MockTableFromMeta should have comment or be unexported (golint)

• gleam/sql/executor/executor_projection.go
  • Line 12: warning: exported type ProjectionExec should have comment or be unexported (golint)
  • Line 25: warning: comment on exported method ProjectionExec.Exec should be of the form "Exec ..." (golint)

• gleam/filesystem/vfs_s3.go
  • Line 17: warning: exported const AWS_ACCESS_KEY should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type S3FileSystem should have comment or be unexported (golint)
  • Line 24: warning: exported method S3FileSystem.Accept should have comment or be unexported (golint)
  • Line 28: warning: exported method S3FileSystem.Open should have comment or be unexported (golint)
  • Line 58: warning: exported method S3FileSystem.List should have comment or be unexported (golint)
  • Line 62: warning: exported method S3FileSystem.IsDir should have comment or be unexported (golint)
  • Line 76: warning: exported type VirtualFileS3 should have comment or be unexported (golint)
  • Line 97: warning: exported method VirtualFileS3.Size should have comment or be unexported (golint)
  • Line 101: warning: exported method VirtualFileS3.Close should have comment or be unexported (golint)

• gleam/gio/type_convertion.go
  • Line 5: warning: exported function ToInt64 should have comment or be unexported (golint)
  • Line 8: warning: exported function ToFloat64 should have comment or be unexported (golint)
  • Line 12: warning: exported function ToString should have comment or be unexported (golint)
  • Line 16: warning: exported function ToBytes should have comment or be unexported (golint)

• gleam/flow/context_hint.go
  • Line 3: warning: exported type FlowHintOption should have comment or be unexported (golint)
  • Line 5: warning: exported type FlowConfig should have comment or be unexported (golint)

• gleam/flow/dataset_merge.go
  • Line 7: warning: exported method Dataset.MergeSortedTo should have comment or be unexported (golint)
  • Line 24: warning: exported method Dataset.TreeMergeSortedTo should have comment or be unexported (golint)
  • Line 35: warning: exported method Dataset.MergeTo should have comment or be unexported (golint)

• gleam/instruction/cogroup_partitioned_sorted.go
  • Line 21: warning: exported type CoGroupPartitionedSorted should have comment or be unexported (golint)
  • Line 25: warning: exported function NewCoGroupPartitionedSorted should have comment or be unexported (golint)
  • Line 29: warning: exported method CoGroupPartitionedSorted.Name should have comment or be unexported (golint)
  • Line 33: warning: exported method CoGroupPartitionedSorted.Function should have comment or be unexported (golint)
  • Line 39: warning: exported method CoGroupPartitionedSorted.SerializeToCommand should have comment or be unexported (golint)
  • Line 47: warning: exported method CoGroupPartitionedSorted.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 51: warning: exported function DoCoGroupPartitionedSorted should have comment or be unexported (golint)

• gleam/distributed/plan/instructions.go
  • Line 8: warning: exported function TranslateToInstructionSet should have comment or be unexported (golint)

• gleam/flow/structure.go
  • Line 14: warning: exported type NetworkType should have comment or be unexported (golint)
  • Line 17: warning: exported const OneShardToOneShard should have comment (or a comment on this block) or be unexported (golint)
  • Line 26: warning: exported type DatasetShardStatus should have comment or be unexported (golint)
  • Line 29: warning: exported const Untouched should have comment (or a comment on this block) or be unexported (golint)
  • Line 37: warning: exported type ModeIO should have comment or be unexported (golint)
  • Line 40: warning: exported const ModeInMemory should have comment (or a comment on this block) or be unexported (golint)
  • Line 44: warning: exported type DasetsetMetadata should have comment or be unexported (golint)
  • Line 49: warning: exported type DasetsetShardMetadata should have comment or be unexported (golint)
  • Line 57: warning: exported type StepMetadata should have comment or be unexported (golint)
  • Line 62: warning: exported type Flow should have comment or be unexported (golint)
  • Line 69: warning: exported type Dataset should have comment or be unexported (golint)
  • Line 81: warning: exported type DatasetShard should have comment or be unexported (golint)
  • Line 93: warning: exported type Step should have comment or be unexported (golint)
  • Line 114: warning: exported type Task should have comment or be unexported (golint)
  • Line 123: warning: exported type RunLocked should have comment or be unexported (golint)

• gleam/sql/expression/builtin_like.go
  • Line 144: warning: context.Context should be the first parameter of a function (golint)
  • Line 161: warning: context.Context should be the first parameter of a function (golint)
  • Line 190: warning: context.Context should be the first parameter of a function (golint)
  • Line 207: warning: context.Context should be the first parameter of a function (golint)

• gleam/sql/expression/expression.go
  • Line 78: warning: context.Context should be the first parameter of a function (golint)
  • Line 141: warning: context.Context should be the first parameter of a function (golint)
  • Line 146: warning: context.Context should be the first parameter of a function (golint)
  • Line 323: warning: context.Context should be the first parameter of a function (golint)
  • Line 333: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/channel_util.go
  • Line 54: warning: exported const BUFFER_SIZE should have comment (or a comment on this block) or be unexported (golint)
  • Line 57: warning: comment on exported function CopyMultipleReaders should be of the form "CopyMultipleReaders ..." (golint)
  • Line 103: warning: exported function ReaderToChannel should have comment or be unexported (golint)
  • Line 125: warning: exported function ChannelToWriter should have comment or be unexported (golint)
  • Line 142: warning: exported function LineReaderToChannel should have comment or be unexported (golint)
  • Line 170: warning: exported function ConvertLineReaderToRowReader should have comment or be unexported (golint)
  • Line 191: warning: exported function ChannelToLineWriter should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/scheduler_fetch.go
  • Line 13: warning: comment on exported method Scheduler.Fetch should be of the form "Fetch ..." (golint)

• gleam/pb/status_proto_helper.go
  • Line 7: warning: exported method FlowExecutionStatus_TaskGroup.Track should have comment or be unexported (golint)
  • Line 26: warning: exported method FlowExecutionStatus.GetDataset should have comment or be unexported (golint)
  • Line 37: warning: exported method FlowExecutionStatus.GetDatasetShard should have comment or be unexported (golint)
  • Line 48: warning: exported method FlowExecutionStatus.GetTask should have comment or be unexported (golint)
  • Line 59: warning: exported method FlowExecutionStatus.GetStep should have comment or be unexported (golint)

• gleam/flow/dataset_join_hash.go
  • Line 13: warning: exported method Dataset.LocalHashAndJoinWith should have comment or be unexported (golint)
  • Line 13: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 24: warning: receiver name d should be consistent with previous receiver name bigger for Dataset (golint)

• gleam/flow/dataset_source.go
  • Line 12: warning: exported type Sourcer should have comment or be unexported (golint)

• gleam/instruction/local_top.go
  • Line 23: warning: exported type LocalTop should have comment or be unexported (golint)
  • Line 28: warning: exported function NewLocalTop should have comment or be unexported (golint)
  • Line 32: warning: exported method LocalTop.Name should have comment or be unexported (golint)
  • Line 36: warning: exported method LocalTop.Function should have comment or be unexported (golint)
  • Line 42: warning: exported method LocalTop.SerializeToCommand should have comment or be unexported (golint)
  • Line 51: warning: exported method LocalTop.GetMemoryCostInMB should have comment or be unexported (golint)

• gleam/sql/expression/builtin_time.go
  • Line 149: warning: context.Context should be the first parameter of a function (golint)
  • Line 166: warning: context.Context should be the first parameter of a function (golint)
  • Line 184: warning: context.Context should be the first parameter of a function (golint)
  • Line 201: warning: context.Context should be the first parameter of a function (golint)
  • Line 226: warning: context.Context should be the first parameter of a function (golint)
  • Line 243: warning: context.Context should be the first parameter of a function (golint)
  • Line 263: warning: context.Context should be the first parameter of a function (golint)
  • Line 280: warning: context.Context should be the first parameter of a function (golint)
  • Line 300: warning: context.Context should be the first parameter of a function (golint)
  • Line 317: warning: context.Context should be the first parameter of a function (golint)
  • Line 327: warning: context.Context should be the first parameter of a function (golint)
  • Line 345: warning: context.Context should be the first parameter of a function (golint)
  • Line 353: warning: context.Context should be the first parameter of a function (golint)
  • Line 370: warning: context.Context should be the first parameter of a function (golint)
  • Line 386: warning: context.Context should be the first parameter of a function (golint)
  • Line 403: warning: context.Context should be the first parameter of a function (golint)
  • Line 419: warning: context.Context should be the first parameter of a function (golint)
  • Line 436: warning: context.Context should be the first parameter of a function (golint)
  • Line 452: warning: context.Context should be the first parameter of a function (golint)
  • Line 469: warning: context.Context should be the first parameter of a function (golint)
  • Line 485: warning: context.Context should be the first parameter of a function (golint)
  • Line 502: warning: context.Context should be the first parameter of a function (golint)
  • Line 524: warning: context.Context should be the first parameter of a function (golint)
  • Line 541: warning: context.Context should be the first parameter of a function (golint)
  • Line 564: warning: context.Context should be the first parameter of a function (golint)
  • Line 581: warning: context.Context should be the first parameter of a function (golint)
  • Line 614: warning: context.Context should be the first parameter of a function (golint)
  • Line 631: warning: context.Context should be the first parameter of a function (golint)
  • Line 649: warning: context.Context should be the first parameter of a function (golint)
  • Line 666: warning: context.Context should be the first parameter of a function (golint)
  • Line 688: warning: context.Context should be the first parameter of a function (golint)
  • Line 705: warning: context.Context should be the first parameter of a function (golint)
  • Line 728: warning: context.Context should be the first parameter of a function (golint)
  • Line 745: warning: context.Context should be the first parameter of a function (golint)
  • Line 767: warning: context.Context should be the first parameter of a function (golint)
  • Line 784: warning: context.Context should be the first parameter of a function (golint)
  • Line 817: warning: context.Context should be the first parameter of a function (golint)
  • Line 834: warning: context.Context should be the first parameter of a function (golint)
  • Line 860: warning: context.Context should be the first parameter of a function (golint)
  • Line 877: warning: context.Context should be the first parameter of a function (golint)
  • Line 888: warning: context.Context should be the first parameter of a function (golint)
  • Line 905: warning: context.Context should be the first parameter of a function (golint)
  • Line 926: warning: context.Context should be the first parameter of a function (golint)
  • Line 943: warning: context.Context should be the first parameter of a function (golint)
  • Line 978: warning: context.Context should be the first parameter of a function (golint)
  • Line 995: warning: context.Context should be the first parameter of a function (golint)
  • Line 1068: warning: context.Context should be the first parameter of a function (golint)
  • Line 1085: warning: context.Context should be the first parameter of a function (golint)
  • Line 1107: warning: context.Context should be the first parameter of a function (golint)
  • Line 1124: warning: context.Context should be the first parameter of a function (golint)
  • Line 1135: warning: context.Context should be the first parameter of a function (golint)
  • Line 1152: warning: context.Context should be the first parameter of a function (golint)
  • Line 1165: warning: context.Context should be the first parameter of a function (golint)
  • Line 1182: warning: context.Context should be the first parameter of a function (golint)
  • Line 1199: warning: context.Context should be the first parameter of a function (golint)
  • Line 1216: warning: context.Context should be the first parameter of a function (golint)
  • Line 1243: warning: context.Context should be the first parameter of a function (golint)
  • Line 1260: warning: context.Context should be the first parameter of a function (golint)
  • Line 1273: warning: context.Context should be the first parameter of a function (golint)
  • Line 1290: warning: context.Context should be the first parameter of a function (golint)
  • Line 1344: warning: context.Context should be the first parameter of a function (golint)
  • Line 1479: warning: context.Context should be the first parameter of a function (golint)
  • Line 1496: warning: context.Context should be the first parameter of a function (golint)
  • Line 1516: warning: context.Context should be the first parameter of a function (golint)
  • Line 1530: warning: context.Context should be the first parameter of a function (golint)
  • Line 1547: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/dirpath.go
  • Line 9: warning: exported function UserHomeDir should have comment or be unexported (golint)
  • Line 20: warning: exported function CleanPath should have comment or be unexported (golint)

• gleam/util/piper.go
  • Line 7: warning: exported type Piper should have comment or be unexported (golint)
  • Line 14: warning: exported function NewPiper should have comment or be unexported (golint)

• gleam/distributed/store/local_file_data_store.go
  • Line 1: warning: package comment should be of the form "Package store ..." (golint)
  • Line 10: warning: exported type DataStore should have comment or be unexported (golint)
  • Line 18: warning: exported type LocalFileDataStore should have comment or be unexported (golint)
  • Line 26: warning: exported function NewLocalFileDataStore should have comment or be unexported (golint)
  • Line 45: warning: exported method LocalFileDataStore.ReadAt should have comment or be unexported (golint)
  • Line 50: warning: exported method LocalFileDataStore.Destroy should have comment or be unexported (golint)
  • Line 54: warning: exported method LocalFileDataStore.LastWriteAt should have comment or be unexported (golint)
  • Line 58: warning: exported method LocalFileDataStore.LastReadAt should have comment or be unexported (golint)

• gleam/util/row_codec.go
  • Line 26: warning: don't use underscores in Go names; const maxFields2zgensym_56fd93edf47ccbd5_3 should be maxFields2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 29: warning: don't use underscores in Go names; var totalEncodedFields2zgensym_56fd93edf47ccbd5_3 should be totalEncodedFields2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 34: warning: don't use underscores in Go names; var encodedFieldsLeft2zgensym_56fd93edf47ccbd5_3 should be encodedFieldsLeft2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 35: warning: don't use underscores in Go names; var missingFieldsLeft2zgensym_56fd93edf47ccbd5_3 should be missingFieldsLeft2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 37: warning: don't use underscores in Go names; var nextMiss2zgensym_56fd93edf47ccbd5_3 should be nextMiss2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 38: warning: don't use underscores in Go names; var found2zgensym_56fd93edf47ccbd5_3 should be found2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 39: warning: don't use underscores in Go names; var curField2zgensym_56fd93edf47ccbd5_3 should be curField2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 77: warning: don't use underscores in Go names; var zgensym_56fd93edf47ccbd5_4 should be zgensym56fd93edf47ccbd5_4 (golint)
  • Line 87: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_0 should be zgensym56fd93edf47ccbd5_0 (golint)
  • Line 95: warning: don't use underscores in Go names; var zgensym_56fd93edf47ccbd5_5 should be zgensym56fd93edf47ccbd5_5 (golint)
  • Line 105: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_1 should be zgensym56fd93edf47ccbd5_1 (golint)
  • Line 140: warning: don't use underscores in Go names; var decodeMsgFieldOrder2zgensym_56fd93edf47ccbd5_3 should be decodeMsgFieldOrder2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 142: warning: don't use underscores in Go names; var decodeMsgFieldSkip2zgensym_56fd93edf47ccbd5_3 should be decodeMsgFieldSkip2zgensym56fd93edf47ccbd5_3 (golint)
  • Line 173: warning: don't use underscores in Go names; var empty_zgensym_56fd93edf47ccbd5_6 should be emptyZgensym56fd93edf47ccbd5_6 (golint)
  • Line 174: warning: don't use underscores in Go names; var fieldsInUse_zgensym_56fd93edf47ccbd5_7 should be fieldsInUseZgensym56fd93edf47ccbd5_7 (golint)
  • Line 192: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_0 should be zgensym56fd93edf47ccbd5_0 (golint)
  • Line 210: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_1 should be zgensym56fd93edf47ccbd5_1 (golint)
  • Line 250: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_0 should be zgensym56fd93edf47ccbd5_0 (golint)
  • Line 262: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_1 should be zgensym56fd93edf47ccbd5_1 (golint)
  • Line 284: warning: exported method Row.UnmarshalMsgWithCfg should have comment or be unexported (golint)
  • Line 295: warning: don't use underscores in Go names; const maxFields8zgensym_56fd93edf47ccbd5_9 should be maxFields8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 298: warning: don't use underscores in Go names; var totalEncodedFields8zgensym_56fd93edf47ccbd5_9 should be totalEncodedFields8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 305: warning: don't use underscores in Go names; var encodedFieldsLeft8zgensym_56fd93edf47ccbd5_9 should be encodedFieldsLeft8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 306: warning: don't use underscores in Go names; var missingFieldsLeft8zgensym_56fd93edf47ccbd5_9 should be missingFieldsLeft8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 308: warning: don't use underscores in Go names; var nextMiss8zgensym_56fd93edf47ccbd5_9 should be nextMiss8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 309: warning: don't use underscores in Go names; var found8zgensym_56fd93edf47ccbd5_9 should be found8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 310: warning: don't use underscores in Go names; var curField8zgensym_56fd93edf47ccbd5_9 should be curField8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 351: warning: don't use underscores in Go names; var zgensym_56fd93edf47ccbd5_10 should be zgensym56fd93edf47ccbd5_10 (golint)
  • Line 361: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_0 should be zgensym56fd93edf47ccbd5_0 (golint)
  • Line 375: warning: don't use underscores in Go names; var zgensym_56fd93edf47ccbd5_11 should be zgensym56fd93edf47ccbd5_11 (golint)
  • Line 385: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_1 should be zgensym56fd93edf47ccbd5_1 (golint)
  • Line 423: warning: don't use underscores in Go names; var unmarshalMsgFieldOrder8zgensym_56fd93edf47ccbd5_9 should be unmarshalMsgFieldOrder8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 425: warning: don't use underscores in Go names; var unmarshalMsgFieldSkip8zgensym_56fd93edf47ccbd5_9 should be unmarshalMsgFieldSkip8zgensym56fd93edf47ccbd5_9 (golint)
  • Line 430: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_0 should be zgensym56fd93edf47ccbd5_0 (golint)
  • Line 434: warning: don't use underscores in Go names; range var zgensym_56fd93edf47ccbd5_1 should be zgensym56fd93edf47ccbd5_1 (golint)

• gleam/distributed/driver/driver.go
  • Line 21: warning: exported type Option should have comment or be unexported (golint)
  • Line 32: warning: exported type FlowDriver should have comment or be unexported (golint)
  • Line 41: warning: exported function NewFlowDriver should have comment or be unexported (golint)
  • Line 48: warning: comment on exported method FlowDriver.RunFlowContext should be of the form "RunFlowContext ..." (golint)
  • Line 135: warning: should omit 2nd value from range; this loop is equivalent to `for url := range ...` (golint)

• gleam/plugins/kafka/kafka_source_builder.go
  • Line 7: warning: exported function New should have comment or be unexported (golint)
  • Line 18: warning: exported method KafkaSource.Timeout should have comment or be unexported (golint)

• gleam/script/script.go
  • Line 1: warning: package comment should be of the form "Package script ..." (golint)
  • Line 8: warning: exported type Command should have comment or be unexported (golint)
  • Line 14: warning: exported type Script should have comment or be unexported (golint)
  • Line 29: warning: exported method Command.ToOsExecCommand should have comment or be unexported (golint)

• gleam/instruction/local_group_by_sorted.go
  • Line 22: warning: exported type LocalGroupBySorted should have comment or be unexported (golint)
  • Line 26: warning: exported function NewLocalGroupBySorted should have comment or be unexported (golint)
  • Line 30: warning: exported method LocalGroupBySorted.Name should have comment or be unexported (golint)
  • Line 34: warning: exported method LocalGroupBySorted.Function should have comment or be unexported (golint)
  • Line 40: warning: exported method LocalGroupBySorted.SerializeToCommand should have comment or be unexported (golint)
  • Line 48: warning: exported method LocalGroupBySorted.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 52: warning: exported function DoLocalGroupBySorted should have comment or be unexported (golint)

• gleam/instruction/local_hash_and_join_with.go
  • Line 23: warning: exported type LocalHashAndJoinWith should have comment or be unexported (golint)
  • Line 27: warning: exported function NewLocalHashAndJoinWith should have comment or be unexported (golint)
  • Line 31: warning: exported method LocalHashAndJoinWith.Name should have comment or be unexported (golint)
  • Line 35: warning: exported method LocalHashAndJoinWith.Function should have comment or be unexported (golint)
  • Line 41: warning: exported method LocalHashAndJoinWith.SerializeToCommand should have comment or be unexported (golint)
  • Line 49: warning: exported method LocalHashAndJoinWith.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 53: warning: exported function DoLocalHashAndJoinWith should have comment or be unexported (golint)

• gleam/distributed/resource/related_files.go
  • Line 11: warning: exported type FileResource should have comment or be unexported (golint)
  • Line 16: warning: exported type FileHash should have comment or be unexported (golint)
  • Line 23: warning: exported function GenerateFileHash should have comment or be unexported (golint)

• gleam/gio/map_reduce.go
  • Line 14: warning: exported type MapperId should have comment or be unexported (golint)
  • Line 15: warning: exported type ReducerId should have comment or be unexported (golint)
  • Line 16: warning: exported type Mapper should have comment or be unexported (golint)
  • Line 17: warning: exported type Reducer should have comment or be unexported (golint)
  • Line 35: warning: exported var HasInitalized should have comment or be unexported (golint)
  • Line 59: warning: exported type MapperObject should have comment or be unexported (golint)
  • Line 64: warning: exported type ReducerObject should have comment or be unexported (golint)
  • Line 85: warning: exported function GetMapper should have comment or be unexported (golint)
  • Line 94: warning: exported function RegisterReducer should have comment or be unexported (golint)
  • Line 104: warning: exported function GetReducer should have comment or be unexported (golint)

• gleam/plugins/cassandra/cassandra_shard_info.go
  • Line 16: warning: exported type CassandraShardInfo should have comment or be unexported (golint)
  • Line 30: warning: exported var MapperReadShard should have comment or be unexported (golint)
  • Line 42: warning: exported method CassandraShardInfo.ReadSplit should have comment or be unexported (golint)

• gleam/flow/dataset_sort.go
  • Line 37: warning: exported method Dataset.SortByKey should have comment or be unexported (golint)
  • Line 51: warning: exported method Dataset.LocalDistinct should have comment or be unexported (golint)
  • Line 59: warning: exported method Dataset.LocalSort should have comment or be unexported (golint)
  • Line 72: warning: exported method Dataset.LocalTop should have comment or be unexported (golint)

• gleam/sql/expression/aggregation.go
  • Line 140: warning: context.Context should be the first parameter of a function (golint)
  • Line 186: warning: context.Context should be the first parameter of a function (golint)
  • Line 253: warning: context.Context should be the first parameter of a function (golint)
  • Line 280: warning: context.Context should be the first parameter of a function (golint)
  • Line 322: warning: context.Context should be the first parameter of a function (golint)
  • Line 327: warning: context.Context should be the first parameter of a function (golint)
  • Line 347: warning: context.Context should be the first parameter of a function (golint)
  • Line 388: warning: context.Context should be the first parameter of a function (golint)
  • Line 416: warning: context.Context should be the first parameter of a function (golint)
  • Line 453: warning: context.Context should be the first parameter of a function (golint)
  • Line 523: warning: context.Context should be the first parameter of a function (golint)
  • Line 555: warning: context.Context should be the first parameter of a function (golint)
  • Line 563: warning: context.Context should be the first parameter of a function (golint)
  • Line 619: warning: context.Context should be the first parameter of a function (golint)
  • Line 655: warning: context.Context should be the first parameter of a function (golint)
  • Line 731: warning: context.Context should be the first parameter of a function (golint)
  • Line 765: warning: context.Context should be the first parameter of a function (golint)
  • Line 793: warning: context.Context should be the first parameter of a function (golint)
  • Line 840: warning: context.Context should be the first parameter of a function (golint)
  • Line 858: warning: context.Context should be the first parameter of a function (golint)
  • Line 891: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/master/ui/job_status_template.go
  • Line 7: warning: exported var JobStatusTpl should have comment or be unexported (golint)

• gleam/sql/executor/executor_union_scan.go
  • Line 9: warning: exported type UnionScanExec should have comment or be unexported (golint)
  • Line 23: warning: comment on exported method UnionScanExec.Exec should be of the form "Exec ..." (golint)

• gleam/flow/dataset_map.go
  • Line 12: warning: comment on exported method Dataset.Map should be of the form "Map ..." (golint)
  • Line 51: warning: comment on exported method Dataset.SelectKV should be of the form "SelectKV ..." (golint)

• gleam/instruction/partition_collect.go
  • Line 19: warning: exported type CollectPartitions should have comment or be unexported (golint)
  • Line 22: warning: exported function NewCollectPartitions should have comment or be unexported (golint)
  • Line 26: warning: exported method CollectPartitions.Name should have comment or be unexported (golint)
  • Line 30: warning: exported method CollectPartitions.Function should have comment or be unexported (golint)
  • Line 36: warning: exported method CollectPartitions.SerializeToCommand should have comment or be unexported (golint)
  • Line 42: warning: exported method CollectPartitions.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 46: warning: exported function DoCollectPartitions should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/grpc_client_to_agent.go
  • Line 191: warning: exported function SendCleanupRequest should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/scheduler_dataset_shard.go
  • Line 11: warning: exported method Scheduler.DeleteOutput should have comment or be unexported (golint)
  • Line 60: warning: exported method Scheduler.GetShardLocation should have comment or be unexported (golint)

• gleam/sql/executor/executor.go
  • Line 8: warning: exported type Executor should have comment or be unexported (golint)

• gleam/gio/mapper/simple_mapper.go
  • Line 10: warning: exported var Tokenize should have comment or be unexported (golint)

• gleam/distributed/planner.go
  • Line 11: warning: exported type DistributedPlanner should have comment or be unexported (golint)
  • Line 14: warning: exported function Planner should have comment or be unexported (golint)
  • Line 18: warning: exported method DistributedPlanner.GetFlowRunner should have comment or be unexported (golint)
  • Line 22: warning: comment on exported method DistributedPlanner.RunFlowContext should be of the form "RunFlowContext ..." (golint)
  • Line 23: warning: receiver name fcd should be consistent with previous receiver name o for DistributedPlanner (golint)

• gleam/instruction/local_distinct.go
  • Line 22: warning: exported type LocalDistinct should have comment or be unexported (golint)
  • Line 26: warning: exported function NewLocalDistinct should have comment or be unexported (golint)
  • Line 30: warning: exported method LocalDistinct.Name should have comment or be unexported (golint)
  • Line 34: warning: exported method LocalDistinct.Function should have comment or be unexported (golint)
  • Line 40: warning: exported method LocalDistinct.SerializeToCommand should have comment or be unexported (golint)
  • Line 48: warning: exported method LocalDistinct.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 52: warning: exported function DoLocalDistinct should have comment or be unexported (golint)

• gleam/sql/expression/builtin_compare.go
  • Line 45: warning: context.Context should be the first parameter of a function (golint)
  • Line 62: warning: context.Context should be the first parameter of a function (golint)
  • Line 75: warning: context.Context should be the first parameter of a function (golint)
  • Line 92: warning: context.Context should be the first parameter of a function (golint)
  • Line 120: warning: context.Context should be the first parameter of a function (golint)
  • Line 137: warning: context.Context should be the first parameter of a function (golint)
  • Line 165: warning: context.Context should be the first parameter of a function (golint)
  • Line 182: warning: context.Context should be the first parameter of a function (golint)
  • Line 218: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/retry.go
  • Line 8: warning: exported function Retry should have comment or be unexported (golint)
  • Line 12: warning: exported function TimeDelayedRetry should have comment or be unexported (golint)

• gleam/examples/parquet/parquet_reading.go
  • Line 4: warning: should not use dot imports (golint)

• gleam/sql/resolver/resolver.go
  • Line 30: warning: context.Context should be the first parameter of a function (golint)

• gleam/instruction/join_partitioned_sorted.go
  • Line 23: warning: exported type JoinPartitionedSorted should have comment or be unexported (golint)
  • Line 29: warning: exported function NewJoinPartitionedSorted should have comment or be unexported (golint)
  • Line 33: warning: exported method JoinPartitionedSorted.Name should have comment or be unexported (golint)
  • Line 37: warning: exported method JoinPartitionedSorted.Function should have comment or be unexported (golint)
  • Line 43: warning: exported method JoinPartitionedSorted.SerializeToCommand should have comment or be unexported (golint)
  • Line 53: warning: exported method JoinPartitionedSorted.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 57: warning: exported function DoJoinPartitionedSorted should have comment or be unexported (golint)

• gleam/sql/expression/builtin_control.go
  • Line 40: warning: context.Context should be the first parameter of a function (golint)
  • Line 57: warning: context.Context should be the first parameter of a function (golint)
  • Line 86: warning: context.Context should be the first parameter of a function (golint)
  • Line 103: warning: context.Context should be the first parameter of a function (golint)
  • Line 132: warning: context.Context should be the first parameter of a function (golint)
  • Line 149: warning: context.Context should be the first parameter of a function (golint)
  • Line 166: warning: context.Context should be the first parameter of a function (golint)
  • Line 183: warning: context.Context should be the first parameter of a function (golint)

• gleam/script/shell.go
  • Line 1: warning: package comment should be of the form "Package script ..." (golint)
  • Line 4: warning: exported type Operation should have comment or be unexported (golint)
  • Line 9: warning: exported type ShellScript should have comment or be unexported (golint)
  • Line 15: warning: exported function NewShellScript should have comment or be unexported (golint)
  • Line 19: warning: exported method ShellScript.Init should have comment or be unexported (golint)
  • Line 22: warning: exported method ShellScript.Name should have comment or be unexported (golint)
  • Line 26: warning: exported method ShellScript.GetCommand should have comment or be unexported (golint)
  • Line 35: warning: exported method ShellScript.Pipe should have comment or be unexported (golint)

• gleam/plugins/file/zipfile/zip_file_reader.go
  • Line 11: warning: exported type FileReader should have comment or be unexported (golint)
  • Line 17: warning: exported function New should have comment or be unexported (golint)
  • Line 27: warning: exported method FileReader.ReadHeader should have comment or be unexported (golint)

• gleam/flow/context.go
  • Line 15: warning: exported function New should have comment or be unexported (golint)
  • Line 25: warning: exported method Flow.Run should have comment or be unexported (golint)
  • Line 29: warning: exported method Flow.RunContext should have comment or be unexported (golint)
  • Line 45: warning: exported method Flow.NewNextDataset should have comment or be unexported (golint)
  • Line 51: warning: comment on exported method Flow.AddOneToOneStep should be of the form "AddOneToOneStep ..." (golint)
  • Line 52: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 77: warning: comment on exported method Flow.AddAllToOneStep should be of the form "AddAllToOneStep ..." (golint)
  • Line 78: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 95: warning: comment on exported method Flow.AddOneToAllStep should be of the form "AddOneToAllStep ..." (golint)
  • Line 97: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 114: warning: exported method Flow.AddAllToAllStep should have comment or be unexported (golint)
  • Line 114: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 131: warning: exported method Flow.AddOneToEveryNStep should have comment or be unexported (golint)
  • Line 131: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 149: warning: exported method Flow.AddLinkedNToOneStep should have comment or be unexported (golint)
  • Line 149: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)
  • Line 166: warning: comment on exported method Flow.MergeDatasets1ShardTo1Step should be of the form "MergeDatasets1ShardTo1Step ..." (golint)
  • Line 167: warning: receiver name f should be consistent with previous receiver name fc for Flow (golint)

• gleam/flow/dataset_partition.go
  • Line 7: warning: exported method Dataset.RoundRobin should have comment or be unexported (golint)
  • Line 18: warning: comment on exported method Dataset.Partition should be of the form "Partition ..." (golint)
  • Line 38: warning: exported method Dataset.PartitionByKey should have comment or be unexported (golint)
  • Line 42: warning: don't use underscores in Go names; method partition_scatter should be partitionScatter (golint)
  • Line 50: warning: don't use underscores in Go names; method partition_collect should be partitionCollect (golint)

• gleam/sql/expression/builtin_math.go
  • Line 71: warning: context.Context should be the first parameter of a function (golint)
  • Line 88: warning: context.Context should be the first parameter of a function (golint)
  • Line 116: warning: context.Context should be the first parameter of a function (golint)
  • Line 133: warning: context.Context should be the first parameter of a function (golint)
  • Line 151: warning: context.Context should be the first parameter of a function (golint)
  • Line 168: warning: context.Context should be the first parameter of a function (golint)
  • Line 193: warning: context.Context should be the first parameter of a function (golint)
  • Line 210: warning: context.Context should be the first parameter of a function (golint)
  • Line 251: warning: context.Context should be the first parameter of a function (golint)
  • Line 268: warning: context.Context should be the first parameter of a function (golint)
  • Line 287: warning: context.Context should be the first parameter of a function (golint)
  • Line 304: warning: context.Context should be the first parameter of a function (golint)
  • Line 324: warning: context.Context should be the first parameter of a function (golint)
  • Line 346: warning: context.Context should be the first parameter of a function (golint)
  • Line 362: warning: context.Context should be the first parameter of a function (golint)
  • Line 379: warning: context.Context should be the first parameter of a function (golint)
  • Line 398: warning: context.Context should be the first parameter of a function (golint)
  • Line 415: warning: context.Context should be the first parameter of a function (golint)
  • Line 464: warning: context.Context should be the first parameter of a function (golint)
  • Line 481: warning: context.Context should be the first parameter of a function (golint)
  • Line 564: warning: context.Context should be the first parameter of a function (golint)
  • Line 581: warning: context.Context should be the first parameter of a function (golint)
  • Line 598: warning: context.Context should be the first parameter of a function (golint)
  • Line 615: warning: context.Context should be the first parameter of a function (golint)
  • Line 631: warning: context.Context should be the first parameter of a function (golint)
  • Line 648: warning: context.Context should be the first parameter of a function (golint)
  • Line 676: warning: context.Context should be the first parameter of a function (golint)

• gleam/sql/plan/optimizer.go
  • Line 51: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/context.go
  • Line 7: warning: exported function ExecuteWithCleanup should have comment or be unexported (golint)

• gleam/plugins/file/txt/txt_file_reader.go
  • Line 10: warning: exported type TxtFileReader should have comment or be unexported (golint)
  • Line 14: warning: exported function New should have comment or be unexported (golint)
  • Line 21: warning: exported method TxtFileReader.ReadHeader should have comment or be unexported (golint)

• gleam/distributed/master/master_grpc_server.go
  • Line 19: warning: exported type MasterServer should have comment or be unexported (golint)
  • Line 40: warning: exported method MasterServer.GetResources should have comment or be unexported (golint)
  • Line 64: warning: exported method MasterServer.SendHeartbeat should have comment or be unexported (golint)
  • Line 90: warning: exported method MasterServer.SendFlowExecutionStatus should have comment or be unexported (golint)

• gleam/filesystem/vfs_hdfs.go
  • Line 12: warning: comment on exported type HdfsFileSystem should be of the form "HdfsFileSystem ..." (with optional leading article) (golint)
  • Line 22: warning: exported method HdfsFileSystem.Accept should have comment or be unexported (golint)
  • Line 26: warning: exported method HdfsFileSystem.Open should have comment or be unexported (golint)
  • Line 70: warning: exported method HdfsFileSystem.IsDir should have comment or be unexported (golint)
  • Line 104: warning: exported type VirtualFileHdfs should have comment or be unexported (golint)
  • Line 108: warning: exported method VirtualFileHdfs.Size should have comment or be unexported (golint)

• gleam/sql/expression/builtin_other.go
  • Line 54: warning: context.Context should be the first parameter of a function (golint)
  • Line 76: warning: context.Context should be the first parameter of a function (golint)
  • Line 112: warning: context.Context should be the first parameter of a function (golint)
  • Line 129: warning: context.Context should be the first parameter of a function (golint)
  • Line 168: warning: context.Context should be the first parameter of a function (golint)
  • Line 184: warning: context.Context should be the first parameter of a function (golint)
  • Line 195: warning: context.Context should be the first parameter of a function (golint)
  • Line 239: warning: context.Context should be the first parameter of a function (golint)
  • Line 260: warning: context.Context should be the first parameter of a function (golint)
  • Line 277: warning: context.Context should be the first parameter of a function (golint)
  • Line 298: warning: context.Context should be the first parameter of a function (golint)
  • Line 311: warning: context.Context should be the first parameter of a function (golint)
  • Line 329: warning: context.Context should be the first parameter of a function (golint)
  • Line 338: warning: context.Context should be the first parameter of a function (golint)
  • Line 356: warning: context.Context should be the first parameter of a function (golint)
  • Line 367: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/driver/driver_execution_status.go
  • Line 14: warning: exported method FlowDriver.GetTaskGroupStatus should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/scheduler.go
  • Line 1: warning: package comment should be of the form "Package scheduler ..." (golint)
  • Line 14: warning: exported type Scheduler should have comment or be unexported (golint)
  • Line 24: warning: exported type RemoteExecutorStatus should have comment or be unexported (golint)
  • Line 35: warning: exported type Option should have comment or be unexported (golint)
  • Line 46: warning: exported function New should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/scheduler_execute_task_group.go
  • Line 123: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

• gleam/distributed/executor/executor.go
  • Line 22: warning: exported type ExecutorOption should have comment or be unexported (golint)
  • Line 28: warning: exported type Executor should have comment or be unexported (golint)
  • Line 35: warning: exported function NewExecutor should have comment or be unexported (golint)
  • Line 43: warning: exported method Executor.ExecuteInstructionSet should have comment or be unexported (golint)

• gleam/distributed/agent/agent_grpc_server.go
  • Line 24: warning: exported method AgentServer.SendFileResource should have comment or be unexported (golint)
  • Line 112: warning: comment on exported method AgentServer.CollectExecutionStatistics should be of the form "CollectExecutionStatistics ..." (golint)

• gleam/plugins/file/parquet/parquet_file_reader.go
  • Line 6: warning: should not use dot imports (golint)
  • Line 7: warning: should not use dot imports (golint)
  • Line 8: warning: should not use dot imports (golint)
  • Line 12: warning: exported type PqFile should have comment or be unexported (golint)
  • Line 17: warning: exported method PqFile.Create should have comment or be unexported (golint)
  • Line 17: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 21: warning: exported method PqFile.Open should have comment or be unexported (golint)
  • Line 21: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 35: warning: exported method PqFile.Seek should have comment or be unexported (golint)
  • Line 35: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 38: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 41: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 44: warning: exported method PqFile.Close should have comment or be unexported (golint)
  • Line 44: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 46: warning: exported type ParquetFileReader should have comment or be unexported (golint)
  • Line 52: warning: exported function New should have comment or be unexported (golint)
  • Line 61: warning: exported method ParquetFileReader.ReadHeader should have comment or be unexported (golint)
  • Line 61: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)
  • Line 65: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• gleam/instruction/local_limit.go
  • Line 22: warning: exported type LocalLimit should have comment or be unexported (golint)
  • Line 27: warning: exported function NewLocalLimit should have comment or be unexported (golint)
  • Line 31: warning: exported method LocalLimit.Name should have comment or be unexported (golint)
  • Line 35: warning: exported method LocalLimit.Function should have comment or be unexported (golint)
  • Line 41: warning: exported method LocalLimit.SerializeToCommand should have comment or be unexported (golint)
  • Line 50: warning: exported method LocalLimit.GetMemoryCostInMB should have comment or be unexported (golint)

• gleam/distributed/option.go
  • Line 11: warning: exported type DistributedOption should have comment or be unexported (golint)
  • Line 22: warning: exported function Option should have comment or be unexported (golint)
  • Line 31: warning: exported method DistributedOption.GetFlowRunner should have comment or be unexported (golint)
  • Line 44: warning: exported method DistributedOption.SetDataCenter should have comment or be unexported (golint)
  • Line 49: warning: exported method DistributedOption.SetMaster should have comment or be unexported (golint)

• gleam/distributed/master/master.go
  • Line 19: warning: exported function RunMaster should have comment or be unexported (golint)

• gleam/plugins/file/file_reader.go
  • Line 21: warning: exported type FileReader should have comment or be unexported (golint)
  • Line 26: warning: exported function Csv should have comment or be unexported (golint)
  • Line 29: warning: exported function Txt should have comment or be unexported (golint)
  • Line 32: warning: exported function Tsv should have comment or be unexported (golint)
  • Line 35: warning: exported function Orc should have comment or be unexported (golint)
  • Line 38: warning: exported function Parquet should have comment or be unexported (golint)
  • Line 41: warning: exported function Zip should have comment or be unexported (golint)
  • Line 45: warning: exported method FileShardInfo.NewReader should have comment or be unexported (golint)
  • Line 51: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

• gleam/instruction/merge_to.go
  • Line 20: warning: exported type MergeTo should have comment or be unexported (golint)
  • Line 22: warning: exported function NewMergeTo should have comment or be unexported (golint)
  • Line 26: warning: exported method MergeTo.Name should have comment or be unexported (golint)
  • Line 30: warning: exported method MergeTo.Function should have comment or be unexported (golint)
  • Line 36: warning: exported method MergeTo.SerializeToCommand should have comment or be unexported (golint)
  • Line 42: warning: exported method MergeTo.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 46: warning: exported function DoMergeTo should have comment or be unexported (golint)

• gleam/instruction/pipe_as_args.go
  • Line 25: warning: exported type PipeAsArgs should have comment or be unexported (golint)
  • Line 29: warning: exported function NewPipeAsArgs should have comment or be unexported (golint)
  • Line 33: warning: exported method PipeAsArgs.Name should have comment or be unexported (golint)
  • Line 37: warning: exported method PipeAsArgs.Function should have comment or be unexported (golint)
  • Line 43: warning: exported method PipeAsArgs.SerializeToCommand should have comment or be unexported (golint)
  • Line 51: warning: exported method PipeAsArgs.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 55: warning: exported function DoPipeAsArgs should have comment or be unexported (golint)

• gleam/util/http_util.go
  • Line 13: warning: exported var Transport should have comment or be unexported (golint)
  • Line 24: warning: exported function Post should have comment or be unexported (golint)
  • Line 37: warning: exported function Get should have comment or be unexported (golint)
  • Line 53: warning: exported function DownloadUrl should have comment or be unexported (golint)

• gleam/sql/executor/adapter.go
  • Line 14: warning: comment on exported type Statement should be of the form "Statement ..." (with optional leading article) (golint)
  • Line 24: warning: exported method Statement.OriginText should have comment or be unexported (golint)

• gleam/distributed/agent/agent_server.go
  • Line 21: warning: exported type AgentServerOption should have comment or be unexported (golint)
  • Line 34: warning: exported type AgentServer should have comment or be unexported (golint)
  • Line 46: warning: exported function RunAgentServer should have comment or be unexported (golint)
  • Line 127: warning: receiver name r should be consistent with previous receiver name as for AgentServer (golint)

• gleam/instruction/union.go
  • Line 21: warning: exported type Union should have comment or be unexported (golint)
  • Line 25: warning: exported function NewUnion should have comment or be unexported (golint)
  • Line 31: warning: exported method Union.Name should have comment or be unexported (golint)
  • Line 35: warning: exported method Union.Function should have comment or be unexported (golint)
  • Line 41: warning: exported method Union.SerializeToCommand should have comment or be unexported (golint)
  • Line 49: warning: exported method Union.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 53: warning: exported function DoUnion should have comment or be unexported (golint)

• gleam/util/row.go
  • Line 1: warning: package comment should be of the form "Package util ..." (golint)
  • Line 4: warning: exported type Row should have comment or be unexported (golint)
  • Line 10: warning: exported function NewRow should have comment or be unexported (golint)
  • Line 20: warning: exported method Row.AppendKey should have comment or be unexported (golint)
  • Line 25: warning: exported method Row.AppendValue should have comment or be unexported (golint)

• gleam/distributed/netchan/channels.go
  • Line 19: warning: exported function DialReadChannel should have comment or be unexported (golint)
  • Line 54: warning: exported function DialWriteChannel should have comment or be unexported (golint)

• gleam/filesystem/vfs_local.go
  • Line 10: warning: exported type LocalFileSystem should have comment or be unexported (golint)
  • Line 13: warning: exported method LocalFileSystem.Accept should have comment or be unexported (golint)
  • Line 26: warning: exported method LocalFileSystem.Open should have comment or be unexported (golint)
  • Line 31: warning: exported method LocalFileSystem.List should have comment or be unexported (golint)
  • Line 43: warning: exported method LocalFileSystem.IsDir should have comment or be unexported (golint)
  • Line 64: warning: exported type VirtualFileLocal should have comment or be unexported (golint)
  • Line 68: warning: exported method VirtualFileLocal.Size should have comment or be unexported (golint)

• gleam/pb/instruction_helper.go
  • Line 7: warning: exported method DatasetShard.Name should have comment or be unexported (golint)
  • Line 11: warning: exported method DatasetShardLocation.Address should have comment or be unexported (golint)
  • Line 15: warning: exported method InstructionSet.InstructionNames should have comment or be unexported (golint)
  • Line 22: warning: exported method Instruction.SetInputLocations should have comment or be unexported (golint)
  • Line 33: warning: exported method Instruction.SetOutputLocations should have comment or be unexported (golint)
  • Line 44: warning: exported method Instruction.GetName should have comment or be unexported (golint)

• gleam/plugins/file/csv/generic_csv_reader.go
  • Line 82: warning: exported const SINGLE_QUOTE should have comment (or a comment on this block) or be unexported (golint)

• gleam/flow/dataset_cogroup.go
  • Line 11: warning: don't use underscores in Go names; var sorted_d should be sortedD (golint)
  • Line 16: warning: don't use underscores in Go names; var sorted_other should be sortedOther (golint)
  • Line 24: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• gleam/util/grpc_util.go
  • Line 31: warning: exported function GleamGrpcDial should have comment or be unexported (golint)
  • Line 39: warning: exported function ParseServerToGrpcAddress should have comment or be unexported (golint)

• gleam/sql/executor/executor_limit.go
  • Line 8: warning: exported type LimitExec should have comment or be unexported (golint)
  • Line 20: warning: comment on exported method LimitExec.Exec should be of the form "Exec ..." (golint)

• gleam/util/message_read.go
  • Line 13: warning: exported type MessageControl should have comment or be unexported (golint)
  • Line 16: warning: exported const MessageControlEOF should have comment (or a comment on this block) or be unexported (golint)

• gleam/examples/orc/orc_reading.go
  • Line 7: warning: should not use dot imports (golint)

• gleam/plugins/cassandra/cassandra_source_builder.go
  • Line 7: warning: exported function Hosts should have comment or be unexported (golint)
  • Line 19: warning: exported method CassandraSource.Keyspace should have comment or be unexported (golint)
  • Line 24: warning: exported method CassandraSource.From should have comment or be unexported (golint)
  • Line 29: warning: exported method CassandraSource.Select should have comment or be unexported (golint)
  • Line 34: warning: exported method CassandraSource.Where should have comment or be unexported (golint)

• gleam/sql/expression/builtin_info.go
  • Line 47: warning: context.Context should be the first parameter of a function (golint)
  • Line 69: warning: context.Context should be the first parameter of a function (golint)
  • Line 82: warning: context.Context should be the first parameter of a function (golint)
  • Line 103: warning: context.Context should be the first parameter of a function (golint)
  • Line 117: warning: context.Context should be the first parameter of a function (golint)
  • Line 140: warning: context.Context should be the first parameter of a function (golint)
  • Line 154: warning: context.Context should be the first parameter of a function (golint)
  • Line 175: warning: context.Context should be the first parameter of a function (golint)
  • Line 189: warning: context.Context should be the first parameter of a function (golint)
  • Line 210: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/master/ui/svg_writer.go
  • Line 12: warning: exported var WidthStep should have comment or be unexported (golint)
  • Line 26: warning: exported function GenSvg should have comment or be unexported (golint)

• gleam/instruction/partition_scatter.go
  • Line 21: warning: exported type ScatterPartitions should have comment or be unexported (golint)
  • Line 25: warning: exported function NewScatterPartitions should have comment or be unexported (golint)
  • Line 29: warning: exported method ScatterPartitions.Name should have comment or be unexported (golint)
  • Line 33: warning: exported method ScatterPartitions.Function should have comment or be unexported (golint)
  • Line 39: warning: exported method ScatterPartitions.SerializeToCommand should have comment or be unexported (golint)
  • Line 47: warning: exported method ScatterPartitions.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 51: warning: exported function DoScatterPartitions should have comment or be unexported (golint)

• gleam/util/row_util.go
  • Line 7: warning: exported function Now should have comment or be unexported (golint)

• gleam/sql/executor/register_tables.go
  • Line 8: warning: exported type TableColumn should have comment or be unexported (golint)
  • Line 13: warning: exported type TableSource should have comment or be unexported (golint)
  • Line 19: warning: exported var Tables should have comment or be unexported (golint)

• gleam/flow/runner.go
  • Line 15: warning: exported type FlowRunner should have comment or be unexported (golint)
  • Line 19: warning: exported type FlowOption should have comment or be unexported (golint)
  • Line 28: warning: exported var Local should have comment or be unexported (golint)

• gleam/util/priority_queue.go
  • Line 23: warning: exported function NewPriorityQueue should have comment or be unexported (golint)
  • Line 31: warning: exported method PriorityQueue.Enqueue should have comment or be unexported (golint)
  • Line 35: warning: exported method PriorityQueue.Dequeue should have comment or be unexported (golint)
  • Line 40: warning: exported method PriorityQueue.Top should have comment or be unexported (golint)
  • Line 64: warning: exported method PriorityQueue.Push should have comment or be unexported (golint)
  • Line 73: warning: exported method PriorityQueue.Pop should have comment or be unexported (golint)

• gleam/filesystem/vfs.go
  • Line 10: warning: exported type OptionName should have comment or be unexported (golint)
  • Line 13: warning: exported var Option should have comment or be unexported (golint)
  • Line 16: warning: exported type FileLocation should have comment or be unexported (golint)
  • Line 20: warning: exported type VirtualFile should have comment or be unexported (golint)
  • Line 27: warning: exported type VirtualFileSystem should have comment or be unexported (golint)
  • Line 43: warning: exported function Set should have comment or be unexported (golint)
  • Line 47: warning: exported function Open should have comment or be unexported (golint)
  • Line 57: warning: exported function List should have comment or be unexported (golint)
  • Line 67: warning: exported function IsDir should have comment or be unexported (golint)

• gleam/flow/dataset_group.go
  • Line 18: warning: exported method Dataset.LocalGroupBy should have comment or be unexported (golint)

• gleam/sql/expression/builtin.go
  • Line 36: warning: context.Context should be the first parameter of a function (golint)

• gleam/sql/plan/refiner.go
  • Line 261: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/driver/scheduler/shard_location.go
  • Line 11: warning: exported type DatasetShardLocator should have comment or be unexported (golint)
  • Line 18: warning: exported function NewDatasetShardLocator should have comment or be unexported (golint)
  • Line 26: warning: exported method DatasetShardLocator.GetShardLocation should have comment or be unexported (golint)
  • Line 34: warning: exported method DatasetShardLocator.SetShardLocation should have comment or be unexported (golint)

• gleam/examples/tfidf/tfidf.go
  • Line 40: warning: don't use underscores in Go names; var word_doc_one should be wordDocOne (golint)

• gleam/instruction/broadcast.go
  • Line 19: warning: exported type Broadcast should have comment or be unexported (golint)
  • Line 22: warning: exported function NewBroadcast should have comment or be unexported (golint)
  • Line 26: warning: exported method Broadcast.Name should have comment or be unexported (golint)
  • Line 30: warning: exported method Broadcast.Function should have comment or be unexported (golint)
  • Line 36: warning: exported method Broadcast.SerializeToCommand should have comment or be unexported (golint)
  • Line 42: warning: exported method Broadcast.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 46: warning: exported function DoBroadcast should have comment or be unexported (golint)

• gleam/util/http_handler.go
  • Line 10: warning: exported function Error should have comment or be unexported (golint)
  • Line 16: warning: exported function Json should have comment or be unexported (golint)

• gleam/util/key.go
  • Line 9: warning: exported function HashByKeys should have comment or be unexported (golint)
  • Line 51: warning: exported function PartitionByKeys should have comment or be unexported (golint)
  • Line 55: warning: exported function LessThan should have comment or be unexported (golint)
  • Line 59: warning: exported function Compare should have comment or be unexported (golint)

• gleam/plugins/file/tsv/tsv_file_reader.go
  • Line 11: warning: exported type TsvFileReader should have comment or be unexported (golint)
  • Line 15: warning: exported function New should have comment or be unexported (golint)
  • Line 21: warning: exported method TsvFileReader.ReadHeader should have comment or be unexported (golint)

• gleam/flow/runner_on_interrupt.go
  • Line 7: warning: exported method Flow.OnInterrupt should have comment or be unexported (golint)

• gleam/instruction/merge_sorted_to.go
  • Line 22: warning: exported type MergeSortedTo should have comment or be unexported (golint)
  • Line 26: warning: exported function NewMergeSortedTo should have comment or be unexported (golint)
  • Line 30: warning: exported method MergeSortedTo.Name should have comment or be unexported (golint)
  • Line 34: warning: exported method MergeSortedTo.Function should have comment or be unexported (golint)
  • Line 40: warning: exported method MergeSortedTo.SerializeToCommand should have comment or be unexported (golint)
  • Line 48: warning: exported method MergeSortedTo.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 69: warning: exported function DoMergeSortedTo should have comment or be unexported (golint)

• gleam/instruction/select.go
  • Line 24: warning: exported type Select should have comment or be unexported (golint)
  • Line 29: warning: exported function NewSelect should have comment or be unexported (golint)
  • Line 33: warning: exported method Select.Name should have comment or be unexported (golint)
  • Line 37: warning: exported method Select.Function should have comment or be unexported (golint)
  • Line 43: warning: exported method Select.SerializeToCommand should have comment or be unexported (golint)
  • Line 52: warning: exported method Select.GetMemoryCostInMB should have comment or be unexported (golint)

• gleam/plugins/kafka/kafka_partition_info.go
  • Line 13: warning: exported type KafkaPartitionInfo should have comment or be unexported (golint)
  • Line 22: warning: exported var MapperReadShard should have comment or be unexported (golint)
  • Line 34: warning: exported method KafkaPartitionInfo.ReadSplit should have comment or be unexported (golint)

• gleam/pb/resource_proto_helper.go
  • Line 7: warning: exported method Location.URL should have comment or be unexported (golint)
  • Line 11: warning: comment on exported method Location.Distance should be of the form "Distance ..." (golint)
  • Line 12: warning: receiver name a should be consistent with previous receiver name l for Location (golint)
  • Line 25: warning: exported method ComputeResource.Minus should have comment or be unexported (golint)
  • Line 36: warning: exported method ComputeResource.Plus should have comment or be unexported (golint)
  • Line 47: warning: exported method ComputeResource.GreaterThanZero should have comment or be unexported (golint)
  • Line 51: warning: exported method ComputeResource.IsZero should have comment or be unexported (golint)
  • Line 55: warning: exported method ComputeResource.Covers should have comment or be unexported (golint)

• gleam/plugins/file/file_shard_info.go
  • Line 15: warning: exported type FileShardInfo should have comment or be unexported (golint)
  • Line 36: warning: exported method FileShardInfo.ReadSplit should have comment or be unexported (golint)

• gleam/flow/dataset_reduce.go
  • Line 19: warning: exported method Dataset.ReduceBy should have comment or be unexported (golint)
  • Line 44: warning: exported method Dataset.LocalReduceBy should have comment or be unexported (golint)

• gleam/instruction/roud_robin.go
  • Line 22: warning: exported type RoundRobin should have comment or be unexported (golint)
  • Line 25: warning: exported function NewRoundRobin should have comment or be unexported (golint)
  • Line 29: warning: exported method RoundRobin.Name should have comment or be unexported (golint)
  • Line 33: warning: exported method RoundRobin.Function should have comment or be unexported (golint)
  • Line 39: warning: exported method RoundRobin.SerializeToCommand should have comment or be unexported (golint)
  • Line 45: warning: exported method RoundRobin.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 49: warning: exported function DoRoundRobin should have comment or be unexported (golint)

• gleam/sql/expression/column.go
  • Line 40: warning: context.Context should be the first parameter of a function (golint)
  • Line 45: warning: context.Context should be the first parameter of a function (golint)
  • Line 91: warning: context.Context should be the first parameter of a function (golint)
  • Line 122: warning: context.Context should be the first parameter of a function (golint)

• gleam/sql/infoschema/infoschema.go
  • Line 20: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
  • Line 86: warning: exported function NewInfoSchema should have comment or be unexported (golint)

• gleam/distributed/agent/local_dataset_shards_manager_in_memory.go
  • Line 60: warning: exported type LocalDatasetShardsManagerInMemory should have comment or be unexported (golint)
  • Line 66: warning: exported function NewLocalDatasetShardsManagerInMemory should have comment or be unexported (golint)
  • Line 81: warning: exported method LocalDatasetShardsManagerInMemory.CreateNamedDatasetShard should have comment or be unexported (golint)
  • Line 100: warning: exported method LocalDatasetShardsManagerInMemory.WaitForNamedDatasetShard should have comment or be unexported (golint)
  • Line 120: warning: exported method LocalDatasetShardsManagerInMemory.Cleanup should have comment or be unexported (golint)

• gleam/distributed/master/structure.go
  • Line 10: warning: exported type AgentInformation should have comment or be unexported (golint)
  • Line 17: warning: exported type Rack should have comment or be unexported (golint)
  • Line 25: warning: exported type DataCenter should have comment or be unexported (golint)
  • Line 33: warning: exported type Topology should have comment or be unexported (golint)
  • Line 40: warning: exported function NewTopology should have comment or be unexported (golint)
  • Line 46: warning: exported function NewDataCenter should have comment or be unexported (golint)
  • Line 53: warning: exported function NewRack should have comment or be unexported (golint)
  • Line 60: warning: exported method Topology.GetDataCenter should have comment or be unexported (golint)
  • Line 68: warning: exported method DataCenter.GetRack should have comment or be unexported (golint)
  • Line 76: warning: exported method Rack.GetAgent should have comment or be unexported (golint)
  • Line 84: warning: exported method Topology.AddDataCenter should have comment or be unexported (golint)
  • Line 91: warning: exported method Topology.GetDataCenters should have comment or be unexported (golint)
  • Line 102: warning: exported method DataCenter.GetRacks should have comment or be unexported (golint)
  • Line 113: warning: exported method DataCenter.AddRack should have comment or be unexported (golint)
  • Line 120: warning: exported method Rack.AddAgent should have comment or be unexported (golint)
  • Line 127: warning: exported method Rack.DropAgent should have comment or be unexported (golint)
  • Line 134: warning: exported method Rack.GetAgents should have comment or be unexported (golint)

• gleam/flow/dataset_join.go
  • Line 14: warning: exported method Dataset.JoinByKey should have comment or be unexported (golint)
  • Line 18: warning: exported method Dataset.LeftOuterJoin should have comment or be unexported (golint)
  • Line 22: warning: exported method Dataset.LeftOuterJoinByKey should have comment or be unexported (golint)
  • Line 26: warning: exported method Dataset.RightOuterJoin should have comment or be unexported (golint)
  • Line 30: warning: exported method Dataset.RightOuterJoinByKey should have comment or be unexported (golint)
  • Line 34: warning: exported method Dataset.DoJoin should have comment or be unexported (golint)
  • Line 35: warning: don't use underscores in Go names; var sorted_d should be sortedD (golint)
  • Line 36: warning: don't use underscores in Go names; var sorted_other should be sortedOther (golint)
  • Line 46: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• gleam/flow/dataset_output.go
  • Line 95: warning: exported method Dataset.OutputRow should have comment or be unexported (golint)

• gleam/instruction/instruction.go
  • Line 10: warning: exported var InstructionRunner should have comment or be unexported (golint)
  • Line 13: warning: exported type Order should have comment or be unexported (golint)
  • Line 16: warning: exported const Ascending should have comment (or a comment on this block) or be unexported (golint)
  • Line 21: warning: exported type OrderBy should have comment or be unexported (golint)
  • Line 26: warning: exported type Instruction should have comment or be unexported (golint)

• gleam/sql/expression/builtin_op.go
  • Line 47: warning: context.Context should be the first parameter of a function (golint)
  • Line 63: warning: context.Context should be the first parameter of a function (golint)
  • Line 99: warning: context.Context should be the first parameter of a function (golint)
  • Line 115: warning: context.Context should be the first parameter of a function (golint)
  • Line 151: warning: context.Context should be the first parameter of a function (golint)
  • Line 167: warning: context.Context should be the first parameter of a function (golint)
  • Line 197: warning: context.Context should be the first parameter of a function (golint)
  • Line 261: warning: context.Context should be the first parameter of a function (golint)
  • Line 302: warning: context.Context should be the first parameter of a function (golint)
  • Line 418: warning: context.Context should be the first parameter of a function (golint)
  • Line 435: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/type_convertion.go
  • Line 3: warning: exported function ToInt64 should have comment or be unexported (golint)
  • Line 40: warning: exported function ToFloat64 should have comment or be unexported (golint)
  • Line 50: warning: exported function ToString should have comment or be unexported (golint)
  • Line 60: warning: exported function ToBytes should have comment or be unexported (golint)

• gleam/plugins/kafka/kafka_source.go
  • Line 15: warning: exported type KafkaSource should have comment or be unexported (golint)

• gleam/distributed/executor/executor_grpc_server.go
  • Line 18: warning: comment on exported method Executor.CollectExecutionStatistics should be of the form "CollectExecutionStatistics ..." (golint)

• gleam/distributed/agent/local_dataset_shards_manager.go
  • Line 11: warning: exported type LocalDatasetShardsManager should have comment or be unexported (golint)
  • Line 19: warning: exported function NewLocalDatasetShardsManager should have comment or be unexported (golint)
  • Line 43: warning: exported method LocalDatasetShardsManager.DeleteNamedDatasetShard should have comment or be unexported (golint)
  • Line 56: warning: exported method LocalDatasetShardsManager.CreateNamedDatasetShard should have comment or be unexported (golint)
  • Line 76: warning: exported method LocalDatasetShardsManager.WaitForNamedDatasetShard should have comment or be unexported (golint)

• gleam/plugins/file/orc/orc_file_reader.go
  • Line 10: warning: exported type OrcFileReader should have comment or be unexported (golint)
  • Line 16: warning: comment on exported function New should be of the form "New ..." (golint)
  • Line 27: warning: exported method OrcFileReader.Select should have comment or be unexported (golint)
  • Line 34: warning: exported method OrcFileReader.ReadHeader should have comment or be unexported (golint)

• gleam/plugins/file/file_source.go
  • Line 17: warning: exported type FileSource should have comment or be unexported (golint)
  • Line 38: warning: receiver name q should be consistent with previous receiver name s for FileSource (golint)
  • Line 43: warning: comment on exported method FileSource.Select should be of the form "Select ..." (golint)
  • Line 45: warning: receiver name q should be consistent with previous receiver name s for FileSource (golint)

• gleam/flow/step.go
  • Line 14: warning: exported method Flow.NewStep should have comment or be unexported (golint)
  • Line 24: warning: exported method Step.NewTask should have comment or be unexported (golint)
  • Line 30: warning: exported method Step.SetInstruction should have comment or be unexported (golint)
  • Line 36: warning: exported method Step.RunFunction should have comment or be unexported (golint)
  • Line 69: warning: exported method Step.GetScriptCommand should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/scheduler_score.go
  • Line 9: warning: exported method Scheduler.Score should have comment or be unexported (golint)

• gleam/distributed/master/resource_collect.go
  • Line 9: warning: exported method Topology.UpdateAgentInformation should have comment or be unexported (golint)

• gleam/flow/dataset_hint.go
  • Line 3: warning: exported type DasetsetHint should have comment or be unexported (golint)

• gleam/sql/plan/plan.go
  • Line 121: warning: context.Context should be the first parameter of a function (golint)

• gleam/distributed/master/ui/functions.go
  • Line 15: warning: exported function Duration should have comment or be unexported (golint)
  • Line 23: warning: exported function Unix should have comment or be unexported (golint)

• gleam/sql/flow_query.go
  • Line 15: warning: exported function RegisterTable should have comment or be unexported (golint)
  • Line 41: warning: exported function Query should have comment or be unexported (golint)

• gleam/sql/executor/executor_tablescan.go
  • Line 13: warning: exported type SelectTableExec should have comment or be unexported (golint)
  • Line 50: warning: comment on exported method SelectTableExec.Exec should be of the form "Exec ..." (golint)

• gleam/gio/reducer/simple_reducer.go
  • Line 8: warning: exported var SumInt64 should have comment or be unexported (golint)

• gleam/plugins/file/csv/csv_file_reader.go
  • Line 9: warning: exported type CsvFileReader should have comment or be unexported (golint)
  • Line 13: warning: exported function New should have comment or be unexported (golint)
  • Line 19: warning: exported method CsvFileReader.ReadHeader should have comment or be unexported (golint)

• gleam/flow/dataset.go
  • Line 19: warning: exported method Dataset.GetShards should have comment or be unexported (golint)
  • Line 28: warning: comment on exported method Dataset.RunContext should be of the form "RunContext ..." (golint)
  • Line 33: warning: exported method DatasetShard.Closed should have comment or be unexported (golint)
  • Line 37: warning: exported method DatasetShard.TimeTaken should have comment or be unexported (golint)
  • Line 44: warning: exported method DatasetShard.Name should have comment or be unexported (golint)

• gleam/flow/dataset_union.go
  • Line 8: warning: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (golint)

• gleam/distributed/plan/plan.go
  • Line 13: warning: exported type TaskGroup should have comment or be unexported (golint)
  • Line 25: warning: exported type StepGroup should have comment or be unexported (golint)
  • Line 33: warning: exported function GroupTasks should have comment or be unexported (golint)
  • Line 38: warning: exported function NewStepGroup should have comment or be unexported (golint)
  • Line 44: warning: exported method StepGroup.AddStep should have comment or be unexported (golint)
  • Line 49: warning: exported method StepGroup.AddParent should have comment or be unexported (golint)
  • Line 54: warning: exported function NewTaskGroup should have comment or be unexported (golint)
  • Line 58: warning: exported method TaskGroup.AddTask should have comment or be unexported (golint)
  • Line 63: warning: exported method TaskGroup.AddParent should have comment or be unexported (golint)
  • Line 76: warning: exported method TaskGroup.RequiredResources should have comment or be unexported (golint)
  • Line 95: warning: exported method TaskGroup.MarkStop should have comment or be unexported (golint)
  • Line 101: warning: exported method StepGroup.WaitForAllTasksToComplete should have comment or be unexported (golint)

• gleam/util/hash.go
  • Line 7: warning: exported function Hash should have comment or be unexported (golint)

• gleam/util/message_write.go
  • Line 9: warning: exported function WriteEOFMessage should have comment or be unexported (golint)
  • Line 16: warning: exported function WriteMessage should have comment or be unexported (golint)
  • Line 26: warning: exported type BufferedMessageWriter should have comment or be unexported (golint)
  • Line 33: warning: exported function NewBufferedMessageWriter should have comment or be unexported (golint)
  • Line 40: warning: exported method BufferedMessageWriter.Available should have comment or be unexported (golint)
  • Line 41: warning: exported method BufferedMessageWriter.Buffered should have comment or be unexported (golint)
  • Line 43: warning: exported method BufferedMessageWriter.WriteMessage should have comment or be unexported (golint)
  • Line 61: warning: exported method BufferedMessageWriter.Flush should have comment or be unexported (golint)

• gleam/distributed/store/single_file_store.go
  • Line 10: warning: exported type SingleFileStore should have comment or be unexported (golint)
  • Line 28: warning: exported method SingleFileStore.ReadAt should have comment or be unexported (golint)
  • Line 126: warning: exported method SingleFileStore.Destroy should have comment or be unexported (golint)

• gleam/distributed/driver/scheduler/market/cda_market.go
  • Line 23: warning: exported type Object should have comment or be unexported (golint)
  • Line 25: warning: exported type Requirement should have comment or be unexported (golint)
  • Line 27: warning: exported type Demand should have comment or be unexported (golint)
  • Line 33: warning: exported type Supply should have comment or be unexported (golint)
  • Line 37: warning: exported type Market should have comment or be unexported (golint)
  • Line 46: warning: exported function NewMarket should have comment or be unexported (golint)
  • Line 52: warning: exported method Market.SetScoreFunction should have comment or be unexported (golint)
  • Line 57: warning: exported method Market.SetFetchFunction should have comment or be unexported (golint)
  • Line 62: warning: comment on exported method Market.AddDemand should be of the form "AddDemand ..." (golint)
  • Line 83: warning: exported method Market.FetcherLoop should have comment or be unexported (golint)
  • Line 100: warning: exported method Market.ReturnSupply should have comment or be unexported (golint)
  • Line 104: warning: exported method Market.AddSupply should have comment or be unexported (golint)

• gleam/util/on_interrupt/signal_handling_linux.go
  • Line 3: warning: don't use an underscore in package name (golint)
  • Line 11: warning: exported function OnInterrupt should have comment or be unexported (golint)

• gleam/sql/plan/expression_rewriter.go
  • Line 35: warning: context.Context should be the first parameter of a function (golint)

• gleam/util/exec_util.go
  • Line 13: warning: comment on exported function Execute should be of the form "Execute ..." (golint)

• gleam/examples/cassandra_reader/cassandra_reader.go
  • Line 18: warning: exported var LimitInEachShard should have comment or be unexported (golint)

• gleam/gio/emit.go
  • Line 21: warning: exported function TsEmitKV should have comment or be unexported (golint)

• gleam/instruction/local_sort.go
  • Line 25: warning: exported type LocalSort should have comment or be unexported (golint)
  • Line 30: warning: exported function NewLocalSort should have comment or be unexported (golint)
  • Line 34: warning: exported method LocalSort.Name should have comment or be unexported (golint)
  • Line 38: warning: exported method LocalSort.Function should have comment or be unexported (golint)
  • Line 44: warning: exported method LocalSort.SerializeToCommand should have comment or be unexported (golint)
  • Line 52: warning: exported method LocalSort.GetMemoryCostInMB should have comment or be unexported (golint)
  • Line 56: warning: exported function DoLocalSort should have comment or be unexported (golint)

• gleam/util/source_utils.go
  • Line 11: warning: exported function ListFiles should have comment or be unexported (golint)
  • Line 24: warning: exported function Range should have comment or be unexported (golint)

• gleam/examples/csv/csv_reading.go
  • Line 7: warning: should not use dot imports (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

• gleam/sql/util/types/time.go
  • Line 421: warning: ineffectual assignment to loc (ineffassign)

• gleam/sql/plan/logical_plan_builder.go
  • Line 609: warning: ineffectual assignment to index (ineffassign)
  • Line 730: warning: ineffectual assignment to index (ineffassign)

• gleam/distributed/master/ui/svg_writer_helper.go
  • Line 169: warning: ineffectual assignment to cx (ineffassign)
  • Line 169: warning: ineffectual assignment to cy (ineffassign)

• gleam/sql/expression/constant_propagation.go
  • Line 174: warning: ineffectual assignment to ok (ineffassign)

• gleam/sql/util/types/mytime.go
  • Line 296: warning: ineffectual assignment to neg (ineffassign)

• gleam/sql/plan/physical_plan_builder.go
  • Line 626: warning: ineffectual assignment to err (ineffassign)

• gleam/sql/plan/predicate_push_down.go
  • Line 108: warning: ineffectual assignment to equalCond (ineffassign)
  • Line 108: warning: ineffectual assignment to otherCond (ineffassign)

• gleam/util/printf.go
  • Line 59: warning: ineffectual assignment to written (ineffassign)

• gleam/sql/util/types/mydecimal.go
  • Line 1253: warning: ineffectual assignment to wordIdx (ineffassign)
  • Line 1673: warning: ineffectual assignment to idx2 (ineffassign)
  • Line 1674: warning: ineffectual assignment to idxTo (ineffassign)
  • Line 1699: warning: ineffectual assignment to wordsInt1 (ineffassign)
  • Line 1906: warning: ineffectual assignment to digitsIntTo (ineffassign)
  • Line 1918: warning: ineffectual assignment to stop1 (ineffassign)

• gleam/sql/plan/expression_rewriter.go
  • Line 455: warning: ineffectual assignment to err (ineffassign)

misspell97%

Misspell Finds commonly misspelled English words

• gleam/sql/expression/builtin_time.go
  • Line 1572: warning: "Unkonwn" is a misspelling of "Unknown" (misspell)

• gleam/sql/expression/helper.go
  • Line 144: warning: "varibale" is a misspelling of "variable" (misspell)

• gleam/sql/util/codec/codec.go
  • Line 98: warning: "comaprable" is a misspelling of "comparable" (misspell)
  • Line 99: warning: "comaprable" is a misspelling of "comparable" (misspell)

• gleam/sql/plan/expression_rewriter.go
  • Line 374: warning: "exmaple" is a misspelling of "example" (misspell)

• gleam/sql/util/types/errors.go
  • Line 24: warning: "convertion" is a misspelling of "conversion" (misspell)

• gleam/sql/util/types/overflow.go
  • Line 22: warning: "arthimetic" is a misspelling of "arithmetic" (misspell)

• gleam/distributed/driver/scheduler/scheduler_execute_task_group.go
  • Line 41: warning: "registed" is a misspelling of "registered" (misspell)

• gleam/distributed/master/ui/svg_writer_layout.go
  • Line 7: warning: "depencency" is a misspelling of "dependency" (misspell)