Preparing report...

Report for github.com/cloudworkz/kafka-minion

A+    Excellent!    Found 24 issues across 37 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint37%

Golint is a linter for Go source code.

    • kafka-minion/prometheus/exporter.go
    • Line 47: warning: exported function NewExporter should have comment or be unexported (golint)
    • Line 51: warning: exported method Exporter.InitializeMetrics should have comment or be unexported (golint)
    • Line 184: warning: exported method Exporter.Collect should have comment or be unexported (golint)
    • Line 190: warning: should not use basic type string as key in context.WithValue (golint)
    • kafka-minion/config.go
    • Line 19: warning: exported type Config should have comment or be unexported (golint)
    • Line 28: warning: exported method Config.SetDefaults should have comment or be unexported (golint)
    • Line 35: warning: exported method Config.Validate should have comment or be unexported (golint)
    • kafka-minion/kafka/config_tls.go
    • Line 13: warning: exported method TLSConfig.SetDefaults should have comment or be unexported (golint)
    • Line 17: warning: exported method TLSConfig.Validate should have comment or be unexported (golint)
    • kafka-minion/minion/config.go
    • Line 5: warning: exported type Config should have comment or be unexported (golint)
    • Line 11: warning: exported method Config.SetDefaults should have comment or be unexported (golint)
    • Line 17: warning: exported method Config.Validate should have comment or be unexported (golint)
    • kafka-minion/minion/log_dirs.go
    • Line 9: warning: exported type LogDirResponseShard should have comment or be unexported (golint)
    • Line 15: warning: exported method Service.DescribeLogDirs should have comment or be unexported (golint)
    • kafka-minion/minion/utils.go
    • Line 9: warning: exported method Service.IsGroupAllowed should have comment or be unexported (golint)
    • Line 27: warning: exported method Service.IsTopicAllowed should have comment or be unexported (golint)
    • kafka-minion/logging/config.go
    • Line 8: warning: exported type Config should have comment or be unexported (golint)
    • Line 12: warning: exported method Config.SetDefaults should have comment or be unexported (golint)
    • Line 16: warning: exported method Config.Validate should have comment or be unexported (golint)
    • kafka-minion/minion/metadata.go
    • Line 10: warning: exported method Service.GetMetadataCached should have comment or be unexported (golint)
    • Line 35: warning: exported method Service.GetMetadata should have comment or be unexported (golint)
    • kafka-minion/minion/versions.go
    • Line 11: warning: exported method Service.GetClusterVersion should have comment or be unexported (golint)
    • Line 21: warning: exported method Service.GetAPIVersions should have comment or be unexported (golint)
    • kafka-minion/minion/config_consumer_group.go
    • Line 8: warning: exported const ConsumerGroupScrapeModeOffsetsTopic should have comment (or a comment on this block) or be unexported (golint)
    • Line 15: warning: exported type ConsumerGroupConfig should have comment or be unexported (golint)
    • Line 36: warning: exported method ConsumerGroupConfig.SetDefaults should have comment or be unexported (golint)
    • Line 43: warning: exported method ConsumerGroupConfig.Validate should have comment or be unexported (golint)
    • kafka-minion/minion/service.go
    • Line 16: warning: exported type Service should have comment or be unexported (golint)
    • Line 34: warning: exported function NewService should have comment or be unexported (golint)
    • Line 64: warning: exported method Service.Start should have comment or be unexported (golint)
    • kafka-minion/kafka/config.go
    • Line 5: warning: exported type Config should have comment or be unexported (golint)
    • Line 15: warning: exported method Config.SetDefaults should have comment or be unexported (golint)
    • Line 22: warning: exported method Config.Validate should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign97%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!