Preparing report...

Report for github.com/cmattoon/aws-ssm

A+    Excellent!    Found 7 issues across 11 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint36%

Golint is a linter for Go source code.

    • aws-ssm/pkg/provider/aws.go
    • Line 1: warning: package comment should be of the form "Package provider ..." (golint)
    • Line 29: warning: exported type AWSProvider should have comment or be unexported (golint)
    • Line 36: warning: exported function NewAWSProvider should have comment or be unexported (golint)
    • Line 51: warning: exported method AWSProvider.GetParameterValue should have comment or be unexported (golint)
    • Line 72: warning: exported method AWSProvider.GetParameterDataByPath should have comment or be unexported (golint)
    • aws-ssm/pkg/provider/provider.go
    • Line 1: warning: package comment should be of the form "Package provider ..." (golint)
    • Line 24: warning: exported type Provider should have comment or be unexported (golint)
    • Line 29: warning: exported function NewProvider should have comment or be unexported (golint)
    • Line 34: warning: comment on exported type MockProvider should be of the form "MockProvider ..." (with optional leading article) (golint)
    • Line 41: warning: exported method MockProvider.GetParameterValue should have comment or be unexported (golint)
    • Line 53: warning: exported method MockProvider.GetParameterDataByPath should have comment or be unexported (golint)
    • aws-ssm/pkg/secret/secret.go
    • Line 1: warning: package comment should be of the form "Package secret ..." (golint)
    • Line 31: warning: exported type Secret should have comment or be unexported (golint)
    • Line 49: warning: exported function NewSecret should have comment or be unexported (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter secret_name should be secretName (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter secret_namespace should be secretNamespace (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter param_name should be paramName (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter param_type should be paramType (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter param_key should be paramKey (golint)
    • Line 88: warning: don't use underscores in Go names; var all_params should be allParams (golint)
    • Line 112: warning: don't use underscores in Go names; var param_name should be paramName (golint)
    • Line 113: warning: don't use underscores in Go names; var param_type should be paramType (golint)
    • Line 114: warning: don't use underscores in Go names; var param_key should be paramKey (golint)
    • Line 157: warning: exported method Secret.ParseStringList should have comment or be unexported (golint)
    • Line 182: warning: exported method Secret.Set should have comment or be unexported (golint)
    • Line 190: warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
    • Line 196: warning: exported method Secret.UpdateObject should have comment or be unexported (golint)
    • aws-ssm/pkg/controller/client.go
    • Line 1: warning: package comment should be of the form "Package controller ..." (golint)
    • Line 48: warning: comment on exported function NewKubeClient should be of the form "NewKubeClient ..." (golint)
    • Line 49: warning: don't use underscores in Go names; func parameter master_url should be masterURL (golint)
    • aws-ssm/pkg/controller/controller.go
    • Line 1: warning: package comment should be of the form "Package controller ..." (golint)
    • Line 29: warning: exported type Controller should have comment or be unexported (golint)
    • Line 35: warning: exported function NewController should have comment or be unexported (golint)
    • Line 55: warning: exported method Controller.HandleSecrets should have comment or be unexported (golint)
    • aws-ssm/pkg/config/config.go
    • Line 1: warning: package comment should be of the form "Package config ..." (golint)
    • Line 25: warning: exported var Version should have comment or be unexported (golint)
    • Line 27: warning: don't use underscores in Go names; func parameter default_value should be defaultValue (golint)
    • Line 35: warning: exported type Config should have comment or be unexported (golint)
    • Line 45: warning: exported function DefaultConfig should have comment or be unexported (golint)
    • Line 57: warning: exported method Config.ParseFlags should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!