gofmt89%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• plugins/netctl/cmdimpl/cmd_utils.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/contiv-init/main.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• mock/localclient/dsl/dsl.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/controller/telemetry/telemetry_controller.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/ipam/doc.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/contiv-init/doc.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/pkg/client/clientset/versioned/fake/register.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/datastore/vpp_data_store.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• mock/localclient/txn.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/policy/renderer/cache/cache_api.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/policy/configurator/configurator_api.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/service/plugin_impl_service.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/ipv4net/resync_events.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/service/processor/processor_impl.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/policy/renderer/cache/local_tables.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/contivconf/contivconf.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/controller/plugin_controller.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/cache/telemetry_cache.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/pkg/client/clientset/versioned/scheme/register.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/datastore/vpp_data_store_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/nodesync/nodesync_api.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/ipv4net/doc.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/cache/telemetrymodel/ctm.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/datastore/k8s_data_store.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/controller/dbwatcher.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/netctl/cmdimpl/pods.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• cmd/contiv-cni/doc.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/pkg/apis/nodeconfig/v1/zz_generated.deepcopy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/crd/pkg/apis/telemetry/v1/zz_generated.deepcopy.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• plugins/netctl/cmd/root.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• plugins/ksr/policy_reflector.go
  • Line 134: warning: cyclomatic complexity 18 of function (*PolicyReflector).policyToProto() is high (> 15) (gocyclo)

• cmd/contiv-stn/main.go
  • Line 354: warning: cyclomatic complexity 17 of function (*stnServer).checkLinkState() is high (> 15) (gocyclo)

• plugins/policy/renderer/acl/acl_renderer.go
  • Line 138: warning: cyclomatic complexity 16 of function (*RendererTxn).Commit() is high (> 15) (gocyclo)

• plugins/ipam/ipam.go
  • Line 127: warning: cyclomatic complexity 16 of function (*IPAM).Resync() is high (> 15) (gocyclo)

• plugins/policy/cache/data_change.go
  • Line 27: warning: cyclomatic complexity 28 of function (*PolicyCache).changePropagateEvent() is high (> 15) (gocyclo)

• plugins/policy/processor/matches_calculator.go
  • Line 14: warning: cyclomatic complexity 27 of function (*PolicyProcessor).calculateMatches() is high (> 15) (gocyclo)

• plugins/grpc/grpc_plugin.go
  • Line 232: warning: cyclomatic complexity 21 of function buildConfig() is high (> 15) (gocyclo)

• mock/sessionrules/sessionrules_mock.go
  • Line 231: warning: cyclomatic complexity 19 of function (*MockSessionRules).msgReplyHandler() is high (> 15) (gocyclo)
  • Line 137: warning: cyclomatic complexity 18 of function (*MockSessionRules).hasRule() is high (> 15) (gocyclo)

• plugins/ksr/sfc_pod_reflector.go
  • Line 119: warning: cyclomatic complexity 17 of function (*SfcPodReflector).updatePod() is high (> 15) (gocyclo)

• plugins/contivconf/contivconf.go
  • Line 275: warning: cyclomatic complexity 33 of function (*ContivConf).Init() is high (> 15) (gocyclo)
  • Line 666: warning: cyclomatic complexity 31 of function (*ContivConf).reloadNodeInterfaces() is high (> 15) (gocyclo)

• mock/natplugin/natplugin_mock.go
  • Line 87: warning: cyclomatic complexity 32 of function (*MockNatPlugin).ApplyTxn() is high (> 15) (gocyclo)
  • Line 313: warning: cyclomatic complexity 20 of function (*MockNatPlugin).dnatToStaticMappings() is high (> 15) (gocyclo)
  • Line 250: warning: cyclomatic complexity 17 of function (*MockNatPlugin).putGlobalConfig() is high (> 15) (gocyclo)

• plugins/crd/validator/l2/l2_validator.go
  • Line 149: warning: cyclomatic complexity 28 of function (*Validator).ValidateBridgeDomains() is high (> 15) (gocyclo)
  • Line 354: warning: cyclomatic complexity 23 of function (*Validator).ValidateL2FibEntries() is high (> 15) (gocyclo)
  • Line 574: warning: cyclomatic complexity 19 of function (*Validator).ValidatePodInfo() is high (> 15) (gocyclo)

• plugins/policy/renderer/vpptcp/vpptcp_renderer.go
  • Line 102: warning: cyclomatic complexity 19 of function (*RendererTxn).Commit() is high (> 15) (gocyclo)

• plugins/crd/validator/l3/l3_validator_test.go
  • Line 197: warning: cyclomatic complexity 17 of function testValidateRoutesToLocalPods() is high (> 15) (gocyclo)

• plugins/policy/renderer/cache/cache_impl.go
  • Line 267: warning: cyclomatic complexity 16 of function (*RendererCacheTxn).Commit() is high (> 15) (gocyclo)

• plugins/policy/configurator/configurator_impl.go
  • Line 264: warning: cyclomatic complexity 35 of function (*PolicyConfiguratorTxn).generateRules() is high (> 15) (gocyclo)
  • Line 145: warning: cyclomatic complexity 19 of function (*PolicyConfiguratorTxn).Commit() is high (> 15) (gocyclo)

• plugins/policy/cache/match_expression.go
  • Line 144: warning: cyclomatic complexity 29 of function (*PolicyCache).getPodsByNsMatchExpression() is high (> 15) (gocyclo)
  • Line 33: warning: cyclomatic complexity 26 of function (*PolicyCache).getMatchExpressionPodsInsideNs() is high (> 15) (gocyclo)

• plugins/crd/testdata/create_test_data.go
  • Line 38: warning: cyclomatic complexity 19 of function CreateNodeTestData() is high (> 15) (gocyclo)

• plugins/ksr/ksr_statscollector.go
  • Line 144: warning: cyclomatic complexity 19 of function (*StatsCollector).updatePrometheusStats() is high (> 15) (gocyclo)

• plugins/policy/renderer/vpptcp/rule/session_rule.go
  • Line 263: warning: cyclomatic complexity 21 of function convertContivRule() is high (> 15) (gocyclo)
  • Line 365: warning: cyclomatic complexity 18 of function ImportSessionRules() is high (> 15) (gocyclo)

• plugins/policy/processor/processor.go
  • Line 378: warning: cyclomatic complexity 18 of function (*PolicyProcessor).getPoliciesReferencingPod() is high (> 15) (gocyclo)

• plugins/crd/validator/l2/l2_validator_test.go
  • Line 638: warning: cyclomatic complexity 16 of function testValidatePodInfo() is high (> 15) (gocyclo)

• plugins/controller/plugin_controller.go
  • Line 555: warning: cyclomatic complexity 81 of function (*Controller).processEvent() is high (> 15) (gocyclo)
  • Line 428: warning: cyclomatic complexity 17 of function (*Controller).eventLoop() is high (> 15) (gocyclo)

• plugins/service/processor/processor_impl.go
  • Line 280: warning: cyclomatic complexity 25 of function (*ServiceProcessor).renderService() is high (> 15) (gocyclo)
  • Line 412: warning: cyclomatic complexity 16 of function (*ServiceProcessor).processResyncEvent() is high (> 15) (gocyclo)

• plugins/service/renderer/nat44/nat44_renderer.go
  • Line 577: warning: cyclomatic complexity 24 of function (*Renderer).idleNATSessionCleanup() is high (> 15) (gocyclo)
  • Line 437: warning: cyclomatic complexity 22 of function (*Renderer).exportServiceIPMappings() is high (> 15) (gocyclo)

• mock/aclengine/aclengine_mock.go
  • Line 503: warning: cyclomatic complexity 39 of function (*MockACLEngine).evalACL() is high (> 15) (gocyclo)
  • Line 424: warning: cyclomatic complexity 16 of function (*MockACLEngine).testConnection() is high (> 15) (gocyclo)
  • Line 151: warning: cyclomatic complexity 16 of function (*MockACLEngine).ApplyTxn() is high (> 15) (gocyclo)

• plugins/service/processor/service.go
  • Line 80: warning: cyclomatic complexity 26 of function (*Service).Refresh() is high (> 15) (gocyclo)

• cmd/contiv-cni/contiv_cni.go
  • Line 122: warning: cyclomatic complexity 19 of function cmdAdd() is high (> 15) (gocyclo)

• cmd/contiv-init/main.go
  • Line 278: warning: cyclomatic complexity 17 of function main() is high (> 15) (gocyclo)

• plugins/nodesync/nodesync.go
  • Line 407: warning: cyclomatic complexity 16 of function (*NodeSync).Update() is high (> 15) (gocyclo)

• plugins/controller/dbwatcher.go
  • Line 404: warning: cyclomatic complexity 26 of function (*dbWatcher).processChange() is high (> 15) (gocyclo)

• plugins/statscollector/plugin_impl_statscollector.go
  • Line 317: warning: cyclomatic complexity 25 of function (*Plugin).updatePrometheusStats() is high (> 15) (gocyclo)

• plugins/controller/rest.go
  • Line 68: warning: cyclomatic complexity 24 of function (*Controller).eventHistoryGetHandler() is high (> 15) (gocyclo)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell99%

Misspell Finds commonly misspelled English words

• plugins/ipv4net/ipv4net.go
  • Line 136: warning: "usefull" is a misspelling of "useful" (misspell)