Preparing report...

Report for github.com/cpu/acmeshell

A+    Excellent!    Found 35 issues across 55 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint41%

Golint is a linter for Go source code.

    • acmeshell/net/acme.go
    • Line 21: warning: exported type ACMENet should have comment or be unexported (golint)
    • Line 25: warning: exported function New should have comment or be unexported (golint)
    • Line 103: warning: exported method ACMENet.HeadURL should have comment or be unexported (golint)
    • Line 107: warning: comment on exported method ACMENet.PostRequest should be of the form "PostRequest ..." (golint)
    • Line 118: warning: comment on exported method ACMENet.PostURL should be of the form "PostURL ..." (golint)
    • Line 129: warning: comment on exported method ACMENet.GetRequest should be of the form "GetRequest ..." (golint)
    • Line 135: warning: comment on exported method ACMENet.GetURL should be of the form "GetURL ..." (golint)
    • acmeshell/shell/commands/pick.go
    • Line 12: warning: exported function PickOrderURL should have comment or be unexported (golint)
    • Line 28: warning: exported function PickOrder should have comment or be unexported (golint)
    • Line 45: warning: exported function PickAuthzURL should have comment or be unexported (golint)
    • Line 54: warning: exported function PickAuthz should have comment or be unexported (golint)
    • Line 85: warning: exported function PickChall should have comment or be unexported (golint)
    • acmeshell/acme/client/resources.go
    • Line 97: warning: exported method Client.Rollover should have comment or be unexported (golint)
    • Line 323: warning: exported method Client.OrderByIndex should have comment or be unexported (golint)
    • Line 343: warning: exported method Client.AuthzByIdentifier should have comment or be unexported (golint)
    • acmeshell/shell/commands/command.go
    • Line 19: warning: comment on exported const BasePrompt should be of the form "BasePrompt ..." (golint)
    • Line 21: warning: comment on exported const ClientKey should be of the form "ClientKey ..." (golint)
    • Line 23: warning: comment on exported const ChallSrvKey should be of the form "ChallSrvKey ..." (golint)
    • Line 28: warning: exported function OkURL should have comment or be unexported (golint)
    • Line 79: warning: exported function ReadJSON should have comment or be unexported (golint)
    • Line 87: warning: exported function PrintJSON should have comment or be unexported (golint)
    • Line 102: warning: exported type NewCommandAutocompleter should have comment or be unexported (golint)
    • Line 104: warning: exported function AddCommands should have comment or be unexported (golint)
    • Line 113: warning: exported function RegisterCommand should have comment or be unexported (golint)
    • Line 146: warning: exported function DirectoryAutocompleter should have comment or be unexported (golint)
    • Line 163: warning: exported function FindOrderURL should have comment or be unexported (golint)
    • Line 192: warning: exported function FindAuthzURL should have comment or be unexported (golint)
    • Line 218: warning: exported function FindChallengeURL should have comment or be unexported (golint)
    • Line 241: warning: exported function FindURL should have comment or be unexported (golint)
    • acmeshell/shell/commands/templating.go
    • Line 17: warning: exported type TemplateCtx should have comment or be unexported (golint)
    • Line 149: warning: exported function EvalTemplate should have comment or be unexported (golint)
    • Line 178: warning: exported function ClientTemplate should have comment or be unexported (golint)
    • acmeshell/acme/keys/keys.go
    • Line 1: warning: package comment should be of the form "Package keys ..." (golint)
    • Line 40: warning: exported function JWKJSON should have comment or be unexported (golint)
    • Line 49: warning: exported function JWKThumbprintBytes should have comment or be unexported (golint)
    • Line 55: warning: exported function JWKThumbprint should have comment or be unexported (golint)
    • Line 60: warning: exported function KeyAuth should have comment or be unexported (golint)
    • Line 64: warning: exported function JWKForSigner should have comment or be unexported (golint)
    • Line 71: warning: exported function SigningKeyForSigner should have comment or be unexported (golint)
    • Line 83: warning: exported function MarshalSigner should have comment or be unexported (golint)
    • Line 103: warning: exported function UnmarshalSigner should have comment or be unexported (golint)
    • Line 120: warning: exported function SignerToPEM should have comment or be unexported (golint)
    • Line 144: warning: exported function NewSigner should have comment or be unexported (golint)
    • acmeshell/acme/client/http.go
    • Line 24: warning: exported method Client.GetURL should have comment or be unexported (golint)
    • Line 32: warning: exported method Client.PostURL should have comment or be unexported (golint)
    • Line 40: warning: exported method Client.PostAsGetURL should have comment or be unexported (golint)
    • acmeshell/acme/constants.go
    • Line 8: warning: comment on exported const NEW_NONCE_ENDPOINT should be of the form "NEW_NONCE_ENDPOINT ..." (golint)
    • Line 10: warning: comment on exported const NEW_ACCOUNT_ENDPOINT should be of the form "NEW_ACCOUNT_ENDPOINT ..." (golint)
    • Line 12: warning: comment on exported const NEW_ORDER_ENDPOINT should be of the form "NEW_ORDER_ENDPOINT ..." (golint)
    • Line 15: warning: comment on exported const REPLAY_NONCE_HEADER should be of the form "REPLAY_NONCE_HEADER ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!