Report for github.com/dash-app/dash-home
A+ Excellent! Found 15 issues across 25 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo92%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
dash-home/internal/logger/gin.go
- Line 26: warning: cyclomatic complexity 16 of function SetLogger() is high (> 15) (gocyclo)
-
-
dash-home/pkg/controller/storage.go
- Line 182: warning: cyclomatic complexity 16 of function (*Storage).newEntry() is high (> 15) (gocyclo)
golint44%
Golint is a linter for Go source code.
-
-
dash-home/pkg/storage/agent.go
- Line 12: warning: exported const AGENT_FILE should have comment or be unexported (golint)
- Line 32: warning: exported function NewAgentStore should have comment or be unexported (golint)
- Line 57: warning: exported method AgentStore.Create should have comment or be unexported (golint)
- Line 74: warning: exported method AgentStore.Get should have comment or be unexported (golint)
-
-
dash-home/pkg/agent/agent.go
- Line 181: warning: exported method AgentService.GetAmbient should have comment or be unexported (golint)
-
-
dash-home/pkg/remote/remote.go
- Line 10: warning: exported type Remote should have comment or be unexported (golint)
- Line 17: warning: exported type ProvidedRemote should have comment or be unexported (golint)
- Line 22: warning: exported function GetRemote should have comment or be unexported (golint)
-
-
dash-home/pkg/server/remotes.go
- Line 9: warning: exported type GetRemotesResponse should have comment or be unexported (golint)
-
-
dash-home/pkg/agent/remote.go
- Line 17: warning: exported type IRCode should have comment or be unexported (golint)
- Line 21: warning: exported type Payload should have comment or be unexported (golint)
- Line 26: warning: exported method AgentService.SendIR should have comment or be unexported (golint)
-
-
dash-home/pkg/status/status.go
- Line 3: warning: exported type Error should have comment or be unexported (golint)
-
-
dash-home/pkg/storage/storage.go
- Line 11: warning: exported type Storage should have comment or be unexported (golint)
- Line 18: warning: exported type Adapter should have comment or be unexported (golint)
- Line 23: warning: exported function New should have comment or be unexported (golint)
- Line 44: warning: exported function Load should have comment or be unexported (golint)
- Line 55: warning: exported function Save should have comment or be unexported (golint)
-
-
dash-home/pkg/controller/controller.go
- Line 16: warning: exported type Controller should have comment or be unexported (golint)
- Line 22: warning: exported function New should have comment or be unexported (golint)
- Line 40: warning: exported method Controller.RaiseSwitchBot should have comment or be unexported (golint)
- Line 79: warning: exported method Controller.PushAircon should have comment or be unexported (golint)
- Line 144: warning: exported method Controller.PushLight should have comment or be unexported (golint)
-
-
dash-home/pkg/controller/storage.go
- Line 18: warning: exported type Storage should have comment or be unexported (golint)
- Line 25: warning: exported type Entry should have comment or be unexported (golint)
- Line 54: warning: exported type Options should have comment or be unexported (golint)
- Line 65: warning: exported function NewStorage should have comment or be unexported (golint)
- Line 84: warning: exported method Storage.Load should have comment or be unexported (golint)
- Line 88: warning: exported method Storage.Save should have comment or be unexported (golint)
- Line 107: warning: exported method Storage.GetByID should have comment or be unexported (golint)
-
-
dash-home/pkg/agent/storage.go
- Line 13: warning: exported type Storage should have comment or be unexported (golint)
- Line 19: warning: exported function NewStorage should have comment or be unexported (golint)
- Line 41: warning: exported method Storage.Add should have comment or be unexported (golint)
-
-
dash-home/pkg/agent/switchbot.go
- Line 15: warning: exported type SwitchBot should have comment or be unexported (golint)
- Line 26: warning: exported method AgentService.PostSwitch should have comment or be unexported (golint)
-
-
dash-home/pkg/room/room.go
- Line 5: warning: exported type RoomService should have comment or be unexported (golint)
- Line 10: warning: exported type Room should have comment or be unexported (golint)
- Line 21: warning: exported function New should have comment or be unexported (golint)
- Line 33: warning: exported method RoomService.Get should have comment or be unexported (golint)
-
-
dash-home/pkg/room/storage.go
- Line 27: warning: exported function NewStorage should have comment or be unexported (golint)
- Line 49: warning: exported method Storage.Create should have comment or be unexported (golint)
- Line 65: warning: exported method Storage.Get should have comment or be unexported (golint)
- Line 73: warning: exported method Storage.Load should have comment or be unexported (golint)
- Line 84: warning: exported method Storage.Save should have comment or be unexported (golint)
-
-
dash-home/pkg/server/agents.go
- Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
ineffassign92%
IneffAssign detects ineffectual assignments in Go code.
-
-
dash-home/pkg/agent/remote.go
- Line 27: warning: ineffectual assignment to ctx (ineffassign)
-
-
dash-home/pkg/agent/switchbot.go
- Line 27: warning: ineffectual assignment to ctx (ineffassign)