Preparing report...

Report for github.com/dell/csi-vxflexos

(v1.6.0)

A    Great!    Found 13 issues across 20 files

Tweet

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gofmt70%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


gocyclo55%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • service/csi_extension_server.go
    • Line 17: warning: cyclomatic complexity 17 of function (*service).ValidateVolumeHostConnectivity() is high (> 15) (gocyclo)
    • Line 281: warning: cyclomatic complexity 17 of function (*service).checkIdempotency() is high (> 15) (gocyclo)
    • service/service.go
    • Line 560: warning: cyclomatic complexity 16 of function getArrayConfig() is high (> 15) (gocyclo)
    • Line 293: warning: cyclomatic complexity 16 of function (*service).BeforeServe() is high (> 15) (gocyclo)
    • service/node.go
    • Line 172: warning: cyclomatic complexity 21 of function (*service).NodeUnpublishVolume() is high (> 15) (gocyclo)
    • Line 523: warning: cyclomatic complexity 18 of function (*service).NodeExpandVolume() is high (> 15) (gocyclo)
    • Line 94: warning: cyclomatic complexity 16 of function (*service).NodePublishVolume() is high (> 15) (gocyclo)
    • service/ephemeral.go
    • Line 46: warning: cyclomatic complexity 17 of function (*service).ephemeralNodePublish() is high (> 15) (gocyclo)
    • service/mount.go
    • Line 72: warning: cyclomatic complexity 44 of function publishVolume() is high (> 15) (gocyclo)
    • Line 595: warning: cyclomatic complexity 21 of function validateVolumeCapability() is high (> 15) (gocyclo)
    • Line 415: warning: cyclomatic complexity 17 of function unpublishVolume() is high (> 15) (gocyclo)
    • service/controller.go
    • Line 91: warning: cyclomatic complexity 34 of function (*service).CreateVolume() is high (> 15) (gocyclo)
    • Line 1640: warning: cyclomatic complexity 26 of function (*service).CreateSnapshot() is high (> 15) (gocyclo)
    • Line 609: warning: cyclomatic complexity 24 of function (*service).ControllerPublishVolume() is high (> 15) (gocyclo)
    • Line 1188: warning: cyclomatic complexity 24 of function (*service).listVolumes() is high (> 15) (gocyclo)
    • Line 1519: warning: cyclomatic complexity 20 of function (*service).systemProbe() is high (> 15) (gocyclo)
    • Line 515: warning: cyclomatic complexity 17 of function (*service).DeleteVolume() is high (> 15) (gocyclo)
    • Line 362: warning: cyclomatic complexity 16 of function (*service).createVolumeFromSnapshot() is high (> 15) (gocyclo)
    • Line 1937: warning: cyclomatic complexity 16 of function (*service).ControllerExpandVolume() is high (> 15) (gocyclo)

ineffassign75%

IneffAssign detects ineffectual assignments in Go code.

    • service/controller.go
    • Line 695: warning: ineffectual assignment to allowMultipleMappings (ineffassign)
    • Line 695: warning: ineffectual assignment to allowMultipleMappings (ineffassign)
    • service/service.go
    • Line 204: warning: ineffectual assignment to err (ineffassign)
    • Line 632: warning: ineffectual assignment to copy (ineffassign)
    • Line 204: warning: ineffectual assignment to err (ineffassign)
    • Line 632: warning: ineffectual assignment to copy (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell80%

Misspell Finds commonly misspelled English words