Report for github.com/devimteam/zenrpc

A+    Excellent!    Found 9 issues across 16 files

Tweet

gofmt93%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • zenrpc/parser/parser.go
    • Line 526: warning: cyclomatic complexity 17 of function (*Method).parseReturns() is high (> 15) (gocyclo)
    • Line 453: warning: cyclomatic complexity 16 of function (*Method).parseArguments() is high (> 15) (gocyclo)

golint68%

Golint is a linter for Go source code.

    • zenrpc/smd/model.go
    • Line 6: warning: exported const String should have comment (or a comment on this block) or be unexported (golint)
    • Line 61: warning: exported type JSONSchema should have comment or be unexported (golint)
    • Line 77: warning: exported type Property should have comment or be unexported (golint)
    • Line 85: warning: exported type Definition should have comment or be unexported (golint)
    • Line 90: warning: exported type ServiceInfo should have comment or be unexported (golint)
    • zenrpc/parser/parser.go
    • Line 16: warning: exported const GenerateFileSuffix should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: exported type Service should have comment or be unexported (golint)
    • Line 53: warning: exported type Method should have comment or be unexported (golint)
    • Line 68: warning: exported type DefaultValue should have comment or be unexported (golint)
    • Line 76: warning: exported type Arg should have comment or be unexported (golint)
    • Line 91: warning: exported type Return should have comment or be unexported (golint)
    • Line 96: warning: exported type SMDReturn should have comment or be unexported (golint)
    • Line 103: warning: exported type Struct should have comment or be unexported (golint)
    • Line 111: warning: exported type Interface should have comment or be unexported (golint)
    • Line 119: warning: exported type Property should have comment or be unexported (golint)
    • Line 132: warning: exported type SMDError should have comment or be unexported (golint)
    • Line 137: warning: exported function NewPackageInfo should have comment or be unexported (golint)
    • Line 159: warning: comment on exported method PackageInfo.Parse should be of the form "Parse ..." (golint)
    • Line 163: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign68%

IneffAssign detects ineffectual assignments in Go code.

    • zenrpc/server_test.go
    • Line 8: warning: cannot find package "." in: (ineffassign)
    • Line 9: warning: cannot find package "." in: (ineffassign)
    • Line 8: warning: could not import github.com/devimteam/zenrpc (invalid package name: "") (ineffassign)
    • Line 9: warning: could not import github.com/devimteam/zenrpc/testdata (invalid package name: "") (ineffassign)
    • zenrpc/zenrpc/main.go
    • Line 12: warning: cannot find package "." in: (ineffassign)
    • Line 12: warning: could not import github.com/devimteam/zenrpc/parser (invalid package name: "") (ineffassign)
    • zenrpc/server.go
    • Line 14: warning: cannot find package "." in: (ineffassign)
    • Line 14: warning: could not import github.com/devimteam/zenrpc/smd (invalid package name: "") (ineffassign)
    • zenrpc/handlers.go
    • Line 10: warning: cannot find package "." in: (ineffassign)
    • Line 10: warning: could not import github.com/gorilla/websocket (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!