Preparing report...

Report for github.com/dialup-inc/ascii

A    Great!    Found 23 issues across 31 files

Tweet

gofmt87%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo93%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • ascii/app.go
    • Line 48: warning: cyclomatic complexity 23 of function (*App).run() is high (> 15) (gocyclo)

golint32%

Golint is a linter for Go source code.

    • ascii/term/ansi.go
    • Line 9: warning: exported type ANSI should have comment or be unexported (golint)
    • Line 13: warning: exported method ANSI.Clear should have comment or be unexported (golint)
    • Line 17: warning: exported method ANSI.CursorPosition should have comment or be unexported (golint)
    • Line 31: warning: exported method ANSI.Foreground should have comment or be unexported (golint)
    • Line 42: warning: exported method ANSI.ForegroundReset should have comment or be unexported (golint)
    • Line 46: warning: exported method ANSI.Background should have comment or be unexported (golint)
    • Line 57: warning: exported method ANSI.ResizeWindow should have comment or be unexported (golint)
    • Line 68: warning: exported method ANSI.BackgroundReset should have comment or be unexported (golint)
    • Line 72: warning: exported method ANSI.Normal should have comment or be unexported (golint)
    • Line 76: warning: exported method ANSI.Bold should have comment or be unexported (golint)
    • Line 80: warning: exported method ANSI.HideCursor should have comment or be unexported (golint)
    • Line 84: warning: exported method ANSI.ShowCursor should have comment or be unexported (golint)
    • Line 88: warning: exported method ANSI.Blink should have comment or be unexported (golint)
    • Line 92: warning: exported method ANSI.BlinkOff should have comment or be unexported (golint)
    • Line 96: warning: exported method ANSI.Reset should have comment or be unexported (golint)
    • Line 100: warning: exported var ANSIPalette should have comment or be unexported (golint)
    • ascii/videos/player.go
    • Line 14: warning: exported type Player should have comment or be unexported (golint)
    • Line 24: warning: exported method Player.Play should have comment or be unexported (golint)
    • Line 76: warning: exported function NewPlayer should have comment or be unexported (golint)
    • ascii/signal/group.go
    • Line 5: warning: exported type Group should have comment or be unexported (golint)
    • Line 10: warning: exported function NewGroup should have comment or be unexported (golint)
    • Line 16: warning: exported method Group.Add should have comment or be unexported (golint)
    • Line 22: warning: exported method Group.Remove should have comment or be unexported (golint)
    • Line 36: warning: exported method Group.Pop should have comment or be unexported (golint)
    • ascii/signal/server.go
    • Line 36: warning: exported function NewServer should have comment or be unexported (golint)
    • Line 46: warning: exported type Server should have comment or be unexported (golint)
    • Line 68: warning: exported method Server.HandleStatus should have comment or be unexported (golint)
    • Line 81: warning: exported method Server.HandleWS should have comment or be unexported (golint)
    • ascii/ui/state.go
    • Line 9: warning: exported type Page should have comment or be unexported (golint)
    • Line 12: warning: exported var GlobePage should have comment or be unexported (golint)
    • Line 18: warning: exported type State should have comment or be unexported (golint)
    • Line 31: warning: exported type MessageType should have comment or be unexported (golint)
    • Line 34: warning: exported const MessageTypeIncoming should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported type Message should have comment or be unexported (golint)
    • Line 46: warning: exported type EndConnReason should have comment or be unexported (golint)
    • Line 49: warning: comment on exported const EndConnNormal should be of the form "EndConnNormal ..." (golint)
    • Line 51: warning: comment on exported const EndConnSetupError should be of the form "EndConnSetupError ..." (golint)
    • Line 53: warning: comment on exported const EndConnMatchError should be of the form "EndConnMatchError ..." (golint)
    • Line 55: warning: comment on exported const EndConnTimedOut should be of the form "EndConnTimedOut ..." (golint)
    • Line 57: warning: comment on exported const EndConnDisconnected should be of the form "EndConnDisconnected ..." (golint)
    • Line 59: warning: comment on exported const EndConnGone should be of the form "EndConnGone ..." (golint)
    • ascii/vpx/encoder.go
    • Line 22: warning: exported type Encoder should have comment or be unexported (golint)
    • Line 29: warning: exported function NewEncoder should have comment or be unexported (golint)
    • Line 38: warning: exported method Encoder.Close should have comment or be unexported (golint)
    • Line 49: warning: exported method Encoder.Encode should have comment or be unexported (golint)
    • ascii/app.go
    • Line 28: warning: exported type App should have comment or be unexported (golint)
    • Line 220: warning: exported method App.Run should have comment or be unexported (golint)
    • Line 504: warning: exported function New should have comment or be unexported (golint)
    • ascii/vpx/decoder.go
    • Line 21: warning: exported type Decoder should have comment or be unexported (golint)
    • Line 31: warning: exported function NewDecoder should have comment or be unexported (golint)
    • Line 46: warning: exported method Decoder.Close should have comment or be unexported (golint)
    • Line 57: warning: exported method Decoder.Decode should have comment or be unexported (golint)
    • ascii/videos/ivfreader.go
    • Line 9: warning: exported type IVFReader should have comment or be unexported (golint)
    • Line 14: warning: exported type IVFHeader should have comment or be unexported (golint)
    • Line 27: warning: exported type IVFFrameHeader should have comment or be unexported (golint)
    • Line 32: warning: exported function NewIVFReader should have comment or be unexported (golint)
    • Line 51: warning: exported method IVFReader.Codec should have comment or be unexported (golint)
    • Line 55: warning: exported method IVFReader.ReadFrame should have comment or be unexported (golint)
    • Line 69: warning: exported method IVFReader.Rewind should have comment or be unexported (golint)
    • ascii/ui/renderer.go
    • Line 22: warning: exported function NewRenderer should have comment or be unexported (golint)
    • Line 28: warning: exported type Renderer should have comment or be unexported (golint)
    • Line 37: warning: exported method Renderer.GetState should have comment or be unexported (golint)
    • Line 44: warning: exported method Renderer.Dispatch should have comment or be unexported (golint)
    • Line 59: warning: exported method Renderer.RequestFrame should have comment or be unexported (golint)
    • Line 510: warning: exported method Renderer.Start should have comment or be unexported (golint)
    • Line 517: warning: exported method Renderer.Stop should have comment or be unexported (golint)
    • ascii/conn.go
    • Line 19: warning: exported type DCMessage should have comment or be unexported (golint)
    • Line 24: warning: exported function NewConn should have comment or be unexported (golint)
    • Line 72: warning: exported type Conn should have comment or be unexported (golint)
    • Line 156: warning: exported method Conn.SendMessage should have comment or be unexported (golint)
    • Line 167: warning: exported method Conn.SendPLI should have comment or be unexported (golint)
    • Line 184: warning: exported method Conn.SendBye should have comment or be unexported (golint)
    • Line 197: warning: exported method Conn.IsConnected should have comment or be unexported (golint)
    • ascii/vpx/errors.go
    • Line 5: warning: exported type VPXCodecErr should have comment or be unexported (golint)
    • Line 8: warning: exported const VPX_CODEC_OK should have comment (or a comment on this block) or be unexported (golint)
    • ascii/term/window.go
    • Line 9: warning: exported type WinSize should have comment or be unexported (golint)
    • Line 16: warning: exported function GetWinSize should have comment or be unexported (golint)
    • ascii/videos/videos.go
    • Line 1: warning: package comment should be of the form "Package videos ..." (golint)
    • Line 6: warning: exported function Globe should have comment or be unexported (golint)
    • Line 10: warning: exported function Pion should have comment or be unexported (golint)
    • ascii/camera/cam_linux.go
    • Line 15: warning: exported type Camera should have comment or be unexported (golint)
    • Line 19: warning: exported method Camera.Start should have comment or be unexported (golint)
    • Line 70: warning: exported method Camera.Close should have comment or be unexported (golint)
    • Line 75: warning: exported function New should have comment or be unexported (golint)
    • ascii/capture.go
    • Line 14: warning: exported function NewCapture should have comment or be unexported (golint)
    • Line 36: warning: exported type Capture should have comment or be unexported (golint)
    • Line 54: warning: exported method Capture.Start should have comment or be unexported (golint)
    • Line 58: warning: exported method Capture.Stop should have comment or be unexported (golint)
    • Line 63: warning: exported method Capture.RequestKeyframe should have comment or be unexported (golint)
    • Line 67: warning: exported method Capture.SetTrack should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign96%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!