Report for github.com/docker/go-p9p
A+ Excellent! Found 14 issues across 26 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go-p9p/encoding_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo73%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-p9p/server.go
- Line 71: warning: cyclomatic complexity 23 of function (*conn).serve() is high (> 15) (gocyclo)
-
-
go-p9p/transport.go
- Line 129: warning: cyclomatic complexity 17 of function (*transport).handle() is high (> 15) (gocyclo)
-
-
go-p9p/cmd/9pr/main.go
- Line 29: warning: cyclomatic complexity 19 of function main() is high (> 15) (gocyclo)
-
-
go-p9p/encoding.go
- Line 88: warning: cyclomatic complexity 54 of function (*encoder).encode() is high (> 15) (gocyclo)
- Line 239: warning: cyclomatic complexity 42 of function (*decoder).decode() is high (> 15) (gocyclo)
- Line 410: warning: cyclomatic complexity 28 of function size9p() is high (> 15) (gocyclo)
-
-
go-p9p/fcall.go
- Line 41: warning: cyclomatic complexity 30 of function (FcallType).String() is high (> 15) (gocyclo)
-
-
go-p9p/messages.go
- Line 12: warning: cyclomatic complexity 28 of function newMessage() is high (> 15) (gocyclo)
-
-
go-p9p/dispatcher.go
- Line 28: warning: cyclomatic complexity 24 of function Dispatch() is high (> 15) (gocyclo)
golint80%
Golint is a linter for Go source code.
-
-
go-p9p/ufs/fileref.go
- Line 10: warning: exported type FileRef should have comment or be unexported (golint)
- Line 18: warning: exported method FileRef.Stat should have comment or be unexported (golint)
- Line 34: warning: exported method FileRef.IsDir should have comment or be unexported (golint)
-
-
go-p9p/ufs/session.go
- Line 23: warning: exported function NewSession should have comment or be unexported (golint)
-
-
go-p9p/ufs/util_linux.go
- Line 1: warning: package comment should be of the form "Package ufs ..." (golint)
-
-
go-p9p/cmd/9ps/main.go
- Line 51: warning: should not use basic type untyped string as key in context.WithValue (golint)
-
-
go-p9p/messages.go
- Line 73: warning: comment on exported type MessageTversion should be of the form "MessageTversion ..." (with optional leading article) (golint)
- Line 80: warning: exported type MessageRversion should have comment or be unexported (golint)
- Line 85: warning: exported type MessageTauth should have comment or be unexported (golint)
- Line 91: warning: exported type MessageRauth should have comment or be unexported (golint)
- Line 95: warning: exported type MessageTflush should have comment or be unexported (golint)
- Line 99: warning: exported type MessageRflush should have comment or be unexported (golint)
- Line 101: warning: exported type MessageTattach should have comment or be unexported (golint)
- Line 108: warning: exported type MessageRattach should have comment or be unexported (golint)
- Line 112: warning: exported type MessageTwalk should have comment or be unexported (golint)
- Line 118: warning: exported type MessageRwalk should have comment or be unexported (golint)
- Line 122: warning: exported type MessageTopen should have comment or be unexported (golint)
- Line 127: warning: exported type MessageRopen should have comment or be unexported (golint)
- Line 132: warning: exported type MessageTcreate should have comment or be unexported (golint)
- Line 139: warning: exported type MessageRcreate should have comment or be unexported (golint)
- Line 144: warning: exported type MessageTread should have comment or be unexported (golint)
- Line 150: warning: exported type MessageRread should have comment or be unexported (golint)
- Line 154: warning: exported type MessageTwrite should have comment or be unexported (golint)
- Line 160: warning: exported type MessageRwrite should have comment or be unexported (golint)
- Line 164: warning: exported type MessageTclunk should have comment or be unexported (golint)
- Line 168: warning: exported type MessageRclunk should have comment or be unexported (golint)
- Line 170: warning: exported type MessageTremove should have comment or be unexported (golint)
- Line 174: warning: exported type MessageRremove should have comment or be unexported (golint)
- Line 176: warning: exported type MessageTstat should have comment or be unexported (golint)
- Line 180: warning: exported type MessageRstat should have comment or be unexported (golint)
- Line 184: warning: exported type MessageTwstat should have comment or be unexported (golint)
- Line 189: warning: exported type MessageRwstat should have comment or be unexported (golint)
- Line 191: warning: exported method MessageTversion.Type should have comment or be unexported (golint)
- Line 192: warning: exported method MessageRversion.Type should have comment or be unexported (golint)
- Line 193: warning: exported method MessageTauth.Type should have comment or be unexported (golint)
- Line 194: warning: exported method MessageRauth.Type should have comment or be unexported (golint)
- Line 195: warning: exported method MessageTflush.Type should have comment or be unexported (golint)
- Line 196: warning: exported method MessageRflush.Type should have comment or be unexported (golint)
- Line 197: warning: exported method MessageTattach.Type should have comment or be unexported (golint)
- Line 198: warning: exported method MessageRattach.Type should have comment or be unexported (golint)
- Line 199: warning: exported method MessageTwalk.Type should have comment or be unexported (golint)
- Line 200: warning: exported method MessageRwalk.Type should have comment or be unexported (golint)
- Line 201: warning: exported method MessageTopen.Type should have comment or be unexported (golint)
- Line 202: warning: exported method MessageRopen.Type should have comment or be unexported (golint)
- Line 203: warning: exported method MessageTcreate.Type should have comment or be unexported (golint)
- Line 204: warning: exported method MessageRcreate.Type should have comment or be unexported (golint)
- Line 205: warning: exported method MessageTread.Type should have comment or be unexported (golint)
- Line 206: warning: exported method MessageRread.Type should have comment or be unexported (golint)
- Line 207: warning: exported method MessageTwrite.Type should have comment or be unexported (golint)
- Line 208: warning: exported method MessageRwrite.Type should have comment or be unexported (golint)
- Line 209: warning: exported method MessageTclunk.Type should have comment or be unexported (golint)
- Line 210: warning: exported method MessageRclunk.Type should have comment or be unexported (golint)
- Line 211: warning: exported method MessageTremove.Type should have comment or be unexported (golint)
- Line 212: warning: exported method MessageRremove.Type should have comment or be unexported (golint)
- Line 213: warning: exported method MessageTstat.Type should have comment or be unexported (golint)
- Line 214: warning: exported method MessageRstat.Type should have comment or be unexported (golint)
- Line 215: warning: exported method MessageTwstat.Type should have comment or be unexported (golint)
- Line 216: warning: exported method MessageRwstat.Type should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!
misspell88%
Misspell Finds commonly misspelled English words
-
-
go-p9p/encoding.go
- Line 216: warning: "preceeding" is a misspelling of "preceding" (misspell)
- Line 386: warning: "preceeding" is a misspelling of "preceding" (misspell)
-
-
go-p9p/session.go
- Line 14: warning: "preceeding" is a misspelling of "preceding" (misspell)
-
-
go-p9p/types.go
- Line 49: warning: "protocal" is a misspelling of "protocol" (misspell)