Go Report Card

Preparing report...

Report for github.com/dominodatalab/forge

A+    Excellent!    Found 35 issues across 79 files

Tweet
Last refresh:

Refresh now

gofmt97%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo98%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

golint58%

Golint is a linter for Go source code.

    • forge/internal/buildjob/buildjob.go
    • Line 26: warning: exported type Job should have comment or be unexported (golint)
    • Line 44: warning: exported function New should have comment or be unexported (golint)
    • Line 114: warning: exported method Job.Run should have comment or be unexported (golint)
    • Line 154: warning: exported method Job.Cleanup should have comment or be unexported (golint)
    • forge/internal/archive/extract.go
    • Line 44: warning: exported type Extractor should have comment or be unexported (golint)
    • Line 46: warning: exported type Extraction should have comment or be unexported (golint)
    • Line 51: warning: context.Context should be the first parameter of a function (golint)
    • Line 51: warning: exported function FetchAndExtract should have comment or be unexported (golint)
    • forge/internal/crd/crd.go
    • Line 23: warning: exported function Apply should have comment or be unexported (golint)
    • Line 58: warning: exported function Delete should have comment or be unexported (golint)
    • forge/api/v1alpha1/containerimagebuild_types.go
    • Line 29: warning: exported method BasicAuthConfig.IsInline should have comment or be unexported (golint)
    • Line 33: warning: exported method BasicAuthConfig.IsSecret should have comment or be unexported (golint)
    • Line 37: warning: exported method BasicAuthConfig.Validate should have comment or be unexported (golint)
    • Line 181: warning: comment on exported method ContainerImageBuildStatus.SetState should be of the form "SetState ..." (golint)
    • forge/controllers/start.go
    • Line 14: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 30: warning: exported function StartManager should have comment or be unexported (golint)
    • forge/internal/clientset/v1alpha1/api.go
    • Line 11: warning: exported type Interface should have comment or be unexported (golint)
    • Line 15: warning: exported type Client should have comment or be unexported (golint)
    • Line 19: warning: exported method Client.ContainerImageBuilds should have comment or be unexported (golint)
    • Line 26: warning: exported function NewForConfig should have comment or be unexported (golint)
    • forge/internal/cloud/cloud.go
    • Line 5: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 10: warning: exported var RetrieveRegistryAuthorization should have comment or be unexported (golint)
    • forge/docs/example/preparer_plugin.go
    • Line 17: warning: exported type MyPlugin should have comment or be unexported (golint)
    • Line 19: warning: exported method MyPlugin.Prepare should have comment or be unexported (golint)
    • Line 24: warning: exported method MyPlugin.Cleanup should have comment or be unexported (golint)
    • forge/internal/builder/embedded/bkimage/hosts.go
    • Line 5: warning: exported type CredentialsFn should have comment or be unexported (golint)
    • Line 6: warning: exported type TLSEnabledFn should have comment or be unexported (golint)
    • Line 8: warning: exported method Client.ResetHostConfigurations should have comment or be unexported (golint)
    • Line 15: warning: exported method Client.ConfigureHosts should have comment or be unexported (golint)
    • forge/controllers/containerimagebuild_controller.go
    • Line 28: warning: exported type BuildJobConfig should have comment or be unexported (golint)
    • Line 52: warning: exported type ControllerConfig should have comment or be unexported (golint)
    • Line 122: warning: exported method ContainerImageBuildReconciler.SetupWithManager should have comment or be unexported (golint)
    • Line 131: warning: exported method ContainerImageBuildReconciler.Reconcile should have comment or be unexported (golint)
    • forge/plugins/preparer/plugin.go
    • Line 9: warning: exported type Plugin should have comment or be unexported (golint)
    • Line 14: warning: exported method Plugin.Server should have comment or be unexported (golint)
    • Line 18: warning: exported method Plugin.Client should have comment or be unexported (golint)
    • Line 22: warning: exported method Plugin.Kill should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!