Preparing report...

Report for github.com/edgexfoundry/device-snmp-go

A+    Excellent!    Found 4 issues across 6 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo83%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint33%

Golint is a linter for Go source code.

    • device-snmp-go/internal/driver/snmpclient.go
    • Line 22: warning: exported function NewSNMPClient should have comment or be unexported (golint)
    • Line 29: warning: exported type DeviceCommand should have comment or be unexported (golint)
    • Line 34: warning: exported function NewGetDeviceCommand should have comment or be unexported (golint)
    • Line 42: warning: exported function NewSetDeviceCommand should have comment or be unexported (golint)
    • Line 49: warning: exported method SNMPClient.GetValues should have comment or be unexported (golint)
    • Line 95: warning: exported method SNMPClient.GetValue should have comment or be unexported (golint)
    • Line 104: warning: exported method SNMPClient.SetValues should have comment or be unexported (golint)
    • Line 147: warning: exported method SNMPClient.Disconnect should have comment or be unexported (golint)
    • device-snmp-go/internal/driver/snmpdriver.go
    • Line 21: warning: exported type SNMPDriver should have comment or be unexported (golint)
    • Line 215: warning: exported method SNMPDriver.AddDevice should have comment or be unexported (golint)
    • Line 220: warning: exported method SNMPDriver.UpdateDevice should have comment or be unexported (golint)
    • Line 225: warning: exported method SNMPDriver.RemoveDevice should have comment or be unexported (golint)
    • device-snmp-go/version.go
    • Line 7: warning: don't use an underscore in package name (golint)
    • Line 9: warning: comment on exported const Version should be of the form "Version ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!