Preparing report...

Report for github.com/evilsocket/shellz

A    Great!    Found 20 issues across 27 files

Tweet

gofmt92%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint25%

Golint is a linter for Go source code.

    • shellz/session/ssh_tun.go
    • Line 14: warning: exported type SSHTun should have comment or be unexported (golint)
    • Line 20: warning: error should be the last type when returning multiple items (golint)
    • Line 20: warning: exported function NewSSHTun should have comment or be unexported (golint)
    • Line 34: warning: exported method SSHTun.Type should have comment or be unexported (golint)
    • Line 75: warning: exported method SSHTun.Close should have comment or be unexported (golint)
    • shellz/core/timeouts.go
    • Line 7: warning: exported type Timeouts should have comment or be unexported (golint)
    • Line 13: warning: exported method Timeouts.RW should have comment or be unexported (golint)
    • Line 17: warning: exported method Timeouts.Total should have comment or be unexported (golint)
    • shellz/models/shell.go
    • Line 20: warning: exported type Shell should have comment or be unexported (golint)
    • Line 39: warning: error should be the last type when returning multiple items (golint)
    • Line 39: warning: exported function LoadShell should have comment or be unexported (golint)
    • Line 73: warning: exported method Shell.Save should have comment or be unexported (golint)
    • shellz/models/tunnel.go
    • Line 11: warning: exported type Address should have comment or be unexported (golint)
    • Line 20: warning: exported method Address.Empty should have comment or be unexported (golint)
    • Line 24: warning: exported type Tunnel should have comment or be unexported (golint)
    • Line 29: warning: exported method Tunnel.Empty should have comment or be unexported (golint)
    • shellz/plugins/plugin.go
    • Line 22: warning: exported type Plugin should have comment or be unexported (golint)
    • Line 29: warning: error should be the last type when returning multiple items (golint)
    • Line 29: warning: exported function LoadPlugin should have comment or be unexported (golint)
    • Line 32: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 39: warning: error should be the last type when returning multiple items (golint)
    • Line 39: warning: exported method Plugin.NewSession should have comment or be unexported (golint)
    • Line 58: warning: exported method Plugin.Type should have comment or be unexported (golint)
    • Line 67: warning: exported method Plugin.Exec should have comment or be unexported (golint)
    • Line 89: warning: exported method Plugin.Close should have comment or be unexported (golint)
    • shellz/session/session.go
    • Line 17: warning: exported type Handler should have comment or be unexported (golint)
    • Line 19: warning: exported type Session should have comment or be unexported (golint)
    • Line 25: warning: error should be the last type when returning multiple items (golint)
    • Line 25: warning: exported function For should have comment or be unexported (golint)
    • shellz/session/winrm.go
    • Line 16: warning: exported type WinRMSession should have comment or be unexported (golint)
    • Line 25: warning: error should be the last type when returning multiple items (golint)
    • Line 25: warning: exported function NewWinRM should have comment or be unexported (golint)
    • Line 54: warning: exported method WinRMSession.Type should have comment or be unexported (golint)
    • Line 58: warning: exported method WinRMSession.Exec should have comment or be unexported (golint)
    • Line 67: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 83: warning: exported method WinRMSession.Close should have comment or be unexported (golint)
    • shellz/models/identity.go
    • Line 9: warning: exported type Identity should have comment or be unexported (golint)
    • Line 17: warning: error should be the last type when returning multiple items (golint)
    • Line 17: warning: exported function LoadIdent should have comment or be unexported (golint)
    • shellz/models/paths.go
    • Line 14: warning: exported var Path should have comment or be unexported (golint)
    • Line 18: warning: exported function Init should have comment or be unexported (golint)
    • Line 30: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • shellz/models/proxy.go
    • Line 9: warning: exported type Proxy should have comment or be unexported (golint)
    • Line 16: warning: exported method Proxy.Empty should have comment or be unexported (golint)
    • shellz/session/telnet.go
    • Line 19: warning: exported type TelnetSession should have comment or be unexported (golint)
    • Line 26: warning: error should be the last type when returning multiple items (golint)
    • Line 26: warning: exported function NewTelnet should have comment or be unexported (golint)
    • Line 57: warning: exported method TelnetSession.Type should have comment or be unexported (golint)
    • Line 92: warning: error should be the last type when returning multiple items (golint)
    • Line 107: warning: exported method TelnetSession.Exec should have comment or be unexported (golint)
    • Line 119: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 126: warning: exported method TelnetSession.Close should have comment or be unexported (golint)
    • shellz/core/version.go
    • Line 11: warning: exported const Name should have comment (or a comment on this block) or be unexported (golint)
    • Line 18: warning: exported var Banner should have comment or be unexported (golint)
    • shellz/models/storage.go
    • Line 11: warning: exported type Identities should have comment or be unexported (golint)
    • Line 12: warning: exported type Shells should have comment or be unexported (golint)
    • Line 13: warning: exported type Groups should have comment or be unexported (golint)
    • Line 15: warning: error should be the last type when returning multiple items (golint)
    • Line 15: warning: exported function Load should have comment or be unexported (golint)
    • shellz/plugins/factory.go
    • Line 12: warning: exported type Plugins should have comment or be unexported (golint)
    • Line 18: warning: exported function Load should have comment or be unexported (golint)
    • Line 32: warning: exported function Get should have comment or be unexported (golint)
    • Line 36: warning: exported function Number should have comment or be unexported (golint)
    • Line 40: warning: exported function Each should have comment or be unexported (golint)
    • shellz/session/ssh.go
    • Line 19: warning: exported const SSHAgentKey should have comment (or a comment on this block) or be unexported (golint)
    • Line 23: warning: exported type SSHSession should have comment or be unexported (golint)
    • Line 33: warning: error should be the last type when returning multiple items (golint)
    • Line 33: warning: exported function NewSSH should have comment or be unexported (golint)
    • Line 79: warning: exported method SSHSession.Type should have comment or be unexported (golint)
    • Line 88: warning: exported method SSHSession.Exec should have comment or be unexported (golint)
    • Line 105: warning: exported method SSHSession.Close should have comment or be unexported (golint)
    • shellz/plugins/http.go
    • Line 73: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • shellz/session/ssh_utils.go
    • Line 19: warning: error should be the last type when returning multiple items (golint)
    • Line 32: warning: error should be the last type when returning multiple items (golint)
    • Line 47: warning: error should be the last type when returning multiple items (golint)
    • Line 56: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 62: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign96%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!