Report for github.com/fiorix/go-diameter
A+ Excellent! Found 28 issues across 138 files
gofmt99%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go-diameter/diam/dict/util.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo96%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
go-diameter/diam/reflect.go
- Line 122: warning: cyclomatic complexity 40 of function marshal() is high (> 15) (gocyclo)
-
-
go-diameter/diam/reflect_test.go
- Line 150: warning: cyclomatic complexity 24 of function TestUnmarshalGrouped() is high (> 15) (gocyclo)
- Line 271: warning: cyclomatic complexity 16 of function TestUnmarshalCER() is high (> 15) (gocyclo)
-
-
go-diameter/examples/s6a_proxy/service/test/s6a_proxy_test.go
- Line 23: warning: cyclomatic complexity 19 of function TestS6aProxyService() is high (> 15) (gocyclo)
-
-
go-diameter/diam/sm/sm_test.go
- Line 39: warning: cyclomatic complexity 23 of function testStateMachine() is high (> 15) (gocyclo)
-
-
go-diameter/examples/wireshark-dict-tool/main.go
- Line 84: warning: cyclomatic complexity 18 of function copyAvps() is high (> 15) (gocyclo)
golint82%
Golint is a linter for Go source code.
-
-
go-diameter/examples/s6a_client/main.go
- Line 190: warning: exported const ULR_FLAGS should have comment or be unexported (golint)
- Line 192: warning: exported type EUtranVector should have comment or be unexported (golint)
- Line 199: warning: exported type ExperimentalResult should have comment or be unexported (golint)
- Line 203: warning: exported type AuthenticationInfo should have comment or be unexported (golint)
- Line 207: warning: exported type AIA should have comment or be unexported (golint)
- Line 217: warning: exported type AMBR should have comment or be unexported (golint)
- Line 222: warning: exported type AllocationRetentionPriority should have comment or be unexported (golint)
- Line 228: warning: exported type EPSSubscribedQoSProfile should have comment or be unexported (golint)
- Line 233: warning: exported type APNConfiguration should have comment or be unexported (golint)
- Line 241: warning: exported type APNConfigurationProfile should have comment or be unexported (golint)
- Line 247: warning: exported type SubscriptionData should have comment or be unexported (golint)
- Line 257: warning: exported type ULA should have comment or be unexported (golint)
-
-
go-diameter/examples/middleware/tracer.go
- Line 10: warning: exported type Tracer should have comment or be unexported (golint)
- Line 33: warning: exported method Tracer.ServeDIAM should have comment or be unexported (golint)
- Line 40: warning: exported function NewTracer should have comment or be unexported (golint)
- Line 46: warning: exported function TracerFunc should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/ai.go
- Line 1: warning: package comment should be of the form "Package service ..." (golint)
- Line 192: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-diameter/diam/sm/client_test.go
- Line 95: warning: don't use underscores in Go names; func testClient_Handshake_CustomIP should be testClientHandshakeCustomIP (golint)
-
-
go-diameter/diam/clone_tls_conf_go18.go
- Line 7: warning: exported function TLSConfigClone should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/config.go
- Line 9: warning: exported type S6aProxyConfig should have comment or be unexported (golint)
- Line 18: warning: exported method S6aProxyConfig.Validate should have comment or be unexported (golint)
- Line 41: warning: exported method S6aProxyConfig.CloneWithDefaults should have comment or be unexported (golint)
- Line 41: warning: receiver name srcCfg should be consistent with previous receiver name cfg for S6aProxyConfig (golint)
-
-
go-diameter/examples/s6a_proxy/service/util.go
- Line 1: warning: package comment should be of the form "Package service ..." (golint)
-
-
go-diameter/diam/reflect.go
- Line 75: warning: error should be the last type when returning multiple items (golint)
- Line 122: warning: error should be the last type when returning multiple items (golint)
-
-
go-diameter/diam/sm/sctp_test.go
- Line 18: warning: don't use underscores in Go names; func testClient_Handshake_CustomIP_SCTP should be testClientHandshakeCustomIPSCTP (golint)
-
-
go-diameter/diam/server.go
- Line 396: warning: exported type CommandIndex should have comment or be unexported (golint)
- Line 402: warning: exported var ALL_CMD_INDEX should have comment or be unexported (golint)
- Line 517: warning: comment on exported method ServeMux.HandleIdx should be of the form "HandleIdx ..." (golint)
-
-
go-diameter/examples/s6a_proxy/service/test/test_s6a_server.go
- Line 20: warning: exported const TEST_PLMN_ID should have comment (or a comment on this block) or be unexported (golint)
-
-
go-diameter/diam/dict/util.go
- Line 61: warning: exported function MakeUnknownAVP should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/s6a_definitions.go
- Line 1: warning: package comment should be of the form "Package service ..." (golint)
- Line 44: warning: exported const VENDOR_3GPP should have comment or be unexported (golint)
- Line 46: warning: exported type EUtranVector should have comment or be unexported (golint)
- Line 53: warning: exported type ExperimentalResult should have comment or be unexported (golint)
- Line 58: warning: exported type AuthenticationInfo should have comment or be unexported (golint)
- Line 62: warning: exported type AIA should have comment or be unexported (golint)
- Line 72: warning: comment on exported type AMBR should be of the form "AMBR ..." (with optional leading article) (golint)
- Line 120: warning: exported type AllocationRetentionPriority should have comment or be unexported (golint)
- Line 126: warning: exported type EPSSubscribedQoSProfile should have comment or be unexported (golint)
- Line 131: warning: exported type APNConfiguration should have comment or be unexported (golint)
- Line 139: warning: exported type APNConfigurationProfile should have comment or be unexported (golint)
- Line 145: warning: exported type SubscriptionData should have comment or be unexported (golint)
- Line 155: warning: exported type ULA should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/ul.go
- Line 1: warning: package comment should be of the form "Package service ..." (golint)
- Line 148: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-diameter/diam/datatype/time.go
- Line 27: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
go-diameter/diam/sm/cer_test.go
- Line 25: warning: don't use underscores in Go names; func testHandleCER_HandshakeMetadata should be testHandleCERHandshakeMetadata (golint)
- Line 409: warning: don't use underscores in Go names; func testHandleCER_VS_Auth should be testHandleCERVSAuth (golint)
- Line 456: warning: don't use underscores in Go names; func testHandleCER_VS_Auth_Fail should be testHandleCERVSAuthFail (golint)
-
-
go-diameter/diam/sm/sm.go
- Line 124: warning: exported method StateMachine.HandleIdx should have comment or be unexported (golint)
-
-
go-diameter/diam/client.go
- Line 25: warning: exported function DialNetworkBind should have comment or be unexported (golint)
- Line 40: warning: exported function DialNetworkTimeout should have comment or be unexported (golint)
- Line 52: warning: exported function DialTimeout should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/protos/protos.go
- Line 3: warning: package comment should be of the form "Package protos ..." (golint)
-
-
go-diameter/diam/sm/smparser/app.go
- Line 55: warning: error should be the last type when returning multiple items (golint)
-
-
go-diameter/examples/s6a_server/server.go
- Line 34: warning: exported const VENDOR_3GPP should have comment (or a comment on this block) or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/errors.go
- Line 11: warning: exported function Errorf should have comment or be unexported (golint)
- Line 17: warning: exported function Error should have comment or be unexported (golint)
-
-
go-diameter/examples/s6a_proxy/service/s6a_proxy.go
- Line 1: warning: package comment should be of the form "Package service ..." (golint)
- Line 20: warning: exported const ULR_RAT_TYPE should have comment (or a comment on this block) or be unexported (golint)
- Line 39: warning: exported function NewS6aProxy should have comment or be unexported (golint)
-
-
go-diameter/diam/message.go
- Line 265: warning: comment on exported method Message.WriteToWithRetry should be of the form "WriteToWithRetry ..." (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!