Report for github.com/funny/link
A Great! Found 11 issues across 13 files
gofmt84%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
link/session_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
link/codec/json_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint23%
Golint is a linter for Go source code.
-
-
link/codec/bufio.go
- Line 10: warning: exported function Bufio should have comment or be unexported (golint)
-
-
link/manager.go
- Line 7: warning: exported type Manager should have comment or be unexported (golint)
- Line 19: warning: exported function NewManager should have comment or be unexported (golint)
- Line 27: warning: exported method Manager.Dispose should have comment or be unexported (golint)
- Line 42: warning: exported method Manager.NewSession should have comment or be unexported (golint)
- Line 48: warning: exported method Manager.GetSession should have comment or be unexported (golint)
-
-
link/server.go
- Line 5: warning: exported type Server should have comment or be unexported (golint)
- Line 13: warning: exported type Handler should have comment or be unexported (golint)
- Line 19: warning: exported type HandlerFunc should have comment or be unexported (golint)
- Line 21: warning: exported method HandlerFunc.HandleSession should have comment or be unexported (golint)
- Line 25: warning: exported function NewServer should have comment or be unexported (golint)
- Line 35: warning: exported method Server.Listener should have comment or be unexported (golint)
- Line 39: warning: exported method Server.Serve should have comment or be unexported (golint)
- Line 58: warning: exported method Server.GetSession should have comment or be unexported (golint)
- Line 62: warning: exported method Server.Stop should have comment or be unexported (golint)
-
-
link/session.go
- Line 9: warning: error var SessionClosedError should have name of the form ErrFoo (golint)
- Line 9: warning: exported var SessionClosedError should have comment or be unexported (golint)
- Line 10: warning: error var SessionBlockedError should have name of the form ErrFoo (golint)
- Line 10: warning: exported var SessionBlockedError should have comment or be unexported (golint)
- Line 14: warning: exported type Session should have comment or be unexported (golint)
- Line 31: warning: exported function NewSession should have comment or be unexported (golint)
- Line 49: warning: exported method Session.ID should have comment or be unexported (golint)
- Line 53: warning: exported method Session.IsClosed should have comment or be unexported (golint)
- Line 57: warning: exported method Session.Close should have comment or be unexported (golint)
- Line 84: warning: exported method Session.Codec should have comment or be unexported (golint)
- Line 88: warning: exported method Session.Receive should have comment or be unexported (golint)
- Line 113: warning: exported method Session.Send should have comment or be unexported (golint)
- Line 153: warning: exported method Session.AddCloseCallback should have comment or be unexported (golint)
- Line 171: warning: exported method Session.RemoveCloseCallback should have comment or be unexported (golint)
-
-
link/session_test.go
- Line 63: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)
-
-
link/example/json_toy/main.go
- Line 10: warning: exported type AddReq should have comment or be unexported (golint)
- Line 14: warning: exported type AddRsp should have comment or be unexported (golint)
-
-
link/codec/fixlen.go
- Line 13: warning: exported var ErrTooLargePacket should have comment or be unexported (golint)
- Line 15: warning: exported type FixLenProtocol should have comment or be unexported (golint)
- Line 24: warning: exported function FixLen should have comment or be unexported (golint)
- Line 84: warning: exported method FixLenProtocol.NewCodec should have comment or be unexported (golint)
-
-
link/codec/json.go
- Line 11: warning: exported type JsonProtocol should have comment or be unexported (golint)
- Line 16: warning: exported function Json should have comment or be unexported (golint)
- Line 23: warning: exported method JsonProtocol.Register should have comment or be unexported (golint)
- Line 33: warning: exported method JsonProtocol.RegisterName should have comment or be unexported (golint)
- Line 42: warning: exported method JsonProtocol.NewCodec should have comment or be unexported (golint)
-
-
link/api.go
- Line 10: warning: exported type Protocol should have comment or be unexported (golint)
- Line 14: warning: exported type ProtocolFunc should have comment or be unexported (golint)
- Line 16: warning: exported method ProtocolFunc.NewCodec should have comment or be unexported (golint)
- Line 20: warning: exported type Codec should have comment or be unexported (golint)
- Line 26: warning: exported type ClearSendChan should have comment or be unexported (golint)
- Line 30: warning: exported function Listen should have comment or be unexported (golint)
- Line 38: warning: exported function Dial should have comment or be unexported (golint)
- Line 50: warning: exported function DialTimeout should have comment or be unexported (golint)
- Line 62: warning: exported function Accept should have comment or be unexported (golint)
-
-
link/channel.go
- Line 7: warning: exported type KEY should have comment or be unexported (golint)
- Line 9: warning: exported type Channel should have comment or be unexported (golint)
- Line 17: warning: exported function NewChannel should have comment or be unexported (golint)
- Line 23: warning: exported method Channel.Len should have comment or be unexported (golint)
- Line 29: warning: exported method Channel.Fetch should have comment or be unexported (golint)
- Line 37: warning: exported method Channel.Get should have comment or be unexported (golint)
- Line 44: warning: exported method Channel.Put should have comment or be unexported (golint)
- Line 61: warning: exported method Channel.Remove should have comment or be unexported (golint)
- Line 71: warning: exported method Channel.FetchAndRemove should have comment or be unexported (golint)
- Line 81: warning: exported method Channel.Close should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!