Preparing report...

Report for github.com/gardener/gardener-extension-shoot-dns-service

A+    Excellent!    Found 10 issues across 35 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint71%

Golint is a linter for Go source code.

    • gardener-extension-shoot-dns-service/pkg/controller/common/utils.go
    • Line 35: warning: exported const ANNOTATION_OPERATION should have comment (or a comment on this block) or be unexported (golint)
    • Line 40: warning: exported function CopyMap should have comment or be unexported (golint)
    • Line 51: warning: exported function FindExtension should have comment or be unexported (golint)
    • Line 68: warning: exported function IsMigrating should have comment or be unexported (golint)
    • Line 75: warning: exported function IsRestoring should have comment or be unexported (golint)
    • gardener-extension-shoot-dns-service/pkg/controller/common/dnsentrieshelper.go
    • Line 37: warning: exported type ShootDNSEntriesHelper should have comment or be unexported (golint)
    • Line 44: warning: exported function NewShootDNSEntriesHelper should have comment or be unexported (golint)
    • Line 52: warning: exported method ShootDNSEntriesHelper.Context should have comment or be unexported (golint)
    • Line 56: warning: exported method ShootDNSEntriesHelper.Extension should have comment or be unexported (golint)
    • Line 60: warning: exported method ShootDNSEntriesHelper.GetCluster should have comment or be unexported (golint)
    • Line 72: warning: exported method ShootDNSEntriesHelper.ShootID should have comment or be unexported (golint)
    • Line 83: warning: exported method ShootDNSEntriesHelper.ShootDNSEntryMatchingLabel should have comment or be unexported (golint)
    • Line 91: warning: exported method ShootDNSEntriesHelper.List should have comment or be unexported (golint)
    • Line 104: warning: exported method ShootDNSEntriesHelper.DeleteAll should have comment or be unexported (golint)
    • gardener-extension-shoot-dns-service/pkg/controller/common/env.go
    • Line 33: warning: exported type Env should have comment or be unexported (golint)
    • Line 41: warning: exported function NewEnv should have comment or be unexported (golint)
    • Line 49: warning: exported method Env.Infof should have comment or be unexported (golint)
    • Line 53: warning: exported method Env.RestConfig should have comment or be unexported (golint)
    • Line 57: warning: exported method Env.Client should have comment or be unexported (golint)
    • Line 61: warning: exported method Env.Config should have comment or be unexported (golint)
    • Line 65: warning: exported method Env.CreateObject should have comment or be unexported (golint)
    • Line 69: warning: exported method Env.GetObject should have comment or be unexported (golint)
    • Line 73: warning: exported method Env.UpdateObject should have comment or be unexported (golint)
    • Line 94: warning: comment on exported method Env.InjectClient should be of the form "InjectClient ..." (golint)
    • gardener-extension-shoot-dns-service/pkg/controller/common/state.go
    • Line 43: warning: exported type StateHandler should have comment or be unexported (golint)
    • Line 53: warning: exported function NewStateHandler should have comment or be unexported (golint)
    • Line 85: warning: exported method StateHandler.Infof should have comment or be unexported (golint)
    • Line 89: warning: exported method StateHandler.ShootDNSEntriesHelper should have comment or be unexported (golint)
    • Line 93: warning: exported method StateHandler.Delete should have comment or be unexported (golint)
    • Line 101: warning: exported method StateHandler.StateItems should have comment or be unexported (golint)
    • Line 105: warning: exported method StateHandler.Refresh should have comment or be unexported (golint)
    • Line 124: warning: exported method StateHandler.EnsureEntries should have comment or be unexported (golint)
    • Line 144: warning: exported method StateHandler.EnsureEntryDeleted should have comment or be unexported (golint)
    • Line 155: warning: exported method StateHandler.EnsureEntryFor should have comment or be unexported (golint)
    • Line 187: warning: exported method StateHandler.Update should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell0%

Misspell Finds commonly misspelled English words

An error occurred while running this test (exit status 2)