Report for github.com/gardener/hvpa-controller
A+ Excellent! Found 3 issues across 24 files
gofmt95%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
hvpa-controller/controllers/suite_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo91%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
hvpa-controller/controllers/hvpa_controller.go
- Line 844: warning: cyclomatic complexity 68 of function getWeightedRequests() is high (> 15) (gocyclo)
- Line 656: warning: cyclomatic complexity 36 of function getWeightedReplicas() is high (> 15) (gocyclo)
- Line 1457: warning: cyclomatic complexity 31 of function getPodEventHandler() is high (> 15) (gocyclo)
- Line 464: warning: cyclomatic complexity 27 of function (*HvpaReconciler).scaleIfRequired() is high (> 15) (gocyclo)
- Line 1311: warning: cyclomatic complexity 26 of function (*HvpaReconciler).Reconcile() is high (> 15) (gocyclo)
- Line 330: warning: cyclomatic complexity 18 of function (*HvpaReconciler).reconcileHpa() is high (> 15) (gocyclo)
- Line 1189: warning: cyclomatic complexity 17 of function getScaledResourceLimit() is high (> 15) (gocyclo)
-
-
hvpa-controller/controllers/hvpa_metrics.go
- Line 404: warning: cyclomatic complexity 29 of function (*HvpaReconciler).updateScalingMetrics() is high (> 15) (gocyclo)
ineffassign95%
IneffAssign detects ineffectual assignments in Go code.
-
-
hvpa-controller/controllers/hvpa_controller.go
- Line 177: warning: ineffectual assignment to err (ineffassign)