Preparing report...

Report for github.com/gfrey/smutje

A+    Excellent!    Found 7 issues across 24 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint70%

Golint is a linter for Go source code.

    • smutje/resource.go
    • Line 15: warning: exported type Resource should have comment or be unexported (golint)
    • Line 33: warning: exported function NewResource should have comment or be unexported (golint)
    • Line 61: warning: exported method Resource.Prepare should have comment or be unexported (golint)
    • Line 76: warning: exported method Resource.Generate should have comment or be unexported (golint)
    • Line 105: warning: exported method Resource.Provision should have comment or be unexported (golint)
    • smutje/smutje.go
    • Line 12: warning: exported function ReadFile should have comment or be unexported (golint)
    • Line 32: warning: exported function Provision should have comment or be unexported (golint)
    • Line 49: warning: exported function ProvisionHost should have comment or be unexported (golint)
    • smutje/parser/ast.go
    • Line 34: warning: exported const AstResource should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: exported type AstNode should have comment or be unexported (golint)
    • Line 101: warning: exported type Attribute should have comment or be unexported (golint)
    • Line 106: warning: exported type BashScript should have comment or be unexported (golint)
    • Line 110: warning: exported method BashScript.IndentedString should have comment or be unexported (golint)
    • Line 118: warning: exported type SmutjeScript should have comment or be unexported (golint)
    • Line 122: warning: exported method SmutjeScript.IndentedString should have comment or be unexported (golint)
    • smutje/parser/parser.go
    • Line 11: warning: exported function ParseString should have comment or be unexported (golint)
    • Line 21: warning: exported function Parse should have comment or be unexported (golint)
    • smutje/hypervisor/smartos.go
    • Line 22: warning: exported function SmartOS should have comment or be unexported (golint)
    • Line 149: warning: don't use underscores in Go names; func image_uuid should be imageUUID (golint)
    • Line 161: warning: don't use underscores in Go names; func image_uuids should be imageUuids (golint)
    • smutje/attributes.go
    • Line 8: warning: exported type Attributes should have comment or be unexported (golint)
    • Line 19: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • Line 28: warning: exported method Attributes.Copy should have comment or be unexported (golint)
    • Line 36: warning: exported method Attributes.Merge should have comment or be unexported (golint)
    • Line 44: warning: exported method Attributes.MergeInplace should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign95%

IneffAssign detects ineffectual assignments in Go code.


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!