gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

golint97%

Golint is a linter for Go source code.

• harbor/src/testing/apitests/apilib/rep_target_post.go
  • Line 25: warning: exported type RepTargetPost should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/top_repo.go
  • Line 25: warning: exported type TopRepo should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/user_profile.go
  • Line 25: warning: exported type UserProfile should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/rep_policy_enablement_req.go
  • Line 25: warning: exported type RepPolicyEnablementReq should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/rep_target.go
  • Line 25: warning: exported type RepTarget should have comment or be unexported (golint)
  • Line 43: warning: don't use underscores in Go names; struct field Type_ should be Type (golint)

• harbor/src/testing/apitests/apilib/role.go
  • Line 25: warning: exported type Role should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/search_project.go
  • Line 25: warning: exported type SearchProject should have comment or be unexported (golint)

• harbor/src/testing/pkg/scan/postprocessors/report_converters.go
  • Line 19: warning: comment on exported method ScanReportV1ToV2Converter.FromRelationalSchema should be of the form "FromRelationalSchema ..." (golint)

• harbor/src/testing/apitests/apilib/project_req.go
  • Line 25: warning: exported type ProjectReq should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/search_repository.go
  • Line 25: warning: exported type SearchRepository should have comment or be unexported (golint)

• harbor/src/testing/registryctl/client.go
  • Line 8: warning: exported type Mockclient should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/rep_policy_update.go
  • Line 25: warning: exported type RepPolicyUpdate should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/user.go
  • Line 25: warning: exported type User should have comment or be unexported (golint)

• harbor/src/testing/pkg/registry/client.go
  • Line 127: warning: exported method FakeClient.Do should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/harborlogout.go
  • Line 1: warning: package comment should be of the form "Package apilib ..." (golint)
  • Line 8: warning: exported method HarborAPI.HarborLogout should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/harlogin.go
  • Line 1: warning: package comment should be of the form "Package apilib ..." (golint)
  • Line 11: warning: exported method HarborAPI.HarborLogin should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/ldap.go
  • Line 25: warning: exported type LdapConf should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/repository.go
  • Line 25: warning: exported type Repository should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/statistic_map.go
  • Line 25: warning: exported type StatisticMap should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/tags.go
  • Line 25: warning: exported type Tags should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/job_status.go
  • Line 25: warning: exported type JobStatus should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/password.go
  • Line 25: warning: exported type Password should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/project.go
  • Line 25: warning: exported type Project should have comment or be unexported (golint)
  • Line 61: warning: exported type ProjectQuery should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/rep_policy.go
  • Line 25: warning: exported type RepPolicy should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/search.go
  • Line 29: warning: exported type Search should have comment or be unexported (golint)

• harbor/src/registryctl/api/registry/test/util.go
  • Line 70: warning: comment on exported function GetKeys should be of the form "GetKeys ..." (golint)

• harbor/src/testing/apitests/apilib/harborapi.go
  • Line 1: warning: package comment should be of the form "Package apilib ..." (golint)
  • Line 14: warning: exported type HarborAPI should have comment or be unexported (golint)
  • Line 18: warning: exported function NewHarborAPI should have comment or be unexported (golint)
  • Line 24: warning: exported function NewHarborAPIWithBasePath should have comment or be unexported (golint)
  • Line 30: warning: exported type UsrInfo should have comment or be unexported (golint)
  • Line 35: warning: comment on exported method HarborAPI.SearchGet should be of the form "SearchGet ..." (golint)
  • Line 81: warning: comment on exported method HarborAPI.ProjectsPost should be of the form "ProjectsPost ..." (golint)
  • Line 116: warning: comment on exported method HarborAPI.RepositoriesDelete should be of the form "RepositoriesDelete ..." (golint)

• harbor/src/testing/apitests/apilib/rep_policy_post.go
  • Line 25: warning: exported type RepPolicyPost should have comment or be unexported (golint)

• harbor/src/testing/apitests/apilib/role_param.go
  • Line 25: warning: exported type RoleParam should have comment or be unexported (golint)

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• harbor/src/pkg/notifier/notifier_test.go
  • Line 49: warning: cyclomatic complexity 16 of function TestSubscribeAndUnSubscribe() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/aliacr/adapter.go
  • Line 227: warning: cyclomatic complexity 21 of function (*adapter).FetchArtifacts() is high (> 15) (gocyclo)

• harbor/src/pkg/retention/launcher.go
  • Line 99: warning: cyclomatic complexity 24 of function (*launcher).Launch() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/dockerhub/adapter.go
  • Line 242: warning: cyclomatic complexity 23 of function (*adapter).FetchArtifacts() is high (> 15) (gocyclo)

• harbor/src/jobservice/hook/hook_agent.go
  • Line 195: warning: cyclomatic complexity 16 of function (*basicAgent).isOutdated() is high (> 15) (gocyclo)

• harbor/src/pkg/scan/job.go
  • Line 145: warning: cyclomatic complexity 23 of function (*Job).Run() is high (> 15) (gocyclo)

• harbor/src/controller/member/controller.go
  • Line 117: warning: cyclomatic complexity 22 of function (*controller).Create() is high (> 15) (gocyclo)

• harbor/src/controller/retention/controller.go
  • Line 126: warning: cyclomatic complexity 16 of function (*defaultController).UpdateRetention() is high (> 15) (gocyclo)

• harbor/src/jobservice/job/tracker.go
  • Line 509: warning: cyclomatic complexity 29 of function (*basicTracker).retrieve() is high (> 15) (gocyclo)

• harbor/src/jobservice/mgt/manager.go
  • Line 173: warning: cyclomatic complexity 19 of function (*basicManager).GetPeriodicExecution() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/gitlab/adapter.go
  • Line 84: warning: cyclomatic complexity 19 of function (*adapter).FetchArtifacts() is high (> 15) (gocyclo)

• harbor/src/pkg/retention/policy/alg/or/processor.go
  • Line 63: warning: cyclomatic complexity 20 of function (*processor).Process() is high (> 15) (gocyclo)

• harbor/src/server/middleware/vulnerable/vulnerable.go
  • Line 40: warning: cyclomatic complexity 19 of function Middleware() is high (> 15) (gocyclo)

• harbor/src/server/middleware/security/oidc_cli.go
  • Line 75: warning: cyclomatic complexity 16 of function (*oidcCli).valid() is high (> 15) (gocyclo)

• harbor/src/controller/replication/model/model.go
  • Line 61: warning: cyclomatic complexity 27 of function (*Policy).Validate() is high (> 15) (gocyclo)
  • Line 242: warning: cyclomatic complexity 19 of function parseFilters() is high (> 15) (gocyclo)

• harbor/src/core/main.go
  • Line 102: warning: cyclomatic complexity 25 of function main() is high (> 15) (gocyclo)

• harbor/src/jobservice/job/impl/gc/garbage_collection.go
  • Line 239: warning: cyclomatic complexity 17 of function (*GarbageCollector).sweep() is high (> 15) (gocyclo)

• harbor/src/jobservice/runner/redis.go
  • Line 54: warning: cyclomatic complexity 26 of function (*RedisJob).Run() is high (> 15) (gocyclo)

• harbor/src/lib/config/test/userconfig_test.go
  • Line 39: warning: cyclomatic complexity 36 of function TestConfig() is high (> 15) (gocyclo)

• harbor/src/chartserver/reverse_proxy.go
  • Line 103: warning: cyclomatic complexity 22 of function modifyResponse() is high (> 15) (gocyclo)

• harbor/src/controller/event/handler/webhook/artifact/replication.go
  • Line 76: warning: cyclomatic complexity 17 of function constructReplicationPayload() is high (> 15) (gocyclo)

• harbor/src/controller/artifact/processor/chart/chart.go
  • Line 60: warning: cyclomatic complexity 16 of function (*processor).AbstractAddition() is high (> 15) (gocyclo)

• harbor/src/server/v2.0/handler/registry.go
  • Line 204: warning: cyclomatic complexity 19 of function (*registryAPI).PingRegistry() is high (> 15) (gocyclo)

• harbor/src/controller/artifact/controller.go
  • Line 291: warning: cyclomatic complexity 26 of function (*controller).deleteDeeply() is high (> 15) (gocyclo)

• harbor/src/controller/scan/base_controller.go
  • Line 313: warning: cyclomatic complexity 18 of function (*basicController).startScanAll() is high (> 15) (gocyclo)
  • Line 184: warning: cyclomatic complexity 18 of function (*basicController).Scan() is high (> 15) (gocyclo)
  • Line 572: warning: cyclomatic complexity 17 of function (*basicController).GetScanLog() is high (> 15) (gocyclo)
  • Line 666: warning: cyclomatic complexity 17 of function (*basicController).GetVulnerable() is high (> 15) (gocyclo)

• harbor/src/lib/selector/selectors/doublestar/selector.go
  • Line 53: warning: cyclomatic complexity 18 of function (*selector).Select() is high (> 15) (gocyclo)

• harbor/src/pkg/p2p/preheat/job.go
  • Line 69: warning: cyclomatic complexity 23 of function (*Job).Run() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/artifacthub/chart_registry.go
  • Line 27: warning: cyclomatic complexity 16 of function (*adapter).FetchCharts() is high (> 15) (gocyclo)

• harbor/src/server/v2.0/handler/project.go
  • Line 90: warning: cyclomatic complexity 28 of function (*projectAPI).CreateProject() is high (> 15) (gocyclo)
  • Line 382: warning: cyclomatic complexity 20 of function (*projectAPI).ListProjects() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/dtr/adapter.go
  • Line 136: warning: cyclomatic complexity 18 of function (*adapter).PrepareForPush() is high (> 15) (gocyclo)

• harbor/src/controller/p2p/preheat/enforcer.go
  • Line 245: warning: cyclomatic complexity 18 of function (*defaultEnforcer).PreheatArtifact() is high (> 15) (gocyclo)

• harbor/src/core/controllers/oidc.go
  • Line 74: warning: cyclomatic complexity 16 of function (*OIDCController).Callback() is high (> 15) (gocyclo)

• harbor/src/chartserver/utils.go
  • Line 41: warning: cyclomatic complexity 16 of function parseRedisConfig() is high (> 15) (gocyclo)

• harbor/src/server/registry/tag.go
  • Line 57: warning: cyclomatic complexity 16 of function (*tagHandler).ServeHTTP() is high (> 15) (gocyclo)

• harbor/src/server/v2.0/handler/replication.go
  • Line 251: warning: cyclomatic complexity 16 of function (*replicationAPI).ListReplicationExecutions() is high (> 15) (gocyclo)

• harbor/src/controller/p2p/preheat/controller.go
  • Line 328: warning: cyclomatic complexity 21 of function (*controller).UpdatePolicy() is high (> 15) (gocyclo)

• harbor/src/jobservice/runtime/bootstrap.go
  • Line 81: warning: cyclomatic complexity 16 of function (*Bootstrap).LoadAndRun() is high (> 15) (gocyclo)

• harbor/src/chartserver/utils_test.go
  • Line 10: warning: cyclomatic complexity 21 of function TestParseRedisConfig() is high (> 15) (gocyclo)

• harbor/src/pkg/registry/client.go
  • Line 449: warning: cyclomatic complexity 17 of function (*client).Copy() is high (> 15) (gocyclo)

• harbor/src/pkg/reg/adapter/tencentcr/artifact_registry.go
  • Line 37: warning: cyclomatic complexity 16 of function (*adapter).FetchArtifacts() is high (> 15) (gocyclo)

• harbor/src/server/middleware/quota/quota.go
  • Line 57: warning: cyclomatic complexity 23 of function RequestMiddleware() is high (> 15) (gocyclo)

• harbor/src/server/v2.0/handler/statistic.go
  • Line 45: warning: cyclomatic complexity 17 of function (*statisticAPI).GetStatistic() is high (> 15) (gocyclo)

• harbor/src/jobservice/config/config.go
  • Line 191: warning: cyclomatic complexity 23 of function (*Configuration).loadEnvs() is high (> 15) (gocyclo)
  • Line 281: warning: cyclomatic complexity 20 of function (*Configuration).validate() is high (> 15) (gocyclo)

ineffassign95%

IneffAssign detects ineffectual assignments in Go code.

• harbor/src/jobservice/job/impl/gc/garbage_collection.go
  • Line 366: warning: ineffectual assignment to arts (ineffassign)

• harbor/src/lib/q/builder_test.go
  • Line 77: warning: ineffectual assignment to err (ineffassign)
  • Line 253: warning: ineffectual assignment to keywords (ineffassign)

• harbor/src/pkg/p2p/preheat/dao/instance/dao_test.go
  • Line 63: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/config/config_test.go
  • Line 129: warning: ineffectual assignment to err (ineffassign)
  • Line 130: warning: ineffectual assignment to err (ineffassign)
  • Line 131: warning: ineffectual assignment to err (ineffassign)
  • Line 132: warning: ineffectual assignment to err (ineffassign)
  • Line 133: warning: ineffectual assignment to err (ineffassign)
  • Line 134: warning: ineffectual assignment to err (ineffassign)
  • Line 135: warning: ineffectual assignment to err (ineffassign)
  • Line 136: warning: ineffectual assignment to err (ineffassign)
  • Line 137: warning: ineffectual assignment to err (ineffassign)
  • Line 138: warning: ineffectual assignment to err (ineffassign)
  • Line 145: warning: ineffectual assignment to err (ineffassign)
  • Line 146: warning: ineffectual assignment to err (ineffassign)
  • Line 147: warning: ineffectual assignment to err (ineffassign)
  • Line 148: warning: ineffectual assignment to err (ineffassign)
  • Line 149: warning: ineffectual assignment to err (ineffassign)
  • Line 150: warning: ineffectual assignment to err (ineffassign)
  • Line 151: warning: ineffectual assignment to err (ineffassign)
  • Line 152: warning: ineffectual assignment to err (ineffassign)
  • Line 153: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/job/tracker.go
  • Line 234: warning: ineffectual assignment to err (ineffassign)

• harbor/src/registryctl/api/registry/blob/blob_test.go
  • Line 42: warning: ineffectual assignment to err (ineffassign)

• harbor/src/common/utils/utils_test.go
  • Line 227: warning: ineffectual assignment to id (ineffassign)
  • Line 227: warning: ineffectual assignment to name (ineffassign)

• harbor/src/pkg/retention/launcher_test.go
  • Line 185: warning: ineffectual assignment to n (ineffassign)

• harbor/src/jobservice/logger/entry_test.go
  • Line 20: warning: ineffectual assignment to result (ineffassign)

• harbor/src/controller/replication/execution_test.go
  • Line 71: warning: ineffectual assignment to id (ineffassign)

• harbor/src/controller/event/handler/replication/replication.go
  • Line 66: warning: ineffectual assignment to public (ineffassign)
  • Line 122: warning: ineffectual assignment to public (ineffassign)

• harbor/src/jobservice/core/controller_test.go
  • Line 124: warning: ineffectual assignment to err (ineffassign)

• harbor/src/registryctl/auth/secret_test.go
  • Line 56: warning: ineffectual assignment to req (ineffassign)

• harbor/src/pkg/artifactrash/dao/dao_test.go
  • Line 60: warning: ineffectual assignment to id (ineffassign)

• harbor/src/controller/blob/controller_test.go
  • Line 117: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/migration/migrator_v180.go
  • Line 123: warning: ineffectual assignment to err (ineffassign)
  • Line 137: warning: ineffectual assignment to err (ineffassign)
  • Line 162: warning: ineffectual assignment to err (ineffassign)

• harbor/src/lib/orm/test/orm_test.go
  • Line 145: warning: ineffectual assignment to o (ineffassign)

• harbor/src/pkg/notification/policy/dao/dao_test.go
  • Line 141: warning: ineffectual assignment to err (ineffassign)

• harbor/src/core/api/harborapi_test.go
  • Line 180: warning: ineffectual assignment to err (ineffassign)
  • Line 182: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/reg/adapter/tencentcr/sdk.go
  • Line 72: warning: ineffectual assignment to resp (ineffassign)

• harbor/src/registryctl/api/registry/manifest/manifest_test.go
  • Line 52: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/logger/getter/db_getter_test.go
  • Line 18: warning: ineffectual assignment to result (ineffassign)

• harbor/src/common/http/client.go
  • Line 198: warning: ineffectual assignment to data (ineffassign)

• harbor/src/common/utils/email/mail_test.go
  • Line 29: warning: ineffectual assignment to tls (ineffassign)

• harbor/src/server/v2.0/handler/config.go
  • Line 109: warning: ineffectual assignment to err (ineffassign)

• harbor/src/server/registry/tag.go
  • Line 106: warning: ineffectual assignment to resTags (ineffassign)

• harbor/src/core/auth/ldap/ldap_test.go
  • Line 366: warning: ineffectual assignment to err (ineffassign)
  • Line 409: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/logger/backend/db_logger_test.go
  • Line 20: warning: ineffectual assignment to result (ineffassign)

• harbor/src/pkg/retention/dep/client_test.go
  • Line 88: warning: ineffectual assignment to candidates (ineffassign)

• harbor/src/pkg/task/dao/task.go
  • Line 204: warning: ineffectual assignment to err (ineffassign)

• harbor/src/server/registry/catalog.go
  • Line 76: warning: ineffectual assignment to resRepos (ineffassign)

• harbor/src/server/v2.0/handler/artifact_test.go
  • Line 51: warning: ineffectual assignment to repository (ineffassign)
  • Line 51: warning: ineffectual assignment to reference (ineffassign)
  • Line 56: warning: ineffectual assignment to repository (ineffassign)
  • Line 56: warning: ineffectual assignment to reference (ineffassign)
  • Line 61: warning: ineffectual assignment to repository (ineffassign)
  • Line 61: warning: ineffectual assignment to reference (ineffassign)

• harbor/src/controller/replication/flow/stage_test.go
  • Line 161: warning: ineffectual assignment to result (ineffassign)
  • Line 200: warning: ineffectual assignment to result (ineffassign)

• harbor/src/controller/replication/policy.go
  • Line 74: warning: ineffectual assignment to srcRegistryID (ineffassign)
  • Line 74: warning: ineffectual assignment to destRegistryID (ineffassign)

• harbor/src/common/dao/dao_test.go
  • Line 103: warning: ineffectual assignment to result (ineffassign)

• harbor/src/pkg/scan/job.go
  • Line 177: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/task/task_test.go
  • Line 80: warning: ineffectual assignment to id (ineffassign)

• harbor/src/testing/apitests/apilib/harlogin.go
  • Line 20: warning: ineffectual assignment to err (ineffassign)

• harbor/src/lib/redis/helper.go
  • Line 61: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/notification/job/dao/dao_test.go
  • Line 122: warning: ineffectual assignment to err (ineffassign)
  • Line 143: warning: ineffectual assignment to err (ineffassign)
  • Line 153: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/quota/manager_test.go
  • Line 83: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/replication/dao/dao.go
  • Line 105: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/robot/dao/dao_test.go
  • Line 104: warning: ineffectual assignment to err (ineffassign)
  • Line 148: warning: ineffectual assignment to err (ineffassign)
  • Line 153: warning: ineffectual assignment to err (ineffassign)
  • Line 163: warning: ineffectual assignment to err (ineffassign)

• harbor/src/testing/apitests/apilib/harborapi.go
  • Line 65: warning: ineffectual assignment to err (ineffassign)
  • Line 68: warning: ineffectual assignment to err (ineffassign)
  • Line 106: warning: ineffectual assignment to err (ineffassign)
  • Line 144: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/ldap/filter_test.go
  • Line 33: warning: ineffectual assignment to err (ineffassign)

• harbor/src/core/controllers/oidc.go
  • Line 162: warning: ineffectual assignment to err (ineffassign)

• harbor/src/jobservice/logger/sweeper/db_sweeper_test.go
  • Line 17: warning: ineffectual assignment to result (ineffassign)

• harbor/src/jobservice/period/enqueuer.go
  • Line 272: warning: ineffectual assignment to shouldEnq (ineffassign)

• harbor/src/lib/encrypt/encrypt_test.go
  • Line 27: warning: ineffectual assignment to err (ineffassign)

• harbor/src/common/job/client_test.go
  • Line 70: warning: ineffectual assignment to status (ineffassign)
  • Line 75: warning: ineffectual assignment to status (ineffassign)

• harbor/src/common/dao/resource_label_test.go
  • Line 81: warning: ineffectual assignment to id (ineffassign)
  • Line 90: warning: ineffectual assignment to id (ineffassign)

• harbor/src/pkg/scan/postprocessors/report_converters_test.go
  • Line 410: warning: ineffectual assignment to err (ineffassign)

• harbor/src/pkg/audit/dao/dao_test.go
  • Line 70: warning: ineffectual assignment to audits (ineffassign)

• harbor/src/controller/proxy/local_test.go
  • Line 106: warning: ineffectual assignment to ct (ineffassign)

• harbor/src/pkg/scheduler/scheduler_test.go
  • Line 56: warning: ineffectual assignment to id (ineffassign)
  • Line 60: warning: ineffectual assignment to id (ineffassign)
  • Line 64: warning: ineffectual assignment to id (ineffassign)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!