Preparing report...

Report for github.com/gojekfarm/darkroom-operator

A+    Excellent!    Found 25 issues across 42 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo97%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint40%

Golint is a linter for Go source code.

    • darkroom-operator/internal/version/version.go
    • Line 4: warning: exported const Product should have comment (or a comment on this block) or be unexported (golint)
    • Line 14: warning: exported type BuildInfo should have comment or be unexported (golint)
    • Line 22: warning: exported var Build should have comment or be unexported (golint)
    • darkroom-operator/internal/testhelper/mocks/client.go
    • Line 13: warning: exported type MockClient should have comment or be unexported (golint)
    • Line 18: warning: exported method MockClient.Get should have comment or be unexported (golint)
    • Line 22: warning: exported method MockClient.List should have comment or be unexported (golint)
    • Line 26: warning: exported method MockClient.Create should have comment or be unexported (golint)
    • Line 30: warning: exported method MockClient.Delete should have comment or be unexported (golint)
    • Line 34: warning: exported method MockClient.Update should have comment or be unexported (golint)
    • Line 38: warning: exported method MockClient.Patch should have comment or be unexported (golint)
    • Line 42: warning: exported method MockClient.DeleteAllOf should have comment or be unexported (golint)
    • Line 46: warning: exported method MockClient.Status should have comment or be unexported (golint)
    • Line 50: warning: exported method MockClient.Scheme should have comment or be unexported (golint)
    • Line 54: warning: exported method MockClient.RESTMapper should have comment or be unexported (golint)
    • darkroom-operator/pkg/api/v1alpha1/darkroom_validation.go
    • Line 10: warning: exported method Darkroom.Default should have comment or be unexported (golint)
    • Line 18: warning: exported method Darkroom.ValidateCreate should have comment or be unexported (golint)
    • Line 43: warning: exported method Darkroom.ValidateUpdate should have comment or be unexported (golint)
    • Line 48: warning: exported method Darkroom.ValidateDelete should have comment or be unexported (golint)
    • darkroom-operator/internal/controllers/darkroom_controller.go
    • Line 56: warning: exported method DarkroomReconciler.Reconcile should have comment or be unexported (golint)
    • Line 81: warning: exported method DarkroomReconciler.SetupControllerWithManager should have comment or be unexported (golint)
    • Line 90: warning: exported method DarkroomReconciler.SetupWebhookWithManager should have comment or be unexported (golint)
    • darkroom-operator/internal/api-server/manager.go
    • Line 22: warning: exported type NewManagerFunc should have comment or be unexported (golint)
    • Line 24: warning: exported type NewManagerFuncOptions should have comment or be unexported (golint)
    • Line 30: warning: exported type Options should have comment or be unexported (golint)
    • Line 39: warning: exported type Manager should have comment or be unexported (golint)
    • Line 56: warning: exported function NewManager should have comment or be unexported (golint)
    • darkroom-operator/pkg/api/v1alpha1/darkroom_types.go
    • Line 32: warning: comment on exported type Type should be of the form "Type ..." (with optional leading article) (golint)
    • Line 35: warning: exported type DeployState should have comment or be unexported (golint)
    • Line 38: warning: exported const Deploying should have comment (or a comment on this block) or be unexported (golint)
    • Line 41: warning: exported type Source should have comment or be unexported (golint)
    • darkroom-operator/internal/testhelper/environment.go
    • Line 31: warning: exported type WaitOption should have comment or be unexported (golint)
    • Line 35: warning: exported type Environment should have comment or be unexported (golint)
    • Line 46: warning: exported type WebhookWaitOption should have comment or be unexported (golint)
    • Line 48: warning: exported method WebhookWaitOption.Apply should have comment or be unexported (golint)
    • Line 52: warning: exported type WorkerWaitOption should have comment or be unexported (golint)
    • Line 54: warning: exported method WorkerWaitOption.Apply should have comment or be unexported (golint)
    • Line 170: warning: exported function NewTestEnvironment should have comment or be unexported (golint)
    • Line 202: warning: exported function FreePort should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!