Report for github.com/ihexxa/quickshare
A Great! Found 25 issues across 29 files
gofmt93%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
quickshare/src/kvstore/memstore/provider.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
quickshare/src/server/server_files_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo93%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
quickshare/src/kvstore/test/provider_test.go
- Line 14: warning: cyclomatic complexity 45 of function TestKVStoreProviders() is high (> 15) (gocyclo)
-
-
quickshare/src/server/server_files_test.go
- Line 20: warning: cyclomatic complexity 120 of function TestFileHandlers() is high (> 15) (gocyclo)
golint20%
Golint is a linter for Go source code.
-
-
quickshare/src/handlers/settings/handler.go
- Line 11: warning: exported type SettingsSvc should have comment or be unexported (golint)
- Line 16: warning: exported function NewSettingsSvc should have comment or be unexported (golint)
- Line 23: warning: exported method SettingsSvc.Health should have comment or be unexported (golint)
-
-
quickshare/src/idgen/idgen_interface.go
- Line 3: warning: exported type IIDGen should have comment or be unexported (golint)
-
-
quickshare/src/handlers/util.go
- Line 74: warning: exported type MsgResp should have comment or be unexported (golint)
- Line 78: warning: exported function NewMsgResp should have comment or be unexported (golint)
- Line 87: warning: exported function Resp should have comment or be unexported (golint)
- Line 96: warning: exported function ErrResp should have comment or be unexported (golint)
-
-
quickshare/src/idgen/simpleidgen/simple_id_gen.go
- Line 11: warning: exported type SimpleIDGen should have comment or be unexported (golint)
- Line 13: warning: exported function New should have comment or be unexported (golint)
- Line 17: warning: exported method SimpleIDGen.Gen should have comment or be unexported (golint)
-
-
quickshare/src/fs/fs_interface.go
- Line 8: warning: exported type ReadCloseSeeker should have comment or be unexported (golint)
- Line 15: warning: exported type ISimpleFS should have comment or be unexported (golint)
-
-
quickshare/src/kvstore/boltdbpvd/provider.go
- Line 17: warning: exported var ErrBucketNotFound should have comment or be unexported (golint)
- Line 20: warning: exported type BoltPvd should have comment or be unexported (golint)
- Line 26: warning: exported function New should have comment or be unexported (golint)
- Line 57: warning: exported method BoltPvd.AddNamespace should have comment or be unexported (golint)
- Line 69: warning: exported method BoltPvd.DelNamespace should have comment or be unexported (golint)
- Line 75: warning: exported method BoltPvd.Close should have comment or be unexported (golint)
- Line 79: warning: exported method BoltPvd.GetBool should have comment or be unexported (golint)
- Line 94: warning: exported method BoltPvd.SetBool should have comment or be unexported (golint)
- Line 105: warning: exported method BoltPvd.DelBool should have comment or be unexported (golint)
- Line 112: warning: exported method BoltPvd.GetInt should have comment or be unexported (golint)
- Line 117: warning: exported method BoltPvd.SetInt should have comment or be unexported (golint)
- Line 121: warning: exported method BoltPvd.DelInt should have comment or be unexported (golint)
- Line 125: warning: exported method BoltPvd.GetInt64 should have comment or be unexported (golint)
- Line 129: warning: exported method BoltPvd.GetInt64In should have comment or be unexported (golint)
- Line 154: warning: exported method BoltPvd.SetInt64 should have comment or be unexported (golint)
- Line 158: warning: exported method BoltPvd.SetInt64In should have comment or be unexported (golint)
- Line 171: warning: exported method BoltPvd.DelInt64 should have comment or be unexported (golint)
- Line 175: warning: exported method BoltPvd.DelInt64In should have comment or be unexported (golint)
- Line 185: warning: exported method BoltPvd.ListInt64sIn should have comment or be unexported (golint)
- Line 217: warning: exported method BoltPvd.GetFloat should have comment or be unexported (golint)
- Line 232: warning: exported method BoltPvd.SetFloat should have comment or be unexported (golint)
- Line 238: warning: exported method BoltPvd.DelFloat should have comment or be unexported (golint)
- Line 245: warning: exported method BoltPvd.GetString should have comment or be unexported (golint)
- Line 257: warning: exported method BoltPvd.SetString should have comment or be unexported (golint)
- Line 268: warning: exported method BoltPvd.DelString should have comment or be unexported (golint)
- Line 272: warning: exported method BoltPvd.DelStringIn should have comment or be unexported (golint)
- Line 282: warning: exported method BoltPvd.TryLock should have comment or be unexported (golint)
- Line 292: warning: exported method BoltPvd.Unlock should have comment or be unexported (golint)
- Line 302: warning: exported method BoltPvd.GetStringIn should have comment or be unexported (golint)
- Line 319: warning: exported method BoltPvd.SetStringIn should have comment or be unexported (golint)
- Line 334: warning: exported method BoltPvd.ListStringsIn should have comment or be unexported (golint)
-
-
quickshare/src/kvstore/kvstore_interface.go
- Line 5: warning: exported var ErrLocked should have comment or be unexported (golint)
- Line 6: warning: exported var ErrNoLock should have comment or be unexported (golint)
- Line 8: warning: exported type IKVStore should have comment or be unexported (golint)
-
-
quickshare/src/cryptoutil/jwt/jwt.go
- Line 9: warning: exported type JWTEncDec should have comment or be unexported (golint)
- Line 13: warning: exported function NewJWTEncDec should have comment or be unexported (golint)
- Line 19: warning: exported method JWTEncDec.FromToken should have comment or be unexported (golint)
- Line 40: warning: exported method JWTEncDec.ToToken should have comment or be unexported (golint)
-
-
quickshare/src/handlers/singleuserhdr/middlewares.go
- Line 21: warning: exported function IsPublicPath should have comment or be unexported (golint)
- Line 25: warning: exported function GetHandlerName should have comment or be unexported (golint)
- Line 33: warning: exported method SimpleUserHandlers.Auth should have comment or be unexported (golint)
-
-
quickshare/src/client/utils.go
- Line 5: warning: exported function GetCookie should have comment or be unexported (golint)
-
-
quickshare/src/depidx/deps.go
- Line 13: warning: exported type IUploader should have comment or be unexported (golint)
- Line 21: warning: exported type Deps should have comment or be unexported (golint)
- Line 30: warning: exported function NewDeps should have comment or be unexported (golint)
- Line 34: warning: exported method Deps.FS should have comment or be unexported (golint)
- Line 38: warning: exported method Deps.SetFS should have comment or be unexported (golint)
- Line 42: warning: exported method Deps.Token should have comment or be unexported (golint)
- Line 46: warning: exported method Deps.SetToken should have comment or be unexported (golint)
- Line 50: warning: exported method Deps.KV should have comment or be unexported (golint)
- Line 54: warning: exported method Deps.SetKV should have comment or be unexported (golint)
- Line 58: warning: exported method Deps.ID should have comment or be unexported (golint)
- Line 62: warning: exported method Deps.SetID should have comment or be unexported (golint)
- Line 66: warning: exported method Deps.Log should have comment or be unexported (golint)
- Line 70: warning: exported method Deps.SetLog should have comment or be unexported (golint)
-
-
quickshare/src/handlers/singleuserhdr/handlers.go
- Line 17: warning: exported var ErrInvalidUser should have comment or be unexported (golint)
- Line 33: warning: exported type SimpleUserHandlers should have comment or be unexported (golint)
- Line 38: warning: exported function NewSimpleUserHandlers should have comment or be unexported (golint)
- Line 56: warning: exported method SimpleUserHandlers.IsInited should have comment or be unexported (golint)
- Line 61: warning: exported method SimpleUserHandlers.Init should have comment or be unexported (golint)
- Line 87: warning: exported type LoginReq should have comment or be unexported (golint)
- Line 101: warning: exported method SimpleUserHandlers.Login should have comment or be unexported (golint)
- Line 136: warning: exported type LogoutReq should have comment or be unexported (golint)
- Line 139: warning: exported method SimpleUserHandlers.Logout should have comment or be unexported (golint)
- Line 147: warning: exported method SimpleUserHandlers.IsAuthed should have comment or be unexported (golint)
- Line 152: warning: exported type SetPwdReq should have comment or be unexported (golint)
- Line 157: warning: exported method SimpleUserHandlers.SetPwd should have comment or be unexported (golint)
-
-
quickshare/src/client/singleuser.go
- Line 11: warning: exported type SingleUserClient should have comment or be unexported (golint)
- Line 16: warning: exported function NewSingleUserClient should have comment or be unexported (golint)
- Line 28: warning: exported method SingleUserClient.Login should have comment or be unexported (golint)
- Line 37: warning: exported method SingleUserClient.Logout should have comment or be unexported (golint)
- Line 43: warning: exported method SingleUserClient.SetPwd should have comment or be unexported (golint)
-
-
quickshare/src/server/config.go
- Line 5: warning: exported type FSConfig should have comment or be unexported (golint)
- Line 11: warning: exported type UsersCfg should have comment or be unexported (golint)
- Line 20: warning: exported type Secrets should have comment or be unexported (golint)
- Line 24: warning: exported type ServerCfg should have comment or be unexported (golint)
- Line 34: warning: exported type Config should have comment or be unexported (golint)
- Line 41: warning: exported function NewConfig should have comment or be unexported (golint)
- Line 45: warning: exported function DefaultConfig should have comment or be unexported (golint)
-
-
quickshare/src/kvstore/memstore/provider.go
- Line 10: warning: exported type MemStore should have comment or be unexported (golint)
- Line 25: warning: exported function New should have comment or be unexported (golint)
- Line 42: warning: exported method MemStore.GetBool should have comment or be unexported (golint)
- Line 49: warning: exported method MemStore.SetBool should have comment or be unexported (golint)
- Line 56: warning: exported method MemStore.GetInt should have comment or be unexported (golint)
- Line 63: warning: exported method MemStore.SetInt should have comment or be unexported (golint)
- Line 70: warning: exported method MemStore.GetInt64 should have comment or be unexported (golint)
- Line 77: warning: exported method MemStore.SetInt64 should have comment or be unexported (golint)
- Line 84: warning: exported method MemStore.GetFloat should have comment or be unexported (golint)
- Line 91: warning: exported method MemStore.SetFloat should have comment or be unexported (golint)
- Line 98: warning: exported method MemStore.GetString should have comment or be unexported (golint)
- Line 105: warning: exported method MemStore.SetString should have comment or be unexported (golint)
- Line 112: warning: exported method MemStore.DelBool should have comment or be unexported (golint)
- Line 119: warning: exported method MemStore.DelInt should have comment or be unexported (golint)
- Line 126: warning: exported method MemStore.DelInt64 should have comment or be unexported (golint)
- Line 133: warning: exported method MemStore.DelFloat should have comment or be unexported (golint)
- Line 140: warning: exported method MemStore.DelString should have comment or be unexported (golint)
- Line 147: warning: exported method MemStore.TryLock should have comment or be unexported (golint)
- Line 158: warning: exported method MemStore.Unlock should have comment or be unexported (golint)
- Line 169: warning: exported method MemStore.AddNamespace should have comment or be unexported (golint)
- Line 173: warning: exported method MemStore.GetInt64In should have comment or be unexported (golint)
- Line 177: warning: exported method MemStore.SetInt64In should have comment or be unexported (golint)
- Line 181: warning: exported method MemStore.ListInt64sIn should have comment or be unexported (golint)
- Line 185: warning: exported method MemStore.GetStringIn should have comment or be unexported (golint)
- Line 189: warning: exported method MemStore.SetStringIn should have comment or be unexported (golint)
- Line 193: warning: exported method MemStore.ListStringsIn should have comment or be unexported (golint)
-
-
quickshare/src/downloadmgr/mgr.go
- Line 3: warning: exported type DownloadMgr should have comment or be unexported (golint)
- Line 5: warning: exported function NewDownloadMgr should have comment or be unexported (golint)
-
-
quickshare/src/fs/local/fs.go
- Line 17: warning: exported var ErrTooManyOpens should have comment or be unexported (golint)
- Line 19: warning: exported type LocalFS should have comment or be unexported (golint)
- Line 36: warning: exported function NewLocalFS should have comment or be unexported (golint)
- Line 54: warning: exported method LocalFS.Root should have comment or be unexported (golint)
- Line 87: warning: exported method LocalFS.Sync should have comment or be unexported (golint)
- Line 101: warning: exported method LocalFS.Create should have comment or be unexported (golint)
- Line 129: warning: exported method LocalFS.MkdirAll should have comment or be unexported (golint)
- Line 137: warning: exported method LocalFS.Remove should have comment or be unexported (golint)
- Line 145: warning: exported method LocalFS.Rename should have comment or be unexported (golint)
- Line 171: warning: exported method LocalFS.ReadAt should have comment or be unexported (golint)
- Line 217: warning: exported method LocalFS.WriteAt should have comment or be unexported (golint)
- Line 263: warning: exported method LocalFS.Stat should have comment or be unexported (golint)
- Line 278: warning: exported method LocalFS.Close should have comment or be unexported (golint)
- Line 298: warning: comment on exported method LocalFS.GetFileReader should be of the form "GetFileReader ..." (golint)
- Line 317: warning: exported method LocalFS.ListDir should have comment or be unexported (golint)
-
-
quickshare/src/client/files.go
- Line 12: warning: exported type FilesClient should have comment or be unexported (golint)
- Line 17: warning: exported function NewFilesClient should have comment or be unexported (golint)
- Line 29: warning: exported method FilesClient.Create should have comment or be unexported (golint)
- Line 38: warning: exported method FilesClient.Delete should have comment or be unexported (golint)
- Line 44: warning: exported method FilesClient.Metadata should have comment or be unexported (golint)
- Line 58: warning: exported method FilesClient.Mkdir should have comment or be unexported (golint)
- Line 64: warning: exported method FilesClient.Move should have comment or be unexported (golint)
- Line 73: warning: exported method FilesClient.UploadChunk should have comment or be unexported (golint)
- Line 83: warning: exported method FilesClient.UploadStatus should have comment or be unexported (golint)
- Line 97: warning: exported method FilesClient.Download should have comment or be unexported (golint)
- Line 106: warning: exported method FilesClient.List should have comment or be unexported (golint)
- Line 122: warning: exported method FilesClient.ListUploadings should have comment or be unexported (golint)
- Line 137: warning: exported method FilesClient.DelUploading should have comment or be unexported (golint)
-
-
quickshare/src/client/settings.go
- Line 10: warning: exported type SettingsClient should have comment or be unexported (golint)
- Line 15: warning: exported function NewSettingsClient should have comment or be unexported (golint)
- Line 27: warning: exported method SettingsClient.Health should have comment or be unexported (golint)
-
-
quickshare/src/handlers/fileshdr/handlers.go
- Line 25: warning: comment on exported var UploadDir should be of the form "UploadDir ..." (golint)
- Line 27: warning: exported var FsDir should have comment or be unexported (golint)
- Line 29: warning: comment on exported var FilePathQuery should be of the form "FilePathQuery ..." (golint)
- Line 41: warning: exported type FileHandlers should have comment or be unexported (golint)
- Line 47: warning: exported function NewFileHandlers should have comment or be unexported (golint)
- Line 64: warning: exported type AutoLocker should have comment or be unexported (golint)
- Line 70: warning: exported method FileHandlers.NewAutoLocker should have comment or be unexported (golint)
- Line 78: warning: exported method AutoLocker.Exec should have comment or be unexported (golint)
- Line 104: warning: exported type CreateReq should have comment or be unexported (golint)
- Line 109: warning: exported method FileHandlers.Create should have comment or be unexported (golint)
- Line 146: warning: exported method FileHandlers.Delete should have comment or be unexported (golint)
- Line 163: warning: exported type MetadataResp should have comment or be unexported (golint)
- Line 170: warning: exported method FileHandlers.Metadata should have comment or be unexported (golint)
- Line 192: warning: exported type MkdirReq should have comment or be unexported (golint)
- Line 196: warning: exported method FileHandlers.Mkdir should have comment or be unexported (golint)
- Line 213: warning: exported type MoveReq should have comment or be unexported (golint)
- Line 218: warning: exported method FileHandlers.Move should have comment or be unexported (golint)
- Line 251: warning: exported type UploadChunkReq should have comment or be unexported (golint)
- Line 257: warning: exported method FileHandlers.UploadChunk should have comment or be unexported (golint)
- Line 349: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
- Line 358: warning: exported type UploadStatusResp should have comment or be unexported (golint)
- Line 365: warning: exported method FileHandlers.UploadStatus should have comment or be unexported (golint)
- Line 394: warning: comment on exported method FileHandlers.Download should be of the form "Download ..." (golint)
- Line 465: warning: exported type ListResp should have comment or be unexported (golint)
- Line 469: warning: exported method FileHandlers.List should have comment or be unexported (golint)
- Line 495: warning: exported method FileHandlers.Copy should have comment or be unexported (golint)
- Line 499: warning: exported method FileHandlers.CopyDir should have comment or be unexported (golint)
- Line 511: warning: exported method FileHandlers.FsPath should have comment or be unexported (golint)
- Line 515: warning: exported type ListUploadingsResp should have comment or be unexported (golint)
- Line 519: warning: exported method FileHandlers.ListUploadings should have comment or be unexported (golint)
- Line 530: warning: exported method FileHandlers.DelUploading should have comment or be unexported (golint)
-
-
quickshare/src/handlers/fileshdr/upload_mgr.go
- Line 12: warning: exported var ErrCreateExisting should have comment or be unexported (golint)
- Line 19: warning: exported type UploadInfo should have comment or be unexported (golint)
- Line 25: warning: exported type UploadMgr should have comment or be unexported (golint)
- Line 29: warning: exported function UploadNS should have comment or be unexported (golint)
- Line 33: warning: exported function NewUploadMgr should have comment or be unexported (golint)
- Line 39: warning: exported method UploadMgr.AddInfo should have comment or be unexported (golint)
- Line 64: warning: exported method UploadMgr.SetInfo should have comment or be unexported (golint)
- Line 84: warning: exported method UploadMgr.GetInfo should have comment or be unexported (golint)
- Line 100: warning: exported method UploadMgr.DelInfo should have comment or be unexported (golint)
- Line 104: warning: exported method UploadMgr.ListInfo should have comment or be unexported (golint)
-
-
quickshare/src/server/server.go
- Line 33: warning: exported type Server should have comment or be unexported (golint)
- Line 39: warning: exported function NewServer should have comment or be unexported (golint)
- Line 213: warning: exported method Server.Start should have comment or be unexported (golint)
- Line 231: warning: exported method Server.Shutdown should have comment or be unexported (golint)
-
-
quickshare/src/cryptoutil/cryptoutil_interface.go
- Line 3: warning: exported type ITokenEncDec should have comment or be unexported (golint)
ineffassign96%
IneffAssign detects ineffectual assignments in Go code.
-
-
quickshare/src/server/server.go
- Line 133: warning: ineffectual assignment to adminPwd (ineffassign)