Preparing report...

Report for github.com/inexio/thola

A+    Excellent!    Found 57 issues across 140 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo81%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • thola/internal/communicator/deviceclass/device_class.go
    • Line 1201: warning: cyclomatic complexity 77 of function interfaceSlice2propertyOperators() is high (> 15) (gocyclo)
    • Line 1097: warning: cyclomatic complexity 29 of function interface2propertyReader() is high (> 15) (gocyclo)
    • Line 982: warning: cyclomatic complexity 27 of function interface2condition() is high (> 15) (gocyclo)
    • Line 689: warning: cyclomatic complexity 24 of function (*yamlComponentsUPSProperties).convert() is high (> 15) (gocyclo)
    • Line 845: warning: cyclomatic complexity 20 of function (*yamlComponentsSBCProperties).convert() is high (> 15) (gocyclo)
    • Line 466: warning: cyclomatic complexity 17 of function (*yamlDeviceClassComponents).convert() is high (> 15) (gocyclo)
    • thola/cmd/check.go
    • Line 68: warning: cyclomatic complexity 18 of function generateCheckThresholds() is high (> 15) (gocyclo)

golint76%

Golint is a linter for Go source code.

    • thola/internal/request/read_interfaces_request.go
    • Line 7: warning: comment on exported type ReadInterfacesRequest should be of the form "ReadInterfacesRequest ..." (with optional leading article) (golint)
    • Line 16: warning: comment on exported type ReadInterfacesResponse should be of the form "ReadInterfacesResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_server_request.go
    • Line 5: warning: comment on exported type ReadServerRequest should be of the form "ReadServerRequest ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ReadServerResponse should be of the form "ReadServerResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_disk_request.go
    • Line 5: warning: comment on exported type ReadDiskRequest should be of the form "ReadDiskRequest ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ReadDiskResponse should be of the form "ReadDiskResponse ..." (with optional leading article) (golint)
    • thola/internal/request/check_identify_request.go
    • Line 7: warning: comment on exported type CheckIdentifyRequest should be of the form "CheckIdentifyRequest ..." (with optional leading article) (golint)
    • Line 24: warning: comment on exported type CheckIdentifyResponse should be of the form "CheckIdentifyResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_count_interfaces_request.go
    • Line 3: warning: comment on exported type ReadCountInterfacesRequest should be of the form "ReadCountInterfacesRequest ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ReadCountInterfacesResponse should be of the form "ReadCountInterfacesResponse ..." (with optional leading article) (golint)
    • thola/internal/device/device.go
    • Line 26: warning: comment on exported type Device should be of the form "Device ..." (with optional leading article) (golint)
    • Line 41: warning: comment on exported type Properties should be of the form "Properties ..." (with optional leading article) (golint)
    • Line 69: warning: comment on exported type Interface should be of the form "Interface ..." (with optional leading article) (golint)
    • Line 135: warning: comment on exported type EthernetLikeInterface should be of the form "EthernetLikeInterface ..." (with optional leading article) (golint)
    • Line 161: warning: comment on exported type RadioInterface should be of the form "RadioInterface ..." (with optional leading article) (golint)
    • Line 173: warning: comment on exported type DWDMInterface should be of the form "DWDMInterface ..." (with optional leading article) (golint)
    • Line 186: warning: comment on exported type OpticalTransponderInterface should be of the form "OpticalTransponderInterface ..." (with optional leading article) (golint)
    • Line 200: warning: comment on exported type OpticalAmplifierInterface should be of the form "OpticalAmplifierInterface ..." (with optional leading article) (golint)
    • Line 213: warning: comment on exported type OpticalOPMInterface should be of the form "OpticalOPMInterface ..." (with optional leading article) (golint)
    • Line 225: warning: comment on exported type OpticalChannel should be of the form "OpticalChannel ..." (with optional leading article) (golint)
    • Line 236: warning: comment on exported type SAPInterface should be of the form "SAPInterface ..." (with optional leading article) (golint)
    • Line 246: warning: comment on exported type VLANInformation should be of the form "VLANInformation ..." (with optional leading article) (golint)
    • Line 255: warning: comment on exported type VLAN should be of the form "VLAN ..." (with optional leading article) (golint)
    • Line 269: warning: comment on exported type CPUComponent should be of the form "CPUComponent ..." (with optional leading article) (golint)
    • Line 279: warning: comment on exported type DiskComponent should be of the form "DiskComponent ..." (with optional leading article) (golint)
    • Line 288: warning: comment on exported type DiskComponentStorage should be of the form "DiskComponentStorage ..." (with optional leading article) (golint)
    • Line 300: warning: comment on exported type UPSComponent should be of the form "UPSComponent ..." (with optional leading article) (golint)
    • Line 319: warning: comment on exported type ServerComponent should be of the form "ServerComponent ..." (with optional leading article) (golint)
    • Line 329: warning: comment on exported type SBCComponent should be of the form "SBCComponent ..." (with optional leading article) (golint)
    • Line 346: warning: comment on exported type SBCComponentAgent should be of the form "SBCComponentAgent ..." (with optional leading article) (golint)
    • Line 361: warning: comment on exported type SBCComponentRealm should be of the form "SBCComponentRealm ..." (with optional leading article) (golint)
    • Line 377: warning: comment on exported type HardwareHealthComponent should be of the form "HardwareHealthComponent ..." (with optional leading article) (golint)
    • Line 388: warning: comment on exported type HardwareHealthComponentFan should be of the form "HardwareHealthComponentFan ..." (with optional leading article) (golint)
    • Line 398: warning: comment on exported type HardwareHealthComponentPowerSupply should be of the form "HardwareHealthComponentPowerSupply ..." (with optional leading article) (golint)
    • Line 408: warning: comment on exported type Rate should be of the form "Rate ..." (with optional leading article) (golint)
    • thola/internal/network/connection_data.go
    • Line 3: warning: comment on exported type ConnectionData should be of the form "ConnectionData ..." (with optional leading article) (golint)
    • Line 15: warning: comment on exported type SNMPConnectionData should be of the form "SNMPConnectionData ..." (with optional leading article) (golint)
    • Line 53: warning: comment on exported type SNMPv3ConnectionData should be of the form "SNMPv3ConnectionData ..." (with optional leading article) (golint)
    • Line 98: warning: comment on exported type HTTPConnectionData should be of the form "HTTPConnectionData ..." (with optional leading article) (golint)
    • thola/internal/request/base_request.go
    • Line 26: warning: comment on exported type DeviceData should be of the form "DeviceData ..." (with optional leading article) (golint)
    • Line 370: warning: comment on exported type BaseResponse should be of the form "BaseResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_available_components.go
    • Line 3: warning: comment on exported type ReadAvailableComponentsRequest should be of the form "ReadAvailableComponentsRequest ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ReadAvailableComponentsResponse should be of the form "ReadAvailableComponentsResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_memory_usage.go
    • Line 3: warning: comment on exported type ReadMemoryUsageRequest should be of the form "ReadMemoryUsageRequest ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ReadMemoryUsageResponse should be of the form "ReadMemoryUsageResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_hardware_health_request.go
    • Line 5: warning: comment on exported type ReadHardwareHealthRequest should be of the form "ReadHardwareHealthRequest ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ReadHardwareHealthResponse should be of the form "ReadHardwareHealthResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_cpu_load.go
    • Line 3: warning: comment on exported type ReadCPULoadRequest should be of the form "ReadCPULoadRequest ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ReadCPULoadResponse should be of the form "ReadCPULoadResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_request.go
    • Line 3: warning: comment on exported type ReadRequest should be of the form "ReadRequest ..." (with optional leading article) (golint)
    • Line 12: warning: comment on exported type ReadResponse should be of the form "ReadResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_sbc_request.go
    • Line 5: warning: comment on exported type ReadSBCRequest should be of the form "ReadSBCRequest ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ReadSBCResponse should be of the form "ReadSBCResponse ..." (with optional leading article) (golint)
    • thola/internal/request/read_ups_request.go
    • Line 5: warning: comment on exported type ReadUPSRequest should be of the form "ReadUPSRequest ..." (with optional leading article) (golint)
    • Line 14: warning: comment on exported type ReadUPSResponse should be of the form "ReadUPSResponse ..." (with optional leading article) (golint)
    • thola/internal/request/check_request.go
    • Line 7: warning: comment on exported type CheckRequest should be of the form "CheckRequest ..." (with optional leading article) (golint)
    • Line 30: warning: comment on exported type CheckResponse should be of the form "CheckResponse ..." (with optional leading article) (golint)
    • thola/internal/request/identify_request.go
    • Line 7: warning: comment on exported type IdentifyRequest should be of the form "IdentifyRequest ..." (with optional leading article) (golint)
    • Line 16: warning: comment on exported type IdentifyResponse should be of the form "IdentifyResponse ..." (with optional leading article) (golint)
    • thola/internal/request/check_snmp_request.go
    • Line 8: warning: comment on exported type CheckSNMPRequest should be of the form "CheckSNMPRequest ..." (with optional leading article) (golint)
    • Line 23: warning: comment on exported type CheckSNMPResponse should be of the form "CheckSNMPResponse ..." (with optional leading article) (golint)

ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!