Preparing report...

Report for github.com/irisnet/irishub

A+    Excellent!    Found 46 issues across 89 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • irishub/app/export.go
    • Line 54: warning: cyclomatic complexity 17 of function (*IrisApp).prepForZeroHeightGenesis() is high (> 15) (gocyclo)

golint73%

Golint is a linter for Go source code.

    • irishub/migrate/htlc/keys.go
    • Line 22: warning: comment on exported var HTLCKey should be of the form "HTLCKey ..." (golint)
    • Line 24: warning: exported var HTLCExpiredQueueKey should have comment or be unexported (golint)
    • irishub/app/genesis.go
    • Line 7: warning: comment on exported type GenesisState should be of the form "GenesisState ..." (with optional leading article) (golint)
    • irishub/modules/guardian/types/msgs.go
    • Line 9: warning: exported const TypeMsgAddSuper should have comment (or a comment on this block) or be unexported (golint)
    • Line 93: warning: comment on exported method MsgDeleteSuper.ValidateBasic should be of the form "ValidateBasic ..." (golint)
    • irishub/modules/mint/types/expected_keepers.go
    • Line 8: warning: comment on exported type AccountKeeper should be of the form "AccountKeeper ..." (with optional leading article) (golint)
    • Line 17: warning: comment on exported type BankKeeper should be of the form "BankKeeper ..." (with optional leading article) (golint)
    • irishub/simapp/test_helpers.go
    • Line 89: warning: exported function NewConfig should have comment or be unexported (golint)
    • Line 101: warning: exported function SimAppConstructor should have comment or be unexported (golint)
    • Line 220: warning: exported type GenerateAccountStrategy should have comment or be unexported (golint)
    • Line 280: warning: comment on exported function AddTestAddrsIncremental should be of the form "AddTestAddrsIncremental ..." (golint)
    • Line 321: warning: exported function TestAddr should have comment or be unexported (golint)
    • irishub/simapp/genesis.go
    • Line 9: warning: comment on exported type GenesisState should be of the form "GenesisState ..." (with optional leading article) (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign74%

IneffAssign detects ineffectual assignments in Go code.

    • /home/shawn/mygo/src/github.com/gojp/goreportcard/_repos/src/github.com/irisnet/irishub/lite/swagger.go
    • Line 11: warning: no required module provides package github.com/irisnet/irishub/lite/statik; to add it: (ineffassign)
    • Line 4: warning: could not import net/http (no metadata for net/http) (ineffassign)
    • Line 6: warning: could not import github.com/gorilla/mux (no metadata for github.com/gorilla/mux) (ineffassign)
    • Line 7: warning: could not import github.com/rakyll/statik/fs (no metadata for github.com/rakyll/statik/fs) (ineffassign)
    • Line 9: warning: could not import github.com/cosmos/cosmos-sdk/client (no metadata for github.com/cosmos/cosmos-sdk/client) (ineffassign)
    • Line 11: warning: could not import github.com/irisnet/irishub/lite/statik (no metadata for github.com/irisnet/irishub/lite/statik) (ineffassign)
    • irishub/lite/swagger.go
    • Line 11: warning: no required module provides package github.com/irisnet/irishub/lite/statik; to add it: (ineffassign)
    • Line 11: warning: could not import github.com/irisnet/irishub/lite/statik (invalid package name: "") (ineffassign)
    • irishub/modules/guardian/types/types.go
    • Line 12: warning: undeclared name: AccountType (ineffassign)
    • Line 12: warning: undeclared name: Super (ineffassign)
    • Line 22: warning: undeclared name: Super (ineffassign)
    • Line 22: warning: undeclared name: Super (ineffassign)
    • Line 30: warning: undeclared name: AccountType (ineffassign)
    • Line 42: warning: undeclared name: AccountType (ineffassign)
    • Line 51: warning: undeclared name: AccountType (ineffassign)
    • Line 56: warning: undeclared name: AccountType (ineffassign)
    • Line 62: warning: undeclared name: AccountType (ineffassign)
    • Line 13: warning: undeclared name: Super (ineffassign)
    • Line 33: warning: undeclared name: Genesis (ineffassign)
    • Line 35: warning: undeclared name: Ordinary (ineffassign)
    • Line 37: warning: undeclared name: AccountType (ineffassign)
    • Line 43: warning: undeclared name: Genesis (ineffassign)
    • Line 44: warning: undeclared name: Ordinary (ineffassign)
    • Line 57: warning: undeclared name: AccountType (ineffassign)
    • Line 12: warning: undeclared name: AccountType (ineffassign)
    • Line 12: warning: undeclared name: Super (ineffassign)
    • Line 22: warning: undeclared name: Super (ineffassign)
    • Line 22: warning: undeclared name: Super (ineffassign)
    • Line 30: warning: undeclared name: AccountType (ineffassign)
    • Line 42: warning: undeclared name: AccountType (ineffassign)
    • Line 51: warning: undeclared name: AccountType (ineffassign)
    • Line 56: warning: undeclared name: AccountType (ineffassign)
    • Line 62: warning: undeclared name: AccountType (ineffassign)
    • Line 13: warning: undeclared name: Super (ineffassign)
    • Line 33: warning: undeclared name: Genesis (ineffassign)
    • Line 35: warning: undeclared name: Ordinary (ineffassign)
    • Line 37: warning: undeclared name: AccountType (ineffassign)
    • Line 43: warning: undeclared name: Genesis (ineffassign)
    • Line 44: warning: undeclared name: Ordinary (ineffassign)
    • Line 57: warning: undeclared name: AccountType (ineffassign)
    • /home/shawn/mygo/src/github.com/gojp/goreportcard/_repos/src/github.com/irisnet/irishub/modules/guardian/keeper/msg_service.go
    • Line 16: warning: MsgServer not declared by package types (ineffassign)
    • Line 19: warning: MsgServer not declared by package types (ineffassign)
    • Line 23: warning: MsgAddSuper not declared by package types (ineffassign)
    • Line 23: warning: MsgAddSuperResponse not declared by package types (ineffassign)
    • Line 59: warning: MsgDeleteSuper not declared by package types (ineffassign)
    • Line 59: warning: MsgDeleteSuperResponse not declared by package types (ineffassign)
    • Line 16: warning: MsgServer not declared by package types (ineffassign)
    • Line 19: warning: MsgServer not declared by package types (ineffassign)
    • Line 23: warning: MsgAddSuper not declared by package types (ineffassign)
    • Line 23: warning: MsgAddSuperResponse not declared by package types (ineffassign)
    • Line 59: warning: MsgDeleteSuper not declared by package types (ineffassign)
    • Line 59: warning: MsgDeleteSuperResponse not declared by package types (ineffassign)
    • irishub/modules/guardian/types/genesis.go
    • Line 4: warning: undeclared name: Super (ineffassign)
    • Line 4: warning: undeclared name: GenesisState (ineffassign)
    • Line 11: warning: undeclared name: GenesisState (ineffassign)
    • Line 5: warning: undeclared name: GenesisState (ineffassign)
    • Line 12: warning: undeclared name: GenesisState (ineffassign)
    • Line 4: warning: undeclared name: Super (ineffassign)
    • Line 4: warning: undeclared name: GenesisState (ineffassign)
    • Line 11: warning: undeclared name: GenesisState (ineffassign)
    • Line 5: warning: undeclared name: GenesisState (ineffassign)
    • Line 12: warning: undeclared name: GenesisState (ineffassign)
    • irishub/modules/guardian/types/msgs.go
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 19: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 28: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 31: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 34: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 43: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 60: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 71: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 79: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 82: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 85: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 94: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 105: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 114: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 20: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 72: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 19: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 28: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 31: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 34: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 43: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 60: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 71: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 79: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 82: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 85: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 94: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 105: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 114: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 20: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 72: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • irishub/modules/guardian/types/codec.go
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 20: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 21: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 23: warning: undeclared name: _Msg_serviceDesc (ineffassign)
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 20: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 21: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 23: warning: undeclared name: _Msg_serviceDesc (ineffassign)
    • irishub/modules/guardian/client/cli/cli_test.go
    • Line 42: warning: Genesis not declared by package types (ineffassign)
    • Line 44: warning: GenesisState not declared by package types (ineffassign)
    • Line 42: warning: guardian declared but not used (ineffassign)
    • Line 86: warning: QuerySupersResponse not declared by package types (ineffassign)
    • Line 112: warning: QuerySupersResponse not declared by package types (ineffassign)
    • Line 136: warning: QuerySupersResponse not declared by package types (ineffassign)
    • /home/shawn/mygo/src/github.com/gojp/goreportcard/_repos/src/github.com/irisnet/irishub/modules/guardian/types/msgs.go
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 19: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 28: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 31: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 34: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 43: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 60: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 71: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 79: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 82: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 85: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 94: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 105: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 114: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 14: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 15: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 19: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 28: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 31: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 34: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 43: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 60: warning: undeclared name: MsgAddSuper (ineffassign)
    • Line 71: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 79: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 82: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 85: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 94: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 105: warning: undeclared name: MsgDeleteSuper (ineffassign)
    • Line 114: warning: undeclared name: MsgAddSuper (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!