Preparing report...

Report for github.com/jeffreydwalter/arlo-go

A    Great!    Found 15 issues across 17 files

Tweet

gofmt94%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint11%

Golint is a linter for Go source code.

    • arlo-go/types.go
    • Line 62: warning: exported type AppStore should have comment or be unexported (golint)
    • Line 68: warning: exported type Session should have comment or be unexported (golint)
    • Line 75: warning: exported type UserProfile should have comment or be unexported (golint)
    • Line 117: warning: exported type BaseStationMetadata should have comment or be unexported (golint)
    • Line 152: warning: exported type Favorite should have comment or be unexported (golint)
    • Line 157: warning: exported type BaseDetectionProperties should have comment or be unexported (golint)
    • Line 173: warning: exported type EmailNotification should have comment or be unexported (golint)
    • Line 179: warning: exported type PlayTrackProperties should have comment or be unexported (golint)
    • Line 184: warning: exported type BaseLoopbackModeProperties should have comment or be unexported (golint)
    • Line 188: warning: exported type LoopbackModeProperties should have comment or be unexported (golint)
    • Line 192: warning: exported type BaseSleepTimerProperties should have comment or be unexported (golint)
    • Line 197: warning: exported type SleepTimerProperties should have comment or be unexported (golint)
    • Line 200: warning: exported type BaseEventActionProperties should have comment or be unexported (golint)
    • Line 207: warning: exported type EventActionProperties should have comment or be unexported (golint)
    • Line 211: warning: exported type BaseShuffleProperties should have comment or be unexported (golint)
    • Line 215: warning: exported type ShuffleProperties should have comment or be unexported (golint)
    • Line 219: warning: exported type VolumeProperties should have comment or be unexported (golint)
    • Line 224: warning: exported type SpeakerProperties should have comment or be unexported (golint)
    • Line 228: warning: exported type NightLightRGBProperties should have comment or be unexported (golint)
    • Line 234: warning: exported type BaseNightLightProperties should have comment or be unexported (golint)
    • Line 243: warning: exported type NightLightProperties should have comment or be unexported (golint)
    • Line 247: warning: exported type SirenProperties should have comment or be unexported (golint)
    • Line 254: warning: exported type BasestationModeProperties should have comment or be unexported (golint)
    • Line 258: warning: exported type BasestationScheduleProperties should have comment or be unexported (golint)
    • Line 262: warning: exported type CameraProperties should have comment or be unexported (golint)
    • Line 278: warning: exported type PlaylistItem should have comment or be unexported (golint)
    • Line 287: warning: exported type CvrPlaylist should have comment or be unexported (golint)
    • arlo-go/util.go
    • Line 104: warning: exported method Arlo.DownloadFile should have comment or be unexported (golint)
    • Line 122: warning: exported function FromUnixMicro should have comment or be unexported (golint)
    • Line 124: warning: exported function FromUnixMilli should have comment or be unexported (golint)
    • arlo-go/internal/request/response.go
    • Line 31: warning: exported type Response should have comment or be unexported (golint)
    • Line 35: warning: exported method Response.GetContentType should have comment or be unexported (golint)
    • Line 44: warning: exported method Response.Decode should have comment or be unexported (golint)
    • Line 65: warning: error should be the last type when returning multiple items (golint)
    • Line 65: warning: exported method Response.Download should have comment or be unexported (golint)
    • arlo-go/arlo.go
    • Line 30: warning: exported type Arlo should have comment or be unexported (golint)
    • Line 58: warning: exported function Login should have comment or be unexported (golint)
    • Line 91: warning: exported method Arlo.Logout should have comment or be unexported (golint)
    • Line 96: warning: exported method Arlo.CheckSession should have comment or be unexported (golint)
    • Line 198: warning: exported method Arlo.UpdatePassword should have comment or be unexported (golint)
    • Line 210: warning: exported method Arlo.UpdateFriends should have comment or be unexported (golint)
    • arlo-go/arlobaby.go
    • Line 224: warning: exported method Camera.Continuous should have comment or be unexported (golint)
    • Line 228: warning: exported method Camera.SingleTrack should have comment or be unexported (golint)
    • Line 232: warning: exported method Camera.SetLoopBackMode should have comment or be unexported (golint)
    • Line 256: warning: exported method Camera.GetAudioPlayback should have comment or be unexported (golint)
    • Line 275: warning: exported method Camera.EnableSleepTimer should have comment or be unexported (golint)
    • Line 304: warning: exported method Camera.DisableSleepTimer should have comment or be unexported (golint)
    • Line 333: warning: comment on exported method Camera.NightLight should be of the form "NightLight ..." (golint)
    • Line 367: warning: exported method Camera.SetNightLightBrightness should have comment or be unexported (golint)
    • Line 466: warning: exported method Camera.EnableNightLightTimer should have comment or be unexported (golint)
    • Line 495: warning: exported method Camera.DisableNightLightTimer should have comment or be unexported (golint)
    • arlo-go/basestation.go
    • Line 95: warning: exported method Basestation.IsConnected should have comment or be unexported (golint)
    • Line 105: warning: exported method Basestation.Subscribe should have comment or be unexported (golint)
    • Line 143: warning: exported method Basestation.Unsubscribe should have comment or be unexported (golint)
    • Line 148: warning: exported method Basestation.Disconnect should have comment or be unexported (golint)
    • Line 173: warning: exported method Basestation.NotifyEventStream should have comment or be unexported (golint)
    • Line 183: warning: exported method Basestation.GetState should have comment or be unexported (golint)
    • Line 196: warning: exported method Basestation.GetAssociatedCamerasState should have comment or be unexported (golint)
    • Line 208: warning: exported method Basestation.GetRules should have comment or be unexported (golint)
    • Line 220: warning: exported method Basestation.GetCalendarMode should have comment or be unexported (golint)
    • Line 250: warning: exported method Basestation.GetModes should have comment or be unexported (golint)
    • Line 262: warning: exported method Basestation.SetCustomMode should have comment or be unexported (golint)
    • Line 277: warning: exported method Basestation.DeleteMode should have comment or be unexported (golint)
    • Line 289: warning: exported method Basestation.Arm should have comment or be unexported (golint)
    • Line 293: warning: exported method Basestation.Disarm should have comment or be unexported (golint)
    • Line 297: warning: exported method Basestation.SirenOn should have comment or be unexported (golint)
    • Line 315: warning: exported method Basestation.SirenOff should have comment or be unexported (golint)
    • arlo-go/events_stream.go
    • Line 31: warning: error var FAILED_TO_PUBLISH should have name of the form ErrFoo (golint)
    • Line 31: warning: exported var FAILED_TO_PUBLISH should have comment or be unexported (golint)
    • Line 32: warning: error var FAILED_TO_DECODE_JSON should have name of the form ErrFoo (golint)
    • Line 33: warning: error var FAILED_TO_SUBSCRIBE should have name of the form ErrFoo (golint)
    • arlo-go/internal/request/client.go
    • Line 34: warning: exported type Client should have comment or be unexported (golint)
    • Line 41: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 68: warning: exported method Client.AddHeader should have comment or be unexported (golint)
    • Line 74: warning: exported method Client.Get should have comment or be unexported (golint)
    • Line 82: warning: exported method Client.Post should have comment or be unexported (golint)
    • Line 90: warning: exported method Client.Put should have comment or be unexported (golint)
    • arlo-go/camera.go
    • Line 68: warning: comment on exported method Camera.Off should be of the form "Off ..." (golint)
    • Line 123: warning: exported method Camera.EnableMotionAlerts should have comment or be unexported (golint)
    • Line 149: warning: exported method Camera.DisableMotionAlerts should have comment or be unexported (golint)
    • Line 175: warning: exported method Camera.EnableAudioAlerts should have comment or be unexported (golint)
    • Line 200: warning: exported method Camera.DisableAudioAlerts should have comment or be unexported (golint)
    • Line 403: warning: comment on exported method Camera.SetAlertNotificationMethods should be of the form "SetAlertNotificationMethods ..." (golint)
    • Line 438: warning: comment on exported method Camera.StartStream should be of the form "StartStream ..." (golint)
    • Line 481: warning: comment on exported method Camera.TakeSnapshot should be of the form "TakeSnapshot ..." (golint)
    • Line 578: warning: comment on exported method Camera.GetCvrPlaylist should be of the form "GetCvrPlaylist ..." (golint)
    • arlo-go/library.go
    • Line 32: warning: comment on exported type Recording should be of the form "Recording ..." (with optional leading article) (golint)
    • Line 54: warning: exported type Library should have comment or be unexported (golint)
    • Line 56: warning: exported method Arlo.GetLibraryMetaData should have comment or be unexported (golint)
    • Line 78: warning: exported method Arlo.GetLibrary should have comment or be unexported (golint)
    • Line 100: warning: comment on exported method Arlo.DeleteRecording should be of the form "DeleteRecording ..." (golint)
    • Line 113: warning: comment on exported method Arlo.BatchDeleteRecordings should be of the form "BatchDeleteRecordings ..." (golint)
    • arlo-go/internal/util/util.go
    • Line 26: warning: exported function PrettyPrint should have comment or be unexported (golint)
    • Line 34: warning: exported function FloatToHex should have comment or be unexported (golint)
    • Line 77: warning: exported function HeaderToArray should have comment or be unexported (golint)
    • Line 86: warning: exported function HeaderToMap should have comment or be unexported (golint)
    • arlo-go/const.go
    • Line 20: warning: exported const DeviceTypeArloQ should have comment (or a comment on this block) or be unexported (golint)
    • Line 30: warning: comment on exported const ActiveAutomationUri should be of the form "ActiveAutomationUri ..." (golint)
    • arlo-go/devices.go
    • Line 89: warning: exported method Devices.FindCameras should have comment or be unexported (golint)
    • Line 100: warning: exported method Device.IsBasestation should have comment or be unexported (golint)
    • Line 104: warning: exported method Device.IsCamera should have comment or be unexported (golint)
    • Line 114: warning: exported method Device.IsArloQ should have comment or be unexported (golint)
    • Line 118: warning: exported method Device.IsLight should have comment or be unexported (golint)
    • Line 122: warning: exported method Device.IsSiren should have comment or be unexported (golint)
    • arlo-go/responses.go
    • Line 19: warning: comment on exported type Data should be of the form "Data ..." (with optional leading article) (golint)
    • Line 39: warning: exported type SessionResponse should have comment or be unexported (golint)
    • Line 44: warning: exported type UserProfileResponse should have comment or be unexported (golint)
    • Line 61: warning: exported type LibraryResponse should have comment or be unexported (golint)
    • Line 66: warning: exported type CvrPlaylistResponse should have comment or be unexported (golint)
    • Line 71: warning: exported type Stream should have comment or be unexported (golint)
    • Line 75: warning: exported type StreamResponse should have comment or be unexported (golint)
    • Line 80: warning: exported type RecordingResponse should have comment or be unexported (golint)
    • Line 85: warning: exported type EventStreamResponse should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!