gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo91%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• jx-secret/pkg/extsecrets/editor/local/local_editor.go
  • Line 44: warning: cyclomatic complexity 19 of function (*client).Write() is high (> 15) (gocyclo)

• jx-secret/pkg/extsecrets/helpers.go
  • Line 52: warning: cyclomatic complexity 16 of function CopySecretToNamespace() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/replicate/replicate.go
  • Line 79: warning: cyclomatic complexity 24 of function (*Options).Run() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/convert/convert.go
  • Line 164: warning: cyclomatic complexity 37 of function (*Options).ModifyYAML() is high (> 15) (gocyclo)
  • Line 621: warning: cyclomatic complexity 23 of function (*Options).moveMetadataToTemplate() is high (> 15) (gocyclo)
  • Line 458: warning: cyclomatic complexity 18 of function (*Options).modifyDefault() is high (> 15) (gocyclo)
  • Line 319: warning: cyclomatic complexity 17 of function (*Options).convertData() is high (> 15) (gocyclo)
  • Line 556: warning: cyclomatic complexity 17 of function (*Options).modifyGSM() is high (> 15) (gocyclo)

• jx-secret/pkg/masker/masker.go
  • Line 122: warning: cyclomatic complexity 17 of function (*Client).LoadSecret() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/import/import.go
  • Line 72: warning: cyclomatic complexity 17 of function (*Options).Run() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/populate/templater.go
  • Line 26: warning: cyclomatic complexity 33 of function (*Options).EvaluateTemplate() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/populate/populate.go
  • Line 162: warning: cyclomatic complexity 26 of function (*Options).PopulateLoop() is high (> 15) (gocyclo)

• jx-secret/pkg/cmd/edit/edit.go
  • Line 82: warning: cyclomatic complexity 20 of function (*Options).Run() is high (> 15) (gocyclo)

golint74%

Golint is a linter for Go source code.

• jx-secret/pkg/extsecrets/editor/local/local_editor.go
  • Line 28: warning: exported function NewEditor should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/editor/azure/azure_editor.go
  • Line 19: warning: exported type KeyVault should have comment or be unexported (golint)
  • Line 23: warning: exported type KeyVaultClient should have comment or be unexported (golint)
  • Line 25: warning: exported method KeyVaultClient.SetSecret should have comment or be unexported (golint)
  • Line 46: warning: exported function NewEditor should have comment or be unexported (golint)

• jx-secret/pkg/masker/watcher/watcher.go
  • Line 21: warning: exported type Options should have comment or be unexported (golint)

• jx-secret/pkg/apis/schema/v1alpha1/doc.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• jx-secret/pkg/apis/mapping/v1alpha1/types.go
  • Line 15: warning: exported const SecretMappingFileName should have comment (or a comment on this block) or be unexported (golint)
  • Line 187: warning: comment on exported method SecretMapping.FindSecret should be of the form "FindSecret ..." (golint)
  • Line 198: warning: exported method SecretMapping.IsSecretKeyUnsecured should have comment or be unexported (golint)
  • Line 222: warning: comment on exported method SecretMapping.Validate should be of the form "Validate ..." (golint)

• jx-secret/pkg/extsecrets/editor/vault/vault_editor.go
  • Line 25: warning: exported function NewEditor should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/testsecrets/load_fake_vault.go
  • Line 11: warning: exported type FakeVaultSecrets should have comment or be unexported (golint)
  • Line 15: warning: exported function LoadFakeVaultSecrets should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/testsecrets/vault.go
  • Line 10: warning: exported function AddVaultSecrets should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/secretfacade/verify_filter.go
  • Line 85: warning: exported type SchemaOrder should have comment or be unexported (golint)
  • Line 118: warning: exported type SchemaTemplateOrder should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/interface.go
  • Line 7: warning: exported type Interface should have comment or be unexported (golint)

• jx-secret/pkg/apis/mapping/v1alpha1/doc.go
  • Line 1: warning: package comment should be of the form "Package v1alpha1 ..." (golint)

• jx-secret/pkg/extsecrets/editor/interface.go
  • Line 18: warning: comment on exported type PropertyValue should be of the form "PropertyValue ..." (with optional leading article) (golint)

• jx-secret/pkg/cmd/convert/edit/edit.go
  • Line 44: warning: comment on exported function NewCmdSecretMappingEdit should be of the form "NewCmdSecretMappingEdit ..." (golint)

• jx-secret/pkg/extsecrets/editor/factory/factory.go
  • Line 16: warning: exported function NewEditor should have comment or be unexported (golint)

• jx-secret/pkg/cmd/replicate/replicate.go
  • Line 41: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)
  • Line 79: warning: exported method Options.Run should have comment or be unexported (golint)

• jx-secret/pkg/cmd/convert/convert.go
  • Line 49: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)
  • Line 94: warning: exported method Options.Validate should have comment or be unexported (golint)
  • Line 123: warning: exported method Options.Run should have comment or be unexported (golint)

• jx-secret/pkg/cmd/populate/templatertesting/types.go
  • Line 32: warning: exported type ExternalSecret should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/file_client.go
  • Line 14: warning: exported function NewFileClient should have comment or be unexported (golint)

• jx-secret/pkg/cmd/plugins/upgrade/upgrade.go
  • Line 24: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)

• jx-secret/pkg/cmd/version/version.go
  • Line 28: warning: comment on exported type Options should be of the form "Options ..." (with optional leading article) (golint)
  • Line 55: warning: exported function GetVersion should have comment or be unexported (golint)

• jx-secret/pkg/cmd/populate/populate.go
  • Line 46: warning: exported var DefaultBackoff should have comment or be unexported (golint)
  • Line 97: warning: exported method Options.Validate should have comment or be unexported (golint)
  • Line 272: warning: exported function GetSecretStore should have comment or be unexported (golint)
  • Line 281: warning: exported function GetSecretKey should have comment or be unexported (golint)
  • Line 320: warning: exported function GetExternalSecretLocation should have comment or be unexported (golint)
  • Line 514: warning: exported function KubectlExecRunner should have comment or be unexported (golint)

• jx-secret/pkg/extsecrets/editor/gsm/gsm_editor.go
  • Line 36: warning: exported function NewEditor should have comment or be unexported (golint)
  • Line 168: warning: exported function VerifyGcloudInstalled should have comment or be unexported (golint)

• jx-secret/pkg/cmd/wait/wait.go
  • Line 84: warning: comment on exported method Options.WaitCheck should be of the form "WaitCheck ..." (golint)

• jx-secret/pkg/extsecrets/secretfacade/types.go
  • Line 40: warning: exported type ExternalSecretLocation should have comment or be unexported (golint)
  • Line 42: warning: exported const FileSystem should have comment or be unexported (golint)
  • Line 43: warning: exported const Kubernetes should have comment or be unexported (golint)
  • Line 45: warning: exported method Options.AddFlags should have comment or be unexported (golint)
  • Line 52: warning: exported method Options.Validate should have comment or be unexported (golint)
  • Line 74: warning: exported method Options.ExternalSecretByName should have comment or be unexported (golint)

• jx-secret/pkg/apis/schema/v1alpha1/types.go
  • Line 6: warning: exported const LabelKind should have comment (or a comment on this block) or be unexported (golint)

• jx-secret/pkg/apis/external/v1/doc.go
  • Line 1: warning: package comment should be of the form "Package v1 ..." (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• jx-secret/pkg/cmd/convert/convert.go
  • Line 275: warning: ineffectual assignment to flag (ineffassign)

• jx-secret/pkg/cmd/populate/populate_test.go
  • Line 325: warning: ineffectual assignment to err (ineffassign)

• jx-secret/pkg/cmd/populate/templater.go
  • Line 274: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!