Report for github.com/k8snetworkplumbingwg/ib-sriov-cni
A+ Excellent! Found 4 issues across 13 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo92%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
ib-sriov-cni/pkg/sriov/sriov.go
- Line 208: warning: cyclomatic complexity 16 of function (*sriovManager).ApplyVFConfig() is high (> 15) (gocyclo)
golint76%
Golint is a linter for Go source code.
-
-
ib-sriov-cni/pkg/config/config.go
- Line 38: warning: comment on exported function LoadDeviceInfo should be of the form "LoadDeviceInfo ..." (golint)
-
-
ib-sriov-cni/pkg/utils/rdma.go
- Line 12: warning: comment on exported function EnsureRdmaSystemMode should be of the form "EnsureRdmaSystemMode ..." (golint)
- Line 25: warning: comment on exported function MoveRdmaDevToNs should be of the form "MoveRdmaDevToNs ..." (golint)
- Line 34: warning: comment on exported function MoveRdmaDevToNsPci should be of the form "MoveRdmaDevToNsPci ..." (golint)
- Line 57: warning: comment on exported function MoveRdmaDevFromNs should be of the form "MoveRdmaDevFromNs ..." (golint)
-
-
ib-sriov-cni/pkg/utils/utils.go
- Line 23: warning: exported const IPoIBAddrLengthBytes should have comment or be unexported (golint)
- Line 216: warning: comment on exported function GetGUIDFromHwAddr should be of the form "GetGUIDFromHwAddr ..." (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!