Preparing report...

Report for github.com/kubeedge/edgemesh

A+    Excellent!    Found 26 issues across 44 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo95%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint45%

Golint is a linter for Go source code.

    • edgemesh/pkg/networking/servicediscovery/proxier/proxier.go
    • Line 31: warning: comment on exported type Proxier should be of the form "Proxier ..." (with optional leading article) (golint)
    • Line 39: warning: exported function Init should have comment or be unexported (golint)
    • Line 76: warning: comment on exported function StartProxier should be of the form "StartProxier ..." (golint)
    • Line 256: warning: exported function Clean should have comment or be unexported (golint)
    • edgemesh/pkg/common/client/client.go
    • Line 20: warning: exported function InitEdgeMeshClient should have comment or be unexported (golint)
    • Line 43: warning: exported function GetKubeClient should have comment or be unexported (golint)
    • Line 47: warning: exported function GetIstioClient should have comment or be unexported (golint)
    • Line 51: warning: exported type EdgeMeshClient should have comment or be unexported (golint)
    • edgemesh/cmd/edgemesh/app/options/options.go
    • Line 12: warning: exported type EdgeMeshOptions should have comment or be unexported (golint)
    • Line 16: warning: exported function NewEdgeMeshOptions should have comment or be unexported (golint)
    • Line 22: warning: exported method EdgeMeshOptions.Flags should have comment or be unexported (golint)
    • Line 28: warning: exported method EdgeMeshOptions.Config should have comment or be unexported (golint)
    • edgemesh/pkg/networking/edgegateway/edgegateway.go
    • Line 29: warning: exported function Init should have comment or be unexported (golint)
    • Line 44: warning: comment on exported method Manager.AddGateway should be of the form "AddGateway ..." (golint)
    • Line 85: warning: comment on exported method Manager.UpdateGateway should be of the form "UpdateGateway ..." (golint)
    • Line 136: warning: comment on exported method Manager.DelGateway should be of the form "DelGateway ..." (golint)
    • edgemesh/pkg/controller/config/config.go
    • Line 9: warning: exported var Config should have comment or be unexported (golint)
    • Line 12: warning: exported type Configure should have comment or be unexported (golint)
    • Line 16: warning: exported function InitConfigure should have comment or be unexported (golint)
    • edgemesh/pkg/networking/trafficplugin/panel/panel.go
    • Line 10: warning: exported type EdgePanel should have comment or be unexported (golint)
    • Line 13: warning: exported method EdgePanel.GetCircuitBreaker should have comment or be unexported (golint)
    • Line 17: warning: exported method EdgePanel.GetLoadBalancing should have comment or be unexported (golint)
    • Line 20: warning: exported method EdgePanel.GetRateLimiting should have comment or be unexported (golint)
    • Line 23: warning: exported method EdgePanel.GetFaultInjection should have comment or be unexported (golint)
    • Line 26: warning: exported method EdgePanel.GetEgressRule should have comment or be unexported (golint)
    • edgemesh/pkg/controller/global.go
    • Line 24: warning: exported type GlobalController should have comment or be unexported (golint)
    • Line 192: warning: exported function NewGlobalController should have comment or be unexported (golint)
    • Line 241: warning: exported function GetPodLister should have comment or be unexported (golint)
    • Line 245: warning: exported function GetSecretLister should have comment or be unexported (golint)
    • Line 249: warning: exported function GetServiceLister should have comment or be unexported (golint)
    • Line 253: warning: exported function GetDestinationRuleLister should have comment or be unexported (golint)
    • Line 257: warning: exported function GetVirtualServiceLister should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!