gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo96%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• sedna/pkg/localcontroller/trigger/trigger.go
  • Line 54: warning: cyclomatic complexity 21 of function (*BinaryTrigger).Trigger() is high (> 15) (gocyclo)

• sedna/pkg/globalmanager/federatedlearningjob.go
  • Line 241: warning: cyclomatic complexity 23 of function (*FederatedController).syncFLJob() is high (> 15) (gocyclo)

• sedna/pkg/globalmanager/jointinferenceservice.go
  • Line 237: warning: cyclomatic complexity 20 of function (*JointInferenceServiceController).sync() is high (> 15) (gocyclo)

• sedna/pkg/globalmanager/incrementallearningjob.go
  • Line 310: warning: cyclomatic complexity 20 of function (*IncrementalJobController).updateIncrementalJobConditions() is high (> 15) (gocyclo)
  • Line 237: warning: cyclomatic complexity 17 of function (*IncrementalJobController).sync() is high (> 15) (gocyclo)

golint80%

Golint is a linter for Go source code.

• sedna/pkg/apis/sedna/v1alpha1/federatedlearningjob_types.go
  • Line 50: warning: comment on exported type TrainingWorker should be of the form "TrainingWorker ..." (with optional leading article) (golint)
  • Line 109: warning: exported type FLJobConditionType should have comment or be unexported (golint)

• sedna/pkg/localcontroller/manager/incrementallearningjob.go
  • Line 93: warning: comment on exported type IncrementalJobManager should be of the form "IncrementalJobManager ..." (with optional leading article) (golint)

• sedna/test/e2e/framework/test_context.go
  • Line 35: warning: exported var TestContext should have comment or be unexported (golint)
  • Line 37: warning: exported function RegisterFlags should have comment or be unexported (golint)

• sedna/pkg/globalmanager/storage_initializer_injector.go
  • Line 76: warning: exported type MountURL should have comment or be unexported (golint)
  • Line 121: warning: exported method MountURL.Parse should have comment or be unexported (golint)

• sedna/pkg/globalmanager/secret_injector.go
  • Line 27: warning: exported const S3EndpointKey should have comment (or a comment on this block) or be unexported (golint)
  • Line 29: warning: comment on exported const S3EndpointURLEnv should be of the form "S3EndpointURLEnv ..." (golint)
  • Line 33: warning: comment on exported const AccessKeyIDEnv should be of the form "AccessKeyIDEnv ..." (golint)
  • Line 37: warning: comment on exported const SecretAccessKeyEnv should be of the form "SecretAccessKeyEnv ..." (golint)
  • Line 109: warning: exported function InjectSecretObj should have comment or be unexported (golint)

• sedna/pkg/globalmanager/worker.go
  • Line 14: warning: exported type WorkerMount should have comment or be unexported (golint)

• sedna/pkg/util/util.go
  • Line 34: warning: exported function SpliceErrors should have comment or be unexported (golint)

• sedna/pkg/localcontroller/storage/storage.go
  • Line 34: warning: comment on exported const S3Endpoint should be of the form "S3Endpoint ..." (golint)
  • Line 38: warning: comment on exported const AccessKeyID should be of the form "AccessKeyID ..." (golint)
  • Line 44: warning: exported type Storage should have comment or be unexported (golint)

• sedna/pkg/version/verflag/verflag.go
  • Line 31: warning: exported type VersionValue should have comment or be unexported (golint)
  • Line 34: warning: exported const VersionFalse should have comment (or a comment on this block) or be unexported (golint)
  • Line 41: warning: exported method VersionValue.IsBoolFlag should have comment or be unexported (golint)
  • Line 45: warning: exported method VersionValue.Get should have comment or be unexported (golint)
  • Line 49: warning: exported method VersionValue.Set should have comment or be unexported (golint)
  • Line 70: warning: comment on exported method VersionValue.Type should be of the form "Type ..." (golint)
  • Line 75: warning: exported function VersionVar should have comment or be unexported (golint)
  • Line 82: warning: exported function Version should have comment or be unexported (golint)

• sedna/pkg/localcontroller/gmclient/types.go
  • Line 42: warning: exported type MessageResourceHandler should have comment or be unexported (golint)
  • Line 48: warning: exported type ClientI should have comment or be unexported (golint)

• sedna/test/e2e/e2e.go
  • Line 30: warning: exported function RunE2ETests should have comment or be unexported (golint)

• sedna/pkg/localcontroller/manager/model.go
  • Line 67: warning: comment on exported method ModelManager.Insert should be of the form "Insert ..." (golint)
  • Line 98: warning: exported method ModelManager.GetName should have comment or be unexported (golint)
  • Line 102: warning: exported method ModelManager.AddWorkerMessage should have comment or be unexported (golint)

• sedna/pkg/localcontroller/manager/types.go
  • Line 86: warning: exported type WorkerInput should have comment or be unexported (golint)

• sedna/pkg/globalmanager/incrementallearningjob.go
  • Line 84: warning: comment on exported method IncrementalJobController.Start should be of the form "Start ..." (golint)
  • Line 416: warning: exported function NewIncrementalJobCondition should have comment or be unexported (golint)
  • Line 492: warning: exported function IsIncrementalJobFinished should have comment or be unexported (golint)

• sedna/pkg/globalmanager/federatedlearningjob.go
  • Line 53: warning: exported const FLJobStageAgg should have comment (or a comment on this block) or be unexported (golint)
  • Line 88: warning: comment on exported method FederatedController.Start should be of the form "Start ..." (golint)
  • Line 347: warning: exported function NewFLJobCondition should have comment or be unexported (golint)
  • Line 393: warning: exported function IsFLJobFinished should have comment or be unexported (golint)
  • Line 530: warning: exported method FederatedController.GetName should have comment or be unexported (golint)

• sedna/pkg/globalmanager/types.go
  • Line 40: warning: exported type Model should have comment or be unexported (golint)
  • Line 46: warning: comment on exported type IncrementalCondData should be of the form "IncrementalCondData ..." (with optional leading article) (golint)
  • Line 72: warning: exported method Model.GetURL should have comment or be unexported (golint)
  • Line 88: warning: exported method IncrementalCondData.GetInputModelURLs should have comment or be unexported (golint)
  • Line 92: warning: exported method IncrementalCondData.GetOutputModelURLs should have comment or be unexported (golint)
  • Line 96: warning: exported method IncrementalCondData.Unmarshal should have comment or be unexported (golint)
  • Line 100: warning: exported method IncrementalCondData.Marshal should have comment or be unexported (golint)

• sedna/pkg/apis/sedna/v1alpha1/incrementallearningjob_types.go
  • Line 71: warning: exported type Trigger should have comment or be unexported (golint)
  • Line 77: warning: exported type Timer should have comment or be unexported (golint)
  • Line 82: warning: exported type Condition should have comment or be unexported (golint)
  • Line 88: warning: exported type ILDataset should have comment or be unexported (golint)
  • Line 93: warning: exported type InitialModel should have comment or be unexported (golint)
  • Line 97: warning: exported type DeployModel should have comment or be unexported (golint)
  • Line 129: warning: exported type ILJobStageConditionType should have comment or be unexported (golint)
  • Line 171: warning: exported const ILJobTrain should have comment (or a comment on this block) or be unexported (golint)

• sedna/pkg/localcontroller/server/server.go
  • Line 62: warning: exported method Server.AddFeatureManager should have comment or be unexported (golint)

• sedna/pkg/localcontroller/trigger/trigger.go
  • Line 28: warning: exported type Base should have comment or be unexported (golint)
  • Line 32: warning: exported type BinaryTrigger should have comment or be unexported (golint)
  • Line 54: warning: exported method BinaryTrigger.Trigger should have comment or be unexported (golint)
  • Line 120: warning: exported type TimerRangeTrigger should have comment or be unexported (golint)
  • Line 126: warning: exported method TimerRangeTrigger.Trigger should have comment or be unexported (golint)
  • Line 148: warning: exported type AndTrigger should have comment or be unexported (golint)
  • Line 152: warning: exported method AndTrigger.Trigger should have comment or be unexported (golint)
  • Line 173: warning: exported function NewTrigger should have comment or be unexported (golint)

• sedna/pkg/localcontroller/manager/dataset.go
  • Line 90: warning: comment on exported method DatasetManager.GetDataset should be of the form "GetDataset ..." (golint)
  • Line 244: warning: exported method DatasetManager.GetName should have comment or be unexported (golint)
  • Line 248: warning: exported method DatasetManager.AddWorkerMessage should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign97%

IneffAssign detects ineffectual assignments in Go code.

• sedna/pkg/globalmanager/federatedlearningjob.go
  • Line 541: warning: ineffectual assignment to err (ineffassign)

• sedna/pkg/globalmanager/incrementallearningjob.go
  • Line 285: warning: ineffectual assignment to needUpdated (ineffassign)
  • Line 728: warning: ineffectual assignment to err (ineffassign)

• sedna/test/e2e/apps/dataset.go
  • Line 49: warning: ineffectual assignment to err (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!