gofmt81%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

• pytorch-operator/pkg/controller.v1/pytorch/job_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/controller.v1/pytorch/status_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/version/version.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/test/e2e/v1/cleanpolicy/cleanpolicy_all.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/apis/pytorch/validation/validation_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/controller.v1/pytorch/pod_test.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/controller.v1/pytorch/service.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/controller.v1/pytorch/status.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/test/e2e/v1/default/defaults.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/common/util/v1/testutil/job.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

• pytorch-operator/pkg/common/util/v1/testutil/util.go
  • Line 1: warning: file is not gofmted with -s (gofmt)

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo88%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

• pytorch-operator/pkg/apis/pytorch/validation/validation.go
  • Line 23: warning: cyclomatic complexity 16 of function ValidateV1PyTorchJobSpec() is high (> 15) (gocyclo)

• pytorch-operator/test/e2e/v1/cleanpolicy/cleanpolicy_all.go
  • Line 78: warning: cyclomatic complexity 22 of function run() is high (> 15) (gocyclo)

• pytorch-operator/test/e2e/v1/default/defaults.go
  • Line 80: warning: cyclomatic complexity 21 of function run() is high (> 15) (gocyclo)

• pytorch-operator/pkg/controller.v1/pytorch/controller.go
  • Line 336: warning: cyclomatic complexity 34 of function (*PyTorchController).reconcilePyTorchJobs() is high (> 15) (gocyclo)

• pytorch-operator/pkg/controller.v1/pytorch/controller_test.go
  • Line 66: warning: cyclomatic complexity 27 of function TestNormalPath() is high (> 15) (gocyclo)

• pytorch-operator/pkg/controller.v1/pytorch/pod.go
  • Line 140: warning: cyclomatic complexity 16 of function (*PyTorchController).createNewPod() is high (> 15) (gocyclo)

• pytorch-operator/pkg/controller.v1/pytorch/status.go
  • Line 63: warning: cyclomatic complexity 16 of function (*PyTorchController).updateStatusSingle() is high (> 15) (gocyclo)

golint62%

Golint is a linter for Go source code.

• pytorch-operator/pkg/util/util.go
  • Line 28: warning: comment on exported const EnvKubeflowNamespace should be of the form "EnvKubeflowNamespace ..." (golint)

• pytorch-operator/pkg/common/util/v1/testutil/job.go
  • Line 28: warning: exported function NewPyTorchJobWithCleanPolicy should have comment or be unexported (golint)
  • Line 39: warning: exported function NewPyTorchJobWithCleanupJobDelay should have comment or be unexported (golint)
  • Line 54: warning: exported function NewPyTorchJobWithActiveDeadlineSeconds should have comment or be unexported (golint)
  • Line 69: warning: exported function NewPyTorchJobWithBackoffLimit should have comment or be unexported (golint)
  • Line 86: warning: exported function NewPyTorchJobWithMaster should have comment or be unexported (golint)
  • Line 95: warning: exported function NewPyTorchJob should have comment or be unexported (golint)
  • Line 122: warning: exported function NewPyTorchReplicaSpecTemplate should have comment or be unexported (golint)
  • Line 142: warning: exported function SetPyTorchJobCompletionTime should have comment or be unexported (golint)

• pytorch-operator/version/version.go
  • Line 22: warning: exported var Version should have comment or be unexported (golint)
  • Line 26: warning: exported function PrintVersionAndExit should have comment or be unexported (golint)
  • Line 33: warning: exported function Info should have comment or be unexported (golint)

• pytorch-operator/pkg/controller.v1/pytorch/controller.go
  • Line 15: warning: package comment should be of the form "Package pytorch ..." (golint)
  • Line 570: warning: exported method PyTorchController.GetJobFromInformerCache should have comment or be unexported (golint)
  • Line 574: warning: exported method PyTorchController.GetJobFromAPIClient should have comment or be unexported (golint)
  • Line 578: warning: exported method PyTorchController.GetAPIGroupVersionKind should have comment or be unexported (golint)
  • Line 582: warning: exported method PyTorchController.GetAPIGroupVersion should have comment or be unexported (golint)
  • Line 586: warning: exported method PyTorchController.GetGroupNameLabelKey should have comment or be unexported (golint)
  • Line 590: warning: comment on exported method PyTorchController.GetJobNameLabelKey should be of the form "GetJobNameLabelKey ..." (golint)
  • Line 595: warning: exported method PyTorchController.GetGroupNameLabelValue should have comment or be unexported (golint)
  • Line 599: warning: exported method PyTorchController.GetReplicaTypeLabelKey should have comment or be unexported (golint)
  • Line 603: warning: exported method PyTorchController.GetReplicaIndexLabelKey should have comment or be unexported (golint)
  • Line 607: warning: exported method PyTorchController.ControllerName should have comment or be unexported (golint)

• pytorch-operator/pkg/apis/pytorch/v1/register.go
  • Line 24: warning: comment on exported var SchemeBuilder should be of the form "SchemeBuilder ..." (golint)
  • Line 28: warning: exported var AddToScheme should have comment or be unexported (golint)

• pytorch-operator/pkg/common/config/config.go
  • Line 32: warning: exported function GetInitContainerTemplate should have comment or be unexported (golint)

• pytorch-operator/pkg/common/util/v1/testutil/const.go
  • Line 22: warning: exported const TestImageName should have comment (or a comment on this block) or be unexported (golint)
  • Line 32: warning: exported var AlwaysReady should have comment or be unexported (golint)

• pytorch-operator/pkg/common/util/v1/testutil/pod.go
  • Line 38: warning: exported function NewBasePod should have comment or be unexported (golint)
  • Line 49: warning: exported function NewPod should have comment or be unexported (golint)
  • Line 56: warning: comment on exported function NewPodList should be of the form "NewPodList ..." (golint)
  • Line 67: warning: exported function SetPodsStatuses should have comment or be unexported (golint)

• pytorch-operator/pkg/controller.v1/pytorch/informer.go
  • Line 34: warning: exported function NewUnstructuredPyTorchJobInformer should have comment or be unexported (golint)

• pytorch-operator/pkg/apis/pytorch/v1/types.go
  • Line 26: warning: comment on exported type PyTorchJob should be of the form "PyTorchJob ..." (with optional leading article) (golint)

• pytorch-operator/cmd/pytorch-operator.v1/app/options/options.go
  • Line 24: warning: exported const DefaultResyncPeriod should have comment or be unexported (golint)

• pytorch-operator/pkg/common/util/v1/testutil/service.go
  • Line 28: warning: exported function NewBaseService should have comment or be unexported (golint)
  • Line 39: warning: exported function NewService should have comment or be unexported (golint)
  • Line 56: warning: exported function SetServices should have comment or be unexported (golint)

• pytorch-operator/pkg/controller.v1/pytorch/util.go
  • Line 49: warning: exported type InitContainerParam should have comment or be unexported (golint)
  • Line 54: warning: exported function ContainMasterSpec should have comment or be unexported (golint)
  • Line 61: warning: exported function GetInitContainer should have comment or be unexported (golint)
  • Line 80: warning: exported function AddInitContainerForWorkerPod should have comment or be unexported (golint)

• pytorch-operator/pkg/common/util/v1/unstructured/informer.go
  • Line 21: warning: exported type UnstructuredInformer should have comment or be unexported (golint)
  • Line 25: warning: exported function NewPyTorchJobInformer should have comment or be unexported (golint)
  • Line 31: warning: exported method UnstructuredInformer.Informer should have comment or be unexported (golint)
  • Line 35: warning: exported method UnstructuredInformer.Lister should have comment or be unexported (golint)

• pytorch-operator/cmd/pytorch-operator.v1/app/server.go
  • Line 64: warning: exported const RecommendedKubeConfigPathEnv should have comment or be unexported (golint)
  • Line 66: warning: exported function Run should have comment or be unexported (golint)

• pytorch-operator/pkg/common/util/v1/testutil/util.go
  • Line 32: warning: exported const LabelGroupName should have comment (or a comment on this block) or be unexported (golint)
  • Line 35: warning: comment on exported const DeprecatedLabelPyTorchJobName should be of the form "DeprecatedLabelPyTorchJobName ..." (golint)
  • Line 44: warning: exported var GroupName should have comment or be unexported (golint)
  • Line 48: warning: exported function GenLabels should have comment or be unexported (golint)
  • Line 57: warning: exported function GenOwnerReference should have comment or be unexported (golint)
  • Line 82: warning: exported function GetKey should have comment or be unexported (golint)
  • Line 91: warning: exported function CheckCondition should have comment or be unexported (golint)

• pytorch-operator/test/e2e/v1/cleanpolicy/cleanpolicy_all.go
  • Line 80: warning: don't use underscores in Go names; var kube_env should be kubeEnv (golint)

• pytorch-operator/test/e2e/v1/default/defaults.go
  • Line 82: warning: don't use underscores in Go names; var kube_env should be kubeEnv (golint)

• pytorch-operator/pkg/controller.v1/pytorch/pod.go
  • Line 15: warning: package comment should be of the form "Package pytorch ..." (golint)

• pytorch-operator/pkg/controller.v1/pytorch/service.go
  • Line 15: warning: package comment should be of the form "Package pytorch ..." (golint)

• pytorch-operator/pkg/controller.v1/pytorch/status.go
  • Line 15: warning: package comment should be of the form "Package pytorch ..." (golint)

• pytorch-operator/pkg/apis/pytorch/v1/defaults.go
  • Line 88: warning: don't use underscores in Go names; func SetDefaults_PyTorchJob should be SetDefaultsPyTorchJob (golint)

• pytorch-operator/pkg/apis/pytorch/validation/validation.go
  • Line 23: warning: exported function ValidateV1PyTorchJobSpec should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign98%

IneffAssign detects ineffectual assignments in Go code.

• pytorch-operator/pkg/controller.v1/pytorch/pod.go
  • Line 66: warning: ineffectual assignment to masterRole (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!