Preparing report...

Report for github.com/kubernetes-sigs/aws-fsx-csi-driver

A+    Excellent!    Found 19 issues across 28 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo85%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.


golint42%

Golint is a linter for Go source code.

    • aws-fsx-csi-driver/pkg/driver/node.go
    • Line 34: warning: exported method Driver.NodeStageVolume should have comment or be unexported (golint)
    • Line 38: warning: exported method Driver.NodeUnstageVolume should have comment or be unexported (golint)
    • Line 42: warning: exported method Driver.NodePublishVolume should have comment or be unexported (golint)
    • Line 112: warning: exported method Driver.NodeUnpublishVolume should have comment or be unexported (golint)
    • Line 133: warning: exported method Driver.NodeGetVolumeStats should have comment or be unexported (golint)
    • Line 137: warning: exported method Driver.NodeExpandVolume should have comment or be unexported (golint)
    • Line 141: warning: exported method Driver.NodeGetCapabilities should have comment or be unexported (golint)
    • Line 157: warning: exported method Driver.NodeGetInfo should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/util/util.go
    • Line 30: warning: exported const GiB should have comment (or a comment on this block) or be unexported (golint)
    • Line 44: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 52: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 58: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 70: warning: exported function ParseEndpoint should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/driver/identity.go
    • Line 25: warning: exported method Driver.GetPluginInfo should have comment or be unexported (golint)
    • Line 34: warning: exported method Driver.GetPluginCapabilities should have comment or be unexported (golint)
    • Line 50: warning: exported method Driver.Probe should have comment or be unexported (golint)
    • aws-fsx-csi-driver/tests/e2e/testsuites/testsuites.go
    • Line 23: warning: should not use dot imports (golint)
    • Line 24: warning: should not use dot imports (golint)
    • Line 45: warning: exported type TestStorageClass should have comment or be unexported (golint)
    • Line 51: warning: exported function NewTestStorageClass should have comment or be unexported (golint)
    • Line 59: warning: exported method TestStorageClass.Create should have comment or be unexported (golint)
    • Line 68: warning: exported method TestStorageClass.Cleanup should have comment or be unexported (golint)
    • Line 74: warning: exported type TestPersistentVolumeClaim should have comment or be unexported (golint)
    • Line 86: warning: exported function NewTestPersistentVolumeClaim should have comment or be unexported (golint)
    • Line 96: warning: exported method TestPersistentVolumeClaim.Create should have comment or be unexported (golint)
    • Line 109: warning: exported method TestPersistentVolumeClaim.ValidateProvisionedPersistentVolume should have comment or be unexported (golint)
    • Line 150: warning: exported method TestPersistentVolumeClaim.WaitForBound should have comment or be unexported (golint)
    • Line 187: warning: exported method TestPersistentVolumeClaim.Cleanup should have comment or be unexported (golint)
    • Line 207: warning: exported method TestPersistentVolumeClaim.ReclaimPolicy should have comment or be unexported (golint)
    • Line 211: warning: exported method TestPersistentVolumeClaim.WaitForPersistentVolumePhase should have comment or be unexported (golint)
    • Line 216: warning: exported method TestPersistentVolumeClaim.DeleteBoundPersistentVolume should have comment or be unexported (golint)
    • Line 225: warning: exported method TestPersistentVolumeClaim.DeleteBackingVolume should have comment or be unexported (golint)
    • Line 250: warning: exported type TestPod should have comment or be unexported (golint)
    • Line 256: warning: exported function NewTestPod should have comment or be unexported (golint)
    • Line 281: warning: exported method TestPod.Create should have comment or be unexported (golint)
    • Line 288: warning: exported method TestPod.WaitForSuccess should have comment or be unexported (golint)
    • Line 293: warning: exported method TestPod.WaitForRunning should have comment or be unexported (golint)
    • Line 312: warning: exported method TestPod.WaitForFailure should have comment or be unexported (golint)
    • Line 317: warning: exported method TestPod.SetupVolume should have comment or be unexported (golint)
    • Line 336: warning: exported method TestPod.SetupRawBlockVolume should have comment or be unexported (golint)
    • Line 354: warning: exported method TestPod.SetNodeSelector should have comment or be unexported (golint)
    • Line 358: warning: exported method TestPod.Cleanup should have comment or be unexported (golint)
    • Line 362: warning: exported method TestPod.Logs should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/driver/controller.go
    • Line 57: warning: exported method Driver.CreateVolume should have comment or be unexported (golint)
    • Line 164: warning: exported method Driver.DeleteVolume should have comment or be unexported (golint)
    • Line 181: warning: exported method Driver.ControllerPublishVolume should have comment or be unexported (golint)
    • Line 185: warning: exported method Driver.ControllerUnpublishVolume should have comment or be unexported (golint)
    • Line 189: warning: exported method Driver.ControllerGetCapabilities should have comment or be unexported (golint)
    • Line 205: warning: exported method Driver.GetCapacity should have comment or be unexported (golint)
    • Line 210: warning: exported method Driver.ListVolumes should have comment or be unexported (golint)
    • Line 215: warning: exported method Driver.ValidateVolumeCapabilities should have comment or be unexported (golint)
    • Line 245: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 269: warning: exported method Driver.CreateSnapshot should have comment or be unexported (golint)
    • Line 273: warning: exported method Driver.DeleteSnapshot should have comment or be unexported (golint)
    • Line 277: warning: exported method Driver.ListSnapshots should have comment or be unexported (golint)
    • Line 281: warning: exported method Driver.ControllerExpandVolume should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/cloud/fakes.go
    • Line 32: warning: exported type FakeCloudProvider should have comment or be unexported (golint)
    • Line 37: warning: exported function NewFakeCloudProvider should have comment or be unexported (golint)
    • Line 44: warning: exported method FakeCloudProvider.GetMetadata should have comment or be unexported (golint)
    • Line 48: warning: exported method FakeCloudProvider.CreateFileSystem should have comment or be unexported (golint)
    • Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 68: warning: exported method FakeCloudProvider.DeleteFileSystem should have comment or be unexported (golint)
    • Line 78: warning: exported method FakeCloudProvider.DescribeFileSystem should have comment or be unexported (golint)
    • Line 87: warning: exported method FakeCloudProvider.WaitForFileSystemAvailable should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/driver/driver.go
    • Line 31: warning: exported const DriverName should have comment (or a comment on this block) or be unexported (golint)
    • Line 45: warning: exported type Driver should have comment or be unexported (golint)
    • Line 55: warning: exported function NewDriver should have comment or be unexported (golint)
    • Line 72: warning: exported method Driver.Run should have comment or be unexported (golint)
    • Line 103: warning: exported method Driver.Stop should have comment or be unexported (golint)
    • aws-fsx-csi-driver/pkg/driver/version.go
    • Line 31: warning: exported type VersionInfo should have comment or be unexported (golint)
    • Line 40: warning: exported function GetVersion should have comment or be unexported (golint)
    • Line 50: warning: exported function GetVersionJSON should have comment or be unexported (golint)
    • aws-fsx-csi-driver/tests/e2e/testsuites/specs.go
    • Line 26: warning: should not use dot imports (golint)
    • Line 29: warning: exported type PodDetails should have comment or be unexported (golint)
    • Line 34: warning: exported type VolumeDetails should have comment or be unexported (golint)
    • Line 44: warning: exported type VolumeMountDetails should have comment or be unexported (golint)
    • Line 50: warning: exported type VolumeDeviceDetails should have comment or be unexported (golint)
    • Line 55: warning: exported method PodDetails.SetupWithDynamicVolumes should have comment or be unexported (golint)
    • Line 67: warning: exported method VolumeDetails.SetupDynamicPersistentVolumeClaim should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell96%

Misspell Finds commonly misspelled English words