Preparing report...

Report for github.com/kubernetes/helm

A+    Excellent!    Found 46 issues across 357 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo90%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

    • helm/pkg/action/upgrade.go
    • Line 244: warning: cyclomatic complexity 25 of function (*Upgrade).performUpgrade() is high (> 15) (gocyclo)
    • Line 148: warning: cyclomatic complexity 16 of function (*Upgrade).prepareUpgrade() is high (> 15) (gocyclo)
    • helm/pkg/downloader/manager.go
    • Line 243: warning: cyclomatic complexity 32 of function (*Manager).downloadAll() is high (> 15) (gocyclo)
    • Line 541: warning: cyclomatic complexity 24 of function (*Manager).resolveRepoNames() is high (> 15) (gocyclo)
    • helm/pkg/strvals/parser.go
    • Line 272: warning: cyclomatic complexity 22 of function (*parser).listItem() is high (> 15) (gocyclo)
    • Line 153: warning: cyclomatic complexity 19 of function (*parser).key() is high (> 15) (gocyclo)
    • helm/pkg/repo/index_test.go
    • Line 217: warning: cyclomatic complexity 17 of function TestDownloadIndexFile() is high (> 15) (gocyclo)
    • Line 315: warning: cyclomatic complexity 16 of function verifyLocalIndex() is high (> 15) (gocyclo)

golint96%

Golint is a linter for Go source code.

    • helm/pkg/time/time.go
    • Line 43: warning: exported method Time.MarshalJSON should have comment or be unexported (golint)
    • Line 51: warning: exported method Time.UnmarshalJSON should have comment or be unexported (golint)
    • Line 64: warning: exported function Parse should have comment or be unexported (golint)
    • Line 68: warning: exported function ParseInLocation should have comment or be unexported (golint)
    • Line 73: warning: exported function Date should have comment or be unexported (golint)
    • Line 77: warning: exported function Unix should have comment or be unexported (golint)
    • Line 79: warning: exported method Time.Add should have comment or be unexported (golint)
    • Line 80: warning: exported method Time.AddDate should have comment or be unexported (golint)
    • Line 83: warning: exported method Time.After should have comment or be unexported (golint)
    • Line 84: warning: exported method Time.Before should have comment or be unexported (golint)
    • Line 85: warning: exported method Time.Equal should have comment or be unexported (golint)
    • Line 86: warning: exported method Time.In should have comment or be unexported (golint)
    • Line 87: warning: exported method Time.Local should have comment or be unexported (golint)
    • Line 88: warning: exported method Time.Round should have comment or be unexported (golint)
    • Line 89: warning: exported method Time.Sub should have comment or be unexported (golint)
    • Line 90: warning: exported method Time.Truncate should have comment or be unexported (golint)
    • Line 91: warning: exported method Time.UTC should have comment or be unexported (golint)
    • helm/pkg/cli/environment.go
    • Line 73: warning: exported function New should have comment or be unexported (golint)
    • Line 147: warning: exported method EnvSettings.EnvVars should have comment or be unexported (golint)
    • helm/pkg/action/pull.go
    • Line 51: warning: exported type PullOpt should have comment or be unexported (golint)
    • Line 53: warning: exported function WithConfig should have comment or be unexported (golint)
    • helm/pkg/getter/getter.go
    • Line 97: warning: exported function WithTagName should have comment or be unexported (golint)
    • Line 103: warning: exported function WithRegistryClient should have comment or be unexported (golint)
    • Line 109: warning: exported function WithUntar should have comment or be unexported (golint)
    • helm/pkg/repo/repotest/server.go
    • Line 59: warning: exported type OCIServer should have comment or be unexported (golint)
    • Line 68: warning: exported type OCIServerRunConfig should have comment or be unexported (golint)
    • Line 72: warning: exported type OCIServerOpt should have comment or be unexported (golint)
    • Line 74: warning: exported function WithDependingChart should have comment or be unexported (golint)
    • Line 80: warning: exported function NewOCIServer should have comment or be unexported (golint)
    • Line 127: warning: exported method OCIServer.Run should have comment or be unexported (golint)
    • Line 328: warning: exported method Server.Start should have comment or be unexported (golint)
    • Line 337: warning: exported method Server.StartTLS should have comment or be unexported (golint)
    • helm/pkg/kube/fake/printer.go
    • Line 50: warning: exported method PrintingKubeClient.Wait should have comment or be unexported (golint)
    • Line 55: warning: exported method PrintingKubeClient.WaitWithJobs should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!