Report for github.com/kubernetes/perf-tests
A+ Excellent! Found 34 issues across 210 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo94%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
perf-tests/clusterloader2/pkg/measurement/util/pods.go
- Line 52: warning: cyclomatic complexity 16 of function ComputePodsStartupStatus() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/measurement/common/resource_usage.go
- Line 60: warning: cyclomatic complexity 18 of function (*resourceUsageMetricMeasurement).Execute() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/test/simple_test_executor.go
- Line 182: warning: cyclomatic complexity 20 of function (*simpleExecutor).ExecutePhase() is high (> 15) (gocyclo)
- Line 285: warning: cyclomatic complexity 16 of function (*simpleExecutor).ExecuteObject() is high (> 15) (gocyclo)
-
-
perf-tests/compare/src/main/result-comparator.go
- Line 48: warning: cyclomatic complexity 26 of function main() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/cmd/clusterloader.go
- Line 237: warning: cyclomatic complexity 31 of function main() is high (> 15) (gocyclo)
-
-
perf-tests/compare/src/scraper.go
- Line 39: warning: cyclomatic complexity 17 of function ProcessSingleTest() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/prometheus/prometheus.go
- Line 169: warning: cyclomatic complexity 18 of function (*Controller).SetUpPrometheusStack() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/measurement/util/gatherers/container_resource_gatherer.go
- Line 84: warning: cyclomatic complexity 18 of function NewResourceUsageGatherer() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/measurement/common/wait_for_controlled_pods.go
- Line 199: warning: cyclomatic complexity 16 of function (*waitForControlledPodsRunningMeasurement).gather() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/measurement/common/bundle/test_metrics.go
- Line 39: warning: cyclomatic complexity 16 of function createTestMetricsMeasurement() is high (> 15) (gocyclo)
-
-
perf-tests/clusterloader2/pkg/measurement/util/wait_for_pods.go
- Line 52: warning: cyclomatic complexity 19 of function WaitForPods() is high (> 15) (gocyclo)
golint92%
Golint is a linter for Go source code.
-
-
perf-tests/clusterloader2/pkg/provider/aks.go
- Line 23: warning: exported type AKSProvider should have comment or be unexported (golint)
- Line 27: warning: exported function NewAKSProvider should have comment or be unexported (golint)
- Line 38: warning: exported method AKSProvider.Name should have comment or be unexported (golint)
- Line 42: warning: exported method AKSProvider.Features should have comment or be unexported (golint)
- Line 46: warning: exported method AKSProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 50: warning: exported method AKSProvider.GetConfig should have comment or be unexported (golint)
- Line 54: warning: exported method AKSProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 58: warning: exported method AKSProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/constants.go
- Line 20: warning: exported const AKSName should have comment (or a comment on this block) or be unexported (golint)
- Line 33: warning: exported const RootKubeConfigKey should have comment (or a comment on this block) or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/eks.go
- Line 24: warning: exported type EKSProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewEKSProvider should have comment or be unexported (golint)
- Line 40: warning: exported method EKSProvider.Name should have comment or be unexported (golint)
- Line 44: warning: exported method EKSProvider.Features should have comment or be unexported (golint)
- Line 48: warning: exported method EKSProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 52: warning: exported method EKSProvider.GetConfig should have comment or be unexported (golint)
- Line 56: warning: exported method EKSProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 65: warning: exported method EKSProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/gce.go
- Line 31: warning: exported type GCEProvider should have comment or be unexported (golint)
- Line 35: warning: exported function NewGCEProvider should have comment or be unexported (golint)
- Line 52: warning: exported method GCEProvider.Name should have comment or be unexported (golint)
- Line 56: warning: exported method GCEProvider.Features should have comment or be unexported (golint)
- Line 60: warning: exported method GCEProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 64: warning: exported method GCEProvider.GetConfig should have comment or be unexported (golint)
- Line 68: warning: exported method GCEProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 77: warning: exported method GCEProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/kubemark.go
- Line 25: warning: exported type KubemarkProvider should have comment or be unexported (golint)
- Line 30: warning: exported function NewKubemarkProvider should have comment or be unexported (golint)
- Line 47: warning: exported method KubemarkProvider.Name should have comment or be unexported (golint)
- Line 51: warning: exported method KubemarkProvider.Features should have comment or be unexported (golint)
- Line 55: warning: exported method KubemarkProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 59: warning: exported method KubemarkProvider.GetConfig should have comment or be unexported (golint)
- Line 63: warning: exported method KubemarkProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 72: warning: comment on exported method KubemarkProvider.Metadata should be of the form "Metadata ..." (golint)
-
-
perf-tests/util-images/network/netperfbenchmark/pkg/worker/worker.go
- Line 120: warning: exported function NewWorker should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/measurement/common/loadbalancer_nodesync_latency.go
- Line 73: warning: exported type LoadBalancerNodeSyncMeasurement should have comment or be unexported (golint)
- Line 87: warning: comment on exported method LoadBalancerNodeSyncMeasurement.Execute should be of the form "Execute ..." (golint)
- Line 119: warning: exported method LoadBalancerNodeSyncMeasurement.Dispose should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/aws.go
- Line 24: warning: exported type AWSProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewAWSProvider should have comment or be unexported (golint)
- Line 41: warning: exported method AWSProvider.Name should have comment or be unexported (golint)
- Line 45: warning: exported method AWSProvider.Features should have comment or be unexported (golint)
- Line 49: warning: exported method AWSProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 53: warning: exported method AWSProvider.GetConfig should have comment or be unexported (golint)
- Line 57: warning: exported method AWSProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 66: warning: exported method AWSProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/skeleton.go
- Line 24: warning: exported type SkeletonProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewSkeletonProvider should have comment or be unexported (golint)
- Line 41: warning: exported method SkeletonProvider.Name should have comment or be unexported (golint)
- Line 45: warning: exported method SkeletonProvider.Features should have comment or be unexported (golint)
- Line 49: warning: exported method SkeletonProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 53: warning: exported method SkeletonProvider.GetConfig should have comment or be unexported (golint)
- Line 57: warning: exported method SkeletonProvider.GetRootFrameworkKubeConfigOverride should have comment or be unexported (golint)
- Line 61: warning: exported method SkeletonProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 70: warning: exported method SkeletonProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/measurement/util/runtimeobjects/replicaswatcher.go
- Line 61: warning: exported method ConstReplicas.Replicas should have comment or be unexported (golint)
- Line 65: warning: exported method ConstReplicas.Start should have comment or be unexported (golint)
- Line 92: warning: exported method NodeCounter.Start should have comment or be unexported (golint)
- Line 136: warning: exported method NodeCounter.Replicas should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/measurement/common/prometheus_measurement.go
- Line 31: warning: exported function CreatePrometheusMeasurement should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/kind.go
- Line 25: warning: exported type KindProvider should have comment or be unexported (golint)
- Line 29: warning: exported function NewKindProvider should have comment or be unexported (golint)
- Line 42: warning: exported method KindProvider.Name should have comment or be unexported (golint)
- Line 46: warning: exported method KindProvider.Features should have comment or be unexported (golint)
- Line 50: warning: exported method KindProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 54: warning: exported method KindProvider.GetConfig should have comment or be unexported (golint)
- Line 58: warning: exported method KindProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 64: warning: exported method KindProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/vsphere.go
- Line 24: warning: exported type VsphereProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewVsphereProvider should have comment or be unexported (golint)
- Line 41: warning: exported method VsphereProvider.Name should have comment or be unexported (golint)
- Line 45: warning: exported method VsphereProvider.Features should have comment or be unexported (golint)
- Line 49: warning: exported method VsphereProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 53: warning: exported method VsphereProvider.GetConfig should have comment or be unexported (golint)
- Line 57: warning: exported method VsphereProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 66: warning: exported method VsphereProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/test/simple_reporter.go
- Line 37: warning: exported function CreateSimpleReporter should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/gke.go
- Line 24: warning: exported type GKEProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewGKEProvider should have comment or be unexported (golint)
- Line 43: warning: exported method GKEProvider.Name should have comment or be unexported (golint)
- Line 47: warning: exported method GKEProvider.Features should have comment or be unexported (golint)
- Line 51: warning: exported method GKEProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 55: warning: exported method GKEProvider.GetConfig should have comment or be unexported (golint)
- Line 59: warning: exported method GKEProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 68: warning: exported method GKEProvider.Metadata should have comment or be unexported (golint)
-
-
perf-tests/clusterloader2/pkg/provider/local.go
- Line 24: warning: exported type LocalProvider should have comment or be unexported (golint)
- Line 28: warning: exported function NewLocalProvider should have comment or be unexported (golint)
- Line 41: warning: exported method LocalProvider.Name should have comment or be unexported (golint)
- Line 45: warning: exported method LocalProvider.Features should have comment or be unexported (golint)
- Line 49: warning: exported method LocalProvider.GetComponentProtocolAndPort should have comment or be unexported (golint)
- Line 53: warning: exported method LocalProvider.GetConfig should have comment or be unexported (golint)
- Line 57: warning: exported method LocalProvider.RunSSHCommand should have comment or be unexported (golint)
- Line 66: warning: exported method LocalProvider.Metadata should have comment or be unexported (golint)
ineffassign98%
IneffAssign detects ineffectual assignments in Go code.
-
-
perf-tests/clusterloader2/pkg/measurement/util/checker/checker_map.go
- Line 37: warning: ineffectual assignment to cm (ineffassign)
-
-
perf-tests/benchmark/pkg/metricsfetcher/util/mock_util.go
- Line 85: warning: ineffectual assignment to ok (ineffassign)
-
-
perf-tests/slo-monitor/src/monitors/pod_monitor.go
- Line 257: warning: ineffectual assignment to ok (ineffassign)
- Line 272: warning: ineffectual assignment to ok (ineffassign)
- Line 290: warning: ineffectual assignment to ok (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
perf-tests/clusterloader2/pkg/config/template_functions.go
- Line 72: warning: "incremential" is a misspelling of "incremental" (misspell)
- Line 261: warning: "incremential" is a misspelling of "incremental" (misspell)
-
-
perf-tests/clusterloader2/cmd/clusterloader.go
- Line 337: warning: "compliation" is a misspelling of "compilation" (misspell)
-
-
perf-tests/clusterloader2/pkg/chaos/nodes.go
- Line 194: warning: "happend" is a misspelling of "happened" (misspell)
-
-
perf-tests/clusterloader2/pkg/measurement/common/slos/slo_measurement_test.go
- Line 70: warning: "incorect" is a misspelling of "incorrect" (misspell)
-
-
perf-tests/clusterloader2/pkg/measurement/common/scheduler_latency.go
- Line 147: warning: "substract" is a misspelling of "subtract" (misspell)
- Line 155: warning: "substract" is a misspelling of "subtract" (misspell)