Go Report Card

Preparing report...

Report for github.com/kubicorn/controller

A    Great!    Found 13 issues across 13 files

Tweet
Last refresh:

Refresh now

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!

go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!

gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!

golint15%

Golint is a linter for Go source code.

    • controller/service/aws/instance.go
    • Line 36: warning: exported type AWSMachine should have comment or be unexported (golint)
    • Line 45: warning: exported function New should have comment or be unexported (golint)
    • Line 63: warning: exported method AWSMachine.Create should have comment or be unexported (golint)
    • Line 152: warning: exported method AWSMachine.Exists should have comment or be unexported (golint)
    • Line 209: warning: exported method AWSMachine.Destroy should have comment or be unexported (golint)
    • Line 247: warning: exported method AWSMachine.ListIDs should have comment or be unexported (golint)
    • controller/service/common.go
    • Line 35: warning: exported function RunService should have comment or be unexported (golint)
    • Line 47: warning: exported function ConcurrentReconcileMachines should have comment or be unexported (golint)
    • controller/loop/machineset.go
    • Line 17: warning: exported type MemoryMachineSet should have comment or be unexported (golint)
    • Line 20: warning: exported function NewMemoryMachineSetFromCRD should have comment or be unexported (golint)
    • Line 24: warning: exported method MemoryMachineSet.Ensure should have comment or be unexported (golint)
    • controller/machine/aws/instance.go
    • Line 22: warning: exported type AWSMachine should have comment or be unexported (golint)
    • Line 25: warning: exported function New should have comment or be unexported (golint)
    • Line 29: warning: exported method AWSMachine.Create should have comment or be unexported (golint)
    • Line 33: warning: exported method AWSMachine.Get should have comment or be unexported (golint)
    • Line 37: warning: exported method AWSMachine.Destroy should have comment or be unexported (golint)
    • controller/service/config.go
    • Line 22: warning: exported type CloudProvider should have comment or be unexported (golint)
    • Line 24: warning: exported type ServiceConfiguration should have comment or be unexported (golint)
    • Line 30: warning: exported method ServiceConfiguration.GetFilePath should have comment or be unexported (golint)
    • controller/loop/machine.go
    • Line 17: warning: exported type MemoryMachine should have comment or be unexported (golint)
    • Line 20: warning: exported function NewMemoryMachineFromCRD should have comment or be unexported (golint)
    • Line 24: warning: exported method MemoryMachine.Ensure should have comment or be unexported (golint)
    • controller/loop/state.go
    • Line 17: warning: exported type State should have comment or be unexported (golint)
    • Line 20: warning: exported function AtomicGetState should have comment or be unexported (golint)
    • Line 24: warning: exported method State.AtomicEnsureAttempt should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign38%

IneffAssign detects ineffectual assignments in Go code.

    • controller/machine/aws/instance.go
    • Line 18: warning: cannot find package "." in: (ineffassign)
    • Line 19: warning: cannot find package "." in: (ineffassign)
    • Line 18: warning: could not import github.com/kubicorn/controller/machine (invalid package name: "") (ineffassign)
    • Line 19: warning: could not import k8s.io/kube-deploy/cluster-api/api/cluster/v1alpha1 (invalid package name: "") (ineffassign)
    • controller/main.go
    • Line 17: warning: cannot find package "." in: (ineffassign)
    • Line 17: warning: could not import github.com/kubicorn/controller/cmd (invalid package name: "") (ineffassign)
    • controller/cmd/root.go
    • Line 37: warning: cannot find package "." in: (ineffassign)
    • Line 38: warning: cannot find package "." in: (ineffassign)
    • Line 39: warning: cannot find package "." in: (ineffassign)
    • Line 40: warning: cannot find package "." in: (ineffassign)
    • Line 37: warning: could not import github.com/kubicorn/controller/service (invalid package name: "") (ineffassign)
    • Line 38: warning: could not import github.com/kubicorn/controller/service/aws (invalid package name: "") (ineffassign)
    • Line 39: warning: could not import github.com/kubicorn/kubicorn/pkg/logger (invalid package name: "") (ineffassign)
    • Line 40: warning: could not import github.com/spf13/cobra (invalid package name: "") (ineffassign)
    • controller/service/aws/instance.go
    • Line 26: warning: cannot find package "." in: (ineffassign)
    • Line 27: warning: cannot find package "." in: (ineffassign)
    • Line 28: warning: cannot find package "." in: (ineffassign)
    • Line 29: warning: cannot find package "." in: (ineffassign)
    • Line 30: warning: cannot find package "." in: (ineffassign)
    • Line 31: warning: cannot find package "." in: (ineffassign)
    • Line 32: warning: cannot find package "." in: (ineffassign)
    • Line 33: warning: cannot find package "." in: (ineffassign)
    • Line 26: warning: could not import github.com/aws/aws-sdk-go/aws (invalid package name: "") (ineffassign)
    • Line 27: warning: could not import github.com/aws/aws-sdk-go/aws/credentials/stscreds (invalid package name: "") (ineffassign)
    • Line 28: warning: could not import github.com/aws/aws-sdk-go/aws/session (invalid package name: "") (ineffassign)
    • Line 29: warning: could not import github.com/aws/aws-sdk-go/service/ec2 (invalid package name: "") (ineffassign)
    • Line 30: warning: could not import github.com/kubicorn/controller/service (invalid package name: "") (ineffassign)
    • Line 31: warning: could not import github.com/kubicorn/kubicorn/apis/cluster (invalid package name: "") (ineffassign)
    • Line 32: warning: could not import github.com/kubicorn/kubicorn/pkg/logger (invalid package name: "") (ineffassign)
    • Line 33: warning: could not import k8s.io/kube-deploy/cluster-api/api/cluster/v1alpha1 (invalid package name: "") (ineffassign)
    • controller/service/common.go
    • Line 30: warning: cannot find package "." in: (ineffassign)
    • Line 31: warning: cannot find package "." in: (ineffassign)
    • Line 32: warning: cannot find package "." in: (ineffassign)
    • Line 18: warning: cannot find package "." in: (ineffassign)
    • Line 19: warning: cannot find package "." in: (ineffassign)
    • Line 20: warning: cannot find package "." in: (ineffassign)
    • Line 21: warning: cannot find package "." in: (ineffassign)
    • Line 22: warning: cannot find package "." in: (ineffassign)
    • Line 18: warning: could not import k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset (invalid package name: "") (ineffassign)
    • Line 19: warning: could not import k8s.io/apimachinery/pkg/apis/meta/v1 (invalid package name: "") (ineffassign)
    • Line 20: warning: could not import k8s.io/client-go/tools/clientcmd (invalid package name: "") (ineffassign)
    • Line 21: warning: could not import k8s.io/kube-deploy/cluster-api/client (invalid package name: "") (ineffassign)
    • Line 22: warning: could not import k8s.io/kube-deploy/cluster-api/util (invalid package name: "") (ineffassign)
    • Line 30: warning: could not import github.com/kubicorn/controller/backoff (invalid package name: "") (ineffassign)
    • Line 31: warning: could not import github.com/kubicorn/kubicorn/apis/cluster (invalid package name: "") (ineffassign)
    • Line 32: warning: could not import github.com/kubicorn/kubicorn/pkg/logger (invalid package name: "") (ineffassign)

misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!