Report for github.com/leocarmona/workerpool
(v1.0.0)
A+ Excellent! Found 4 issues across 6 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo83%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
workerpool_test.go
- Line 13: warning: cyclomatic complexity 18 of function TestWorkerPool() is high (> 15) (gocyclo)
golint50%
Golint is a linter for Go source code.
-
-
settings.go
- Line 8: warning: exported type Settings should have comment or be unexported (golint)
-
-
workerpool.go
- Line 12: warning: exported type WorkerPool should have comment or be unexported (golint)
- Line 45: warning: exported function New should have comment or be unexported (golint)
- Line 181: warning: comment on exported method WorkerPool.ScaleDown should be of the form "ScaleDown ..." (golint)
- Line 256: warning: exported method WorkerPool.Stopped should have comment or be unexported (golint)
- Line 260: warning: exported method WorkerPool.Metrics should have comment or be unexported (golint)
- Line 264: warning: exported method WorkerPool.MinWorkers should have comment or be unexported (golint)
- Line 268: warning: exported method WorkerPool.SetMinWorkers should have comment or be unexported (golint)
- Line 288: warning: exported method WorkerPool.MaxWorkers should have comment or be unexported (golint)
- Line 292: warning: exported method WorkerPool.SetMaxWorkers should have comment or be unexported (golint)
- Line 315: warning: exported method WorkerPool.IdleTimeout should have comment or be unexported (golint)
- Line 319: warning: exported method WorkerPool.SetIdleTimeout should have comment or be unexported (golint)
- Line 328: warning: exported method WorkerPool.UpScaling should have comment or be unexported (golint)
- Line 332: warning: exported method WorkerPool.SetUpScaling should have comment or be unexported (golint)
- Line 340: warning: exported method WorkerPool.DownScaling should have comment or be unexported (golint)
- Line 344: warning: exported method WorkerPool.SetDownScaling should have comment or be unexported (golint)
- Line 352: warning: exported method WorkerPool.QueueCapacity should have comment or be unexported (golint)
- Line 356: warning: exported method WorkerPool.PanicHandler should have comment or be unexported (golint)
- Line 360: warning: exported method WorkerPool.SetPanicHandler should have comment or be unexported (golint)
- Line 492: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
-
-
metrics.go
- Line 8: warning: exported type Metrics should have comment or be unexported (golint)
- Line 12: warning: exported method Metrics.MinWorkers should have comment or be unexported (golint)
- Line 16: warning: exported method Metrics.MaxWorkers should have comment or be unexported (golint)
- Line 20: warning: exported method Metrics.QueueCapacity should have comment or be unexported (golint)
- Line 24: warning: exported method Metrics.RunningWorkers should have comment or be unexported (golint)
- Line 28: warning: exported method Metrics.IdleWorkers should have comment or be unexported (golint)
- Line 32: warning: exported method Metrics.SubmittedTasks should have comment or be unexported (golint)
- Line 36: warning: exported method Metrics.WaitingTasks should have comment or be unexported (golint)
- Line 40: warning: exported method Metrics.SuccessfulTasks should have comment or be unexported (golint)
- Line 44: warning: exported method Metrics.FailedTasks should have comment or be unexported (golint)
- Line 48: warning: exported method Metrics.CompletedTasks should have comment or be unexported (golint)
- Line 52: warning: exported method Metrics.Snapshot should have comment or be unexported (golint)
- Line 72: warning: exported type MetricsSnapshot should have comment or be unexported (golint)
- Line 84: warning: exported method MetricsSnapshot.MinWorkers should have comment or be unexported (golint)
- Line 88: warning: exported method MetricsSnapshot.MaxWorkers should have comment or be unexported (golint)
- Line 92: warning: exported method MetricsSnapshot.QueueCapacity should have comment or be unexported (golint)
- Line 96: warning: exported method MetricsSnapshot.RunningWorkers should have comment or be unexported (golint)
- Line 100: warning: exported method MetricsSnapshot.IdleWorkers should have comment or be unexported (golint)
- Line 104: warning: exported method MetricsSnapshot.SubmittedTasks should have comment or be unexported (golint)
- Line 108: warning: exported method MetricsSnapshot.WaitingTasks should have comment or be unexported (golint)
- Line 112: warning: exported method MetricsSnapshot.SuccessfulTasks should have comment or be unexported (golint)
- Line 116: warning: exported method MetricsSnapshot.FailedTasks should have comment or be unexported (golint)
- Line 120: warning: exported method MetricsSnapshot.CompletedTasks should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!