Preparing report...

Report for github.com/leotaku/kojirou

A+    Excellent!    Found 17 issues across 21 files

Tweet

gofmt100%

Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command

No problems detected. Good job!


go_vet100%

go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.

No problems detected. Good job!


gocyclo100%

Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

No problems detected. Good job!


golint19%

Golint is a linter for Go source code.

    • kojirou/mangadex/unstructured.go
    • Line 10: warning: exported type MangaInfo should have comment or be unexported (golint)
    • Line 17: warning: exported type ChapterInfo should have comment or be unexported (golint)
    • Line 32: warning: exported type ImageItem should have comment or be unexported (golint)
    • Line 41: warning: exported type PathItem should have comment or be unexported (golint)
    • Line 50: warning: exported method PathItem.WithImage should have comment or be unexported (golint)
    • kojirou/cmd/util/fetch.go
    • Line 6: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
    • Line 22: warning: exported var Client should have comment or be unexported (golint)
    • Line 36: warning: exported function FetchPages should have comment or be unexported (golint)
    • Line 52: warning: exported function FetchCovers should have comment or be unexported (golint)
    • kojirou/cmd/util/mobi.go
    • Line 34: warning: exported function VolumesToMobi should have comment or be unexported (golint)
    • Line 101: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kojirou/mangadex/api/data.go
    • Line 9: warning: exported type Localized should have comment or be unexported (golint)
    • Line 11: warning: exported type StringID should have comment or be unexported (golint)
    • Line 13: warning: exported type Manga should have comment or be unexported (golint)
    • Line 19: warning: exported type MangaData should have comment or be unexported (golint)
    • Line 42: warning: exported type ChapterList should have comment or be unexported (golint)
    • Line 49: warning: exported type Chapter should have comment or be unexported (golint)
    • Line 55: warning: exported type ChapterData should have comment or be unexported (golint)
    • Line 73: warning: exported type CoverList should have comment or be unexported (golint)
    • Line 80: warning: exported type Cover should have comment or be unexported (golint)
    • Line 86: warning: exported type CoverData should have comment or be unexported (golint)
    • Line 99: warning: exported type AuthorList should have comment or be unexported (golint)
    • Line 106: warning: exported type Author should have comment or be unexported (golint)
    • Line 112: warning: exported type AuthorData should have comment or be unexported (golint)
    • Line 125: warning: exported type GroupList should have comment or be unexported (golint)
    • Line 132: warning: exported type Group should have comment or be unexported (golint)
    • Line 138: warning: exported type GroupData should have comment or be unexported (golint)
    • Line 151: warning: exported type IDMapping should have comment or be unexported (golint)
    • Line 157: warning: exported type IDMappingData should have comment or be unexported (golint)
    • Line 167: warning: exported type AtHome should have comment or be unexported (golint)
    • Line 171: warning: exported type Relationships should have comment or be unexported (golint)
    • Line 183: warning: exported method Relationships.UnmarshalJSON should have comment or be unexported (golint)
    • Line 217: warning: exported type Relationship should have comment or be unexported (golint)
    • Line 223: warning: exported type Errors should have comment or be unexported (golint)
    • Line 228: warning: exported type ErrorData should have comment or be unexported (golint)
    • kojirou/mangadex/client.go
    • Line 11: warning: exported var CoverBaseURL should have comment or be unexported (golint)
    • Line 13: warning: exported type Client should have comment or be unexported (golint)
    • Line 18: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 25: warning: exported method Client.WithHTTPClient should have comment or be unexported (golint)
    • Line 30: warning: exported method Client.FetchLegacy should have comment or be unexported (golint)
    • Line 43: warning: exported method Client.FetchManga should have comment or be unexported (golint)
    • Line 73: warning: exported method Client.FetchChapters should have comment or be unexported (golint)
    • Line 84: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 101: warning: exported method Client.FetchCovers should have comment or be unexported (golint)
    • Line 112: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 124: warning: exported method Client.FetchPaths should have comment or be unexported (golint)
    • Line 154: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kojirou/mangadex/list.go
    • Line 5: warning: exported type ChapterList should have comment or be unexported (golint)
    • Line 7: warning: exported type PathList should have comment or be unexported (golint)
    • Line 9: warning: exported type ImageList should have comment or be unexported (golint)
    • Line 11: warning: exported method ChapterList.CollapseBy should have comment or be unexported (golint)
    • Line 30: warning: exported method ChapterList.FilterBy should have comment or be unexported (golint)
    • Line 41: warning: exported method ChapterList.SortBy should have comment or be unexported (golint)
    • Line 50: warning: exported method PathList.FilterBy should have comment or be unexported (golint)
    • kojirou/mangadex/structured.go
    • Line 8: warning: exported type Manga should have comment or be unexported (golint)
    • Line 13: warning: exported type Volume should have comment or be unexported (golint)
    • Line 19: warning: exported type Chapter should have comment or be unexported (golint)
    • Line 25: warning: exported method Manga.Sorted should have comment or be unexported (golint)
    • Line 34: warning: exported method Manga.Chapters should have comment or be unexported (golint)
    • Line 45: warning: exported method Manga.Keys should have comment or be unexported (golint)
    • Line 58: warning: exported method Volume.Sorted should have comment or be unexported (golint)
    • Line 67: warning: exported method Volume.Keys should have comment or be unexported (golint)
    • Line 80: warning: exported method Chapter.Sorted should have comment or be unexported (golint)
    • Line 89: warning: exported method Manga.WithChapters should have comment or be unexported (golint)
    • Line 113: warning: exported method Manga.WithPages should have comment or be unexported (golint)
    • Line 134: warning: exported method Manga.WithCovers should have comment or be unexported (golint)
    • kojirou/cmd/util/cleanup.go
    • Line 13: warning: exported function Cleanup should have comment or be unexported (golint)
    • Line 17: warning: exported function InitCleanup should have comment or be unexported (golint)
    • Line 29: warning: exported function RunCleanup should have comment or be unexported (golint)
    • Line 42: warning: exported function SetupDirectories should have comment or be unexported (golint)
    • kojirou/cmd/util/language.go
    • Line 10: warning: exported function MatchLang should have comment or be unexported (golint)
    • Line 16: warning: exported function MatchRegion should have comment or be unexported (golint)
    • kojirou/cmd/util/range.go
    • Line 9: warning: exported type Range should have comment or be unexported (golint)
    • Line 14: warning: exported function ParseRanges should have comment or be unexported (golint)
    • Line 34: warning: exported method Range.Contains should have comment or be unexported (golint)
    • Line 37: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kojirou/mangadex/api/query.go
    • Line 11: warning: exported type QueryArgs should have comment or be unexported (golint)
    • Line 19: warning: exported method QueryArgs.Values should have comment or be unexported (golint)
    • kojirou/cmd/util/bar.go
    • Line 10: warning: exported type Bar should have comment or be unexported (golint)
    • Line 14: warning: exported function NewBar should have comment or be unexported (golint)
    • Line 22: warning: exported method Bar.Message should have comment or be unexported (golint)
    • Line 28: warning: exported method Bar.Fail should have comment or be unexported (golint)
    • Line 35: warning: exported method Bar.Succeed should have comment or be unexported (golint)
    • Line 43: warning: exported method Bar.AddTotal should have comment or be unexported (golint)
    • kojirou/cmd/util/regex.go
    • Line 8: warning: exported function Match should have comment or be unexported (golint)
    • Line 13: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • kojirou/mangadex/api/client.go
    • Line 12: warning: exported var APIBaseURL should have comment or be unexported (golint)
    • Line 14: warning: exported type Client should have comment or be unexported (golint)
    • Line 19: warning: exported function NewClient should have comment or be unexported (golint)
    • Line 26: warning: exported method Client.WithBaseURL should have comment or be unexported (golint)
    • Line 31: warning: exported method Client.WithClient should have comment or be unexported (golint)
    • Line 36: warning: exported method Client.GetManga should have comment or be unexported (golint)
    • Line 42: warning: exported method Client.GetFeed should have comment or be unexported (golint)
    • Line 49: warning: exported method Client.GetCovers should have comment or be unexported (golint)
    • Line 55: warning: exported method Client.GetAuthors should have comment or be unexported (golint)
    • Line 61: warning: exported method Client.GetGroups should have comment or be unexported (golint)
    • Line 67: warning: exported method Client.GetAtHome should have comment or be unexported (golint)
    • Line 73: warning: exported method Client.PostIDMapping should have comment or be unexported (golint)
    • Line 115: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
    • kojirou/mangadex/identifier.go
    • Line 16: warning: exported type Identifier should have comment or be unexported (golint)
    • Line 21: warning: exported function NewIdentifier should have comment or be unexported (golint)
    • Line 28: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
    • Line 35: warning: exported method Identifier.Equal should have comment or be unexported (golint)
    • Line 46: warning: exported method Identifier.Less should have comment or be unexported (golint)
    • Line 61: warning: exported method Identifier.LessOrEqual should have comment or be unexported (golint)
    • Line 65: warning: exported method Identifier.IsSpecial should have comment or be unexported (golint)
    • Line 69: warning: exported method Identifier.IsUnknown should have comment or be unexported (golint)
    • Line 84: warning: exported method Identifier.MarshalJSON should have comment or be unexported (golint)
    • Line 95: warning: exported method Identifier.MarshalText should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!


ineffassign100%

IneffAssign detects ineffectual assignments in Go code.

No problems detected. Good job!


misspell100%

Misspell Finds commonly misspelled English words

No problems detected. Good job!