Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.

- Line 27: warning: cyclomatic complexity 18 of function (*NetworkService).RenderConnL3PP() is high (> 15) (gocyclo)

- Line 26: warning: cyclomatic complexity 18 of function (*NetworkService).RenderConnL2PP() is high (> 15) (gocyclo)
- Line 196: warning: cyclomatic complexity 16 of function (*NetworkService).renderConnL2PPSameNode() is high (> 15) (gocyclo)

- Line 28: warning: cyclomatic complexity 17 of function (*NetworkService).RenderConnL3MP() is high (> 15) (gocyclo)

- Line 454: warning: cyclomatic complexity 16 of function constructBaseHostName() is high (> 15) (gocyclo)

- Line 162: warning: cyclomatic complexity 20 of function (*KVType).ReadFromEtcd() is high (> 15) (gocyclo)
- Line 91: warning: cyclomatic complexity 16 of function (*KVType).Equal() is high (> 15) (gocyclo)

- Line 573: warning: cyclomatic complexity 43 of function (*NetworkService).validateNetworkPod() is high (> 15) (gocyclo)
- Line 441: warning: cyclomatic complexity 35 of function (*NetworkService).validateConnections() is high (> 15) (gocyclo)

- Line 292: warning: cyclomatic complexity 22 of function (*Plugin).PostProcessLoadedDatastore() is high (> 15) (gocyclo)

- Line 27: warning: cyclomatic complexity 19 of function (*NetworkService).RenderConnL2MP() is high (> 15) (gocyclo)

golint74%

Golint is a linter for Go source code.

- Line 30: warning: exported method Bitmap.IsSet should have comment or be unexported (golint)
- Line 38: warning: exported method Bitmap.Set should have comment or be unexported (golint)
- Line 48: warning: exported method Bitmap.Clear should have comment or be unexported (golint)

- Line 47: warning: exported method PoolAllocatorType.GetAllocatedAddressesStatus should have comment or be unexported (golint)

- Line 29: warning: exported type CRDIpamPoolMgr should have comment or be unexported (golint)
- Line 33: warning: exported method CRDIpamPoolMgr.Init should have comment or be unexported (golint)
- Line 36: warning: exported method CRDIpamPoolMgr.AfterInit should have comment or be unexported (golint)
- Line 54: warning: exported method CRDIpamPoolMgr.CrdToSfcIpamPool should have comment or be unexported (golint)

- Line 36: warning: exported type NetworkNodeMgr should have comment or be unexported (golint)
- Line 40: warning: exported method NetworkNodeMgr.ToArray should have comment or be unexported (golint)
- Line 48: warning: exported method NetworkNodeMgr.Init should have comment or be unexported (golint)
- Line 53: warning: exported method NetworkNodeMgr.AfterInit should have comment or be unexported (golint)
- Line 123: warning: exported method NetworkNodeMgr.FindInterfaceInNode should have comment or be unexported (golint)
- Line 138: warning: exported method NetworkNodeMgr.FindInterfacesForThisLabelInNode should have comment or be unexported (golint)
- Line 210: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 539: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 46: warning: exported var CleanDatastore should have comment or be unexported (golint)
- Line 262: warning: comment on exported method Plugin.InitSystemHTTPHandler should be of the form "InitSystemHTTPHandler ..." (golint)

- Line 20: warning: exported const GroupName should have comment (or a comment on this block) or be unexported (golint)

- Line 41: warning: exported var SchemeBuilder should have comment or be unexported (golint)

- Line 29: warning: exported type CRDNetworkNodeMgr should have comment or be unexported (golint)
- Line 33: warning: exported method CRDNetworkNodeMgr.Init should have comment or be unexported (golint)
- Line 36: warning: exported method CRDNetworkNodeMgr.AfterInit should have comment or be unexported (golint)
- Line 54: warning: exported method CRDNetworkNodeMgr.CrdToSfcNetworkNode should have comment or be unexported (golint)

- Line 29: warning: exported type CRDNetworkNodeOverlayMgr should have comment or be unexported (golint)
- Line 33: warning: exported method CRDNetworkNodeOverlayMgr.Init should have comment or be unexported (golint)
- Line 36: warning: exported method CRDNetworkNodeOverlayMgr.AfterInit should have comment or be unexported (golint)
- Line 54: warning: exported method CRDNetworkNodeOverlayMgr.CrdToSfcNetworkNodeOverlay should have comment or be unexported (golint)

- Line 25: warning: exported function InitInterfaceStatus should have comment or be unexported (golint)
- Line 89: warning: exported function PersistInterfaceStatus should have comment or be unexported (golint)
- Line 105: warning: exported function RetrieveInterfaceStatusFromRamCache should have comment or be unexported (golint)
- Line 118: warning: exported function RemoveInterfaceStatus should have comment or be unexported (golint)
- Line 132: warning: exported function UpdateRamCacheAllocatorsForInterfaceStatus should have comment or be unexported (golint)
- Line 159: warning: comment on exported function InterfaceStatusKeyPrefix should be of the form "InterfaceStatusKeyPrefix ..." (golint)

- Line 34: warning: exported type NetworkNodeOverlayMgr should have comment or be unexported (golint)
- Line 40: warning: exported method NetworkNodeOverlayMgr.ToArray should have comment or be unexported (golint)
- Line 48: warning: exported method NetworkNodeOverlayMgr.Init should have comment or be unexported (golint)
- Line 53: warning: exported method NetworkNodeOverlayMgr.AfterInit should have comment or be unexported (golint)
- Line 193: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)

- Line 39: warning: exported function VppAgentSetLogger should have comment or be unexported (golint)
- Line 603: warning: exported function ConstructStaticArpEntry should have comment or be unexported (golint)

- Line 29: warning: exported function RegisterModelType should have comment or be unexported (golint)
- Line 47: warning: exported method Plugin.RegisterModelTypeManagers should have comment or be unexported (golint)

- Line 37: warning: exported type NetworkServiceMgr should have comment or be unexported (golint)
- Line 41: warning: exported method NetworkServiceMgr.ToArray should have comment or be unexported (golint)
- Line 49: warning: exported method NetworkServiceMgr.Init should have comment or be unexported (golint)
- Line 54: warning: exported method NetworkServiceMgr.AfterInit should have comment or be unexported (golint)
- Line 143: warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
- Line 681: warning: exported method NetworkServiceMgr.FindInterfaceStatus should have comment or be unexported (golint)
- Line 690: warning: exported method NetworkService.RenderL2BD should have comment or be unexported (golint)
- Line 737: warning: exported method NetworkService.RenderNetworkPodL2BD should have comment or be unexported (golint)

- Line 398: warning: comment on exported method NetworkService.RenderInterfaceForwarding should be of the form "RenderInterfaceForwarding ..." (golint)

- Line 36: warning: exported function ConfigMutexSet should have comment or be unexported (golint)
- Line 40: warning: exported function RenderTxnGetAfterMap should have comment or be unexported (golint)

- Line 34: warning: exported type NetworkPodToNodeMapMgr should have comment or be unexported (golint)
- Line 38: warning: exported method NetworkPodToNodeMapMgr.ToArray should have comment or be unexported (golint)
- Line 46: warning: exported method NetworkPodToNodeMapMgr.Init should have comment or be unexported (golint)
- Line 51: warning: exported method NetworkPodToNodeMapMgr.AfterInit should have comment or be unexported (golint)
- Line 288: warning: comment on exported method NetworkPodToNodeMapMgr.ContivKsrNetworkPodToNodePrefix should be of the form "ContivKsrNetworkPodToNodePrefix ..." (golint)
- Line 389: warning: should omit values from range; this loop is equivalent to `for range ...` (golint)

- Line 22: warning: exported type VxlanVniAllocatorType should have comment or be unexported (golint)

- Line 48: warning: comment on exported type SfcController should be of the form "SfcController ..." (with optional leading article) (golint)

- Line 25: warning: exported const CRDGroupName should have comment (or a comment on this block) or be unexported (golint)

- Line 29: warning: exported type CRDNetworkServiceMgr should have comment or be unexported (golint)
- Line 33: warning: exported method CRDNetworkServiceMgr.Init should have comment or be unexported (golint)
- Line 36: warning: exported method CRDNetworkServiceMgr.AfterInit should have comment or be unexported (golint)
- Line 54: warning: exported method CRDNetworkServiceMgr.CrdToSfcNetworkService should have comment or be unexported (golint)

- Line 35: warning: exported type IPAMPoolMgr should have comment or be unexported (golint)
- Line 39: warning: exported method IPAMPoolMgr.ToArray should have comment or be unexported (golint)
- Line 47: warning: exported method IPAMPoolMgr.Init should have comment or be unexported (golint)
- Line 52: warning: exported method IPAMPoolMgr.AfterInit should have comment or be unexported (golint)
- Line 82: warning: receiver name ipamPool should be consistent with previous receiver name ip for IPAMPool (golint)

- Line 20: warning: exported const ModelTypeSysParameters should have comment (or a comment on this block) or be unexported (golint)
- Line 36: warning: exported function RegisterModelType should have comment or be unexported (golint)
- Line 61: warning: exported method Plugin.RegisterModelTypeManagers should have comment or be unexported (golint)
- Line 80: warning: exported const OperationalMsgOpCodeRender should have comment (or a comment on this block) or be unexported (golint)
- Line 88: warning: exported type OperationalMsg should have comment or be unexported (golint)
- Line 93: warning: exported var OperationalMsgChannel should have comment or be unexported (golint)
- Line 169: warning: exported method Plugin.AddOperationMsgToQueue should have comment or be unexported (golint)

license100%

Checks whether your project has a LICENSE file.

No problems detected. Good job!

ineffassign96%

IneffAssign detects ineffectual assignments in Go code.

- Line 212: warning: ineffectual assignment to ipamPoolAllocator (ineffassign)

- Line 116: warning: ineffectual assignment to exists (ineffassign)

- Line 109: warning: ineffectual assignment to exists (ineffassign)

misspell91%

Misspell Finds commonly misspelled English words

- Line 61: warning: "existant" is a misspelling of "existent" (misspell)
- Line 132: warning: "smae" is a misspelling of "same" (misspell)

- Line 65: warning: "existant" is a misspelling of "existent" (misspell)
- Line 146: warning: "netwrok" is a misspelling of "network" (misspell)

- Line 361: warning: "netwrok" is a misspelling of "network" (misspell)

- Line 37: warning: "teh" is a misspelling of "the" (misspell)

- Line 698: warning: "existant" is a misspelling of "existent" (misspell)

- Line 470: warning: "existant" is a misspelling of "existent" (misspell)
- Line 503: warning: "existant" is a misspelling of "existent" (misspell)

- Line 62: warning: "existant" is a misspelling of "existent" (misspell)

- Line 64: warning: "existant" is a misspelling of "existent" (misspell)
- Line 145: warning: "netwrok" is a misspelling of "network" (misspell)

Go Report Card

Preparing report...

Report for github.com/ligato/sfc-controller

gofmt69%

go_vet100%

gocyclo91%

golint74%

license100%

ineffassign96%

misspell91%