Report for github.com/m-lab/go
A+ Excellent! Found 15 issues across 90 files
gofmt96%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
-
-
go/cloudtest/gcs_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
go/cloudtest/bqfake/bqfake_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
-
-
go/cloud/bqx/schema_test.go
- Line 1: warning: file is not gofmted with -s (gofmt)
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo100%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
No problems detected. Good job!
golint93%
Golint is a linter for Go source code.
-
-
go/cloudtest/bqfake/client.go
- Line 93: warning: exported method Client.Query should have comment or be unexported (golint)
- Line 99: warning: exported function NewQueryReadClient should have comment or be unexported (golint)
-
-
go/dataset/dataset.go
- Line 15: warning: package comment should be of the form "Package dataset ..." (golint)
-
-
go/cloudtest/gcsfake/gcsfake.go
- Line 15: warning: package comment should be of the form "Package gcsfake ..." (golint)
-
-
go/cloud/bqfake/bqfake.go
- Line 130: warning: exported method Query.Run should have comment or be unexported (golint)
- Line 148: warning: exported method Job.Wait should have comment or be unexported (golint)
- Line 153: warning: exported type RowIterator should have comment or be unexported (golint)
- Line 159: warning: exported method RowIterator.Next should have comment or be unexported (golint)
-
-
go/cloud/bqfake/client.go
- Line 93: warning: exported method Client.Query should have comment or be unexported (golint)
- Line 99: warning: exported function NewQueryReadClient should have comment or be unexported (golint)
-
-
go/cloudtest/bqfake/bqfake.go
- Line 129: warning: exported method Query.Run should have comment or be unexported (golint)
- Line 147: warning: exported method Job.Wait should have comment or be unexported (golint)
- Line 152: warning: exported type RowIterator should have comment or be unexported (golint)
- Line 158: warning: exported method RowIterator.Next should have comment or be unexported (golint)
ineffassign94%
IneffAssign detects ineffectual assignments in Go code.
-
-
go/siteinfo/client_test.go
- Line 105: warning: ineffectual assignment to res (ineffassign)
- Line 112: warning: ineffectual assignment to res (ineffassign)
- Line 119: warning: ineffectual assignment to res (ineffassign)
-
-
go/cloud/bqx/dataset_integration_test.go
- Line 160: warning: ineffectual assignment to err (ineffassign)
-
-
go/cloudtest/bqfake/bqfake_test.go
- Line 98: warning: ineffectual assignment to meta (ineffassign)
-
-
go/cloud/bqfake/bqfake_test.go
- Line 99: warning: ineffectual assignment to meta (ineffassign)
-
-
go/cloudtest/gcsfake/gcsfake_test.go
- Line 187: warning: ineffectual assignment to got (ineffassign)
misspell97%
Misspell Finds commonly misspelled English words
-
-
go/prometheusx/prom.go
- Line 67: warning: "udpated" is a misspelling of "updated" (misspell)
-
-
go/siteinfo/formats.go
- Line 8: warning: "negotation" is a misspelling of "negotiation" (misspell)