Report for github.com/markphelps/flipt
A+ Excellent! Found 16 issues across 54 files
gofmt100%
Gofmt formats Go programs. We run gofmt -s on your code, where -s is for the "simplify" command
No problems detected. Good job!
go_vet100%
go vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string.
No problems detected. Good job!
gocyclo88%
Gocyclo calculates cyclomatic complexities of functions in Go source code. The cyclomatic complexity of a function is calculated according to the following rules: 1 is the base complexity of a function +1 for each 'if', 'for', 'case', '&&' or '||' Go Report Card warns on functions with cyclomatic complexity > 15.
-
-
flipt/config/config.go
- Line 244: warning: cyclomatic complexity 39 of function Load() is high (> 15) (gocyclo)
-
-
flipt/storage/db/db_test.go
- Line 269: warning: cyclomatic complexity 18 of function run() is high (> 15) (gocyclo)
-
-
flipt/server/evaluator.go
- Line 85: warning: cyclomatic complexity 30 of function (*Server).evaluate() is high (> 15) (gocyclo)
-
-
flipt/cmd/flipt/main.go
- Line 208: warning: cyclomatic complexity 31 of function run() is high (> 15) (gocyclo)
-
-
flipt/cmd/flipt/import.go
- Line 27: warning: cyclomatic complexity 28 of function runImport() is high (> 15) (gocyclo)
-
-
flipt/cmd/flipt/export.go
- Line 69: warning: cyclomatic complexity 19 of function runExport() is high (> 15) (gocyclo)
golint77%
Golint is a linter for Go source code.
-
-
flipt/rpc/operators.go
- Line 4: warning: exported const OpEQ should have comment (or a comment on this block) or be unexported (golint)
- Line 21: warning: exported var ValidOperators should have comment or be unexported (golint)
-
-
flipt/rpc/validation.go
- Line 17: warning: exported method EvaluationRequest.Validate should have comment or be unexported (golint)
- Line 33: warning: exported method GetFlagRequest.Validate should have comment or be unexported (golint)
- Line 41: warning: exported method CreateFlagRequest.Validate should have comment or be unexported (golint)
- Line 57: warning: exported method UpdateFlagRequest.Validate should have comment or be unexported (golint)
- Line 69: warning: exported method DeleteFlagRequest.Validate should have comment or be unexported (golint)
- Line 77: warning: exported method CreateVariantRequest.Validate should have comment or be unexported (golint)
- Line 89: warning: exported method UpdateVariantRequest.Validate should have comment or be unexported (golint)
- Line 105: warning: exported method DeleteVariantRequest.Validate should have comment or be unexported (golint)
- Line 119: warning: exported method ListRuleRequest.Validate should have comment or be unexported (golint)
- Line 127: warning: exported method GetRuleRequest.Validate should have comment or be unexported (golint)
- Line 139: warning: exported method CreateRuleRequest.Validate should have comment or be unexported (golint)
- Line 155: warning: exported method UpdateRuleRequest.Validate should have comment or be unexported (golint)
- Line 171: warning: exported method DeleteRuleRequest.Validate should have comment or be unexported (golint)
- Line 183: warning: exported method OrderRulesRequest.Validate should have comment or be unexported (golint)
- Line 195: warning: exported method CreateDistributionRequest.Validate should have comment or be unexported (golint)
- Line 219: warning: exported method UpdateDistributionRequest.Validate should have comment or be unexported (golint)
- Line 247: warning: exported method DeleteDistributionRequest.Validate should have comment or be unexported (golint)
- Line 269: warning: exported method GetSegmentRequest.Validate should have comment or be unexported (golint)
- Line 277: warning: exported method CreateSegmentRequest.Validate should have comment or be unexported (golint)
- Line 293: warning: exported method UpdateSegmentRequest.Validate should have comment or be unexported (golint)
- Line 305: warning: exported method DeleteSegmentRequest.Validate should have comment or be unexported (golint)
- Line 313: warning: exported method CreateConstraintRequest.Validate should have comment or be unexported (golint)
- Line 355: warning: exported method UpdateConstraintRequest.Validate should have comment or be unexported (golint)
- Line 401: warning: exported method DeleteConstraintRequest.Validate should have comment or be unexported (golint)
-
-
flipt/storage/cache/cache.go
- Line 41: warning: exported method InMemoryCache.Get should have comment or be unexported (golint)
- Line 45: warning: exported method InMemoryCache.Set should have comment or be unexported (golint)
- Line 50: warning: exported method InMemoryCache.Delete should have comment or be unexported (golint)
- Line 55: warning: exported method InMemoryCache.Flush should have comment or be unexported (golint)
-
-
flipt/config/config.go
- Line 17: warning: exported type Config should have comment or be unexported (golint)
- Line 28: warning: exported type LogConfig should have comment or be unexported (golint)
- Line 33: warning: exported type UIConfig should have comment or be unexported (golint)
- Line 37: warning: exported type CorsConfig should have comment or be unexported (golint)
- Line 42: warning: exported type MemoryCacheConfig should have comment or be unexported (golint)
- Line 48: warning: exported type CacheConfig should have comment or be unexported (golint)
- Line 52: warning: exported type ServerConfig should have comment or be unexported (golint)
- Line 62: warning: exported type JaegerTracingConfig should have comment or be unexported (golint)
- Line 68: warning: exported type TracingConfig should have comment or be unexported (golint)
- Line 104: warning: exported type DatabaseConfig should have comment or be unexported (golint)
- Line 118: warning: exported type MetaConfig should have comment or be unexported (golint)
- Line 122: warning: exported type Scheme should have comment or be unexported (golint)
- Line 129: warning: exported const HTTP should have comment (or a comment on this block) or be unexported (golint)
- Line 145: warning: exported function Default should have comment or be unexported (golint)
- Line 244: warning: exported function Load should have comment or be unexported (golint)
-
-
flipt/storage/storage.go
- Line 39: warning: exported type QueryParams should have comment or be unexported (golint)
- Line 44: warning: exported type QueryOption should have comment or be unexported (golint)
- Line 46: warning: exported function WithLimit should have comment or be unexported (golint)
- Line 52: warning: exported function WithOffset should have comment or be unexported (golint)
- Line 58: warning: exported type Store should have comment or be unexported (golint)
-
-
flipt/storage/db/postgres/postgres.go
- Line 24: warning: exported function NewStore should have comment or be unexported (golint)
- Line 32: warning: exported type Store should have comment or be unexported (golint)
- Line 40: warning: exported method Store.CreateFlag should have comment or be unexported (golint)
- Line 56: warning: exported method Store.CreateVariant should have comment or be unexported (golint)
- Line 77: warning: exported method Store.UpdateVariant should have comment or be unexported (golint)
- Line 93: warning: exported method Store.CreateSegment should have comment or be unexported (golint)
- Line 109: warning: exported method Store.CreateConstraint should have comment or be unexported (golint)
- Line 125: warning: exported method Store.CreateRule should have comment or be unexported (golint)
- Line 141: warning: exported method Store.CreateDistribution should have comment or be unexported (golint)
-
-
flipt/storage/db/mysql/mysql.go
- Line 24: warning: exported function NewStore should have comment or be unexported (golint)
- Line 32: warning: exported type Store should have comment or be unexported (golint)
- Line 40: warning: exported method Store.CreateFlag should have comment or be unexported (golint)
- Line 56: warning: exported method Store.CreateVariant should have comment or be unexported (golint)
- Line 77: warning: exported method Store.UpdateVariant should have comment or be unexported (golint)
- Line 93: warning: exported method Store.CreateSegment should have comment or be unexported (golint)
- Line 109: warning: exported method Store.CreateConstraint should have comment or be unexported (golint)
- Line 125: warning: exported method Store.CreateRule should have comment or be unexported (golint)
- Line 141: warning: exported method Store.CreateDistribution should have comment or be unexported (golint)
-
-
flipt/server/server.go
- Line 19: warning: exported type Option should have comment or be unexported (golint)
-
-
flipt/cmd/flipt/export.go
- Line 20: warning: exported type Document should have comment or be unexported (golint)
- Line 25: warning: exported type Flag should have comment or be unexported (golint)
- Line 34: warning: exported type Variant should have comment or be unexported (golint)
- Line 40: warning: exported type Rule should have comment or be unexported (golint)
- Line 46: warning: exported type Distribution should have comment or be unexported (golint)
- Line 51: warning: exported type Segment should have comment or be unexported (golint)
- Line 58: warning: exported type Constraint should have comment or be unexported (golint)
-
-
flipt/storage/db/sqlite/sqlite.go
- Line 37: warning: exported method Store.CreateFlag should have comment or be unexported (golint)
- Line 53: warning: exported method Store.CreateVariant should have comment or be unexported (golint)
- Line 74: warning: exported method Store.UpdateVariant should have comment or be unexported (golint)
- Line 90: warning: exported method Store.CreateSegment should have comment or be unexported (golint)
- Line 106: warning: exported method Store.CreateConstraint should have comment or be unexported (golint)
- Line 122: warning: exported method Store.CreateRule should have comment or be unexported (golint)
- Line 138: warning: exported method Store.CreateDistribution should have comment or be unexported (golint)
-
-
flipt/storage/db/common/evaluation.go
- Line 20: warning: exported method Store.GetEvaluationRules should have comment or be unexported (golint)
- Line 100: warning: exported method Store.GetEvaluationDistributions should have comment or be unexported (golint)
-
-
flipt/storage/db/common/storage.go
- Line 9: warning: exported type Store should have comment or be unexported (golint)
- Line 14: warning: exported function NewStore should have comment or be unexported (golint)
ineffassign100%
IneffAssign detects ineffectual assignments in Go code.
No problems detected. Good job!